Closes: #2298

This fixes the detection of end of response for XAudioCast and ICY.
In addition to better error reporting this also fixes libshout trying
TLS on password error.

This fixes the use of shout_set_metadata() in case TLS Mode is set to
AUTO or AUTO_NO_PLAIN and the server will accept our poke request.

This is normally the case for RoarAudio and XAudioCast and Shoutcast.
While for RoarAudio shout_set_metadata() is not implemented anyway it
is a core requirement for Shoutcast.

Closes: #2298

Jörg Krause authored Aug 28, 2016 and Marvin Scholz committed Nov 08, 2017

Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Thise adds a internal variable to store the actually used TLS mode
in contrast to the requested mode. This is important for AUTO mode
detection requests and error states as they will be different from
the request.

Closes: #2244

Joseph Wallace authored Feb 12, 2016 and Philipp Schafft committed May 16, 2016

regarding indentation and braces.

Marvin Scholz authored Feb 08, 2016 and Philipp Schafft committed Mar 27, 2016

This fixes a few autoconf warnings left.
Thanks to fairch for providing the patch.

Closes: #2243

The make distcheck command was failing because the commons
were not referenced properly. Thanks to fairch for the patch!
Fix #2239

Jean-Baptiste Kempf authored Nov 30, 2015 and Philipp Schafft committed Dec 11, 2015

This fixes the Windows build.

This makes sure we do not escape random chars when sending
a SOURCE request to a server.

Closes: #2233

The original table is off-RFC. I have no idea what the intention
of that is and why it is that super restrictive. I fixed this on
the new table for resoruce encodings by adding the safe chars as
per RFC3986 section 2.3 to the list. Those extra chars are: 0x2D
('-'), 0x2E ('.'), 0x5F ('_') as well as 0x7E ('~').

See: #2233

This function allows to URI encode a string that is the resource
for a HTTP request. In contrast to _shout_util_url_encode() this
allows passthrough all gen-delims (RFC3986 section 2.2) but 0x3F
and 0x23 ('?' and '#').

See: #2233

Prior to this commit mountpoint names were sent to the server as-is
both as part of the SOURCE (or eq.) request as well as part of out-
of-band meta data updates (ICY workaround). This was a source for a
potential problem e.g. if the mountpoint's name contains characters
from the reserved space. This commit fixes this by always doing the
escaping step before sending this to the server. This may only be a
problem in case GET parameters were included in the mountpoint URI.
However this was never part of the concept and was supported by the
main line Icecast2 server. Please test this and feel free to reopen
the ticket in case of any problems. Thank you for reporting and for
your work.

Closes: #2233

This fixes missing includes of standard headers.
This seems to happened as a result of cleaning up the protocol code.