1. 21 May, 2017 2 commits
  2. 10 Feb, 2016 1 commit
  3. 08 Feb, 2016 1 commit
    • Marvin Scholz's avatar
      Fix invalid entities in listclient xml · d739c65e
      Marvin Scholz authored
      This fixes a bug where listener Referer or User-Agent strings containing
      a sequence like `&T;` was not escaped properly and therefore made the
      whole XML document invalid.
      Injecting new XML nodes (<foo></foo>) was not possible, it seems in the
      worse case all it could cause was that the XML failed to parse.
      Fix #2255
  4. 08 Apr, 2015 1 commit
  5. 23 Feb, 2015 1 commit
  6. 09 Feb, 2015 3 commits
  7. 01 Feb, 2015 1 commit
    • Philipp Schafft's avatar
      Fix: Added some more HTTP/1.1 headers · 8941de32
      Philipp Schafft authored
      This adds to all responses:
       * "Accept-Encoding: identity"
       * "Connection: close"
       * "Allow: GET, SOURCE" or "Allow: GET" (on admin pages)
      This is to generate some infrastructure for Icecast to tell futur
      source clients what is supported.
      "Upgrade: TLS/1.0" should be added later when upgrade support is present.
      See: #2152
  8. 25 Jan, 2015 1 commit
    • Marvin Scholz's avatar
      Cleanup codestyle · 0dfc7c5b
      Marvin Scholz authored
      This commit cleanups codestyle a bit, yet there is still some work to be done
  9. 13 Jan, 2015 1 commit
    • Philipp Schafft's avatar
      Cleanup: more cleanly define blocks for admin command IDs · 3b4e3ed0
      Philipp Schafft authored
      This adds info to the blocks about their size.
      Also added two more blocks:
      * for experimental features such as in private branches or
        or feature branches. This is for command IDs that are going to
        be merged with master some day. At merge they need to be changed
        and put into the regular position.
      * for private features that are not going to be merged into master.
        e.g. specific features for a very specific user that are not
        useful for general audiance.
      This should help keeping stuff sorted and largey reducing the risk
      of command ID collissions on merges of branches.
      Also this should make the merger's job a little bit more easy as
      there are less likely any conflicts on merge if someone else got
      a number closeby and those change is within the diff's context lines.
  10. 10 Jan, 2015 2 commits
  11. 26 Dec, 2014 1 commit
  12. 20 Dec, 2014 1 commit
  13. 19 Dec, 2014 1 commit
    • Philipp Schafft's avatar
      Feature: Allow mangement of <role>s via admin/ interface. · 0eb466b7
      Philipp Schafft authored
      This allows to manage <role>s via admin interface if the role supports.
      Also format of admin/manageauth has been changed:
      - <source> was renamed to <role>.
      - mount parameter was removed.
      - <role> got new parameters: type, name,
        can-adduser, can-deleteuser, can-listuser.
      - can-* parameters are bools ("true" or "false"). They should be used
        to show or hide elements on the admin interface.
      Ticket #2123 is nearly complet with this, just admin/manageauth.xsl
      needs up be updated. Please close the bug in the commit that updates
      See #2123
  14. 18 Dec, 2014 1 commit
  15. 14 Dec, 2014 2 commits
  16. 07 Dec, 2014 1 commit
  17. 30 Nov, 2014 1 commit
  18. 29 Nov, 2014 1 commit
    • Philipp Schafft's avatar
      in <listener>: · 23a47c8f
      Philipp Schafft authored
      - Added <role>.
      - Converted <Referer> to <referer>.
      - Set id="nnn" in addition to <ID>nnn</ID>.
      - Added TAGged comments about next steps.
      refs #2097
      svn path=/icecast/trunk/icecast/; revision=19364
  19. 28 Nov, 2014 1 commit
    • Philipp Schafft's avatar
      Wow. Mega patch! · a642cac5
      Philipp Schafft authored
      This patch *replaces* the authentication system completly.
      What is new:
       - <authentication> in mount section is now a container object.
       - <authentication> in root and mount section may hold any number of <role>-Tags.
       - <role> tags:
         Those tags define a 'role' and it's ACL rules.
         A role is a instance of an authentication module (see below).
         <role> takes the following options. All but type are optional.
         - authentication related:
           - type: Type of the authentication module (values: anonymous, static, legacy-password, url or htpasswd;
                   symbolic constants in auth.h)
           - name: Name for the role. For later matching. (values: any string; default: (none))
           - method: This rule is only active on the given list of HTTP methods.
                     (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: *)
         - ACL related:
           - allow-method: Allowed HTTP methods.
             (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: get)
           - deny-method: Rejected HTTP methods.
             (list of enum values: methods as recognized by httpp/ (e.g: get,post); default: *)
           - allow-admin: Allowed admin commands. (list of enum values: admin command; default: buildm3u)
           - deny-admin: Rejected admin commands. (list of enum values: admin command; default: *)
           - allow-web: Allowed web pages. (values: empty or *; default: *)
           - deny-web: Rejected web pages. (values: empty or *; default: (empty))
           - connections-per-user: maximum number of simultaneous connections per role and username.
             This is only active on active sources.  (values: unlimited or number of connections; default: unlimited)
           - connection-duration: maximum time of a connection. This is only active on active sources.
             (values: unlimited or number of secounds; default: unlimited)
         <role> takes <option> child tags. <option> tags contain a name and a value option.
         Meaning of <option> tags is up to the authentication module.
       - <role>s are considered to build a stack. If a role returns with AUTH_NOMATCH the next one will be tried.
       - <role>s are tested in this order: mount specific, default mount specific, global, internal fallback.
         Internal fallback is set to allow web/ access via GET, POST and HEAD (only GET supported by this time)
         and rejects all other requests.
       - New authentication module: anonymous
         This module matches all requests. No options taken.
       - New authentication module: static
         This module matches with a static username and password.
         It takes two <option>s. One with name="username" and one with name="password" to set username and password.
         This replaces old style <*-username> and <*-password> tags.
       - New authentication module: legacy-password
         This module matches with a statich password.
         It takes one <option> with name="password" to set password.
         This replaces old ICE and ICY (shoutcast compat mode) authentication.
       - Parsing <authentication> in <mount> with a type set in a special way to allow 100% backward compatibility.
       - Parsing of <source-password>, <admin-password>, <admin-user>, <relay-password> and <relay-user> in global
         <authentication> for 100% backward compatibility.
       - <alias> is now proccessed very early. This enables them to be used for all kinds of requests.
      To Do List & What does not yet work:
       - type="url" auth: mount_add and mount_remove.
         This should be replaced by an unique feature I would call '<event>'.
       - Admin commands manageauth and manageauth.xsl are disabled as they need more review:
         This code needs to be ported to support multiple <role>s per <mount>.
       - url authentication module can not yet return AUTH_NOMATCH.
         This needs to be reviewed and discussed on how to handle this case best way.
       - Default config files needs to be updated to reflect the changes.
         As this is quite some political act it should be done in dicussion with the whole team
         and permission of the release manager.
       - Docs need to be updated to reflect the changes.
      How does it work:
       Code has been changed so that authentification is done early for all clients.
       This allows accessing the ACL data (client->acl) from nearly everywhere in the code.
       After accept() and initial client setup the request is parsed. In the next step
       all <alias>es are resolved. After this the client is passed for authentication.
       After authentication it is passed to the corresponding subsystem depending on kind of request.
       All authentication instances have a thread running for doing the authentication.
       This thread works on a queue of clients.
      Hints for testers:
       - Test with default config.
       - Test with diffrent authentication modules in <mount>.
       - Test shoutcast compatibility mode.
       - Test with new style <authentication> and any amount of <role> (zero to quite some).
       - Test <alias> lookup on all kinds of objects.
       - Test source level credential login into the admin interface.
       - Test shoucast style meta data updates.
       - Test playlist generation.
      Thank you for reading this long commit message. Have fun reading the full patch!
      svn path=/icecast/trunk/icecast/; revision=19358
  20. 22 Nov, 2014 1 commit
  21. 21 Nov, 2014 2 commits
  22. 20 Nov, 2014 1 commit
  23. 10 Nov, 2014 1 commit
    • Philipp Schafft's avatar
      patch to fix regression on header size with large headers introduced by... · d06b6b18
      Philipp Schafft authored
      patch to fix regression on header size with large headers introduced by support of <server-id> and <http-headers>. This should ensure we have at least space for 2kB of extra headers. Depending on function and call we may have much more space.
      Please test this very carefully.
      Some pointers what should be in the tests (NOT complet list):
      - request to 'static' web/ and admin/ pages.
      - requests to playlist generation.
      - requests to streams.
      - requests to admin/ manipulation functions.
      - test everything with at least 8kB of extra headers, then reduce in 1kB (or 512B) steps.
      - see if response is correct OR 500 is returned.
      - run under valgrind or similar to see no buffer overflow or similiar will happen.
      - take a cookie!
      svn path=/icecast/trunk/icecast/; revision=19300
  24. 07 Nov, 2014 1 commit
  25. 31 Oct, 2014 1 commit
  26. 09 Oct, 2014 1 commit
  27. 23 Feb, 2014 1 commit
  28. 02 Apr, 2013 1 commit
    • Philipp Schafft's avatar
      Added support for a default mount. See #1914. · d54c61bf
      Philipp Schafft authored
      The default mount is a block in the config file that contains settings for
      all mount points that do not have a block in configfile themself.
      This is implemented by a <mount type="default">-block.
      In this case the <mount>-block MUST NOT contain a <mount-name>-subblock.
      svn path=/icecast/trunk/icecast/; revision=18902
  29. 24 Feb, 2013 1 commit
  30. 13 Nov, 2012 1 commit
  31. 17 Jul, 2012 1 commit
  32. 15 Jan, 2009 1 commit
  33. 14 Jan, 2009 1 commit
  34. 11 Jan, 2009 1 commit