• Jörn Heusipp's avatar
    Fix reading maximum, nominal, minimum bitrate in _vorbis_unpack_info(). · 68ebc894
    Jörn Heusipp authored and Timothy B. Terriberry's avatar Timothy B. Terriberry committed
    https://xiph.org/vorbis/doc/Vorbis_I_spec.html#x1-630004.2.2
    
     specifies
    these fields as 32bit signed. oggpack_read(opb,32), which is used to
    read these fields, returns 32 bits stored in a long. On architectures
    where long is 64bit, this results in a positive value being returned.
    This value is then stored in struct vorbis_info in bitrate_upper,
    bitrate_nominal and bitrate_lower, also as long. ogginfo relies on
    these values in order to display the respective header fields and thus
    misrepresented the stored value -1 (which has the intended meaning of
    "bitrate not set") as 2**32-1 on architectures where long is 64bit.
    
    Explicitly cast the return value of oggpack_read() to a signed 32bit
    integer type.
    
    A nominal bitrate value of -1 is valid as per specification, and is
    written by libvorbis for VBR files with samplerate >= 50000Hz.
    Signed-off-by: Timothy B. Terriberry's avatarTimothy B. Terriberry <tterribe@xiph.org>
    68ebc894
info.c 19.2 KB