Matt Oliver authored Sep 08, 2020 and Ralph Giles committed Nov 05, 2020

The cmake build script was not setting a VORBIS_LIBS variable
that is used to update pkg-config files. This results in linking
errors in downstream projects due to missing dependencies
(in this case libm).

This patch just updates the cmake script to behave the same
as configure does currently.
Signed-off-by: evpobr <evpobr@gmail.com>

Properly export Vorbis targets when added via `add_subdirectory()`.

Additional steps developed during the release processes.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Add a SHA-256 checksum file with the various stable source packages
listed to the repository. There are tracked separately on the
release site and mirrors, but having a copy in the source repo
provides another reference for integrity checks.

We already do this for another of other projects.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The fix for this issue was in the 1.3.7 release, but we didn't
refer to the CVE number explicitly in the release notes. Do
so now for the benefit of anyone auditing vulnerability
fixes in the future.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The decoder_example program calls floor() which requires
its own -lm on the link line to resolve the local reference.

It seems on most platforms this was shadowed by the transitive
dependency in the vorbis libraries, but it results in an
unddefined reference error on e.g. debian 10 mipsel.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Bump soname version and vendor string for the new release.

Update the top-level copyright dates for the release.

The have only been bug fixes to the encoder, no tuning changes,
but we updated the codename last time. so doing so again this
time. It's better to be able to distinguish releases than not.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Signed-off-by: Thomas Daede <daede003@umn.edu>

Summary of commits since the last release.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Signed-off-by: Thomas Daede <daede003@umn.edu>

Stop these clutting the `git status` output.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The tools to build the Vorbis format specification are a heavy
dependency, so we keep a built copy of that documentation in
the repository for the convenience of casual developers.

Rebuild the documents to bump the date and footer link
for the 1.3.7 release.

The spec build is broken on current texlive releases, with symptoms
like a missing table of contents in the pdf and incorrect size
attributes on figure images in the html output. This version
was build in a debian:9 (stretch) container to recover more
of the expected behaviour.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Building the html version of the Vorbis format specification
creates a series of image files containing figures and rendered
equations. Previously we were treating these as part of the
static documentation, since we keep a copy of the spec in
the repository.

Hopever, since the static images were listed as dependencies
of the specification document (as the not-generated ones are)
rebuilding the spec necessarily rebuilt them as well, which
meant the spec would always be considered out of date and
rebuilt needlessly.

Instead, split the static image files from the set which
are generated as part of the specification build process,
and only mark dependence on the former.

This allows us to drop the inconsistent DISTCLEAN line which
was working around the problem of always needing to rebuild
the spec, even when it was included in the distribution.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Add a new intermediate file generated when building the spec.
It's necessary to remove all intermediates to pass `make distcheck`.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The earlier commit changed the html, but not the original
TeX source document.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

This was introduced by the recent https link update patch.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The page the LSP algorithm is based on is no longer online.
Link to an archived version instead.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Ross William's website is still up, but the section containing
the CRC introduction is no longer available. Instead link to
a copy on zlib.org which hopefully will remain available.

Also remove the mailto: link. Email is not one of the included
contact links on the author's site, so it seems rude to continue
to publish it here.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The old url is broken. This PDF link is just the first
search engine suggestion for the filename.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The url no longer works, and according to Wikipedia, the EFF
now recommends Creative Commons licenses instead.

Also provide a specific Creative Commons license as an example.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Neither git.xiph.org not the jenkins instances are still online.
Point people at the new gitlab instance and build status badge
instead.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

These were missed in an earlier commit. Thanks to Mark Harris
for the review.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The server is using .shtml index pages, so linking directly
to an index.html page does not work. Truncate the reference
at the directory path and rely on the server's default page
to select the correct contents.

Thanks to Mark Harris for pointing out the breakage.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The old .html versions of these pages no longer redirect to
to the new-style directory-based urls, so this link was
broken.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Use a secure link to the current mirror site.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

- Prefer the shorter, secure url.
- Link to the current xiph.org/vorbis location for the vorbis
  project website.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

There remains a link from the Vorbis RTP format RFC, which is
an immutable published document. We'll have to maintain a
redirect for the sake of that link.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Use secure links to the default domain and current documentation.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

The current link redirects to this secure link.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Use the secure link, which should be the default. Prefer the
url without the `www` prefix because it's shorter.
Signed-off-by: Mark Harris <mark.hsj@gmail.com>

Make it clear to local analysis that no out-of-bounds array
accesses are possible here.

Follow-up to CVE-2018-10393 and CVE-2017-14160.
Signed-off-by: Thomas Daede <daede003@umn.edu>
Signed-off-by: Monty <xiphmont@xiph.org>

We were calling AC_CANONICAL_TARGET in configure.ac under the
mistaken impression that this allowed setting the target
architecture for cross-compilation output.

However, in GNU terminology the system type that this the
target of cross-compilation is the "host" and "target"
is reserved for setting what the output of the compiled
application should itself target, when compiling a
cross-compiler. Finally "build" is the system type the
build system is itself running under.

So to cross-compile, one invokes `./configure --host ...`
not `--target`.

In any case, we only make use of the `host` variable,
so that is the macro we need to invoke to provide it.

Thanks to Maarten Bosmans for reporting the issue.
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Some systems don't require a separate -lm to link with libc
math functions. The configure script checks for this, so
use the corresponding variable to set the dependent libraries
in vorbis.pc dynamically.
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

Use a versioned base image for jobs to reduce variance.

This version number will need to be bumped periodically.
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

This could only help with the initial build, not `make distcheck`
and since config.h is generated fresh for each job, everything
was remade anyway. Thanks to ePirat for pointing out the issue.

Move shared properties into a `default` stanza per current
style recommendations.

Add an additional build job to the gitlab ci pipeline to do a
cmake build. This doesn't run tests, but gives us a little
bit of converage.

Describe a basic autoconf build and test for gitlab's integrated
continuous integration runner. Uses the gcc docker image.

Copied from the theora version.

- `zip` is needed for `make dist`
- `doxygen` is needed to generate api documentation.
  latex is also needed, but a heavy dependency to install every run,
  so skipped for now.

Petter Reinholdtsen authored Apr 13, 2020 and Ralph Giles committed Apr 15, 2020

Based on0002-Avoid-SIGFPE-when-bytespersample-is-zero.patch from Debian,
see https://bugs.debian.org/635906

 , adjusted with input from Ralph
Giles.
Signed-off-by: Ralph Giles <giles@thaumas.net>

evpobr authored Apr 08, 2020 and Ralph Giles committed Apr 08, 2020

Supress warnings about unsafe and deprecated functions like this: strcat is unsafe, use `strcat_s` instead and so on.
Signed-off-by: Ralph Giles <giles@thaumas.net>

evpobr authored Apr 08, 2020 and Ralph Giles committed Apr 08, 2020

MinGW produces DLLs, but exports nothing.