Xiph.Org issueshttps://gitlab.xiph.org/groups/xiph/-/issues2018-06-07T20:52:20Zhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2092Write specification of Icecast specific HTTP protocol features2018-06-07T20:52:20ZThomas B. RückerWrite specification of Icecast specific HTTP protocol featuresUse HTTP 1.0 and 1.1 specs as base, document differences and quirks.
Give guidance what a source client SHOULD, MUST, MUST NOT do, etc.
Explain source and listener HTTP headers, authentication quirks.Use HTTP 1.0 and 1.1 specs as base, document differences and quirks.
Give guidance what a source client SHOULD, MUST, MUST NOT do, etc.
Explain source and listener HTTP headers, authentication quirks.Icecast 2.5.0Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/2300Write album art to encoded .ogg file2024-01-18T19:54:06ZtmpltWrite album art to encoded .ogg fileI use oggenc to create Ogg Vorbis files to save space on my mobile devices. While oggenc seems to write most metadata to the created .ogg file, the album art isn't copied. Could this be implemented?
CheersI use oggenc to create Ogg Vorbis files to save space on my mobile devices. While oggenc seems to write most metadata to the created .ogg file, the album art isn't copied. Could this be implemented?
CheersMichael SmithMichael Smithhttps://gitlab.xiph.org/xiph/theora/-/issues/1601wrapper script to combine mplayer with theora_encoder_example2017-08-20T01:57:18ZJohn Ferlitowrapper script to combine mplayer with theora_encoder_exampleForwarding a bug upstream from debian.
Hi,
I wrote this small script as a wrapper to actually make theora_encoder_example
useful. Without it, one would have to setup named pipes and mplayer processes
by hand, which is annoying and pos...Forwarding a bug upstream from debian.
Hi,
I wrote this small script as a wrapper to actually make theora_encoder_example
useful. Without it, one would have to setup named pipes and mplayer processes
by hand, which is annoying and possibly a showstopper for less experienced
users. Perhaps you could include it in the package.
https://gitlab.xiph.org/xiph/rav1e/-/issues/75Would't supporting multithreading at early stage better?2018-02-28T19:58:32ZThomas DaedeWould't supporting multithreading at early stage better?*Created by: yushincho*
Minimum prerequisite is a tiling support.*Created by: yushincho*
Minimum prerequisite is a tiling support.https://gitlab.xiph.org/xiph/oggdsf/-/issues/1827WMP embed and autorewind doesn't work with Ogg Vorbis2018-04-29T07:18:12ZCristian AdamWMP embed and autorewind doesn't work with Ogg VorbisAutoRewind doesn't work with Ogg Vorbis. Works fine with mp3 files.
```
<OBJECT id=playera height=67 width=300
classid=clsid:22D6F312-B0F6-11D0-94AB-0080C74C7E95>
<PARAM NAME="AutoRewind" VALUE="true">
<PARAM NAME="AutoStart" VALUE="t...AutoRewind doesn't work with Ogg Vorbis. Works fine with mp3 files.
```
<OBJECT id=playera height=67 width=300
classid=clsid:22D6F312-B0F6-11D0-94AB-0080C74C7E95>
<PARAM NAME="AutoRewind" VALUE="true">
<PARAM NAME="AutoStart" VALUE="true">
<PARAM NAME="Balance" VALUE="False">
<PARAM NAME="DisplaySize" VALUE="true">
<PARAM NAME="Filename" VALUE="http://10.10.2.111/aaa.ogg">
<PARAM NAME="Mute" VALUE="False">
</OBJECT>
```
Thank you Miloš Šula for reporting.Cristian AdamCristian Adamhttps://gitlab.xiph.org/xiph/oggdsf/-/issues/1612Windows 7.0 64 bit Issues2018-04-29T07:18:12ZMartin ErdmannWindows 7.0 64 bit IssuesInstalled 64bit stable in Windows 7/64bit op sys, 4Gb ram,
media player worked fine,however after I shut system down and after restart system would come up but explorer stopped working, system just locked up. Had to force shutdown and d...Installed 64bit stable in Windows 7/64bit op sys, 4Gb ram,
media player worked fine,however after I shut system down and after restart system would come up but explorer stopped working, system just locked up. Had to force shutdown and do system restore to use PC .Cristian AdamCristian Adamhttps://gitlab.xiph.org/xiph/oggdsf/-/issues/1536Windows 7 build 7068 only in Play Lists show missing Media Usage Rights2018-04-29T07:18:12ZGitlab BotWindows 7 build 7068 only in Play Lists show missing Media Usage RightsIn Windows 7 build 7068 When right clicking flac files in library the media usage rights show that "This file is not protected. However, when the same file is right clicked from a play list, Media Usage Rights say that "The File is missi...In Windows 7 build 7068 When right clicking flac files in library the media usage rights show that "This file is not protected. However, when the same file is right clicked from a play list, Media Usage Rights say that "The File is missing media usage rights". The files still play, however this poses a problem when using dopisp to sync and convert flac files on the fly to an iPod. They will no longer convert. They used to in Vista, and I believe the Windows 7 7000. I also used WMPTSE 1.4 and have the 64-bit OS, and use both 64 and 32 bit WMP.Cristian AdamCristian Adamhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2486WIndows 32bit builds lead to connection-timout2024-01-20T23:52:33ZStephan JauernickWIndows 32bit builds lead to connection-timoutWe have not dug to deep into this yet.
It broke between 2.5b3 and current devel.
The server starts normally and all looks well, connections timeout.
Nothing is logged even with debugging.
phschafft has config.logs and config.hWe have not dug to deep into this yet.
It broke between 2.5b3 and current devel.
The server starts normally and all looks well, connections timeout.
Nothing is logged even with debugging.
phschafft has config.logs and config.hIcecast 2.5 rc1https://gitlab.xiph.org/xiph/oggdsf/-/issues/1691Winamp feezes while seeking in video file2018-04-29T07:18:12ZCristian AdamWinamp feezes while seeking in video fileTest scenario:
- Windows XP
- Oggcodecs oggcodecs_0.82.16930-win32.exe
- Winamp 5.572
- Video file: http://www.archive.org/download/1941-06-23_Nazis_War_On_Russia/1941-06-23_Nazis_War_On_Russia.ogv
Seeking in file causes Winamp...Test scenario:
- Windows XP
- Oggcodecs oggcodecs_0.82.16930-win32.exe
- Winamp 5.572
- Video file: http://www.archive.org/download/1941-06-23_Nazis_War_On_Russia/1941-06-23_Nazis_War_On_Russia.ogv
Seeking in file causes Winamp to freeze (easy to reproduce, sometimes from first seek request). Windows Media Player 11 doesn't seem to be affected, seeking in the same file works.
Thank you Dan R. for reporting this issue.
Cristian AdamCristian Adamhttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2327When preventing caller "abuse-after-free", abort()2023-03-09T09:48:58ZMoritz GrimmWhen preventing caller "abuse-after-free", abort()The shout_free() function attempts to prevent use-after-free issues by not doing anything in case the caller still has an open connection. While this can mitigate security issues in calling applications, it covers up these flaws in the f...The shout_free() function attempts to prevent use-after-free issues by not doing anything in case the caller still has an open connection. While this can mitigate security issues in calling applications, it covers up these flaws in the form of hard to detect memory leaks.
Libshout should either leave the responsibility for these kinds of defects where they belong and not perform the "is a connection still open?" check, as it will never be able to solve _all_ of these problems (and applications running into this _will_ have other problems as well and are in some dire need of SAST tools).
However, since there is some merit to this safeguard, at least make it highly visible with a proper, noisy abort(): [shout_free_abort_before_use-after-free.diff](/uploads/7eb49ff1ce810e41d523e54cbb6f8428/shout_free_abort_before_use-after-free.diff) -- it might be a wake-up call!https://gitlab.xiph.org/xiph/opus/-/issues/2349When packet loss (less than 30%) exists in the code stream, the decoded resul...2021-01-06T12:40:33ZJie YangWhen packet loss (less than 30%) exists in the code stream, the decoded results will be distorted?When opus is used for codec, if packet loss exists in the code stream, the opus decoding to compensate will occur sound breakage. Especially when the packet loss rate is high, this phenomenon is easy to happen. After many tests, we found...When opus is used for codec, if packet loss exists in the code stream, the opus decoding to compensate will occur sound breakage. Especially when the packet loss rate is high, this phenomenon is easy to happen. After many tests, we found that this abnormal situation would occur at either 16K or 48K sampling rate. We also tried the latest 1.3 version, and unfortunately, this phenomenon hasn't gone away. Now we send you the results of raw data, encoded stream, packet loss and decoding, hoping to get a reply.[data_opus_1.rar](/uploads/bf8412434c03c1982d5112acab866208/data_opus_1.rar)https://gitlab.xiph.org/xiph/cortado/-/issues/1708WebM/VP8 support in Cortado2017-08-21T19:26:29ZPhilip HeronWebM/VP8 support in CortadoAny thoughts on adding VP8 support to Cortado? There are already Java Matroska demuxers in the wild, but I'd imagine it would be a fairly big job porting the decoder itself.Any thoughts on adding VP8 support to Cortado? There are already Java Matroska demuxers in the wild, but I'd imagine it would be a fairly big job porting the decoder itself.https://gitlab.xiph.org/xiph/vorbis-tools/-/issues/1817Wave parser bug in encoder2018-01-22T04:18:37ZJames BoerWave parser bug in encoderIn the find_wav_chunk function (audio.c, line 120), we see:
static int find_wav_chunk(FILE *in, char *type, unsigned int *len) {
unsigned char buf[8];
while(1)
{
if(fread(buf,1,8,in) < 8) /* Suck down a chunk specif...In the find_wav_chunk function (audio.c, line 120), we see:
static int find_wav_chunk(FILE *in, char *type, unsigned int *len) {
unsigned char buf[8];
while(1)
{
if(fread(buf,1,8,in) < 8) /* Suck down a chunk specifier */
{
fprintf(stderr, _("Warning: Unexpected EOF in reading WAV header\n"));
return 0; /* EOF before reaching the appropriate chunk */
}
if(memcmp(buf, type, 4))
{
*len = READ_U32_LE(buf+4);
if(!seek_forward(in, *len))
return 0;
buf[4] = 0;
fprintf(stderr, _("Skipping chunk of type \"%s\", length %d\n"), buf, *len);
}
else
{
*len = READ_U32_LE(buf+4);
return 1;
}
}
}
I believe that the line:
if(!seek_forward(in, *len))
should probably read (note, code change is untested):
if(!seek_forward(in, *len + *len % 2))
This should properly seek to word boundaries as is specified by the RIFF specs (such that I could find).
Attached is a wave file that demonstrates this issue.
Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/xiph-qt/-/issues/1669Washed Out Color on Playback2018-04-29T09:16:11ZTorranceWashed Out Color on PlaybackTheora-encoded videos played through Quicktime (on Mac) using XiphQT are incorrectly reproducing the color of the video, and appear slighly, but noticably, washed out. The same videos can be played via VLC and Firefox and are true to the...Theora-encoded videos played through Quicktime (on Mac) using XiphQT are incorrectly reproducing the color of the video, and appear slighly, but noticably, washed out. The same videos can be played via VLC and Firefox and are true to the original - so I don't believe it's a problem with the videos themselves or the encoding.
I'm observing this problem on Snow Leopard, using Quicktime 7 (theora files don't load with Quicktime X) and XiphQT 0.1.9.
Arek KorbikArek Korbikhttps://gitlab.xiph.org/xiph/rav1e/-/issues/83Warnings with "cargo bench"2018-02-28T19:58:32ZThomas DaedeWarnings with "cargo bench"*Created by: yushincho*
yushin@maui:~/workspace/rav1e$ cargo test
Compiling bitstream-io v0.6.3
Compiling bitflags v1.0.1
Compiling bencher v0.1.5
Compiling bitflags v0.4.0
Compiling encode_unicode v0.1.3
Compili...*Created by: yushincho*
yushin@maui:~/workspace/rav1e$ cargo test
Compiling bitstream-io v0.6.3
Compiling bitflags v1.0.1
Compiling bencher v0.1.5
Compiling bitflags v0.4.0
Compiling encode_unicode v0.1.3
Compiling vec_map v0.8.0
Compiling unicode-width v0.1.4
Compiling ansi_term v0.10.2
Compiling y4m v0.1.1
Compiling byteorder v1.2.1
Compiling libc v0.2.36
Compiling strsim v0.7.0
Compiling textwrap v0.9.0
Compiling nix v0.5.1
Compiling atty v0.2.6
Compiling rand v0.4.2
Compiling clap v2.30.0
Compiling rustyline v1.0.0
Compiling rav1e v0.1.0 (file:///home/yushin/workspace/rav1e)
Finished dev [unoptimized + debuginfo] target(s) in 9.73 secs
Running target/debug/deps/rav1e-9b00cc822757fb1d
running 6 tests
test ec::test::booleans ... ok
test ec::test::cdf ... ok
test ec::test::mixed ... ok
test predict::test::pred_max ... ok
test predict::test::pred_same ... ok
test predict::test::pred_matches ... ok
test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Running target/debug/deps/rav1e-5895d273f770ce9f
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Running target/debug/deps/rav1repl-81dcf9202be56248
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Doc-tests rav1e
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
yushin@maui:~/workspace/rav1e$ cargo bench
Compiling bencher v0.1.5
Compiling rav1e v0.1.0 (file:///home/yushin/workspace/rav1e)
warning: unused import: `rav1e::predict::*;`
--> benches/bench.rs:95:5
|
95 | use rav1e::predict::*;
| ^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
warning: unused variable: `mode`
--> benches/bench.rs:111:9
|
111 | let mode = PredictionMode::DC_PRED;
| ^^^^
|
= note: #[warn(unused_variables)] on by default
= note: to avoid this warning, consider using `_mode` instead
warning: foreign function is never used: `highbd_dc_left_predictor`
--> benches/bench.rs:15:5
|
15 | / fn highbd_dc_left_predictor(dst: *mut u16, stride: libc::ptrdiff_t, bw: libc::c_int,
16 | | bh: libc::c_int, above: *const u16,
17 | | left: *const u16, bd: libc::c_int);
| |______________________________________________________________^
|
= note: #[warn(dead_code)] on by default
warning: foreign function is never used: `highbd_dc_top_predictor`
--> benches/bench.rs:18:5
|
18 | / fn highbd_dc_top_predictor(dst: *mut u16, stride: libc::ptrdiff_t, bw: libc::c_int,
19 | | bh: libc::c_int, above: *const u16,
20 | | left: *const u16, bd: libc::c_int);
| |______________________________________________________________^
warning: foreign function is never used: `highbd_h_predictor`
--> benches/bench.rs:21:5
|
21 | / fn highbd_h_predictor(dst: *mut u16, stride: libc::ptrdiff_t, bw: libc::c_int,
22 | | bh: libc::c_int, above: *const u16,
23 | | left: *const u16, bd: libc::c_int);
| |______________________________________________________________^
warning: foreign function is never used: `highbd_v_predictor`
--> benches/bench.rs:24:5
|
24 | / fn highbd_v_predictor(dst: *mut u16, stride: libc::ptrdiff_t, bw: libc::c_int,
25 | | bh: libc::c_int, above: *const u16,
26 | | left: *const u16, bd: libc::c_int);
| |___________________________________________^
warning: function is never used: `pred_h_4x4`
--> benches/bench.rs:37:1
|
37 | fn pred_h_4x4(output: &mut [u16], stride: usize, above: &[u16], left: &[u16]) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
warning: function is never used: `pred_v_4x4`
--> benches/bench.rs:44:1
|
44 | fn pred_v_4x4(output: &mut [u16], stride: usize, above: &[u16], left: &[u16]) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Finished release [optimized] target(s) in 3.83 secs
Running target/release/deps/rav1e-c60027f9b9bd002f
running 6 tests
test ec::test::booleans ... ignored
test ec::test::cdf ... ignored
test ec::test::mixed ... ignored
test predict::test::pred_matches ... ignored
test predict::test::pred_max ... ignored
test predict::test::pred_same ... ignored
test result: ok. 0 passed; 0 failed; 6 ignored; 0 measured; 0 filtered out
Running target/release/deps/rav1e-ab1af7a55ae80597
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Running target/release/deps/rav1repl-b79447a2b246d724
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Running target/release/deps/bench-741fd4a6e67fa1d0
running 4 tests
test aom ... bench: 1,188,882 ns/iter (+/- 38,736)
test native ... bench: 975,183 ns/iter (+/- 59,961)
test native_trait ... bench: 269,857 ns/iter (+/- 10,470)
test write_b_bench ... bench: 123,071 ns/iter (+/- 6,586)
test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured
yushin@maui:~/workspace/rav1e$
https://gitlab.xiph.org/xiph/tremor/-/issues/1849Warnings in Tremor2017-09-02T15:25:02ZAndrew ChurchWarnings in TremorThe attached patch against SVN r18145 corrects a number of compiler warnings with "gcc -Wall -Wempty-body -Wmissing-declarations -Wpointer-arith -Wstrict-prototypes" on GCC 4.6.1:
- Adds the ov_fopen() declaration to ivorbisfile.h (sinc...The attached patch against SVN r18145 corrects a number of compiler warnings with "gcc -Wall -Wempty-body -Wmissing-declarations -Wpointer-arith -Wstrict-prototypes" on GCC 4.6.1:
- Adds the ov_fopen() declaration to ivorbisfile.h (since it seems intended to be exported).
- #includes block.h in block.c to fix missing-declaration warnings.
- Adds "static" to internal functions which don't have it: res[012]_*() in res012.c, _make_words() and _book_unquantize() in sharedbook.c, and rescale64() in vorbisfile.c.
- Deletes the unused variable j from vorbis_book_decodev_set() in codebook.c.
This patch doesn't address the int vs. ogg_uint32_t problem with serial numbers that I raised in issue 1838; I'll open that as a separate issue.Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/1848Warnings in libvorbis/libvorbisfile2017-11-01T04:49:44ZAndrew ChurchWarnings in libvorbis/libvorbisfileThe attached patch against SVN r18145 corrects a number of compiler warnings with "gcc -Wall -Wempty-body -Wmissing-declarations -Wpointer-arith -Wsign-compare -Wstrict-prototypes" on GCC 4.6.1:
- Adds a new header lib/block.h to hold t...The attached patch against SVN r18145 corrects a number of compiler warnings with "gcc -Wall -Wempty-body -Wmissing-declarations -Wpointer-arith -Wsign-compare -Wstrict-prototypes" on GCC 4.6.1:
- Adds a new header lib/block.h to hold the declaration of vorbis_window(), #includes it in block.c and vorbisfile.c, and removes the declaration of that function from vorbisfile.c.
- Adds "static" to internal functions which don't have it: res[012]_*() in res012.c and _make_words() and run_test() in sharedbook.c.
- Changes () to (void) in function definitions so they are proper prototypes: main() (for tests) in sharedbook.c and host_is_big_endian() in vorbisfile.c.
- Deletes the unused function _vi_gpsy_free() from psy.c.
- Deletes the unused variable lastdelta from Laguerre_With_Deflation() in lsp.c.
- Propagates "const" up from the vwin64/vwin128 arrays in window.c through _vorbis_window_get() to its callers (and onward).
- Fixes a constant in info.c which was one digit too long (0x7ffffffff).
I can split this out into separate patches if desired, but I've bundled the changes together since they don't change any functionality.Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/libao/-/issues/2210Warning: Carbon Component Manager is being depricated2020-06-14T10:09:15ZSethWarning: Carbon Component Manager is being depricatedApplications running in OS X 10.11 (El Capitan) have errors stating that Carbon Component Manager is deprecated:
This application, or a library it uses, is using the deprecated Carbon Component Manager for hosting Audio Units. Support...Applications running in OS X 10.11 (El Capitan) have errors stating that Carbon Component Manager is deprecated:
This application, or a library it uses, is using the deprecated Carbon Component Manager for hosting Audio Units. Support for this will be removed in a future release. Also, this makes the host incompatible with version 3 audio units. Please transition to the API's in AudioComponent.h.Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/ogg/-/issues/2228vorbisfile.c function ov_pcm_total add const to OggVorbis_File *2017-08-26T14:29:54Zirov13vorbisfile.c function ov_pcm_total add const to OggVorbis_File *subjsubjMonty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/1452vorbiscomment should support viewing/editing comments on secondary Vorbis str...2018-01-22T04:18:37Zmgoldvorbiscomment should support viewing/editing comments on secondary Vorbis streamsIf an Ogg file contains multiple multiplexed Vorbis streams, vorbiscomment always works with the first one. There should be an option to view or edit comments on a secondary stream (probably selected by serial number). An option to list ...If an Ogg file contains multiple multiplexed Vorbis streams, vorbiscomment always works with the first one. There should be an option to view or edit comments on a secondary stream (probably selected by serial number). An option to list all supported streams would be helpful if this was implemented.Michael SmithMichael Smith