Xiph.Org issueshttps://gitlab.xiph.org/groups/xiph/-/issues2023-08-15T11:54:20Zhttps://gitlab.xiph.org/xiph/libao/-/issues/2324reserved identifier violation2023-08-15T11:54:20ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__AO_H__`](https://gitlab.xiph.org/xiph/libao/-/blob/cafce902a73c1050474a62feff83e428bbbee5f4/include/ao/ao.h#L27 "Update candidate")” and “[`__PLUGIN_H__`](https://gitlab.xiph.or...:eyes: I would like to point out that identifiers like “[`__AO_H__`](https://gitlab.xiph.org/xiph/libao/-/blob/cafce902a73c1050474a62feff83e428bbbee5f4/include/ao/ao.h#L27 "Update candidate")” and “[`__PLUGIN_H__`](https://gitlab.xiph.org/xiph/libao/-/blob/cafce902a73c1050474a62feff83e428bbbee5f4/include/ao/plugin.h#L25 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/celt/-/issues/6reserved identifier violation2023-08-15T11:33:28ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`_CELT_TYPES_H`](https://gitlab.xiph.org/xiph/celt/-/blob/e18de7747fb1655e66bf8d291560587036bfe53c/libcelt/celt_types.h#L33 "Update candidate")” and “[`_PITCH_H`](https://gitlab.xi...:eyes: I would like to point out that identifiers like “[`_CELT_TYPES_H`](https://gitlab.xiph.org/xiph/celt/-/blob/e18de7747fb1655e66bf8d291560587036bfe53c/libcelt/celt_types.h#L33 "Update candidate")” and “[`_PITCH_H`](https://gitlab.xiph.org/xiph/celt/-/blob/e18de7747fb1655e66bf8d291560587036bfe53c/libcelt/pitch.h#L35 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/icecast-ices/-/issues/2326reserved identifier violation2023-08-15T11:10:22ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__CONFIG_H__`](https://gitlab.xiph.org/xiph/icecast-ices/-/blob/2ccd03ac2ad984919bfe98e0c43a576c0317a943/src/cfgparse.h#L15 "Update candidate")” and “[`__INPUT_H__`](https://gitla...:eyes: I would like to point out that identifiers like “[`__CONFIG_H__`](https://gitlab.xiph.org/xiph/icecast-ices/-/blob/2ccd03ac2ad984919bfe98e0c43a576c0317a943/src/cfgparse.h#L15 "Update candidate")” and “[`__INPUT_H__`](https://gitlab.xiph.org/xiph/icecast-ices/-/blob/2ccd03ac2ad984919bfe98e0c43a576c0317a943/src/input.h#L14 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/icecast-libigloo/-/issues/8reserved identifier violation2023-08-15T10:57:26ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that an identifier like “[`_LIBIGLOO__CONFIG_H_`](https://gitlab.xiph.org/xiph/icecast-libigloo/-/blob/b6f1d9b977f7e383bda27b804d6444d50442e434/include/igloo/config.h#L20 "Update candidate")” [does not fi...:eyes: I would like to point out that an identifier like “[`_LIBIGLOO__CONFIG_H_`](https://gitlab.xiph.org/xiph/icecast-libigloo/-/blob/b6f1d9b977f7e383bda27b804d6444d50442e434/include/igloo/config.h#L20 "Update candidate")” [does not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2340reserved identifier violation2023-08-15T10:34:09ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that an identifier like “[`__LIBSHOUT_SHOUT_H__`](https://gitlab.xiph.org/xiph/icecast-libshout/-/blob/d8592a0be35867691219f470b7db506fbb8cb912/include/shout/shout.h.in#L22 "Update candidate")” [does not ...:eyes: I would like to point out that an identifier like “[`__LIBSHOUT_SHOUT_H__`](https://gitlab.xiph.org/xiph/icecast-libshout/-/blob/d8592a0be35867691219f470b7db506fbb8cb912/include/shout/shout.h.in#L22 "Update candidate")” [does not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/icecast-server/-/issues/2481reserved identifier violation2023-08-15T09:33:30ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__BUFFER_H__`](https://gitlab.xiph.org/xiph/icecast-server/-/blob/57093def7baacf2aaaff3a17915cd7fc0b8cfec3/src/buffer.h#L14 "Update candidate")” and “[`__CFGFILE_H__`](https://git...:eyes: I would like to point out that identifiers like “[`__BUFFER_H__`](https://gitlab.xiph.org/xiph/icecast-server/-/blob/57093def7baacf2aaaff3a17915cd7fc0b8cfec3/src/buffer.h#L14 "Update candidate")” and “[`__CFGFILE_H__`](https://gitlab.xiph.org/xiph/icecast-server/-/blob/57093def7baacf2aaaff3a17915cd7fc0b8cfec3/src/cfgfile.h#L15 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/rnnoise/-/issues/8Completion of error handling2023-08-15T08:02:28ZMarkus ElfringCompletion of error handlingWould you like to add more error handling for return values from functions like the following?
* [fopen](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html "Open a stream") ⇒ [main](https://gitlab.xiph.org/xiph/rnnois...Would you like to add more error handling for return values from functions like the following?
* [fopen](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html "Open a stream") ⇒ [main](https://gitlab.xiph.org/xiph/rnnoise/-/blob/7f449bf8bd3b933891d12c30112268c4090e4d59/src/denoise.c#L540)
* [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [rnnoise_create](https://gitlab.xiph.org/xiph/rnnoise/-/blob/7f449bf8bd3b933891d12c30112268c4090e4d59/src/denoise.c#L276)https://gitlab.xiph.org/xiph/flac/-/issues/5Remove unnecessary null pointer checks2023-08-15T07:09:18ZMarkus ElfringRemove unnecessary null pointer checks:eyes: [A few extra null pointer checks are not needed](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") in [the function “static_metadata_clear”](https:...:eyes: [A few extra null pointer checks are not needed](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") in [the function “static_metadata_clear”](https://gitlab.xiph.org/xiph/flac/-/blob/28e4f0528c76b296c561e922ba67d43751990599/src/flac/encode.c#L1587 "Update candidate").https://gitlab.xiph.org/xiph/flac/-/issues/4reserved identifier violation2023-08-15T06:42:10ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`FLACPP__METADATA_H`](https://gitlab.xiph.org/xiph/flac/-/blob/28e4f0528c76b296c561e922ba67d43751990599/include/FLAC++/metadata.h#L33 "Update candidate")” and “[`FLAC__SubframeType...:eyes: I would like to point out that identifiers like “[`FLACPP__METADATA_H`](https://gitlab.xiph.org/xiph/flac/-/blob/28e4f0528c76b296c561e922ba67d43751990599/include/FLAC++/metadata.h#L33 "Update candidate")” and “[`FLAC__SubframeType`](https://gitlab.xiph.org/xiph/flac/-/blob/28e4f0528c76b296c561e922ba67d43751990599/include/FLAC/format.h#L263 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/speexdsp/-/issues/12Remove unnecessary null pointer checks2023-08-14T16:32:27ZMarkus ElfringRemove unnecessary null pointer checks:eyes: [A few extra null pointer checks are not needed](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") in [the function “spx_drft_clear”](https://gitla...:eyes: [A few extra null pointer checks are not needed](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") in [the function “spx_drft_clear”](https://gitlab.xiph.org/xiph/speexdsp/-/blob/738e17905e1ca2a1fa932ddd9c2a85d089f4e845/libspeexdsp/smallft.c#L1252 "Update candidate").https://gitlab.xiph.org/xiph/postfish/-/issues/12Completion of error handling2023-08-14T11:55:10ZMarkus ElfringCompletion of error handlingWould you like to add more error handling for return values from functions like the following?
* [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [config_save](https://gitlab....Would you like to add more error handling for return values from functions like the following?
* [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [config_save](https://gitlab.xiph.org/xiph/postfish/-/blob/ad624e7e46b043183d3ab669e6cf54cba887e1a6/config.c#L234)
* [pthread_mutex_init](https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_init.html "Initialize a mutex") ⇒ [input_init](https://gitlab.xiph.org/xiph/postfish/-/blob/ad624e7e46b043183d3ab669e6cf54cba887e1a6/input.c#L81)https://gitlab.xiph.org/xiph/libxspf/-/issues/1269Remove unnecessary null pointer checks2023-08-14T11:30:10ZMarkus ElfringRemove unnecessary null pointer checks[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following.
- [Collector](https://gitlab.xiph.org/xiph/libxs...[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following.
- [Collector](https://gitlab.xiph.org/xiph/libxspf/-/blob/63495bcec37fccbe955ccab106c1fd1ea49cb965/examples/strip/strip.cpp#L81 "Destructor for Collector")
- [XspfExtensionReaderFactoryPrivate](https://gitlab.xiph.org/xiph/libxspf/-/blob/63495bcec37fccbe955ccab106c1fd1ea49cb965/src/XspfExtensionReaderFactory.cpp#L189 "Destructor for XspfExtensionReaderFactoryPrivate")
- [Assignment operator](https://gitlab.xiph.org/xiph/libxspf/-/blob/63495bcec37fccbe955ccab106c1fd1ea49cb965/src/XspfReader.cpp#L315 "operator=()")https://gitlab.xiph.org/xiph/liboggz/-/issues/11reserved identifier violation2023-08-14T11:00:06ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__OGGZ_H__`](https://gitlab.xiph.org/xiph/liboggz/-/blob/acf142b3915bf6350fe3f8169614d9962b802391/include/oggz/oggz.h#L33 "Update candidate")” and “[`_OggzVector`](https://gitlab....:eyes: I would like to point out that identifiers like “[`__OGGZ_H__`](https://gitlab.xiph.org/xiph/liboggz/-/blob/acf142b3915bf6350fe3f8169614d9962b802391/include/oggz/oggz.h#L33 "Update candidate")” and “[`_OggzVector`](https://gitlab.xiph.org/xiph/liboggz/-/blob/acf142b3915bf6350fe3f8169614d9962b802391/src/liboggz/oggz_vector.c#L46 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/libskeleton/-/issues/2088reserved identifier violation2023-08-14T10:15:27ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__OGG_SKELETON_H__`](https://gitlab.xiph.org/xiph/libskeleton/-/blob/3c56c1b76a9b805bb1e2d2141a43b50f8e2dd232/include/skeleton/skeleton.h#L32 "Update candidate")” and “[`_OggSkele...:eyes: I would like to point out that identifiers like “[`__OGG_SKELETON_H__`](https://gitlab.xiph.org/xiph/libskeleton/-/blob/3c56c1b76a9b805bb1e2d2141a43b50f8e2dd232/include/skeleton/skeleton.h#L32 "Update candidate")” and “[`_OggSkeletonError`](https://gitlab.xiph.org/xiph/libskeleton/-/blob/3c56c1b76a9b805bb1e2d2141a43b50f8e2dd232/include/skeleton/skeleton_constants.h#L40 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/libfishsound/-/issues/12reserved identifier violation2023-08-14T09:30:05ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__FISH_SOUND_H__`](https://gitlab.xiph.org/xiph/libfishsound/-/blob/6815cab63df1a66f4d2b27c43632fe918857d1ce/include/fishsound/fishsound.h#L33 "Update candidate")” and “[`_FishSou...:eyes: I would like to point out that identifiers like “[`__FISH_SOUND_H__`](https://gitlab.xiph.org/xiph/libfishsound/-/blob/6815cab63df1a66f4d2b27c43632fe918857d1ce/include/fishsound/fishsound.h#L33 "Update candidate")” and “[`_FishSoundFlacInfo`](https://gitlab.xiph.org/xiph/libfishsound/-/blob/6815cab63df1a66f4d2b27c43632fe918857d1ce/src/libfishsound/flac.c#L59 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/liboggplay/-/issues/200Completion of error handling2023-08-14T09:11:14ZMarkus ElfringCompletion of error handlingWould you like to add more error handling for return values from functions like the following?
* [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [dump_streams_callback](https://gitl...Would you like to add more error handling for return values from functions like the following?
* [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [dump_streams_callback](https://gitlab.xiph.org/xiph/liboggplay/-/blob/c19ee00e23054f47445141c5870c1ed61b38f2ad/src/tools/oggplay-info.c#L19)
* [printf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output") ⇒ [_print_list](https://gitlab.xiph.org/xiph/liboggplay/-/blob/c19ee00e23054f47445141c5870c1ed61b38f2ad/src/liboggplay/oggplay_data.c#L122)https://gitlab.xiph.org/xiph/liboggplay/-/issues/199Complete build options for Pthread API2023-08-14T08:55:12ZMarkus ElfringComplete build options for Pthread API:thought_balloon: Would you like to add the configuration script “[AX_PTHREAD](https://www.gnu.org/software/autoconf-archive/ax_pthread.html "How to build C programs using POSIX threads")” to [your build specification](https://gitlab.xip...:thought_balloon: Would you like to add the configuration script “[AX_PTHREAD](https://www.gnu.org/software/autoconf-archive/ax_pthread.html "How to build C programs using POSIX threads")” to [your build specification](https://gitlab.xiph.org/xiph/liboggplay/-/blob/c19ee00e23054f47445141c5870c1ed61b38f2ad/configure.ac#L263 "Update candidate")?https://gitlab.xiph.org/xiph/liboggplay/-/issues/198reserved identifier violation2023-08-14T07:48:11ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__OGGPLAY_H__`](https://gitlab.xiph.org/xiph/liboggplay/-/blob/c19ee00e23054f47445141c5870c1ed61b38f2ad/include/oggplay/oggplay.h#L43 "Update candidate")” and “[`_OggPlayReader`](...:eyes: I would like to point out that identifiers like “[`__OGGPLAY_H__`](https://gitlab.xiph.org/xiph/liboggplay/-/blob/c19ee00e23054f47445141c5870c1ed61b38f2ad/include/oggplay/oggplay.h#L43 "Update candidate")” and “[`_OggPlayReader`](https://gitlab.xiph.org/xiph/liboggplay/-/blob/c19ee00e23054f47445141c5870c1ed61b38f2ad/include/oggplay/oggplay_reader.h#L48 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?https://gitlab.xiph.org/xiph/speexdsp/-/issues/11Completion of error handling2023-08-14T07:04:23ZMarkus ElfringCompletion of error handlingWould you like to [add more error handling](https://gitlab.xiph.org/xiph/speexdsp/-/blob/738e17905e1ca2a1fa932ddd9c2a85d089f4e845/libspeexdsp/fftwrap.c#L231 "Update candidate: spx_fft_init()") for return values from functions like [speex...Would you like to [add more error handling](https://gitlab.xiph.org/xiph/speexdsp/-/blob/738e17905e1ca2a1fa932ddd9c2a85d089f4e845/libspeexdsp/fftwrap.c#L231 "Update candidate: spx_fft_init()") for return values from functions like [speex_alloc()](https://gitlab.xiph.org/xiph/speexdsp/-/blob/738e17905e1ca2a1fa932ddd9c2a85d089f4e845/libspeexdsp/os_support.h#L48 "Memory allocation")?https://gitlab.xiph.org/xiph/speexdsp/-/issues/10reserved identifier violation2023-08-14T06:24:58ZMarkus Elfringreserved identifier violation:eyes: I would like to point out that identifiers like “[`__SPEEX_TYPES_H__`](https://gitlab.xiph.org/xiph/speexdsp/-/blob/738e17905e1ca2a1fa932ddd9c2a85d089f4e845/include/speex/speexdsp_config_types.h.in#L1 "Update candidate")” and “[`_...:eyes: I would like to point out that identifiers like “[`__SPEEX_TYPES_H__`](https://gitlab.xiph.org/xiph/speexdsp/-/blob/738e17905e1ca2a1fa932ddd9c2a85d089f4e845/include/speex/speexdsp_config_types.h.in#L1 "Update candidate")” and “[`_JitterBufferPacket`](https://gitlab.xiph.org/xiph/speexdsp/-/blob/738e17905e1ca2a1fa932ddd9c2a85d089f4e845/include/speex/speex_jitter.h#L56 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
:thought_balloon: Would you like to adjust your selection for unique names?