Xiph.Org issueshttps://gitlab.xiph.org/groups/xiph/-/issues2017-08-21T19:26:29Zhttps://gitlab.xiph.org/xiph/cortado/-/issues/1565[PATCH] Cortado doesn't handle incomplete packets correctly2017-08-21T19:26:29ZPhilip Heron[PATCH] Cortado doesn't handle incomplete packets correctlyThis patch updates the pagein function to match the current libogg
implementation. This fixes a bug where Cortado would die or display corrupt video when a Theora stream begins with an incomplete packet.
I have been testing this patch o...This patch updates the pagein function to match the current libogg
implementation. This fixes a bug where Cortado would die or display corrupt video when a Theora stream begins with an incomplete packet.
I have been testing this patch on my website for a few months now without issue.
This patch was also posted here:
https://bugzilla.wikimedia.org/show_bug.cgi?id=18906https://gitlab.xiph.org/xiph/libao/-/issues/611[PATCH] Current ao_sun.c does not support network environments2010-01-29T11:13:12Zosmail[PATCH] Current ao_sun.c does not support network environmentsSun has established environment variables to be used in determining the appropriate audio device. These environment variables were not being checked by src/plugins/sun/ao_sun.c, which simply hardcoded /dev/audio as the device.
I'm atta...Sun has established environment variables to be used in determining the appropriate audio device. These environment variables were not being checked by src/plugins/sun/ao_sun.c, which simply hardcoded /dev/audio as the device.
I'm attaching a context diff (as soon as I figure out how, or I'll mail it on request if I can't) which changes ao_sun.c so that it checks the environment. This updated ao_sun.c will:
1) use the UTAUDIODEV environment variable (used by the SunRay thin client), if set
2) try to use the AUDIODEV environment variable, if set
3) fall back to the hard-coded /dev/audio device if neither of the above two environment variables are set.
Also, I'm compiling libao-0.8.6, which isn't in the version list.Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/729[PATCH] Default of dev option not 0 for alsa09 as stated in ogg123, no inform...2009-04-19T21:09:40Ztmpusr67[PATCH] Default of dev option not 0 for alsa09 as stated in ogg123, no information on valid options for devThe man page lists the default for the alsa09 dev option as "0". If that were the case the following two lines would be equivalent.
```
ogg123 -d alsa09 cdda.ogg
ogg123 -d alsa09 -o dev:0 cdda.ogg
```
However the first line play...The man page lists the default for the alsa09 dev option as "0". If that were the case the following two lines would be equivalent.
```
ogg123 -d alsa09 cdda.ogg
ogg123 -d alsa09 -o dev:0 cdda.ogg
```
However the first line plays music on card number 0. The second line gives the error:
```
ALSA lib pcm.c:2090:(snd_pcm_open_noupdate) Unknown PCM 0
ALSA snd_pcm_open error: No such file or directory
Error: Cannot open device alsa09
```
I can find no example of how to play sound from ALSA card number 1 on the web. That "-o card:" is ignored is a known bug (see below) and the only hits on Google for
```
ogg123 alsa09 "-o dev:" or "-o card:"
```
are
```
ogg123 -d alsa09 -o dev:dmixer
```
and
```
DA bug report logs: maintainer ccheney@debian.org
#298237: /usr/bin/ogg123: ogg123 ignores -o card:1 option for alsa09 Package:
vorbis-tools (1.0.1-1.2); Reported by: Nathan Hurst ...
bugs.donarmstrong.com/cgi-bin/pkgreport.cgi?maint=ccheney@debian.org&arch=source
```tan Seiberttan Seiberthttps://gitlab.xiph.org/xiph/vorbis/-/issues/1557[PATCH] DESTROY ALL TRAILING BLANKS2017-04-08T10:58:44ZEldar[PATCH] DESTROY ALL TRAILING BLANKSDestroy all trailing blanks from libVorbis source files.Destroy all trailing blanks from libVorbis source files.Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/oggdsf/-/issues/1262[PATCH] directshow filters: generate correct number of frames, for Theora, Sp...2008-11-03T21:45:22ZGitlab Bot[PATCH] directshow filters: generate correct number of frames, for Theora, Speex and Vorbis encodersSee here:
http://lists.xiph.org/pipermail/theora-dev/2007-November/003449.htmlSee here:
http://lists.xiph.org/pipermail/theora-dev/2007-November/003449.htmlCristian AdamCristian Adamhttps://gitlab.xiph.org/xiph/theora/-/issues/1479[PATCH] Division by zero in libtheora-1.02010-02-01T21:13:50ZGitlab Bot[PATCH] Division by zero in libtheora-1.0Just for the record:
http://lists.xiph.org/pipermail/theora-dev/2008-December/003806.htmlJust for the record:
http://lists.xiph.org/pipermail/theora-dev/2008-December/003806.htmlhttps://gitlab.xiph.org/xiph/vorbis/-/issues/1352[PATCH] enable filter callback in ov_read()2017-04-08T10:58:44ZGitlab Bot[PATCH] enable filter callback in ov_read()Adding a separate ticket for libvorbis component of #381.Adding a separate ticket for libvorbis component of #381.Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/783[PATCH] Explicitly casts for (un)signed char* conversions (1/3)2018-03-06T12:49:49Zgtgbr[PATCH] Explicitly casts for (un)signed char* conversions (1/3)Pass 1/3: Add XMLSTR(str) macro to cast to (xmlChar *). Requires a fix to global.h, which needs to #include "avl/avl.h" for its avl_tree usage.Pass 1/3: Add XMLSTR(str) macro to cast to (xmlChar *). Requires a fix to global.h, which needs to #include "avl/avl.h" for its avl_tree usage.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/784[PATCH] Explicitly casts for (un)signed char* conversions (2/3)2018-03-06T12:49:49Zgtgbr[PATCH] Explicitly casts for (un)signed char* conversions (2/3)Pass 2/3: Add another macro, CCPSTR(str), for the other way round: casts to (const char *).Pass 2/3: Add another macro, CCPSTR(str), for the other way round: casts to (const char *).Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/785[PATCH] Explicitly casts for (un)signed char* conversions (3/3)2018-03-06T12:49:49Zgtgbr[PATCH] Explicitly casts for (un)signed char* conversions (3/3)Mop up the rest ... after this, lint is happy about it (gcc on recent Linux dists isn't quite happy yet, though.)Mop up the rest ... after this, lint is happy about it (gcc on recent Linux dists isn't quite happy yet, though.)Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/vorbis/-/issues/851[PATCH] Files missing in tarball2017-04-08T10:58:44ZGitlab Bot[PATCH] Files missing in tarballHi I see some files are missing from the tarball created with make dist:
The more recent RTP draft are not included, even if mentioned in the 1.1.2 changelog. There also other things not included (symbian dir, doc/fish_xiph_org.png, exa...Hi I see some files are missing from the tarball created with make dist:
The more recent RTP draft are not included, even if mentioned in the 1.1.2 changelog. There also other things not included (symbian dir, doc/fish_xiph_org.png, examples/frameview.pl, lib/misc.c, many files in vq/, todo.txt, and others ...) that may be useful.
Would be nice to build also a .bz2 tarball with make dist.
The same is for Theora, ticket #852 .Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2020[PATCH] Fix autogen.sh to work properly on Mac OS2018-03-06T12:49:47ZMarvin Scholz[PATCH] Fix autogen.sh to work properly on Mac OSThis patch fixes autogen.sh, so it will not exit with the error that libtool is not installed on Mac OS.
The command `libtoolize` on Mac OS is called `glibtoolize`, this patch makes it check for both versions.
This patch fixes autogen.sh, so it will not exit with the error that libtool is not installed on Mac OS.
The command `libtoolize` on Mac OS is called `glibtoolize`, this patch makes it check for both versions.
Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2306[PATCH] Fix build failure due to incorrect include ordering2020-10-21T08:50:27ZJoshua Root[PATCH] Fix build failure due to incorrect include orderingCommit 627da3d8 made an incorrect change: INCLUDES should have been changed to AM_CPPFLAGS rather than its contents being moved to AM_CFLAGS. Putting preprocessor flags in AM_CFLAGS results in them being passed in the wrong order relativ...Commit 627da3d8 made an incorrect change: INCLUDES should have been changed to AM_CPPFLAGS rather than its contents being moved to AM_CFLAGS. Putting preprocessor flags in AM_CFLAGS results in them being passed in the wrong order relative to CPPFLAGS, which results in build failure when a previous version of libshout is installed and its headers are in the same place as those of its dependencies.
Downstream bug: https://trac.macports.org/ticket/58466
[Makefile.am.patch](/uploads/bf297f2da070f02f791e49f0800e6205/Makefile.am.patch)Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/1136[PATCH] fix for libcurl API change in version 7.16.x2007-11-16T02:17:28Zgreeneg[PATCH] fix for libcurl API change in version 7.16.xI was trying to get vorbis-tools to compile with libcurl 7.16.1, which appears to have removed some defines from the API, specifically, CURLOPT_MUTE. After carefully tracing through the code when using version 7.15.5, the call to curl_ea...I was trying to get vorbis-tools to compile with libcurl 7.16.1, which appears to have removed some defines from the API, specifically, CURLOPT_MUTE. After carefully tracing through the code when using version 7.15.5, the call to curl_easy_setopt(handle, CURLOPT_MUTE, 1); would get discarded in the enormous switch statement in Curl_setopt. After removing that call in ogg123/http-transport.c vorbis-tools seems to build correctly and ogg123 works as expected with a cursory test pass by hand. Patch will be attached to this ticket.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/theora/-/issues/1192[PATCH] Fix invalid memory access when no theoracomments are found2007-11-23T00:19:07ZDiego Elio Pettenò[PATCH] Fix invalid memory access when no theoracomments are foundI'm attaching a patch that fixes invalid memory accesses when a stream contains no theoracomments. A sample where the problem can be seen is richard_stallman-speech-for-arcis-spanish-23_05_2005-1.ogg from FSF ( http://audio-video.gnu.org...I'm attaching a patch that fixes invalid memory accesses when a stream contains no theoracomments. A sample where the problem can be seen is richard_stallman-speech-for-arcis-spanish-23_05_2005-1.ogg from FSF ( http://audio-video.gnu.org/video/ ).
Without this patch, on glibc 2.6, libtheora usage causes bad crashes on xine-lib because of failed assertions during malloc().
As far as I can see on trunk/1.1 there is a similar issue, although the code is completely different, as the case for no comments at all is not handled differently, so at least one comment is being loaded.
https://gitlab.xiph.org/xiph/theora/-/issues/1804[PATCH] fix two spelling errors in theora2017-08-20T01:57:18Zmnemo[PATCH] fix two spelling errors in theorahttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/1122[PATCH] free of an unallocated pointer in ogginfo2007-11-16T01:54:48Ztentra[PATCH] free of an unallocated pointer in ogginfoWhen running ogginfo against a file with an invalid byte sequence in the comment section, ogginfo frees the pointer _decoded_ when it is only allocated through the call to utf8_decode that only happens when no detected encoding errors ar...When running ogginfo against a file with an invalid byte sequence in the comment section, ogginfo frees the pointer _decoded_ when it is only allocated through the call to utf8_decode that only happens when no detected encoding errors are present.
## Patch
```
--- vorbis-tools-1.1.1.orig/ogginfo/ogginfo2.c 2007-01-19 19:51:05.000000000 -0500
+++ vorbis-tools-1.1.1/ogginfo/ogginfo2.c 2007-01-19 19:49:47.000000000 -0500
@@ -298,8 +298,10 @@
}
*sep = 0;
- info("\t%s=%s\n", comment, decoded);
- free(decoded);
+ if(!broken) {
+ info("\t%s=%s\n", comment, decoded);
+ free(decoded);
+ }
}
static void theora_process(stream_processor *stream, ogg_page *page)
```
## Mac OS X (PPC), self compiled pre-patch output
```
herodotus:~/Desktop/sophocles/Mike_Oldfield-Tubular_Bells_2003 seneca$ ogginfo 09.Ghost_Bells.ogg
Processing file "09.Ghost_Bells.ogg"...
New logical stream (#1, serial: 0520f5a8): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
Vendor: Xiph.Org libVorbis I 20050304
Channels: 2
Rate: 44100
Nominal bitrate: 224.000000 kb/s
Upper bitrate not set
Lower bitrate not set
User comments section follows...
ARTIST=Mike Oldfield
Warning: Illegal UTF-8 sequence in comment 1 (stream 1): length marker wrong
ALBUM=Mike Oldfield
ogginfo(8965) malloc: *** error for object 0x4030a0: double free
ogginfo(8965) malloc: *** set a breakpoint in szone_error to debug
TITLE=Ghost Bells
DATE=2003
GENRE=New Age
TRACKNUMBER=09
CDDB=03115612
Vorbis stream 1:
Total data length: 731280 bytes
Playback length: 0m:30.546s
Average bitrate: 191.518114 kb/s
Logical stream 1 ended
herodotus:~/Desktop/sophocles/Mike_Oldfield-Tubular_Bells_2003 seneca$
```
## Ubuntu 6.10 (i386), package version 1.1.1-5 pre-patch output
```
seneca@hawk:~$ ogginfo /music/Mike_Oldfield-Tubular_Bells_2003/17.The_Sailors_Hornpipe.ogg
Processing file "/music/Mike_Oldfield-Tubular_Bells_2003/17.The_Sailors_Hornpipe.ogg"...
New logical stream (#1, serial: 121967e8): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
Vendor: Xiph.Org libVorbis I 20050304
Channels: 2
Rate: 44100
Nominal bitrate: 224.000000 kb/s
Upper bitrate not set
Lower bitrate not set
User comments section follows...
ARTIST=Mike Oldfield
Warning: Illegal UTF-8 sequence in comment 1 (stream 1): length marker wrong
ALBUM=
*** glibc detected *** ogginfo: double free or corruption (fasttop): 0x08070088 ***
======= Backtrace: =========
/lib/tls/i686/cmov/libc.so.6[0xb7e8f8bd]
/lib/tls/i686/cmov/libc.so.6(__libc_free+0x84)[0xb7e8fa44]
ogginfo[0x8049503]
ogginfo[0x8049936]
ogginfo[0x804a687]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xdc)[0xb7e3e8cc]
ogginfo[0x8048fb1]
======= Memory map: ========
08048000-0804d000 r-xp 00000000 03:01 1242650 /usr/bin/ogginfo
0804d000-0804e000 rwxp 00005000 03:01 1242650 /usr/bin/ogginfo
0804e000-08091000 rwxp 0804e000 00:00 0 [heap]
b7bf5000-b7bff000 r-xp 00000000 03:01 651600 /lib/libgcc_s.so.1
b7bff000-b7c00000 rwxp 00009000 03:01 651600 /lib/libgcc_s.so.1
b7c00000-b7c21000 rwxp b7c00000 00:00 0
b7c21000-b7d00000 ---p b7c21000 00:00 0
b7d1c000-b7d1e000 rwxp b7d1c000 00:00 0
b7d1e000-b7d51000 r-xp 00000000 03:01 2170271 /usr/lib/locale/en_CA.utf8/LC_CTYPE
b7d51000-b7e28000 r-xp 00000000 03:01 2170294 /usr/lib/locale/en_CA.utf8/LC_COLLATE
b7e28000-b7e29000 rwxp b7e28000 00:00 0
b7e29000-b7f56000 r-xp 00000000 03:01 652966 /lib/tls/i686/cmov/libc-2.4.so
b7f56000-b7f58000 r-xp 0012c000 03:01 652966 /lib/tls/i686/cmov/libc-2.4.so
b7f58000-b7f5a000 rwxp 0012e000 03:01 652966 /lib/tls/i686/cmov/libc-2.4.so
b7f5a000-b7f5d000 rwxp b7f5a000 00:00 0
b7f5d000-b7f61000 r-xp 00000000 03:01 1244259 /usr/lib/libogg.so.0.5.3
b7f61000-b7f62000 rwxp 00003000 03:01 1244259 /usr/lib/libogg.so.0.5.3
b7f62000-b7f86000 r-xp 00000000 03:01 655753 /lib/tls/i686/cmov/libm-2.4.so
b7f86000-b7f88000 rwxp 00023000 03:01 655753 /lib/tls/i686/cmov/libm-2.4.so
b7f88000-b7fa1000 r-xp 00000000 03:01 1244267 /usr/lib/libvorbis.so.0.3.1
b7fa1000-b7faf000 rwxp 00019000 03:01 1244267 /usr/lib/libvorbis.so.0.3.1
b7faf000-b7fb0000 rwxp b7faf000 00:00 0
b7fb3000-b7fb4000 r-xp 00000000 03:01 2170272 /usr/lib/locale/en_CA.utf8/LC_NUMERIC
b7fb4000-b7fb5000 r-xp 00000000 03:01 2170293 /usr/lib/locale/en_CA.utf8/LC_TIME
b7fb5000-b7fb6000 r-xp 00000000 03:01 2170295 /usr/lib/locale/en_CA.utf8/LC_MONETARY
b7fb6000-b7fb7000 r-xp 00000000 03:01 2170297 /usr/lib/locale/en_CA.utf8/LC_MESSAGES/SYS_LC_MESSAGES
b7fb7000-b7fb8000 r-xp 00000000 03:01 2170298 /usr/lib/locale/en_CA.utf8/LC_PAPER
b7fb8000-b7fb9000 r-xp 00000000 03:01 2170279 /usr/lib/locale/en_CA.utf8/LC_NAME
b7fb9000-b7fba000 r-xp 00000000 03:01 2170299 /usr/lib/locale/en_CA.utf8/LC_ADDRESS
b7fba000-b7fbb000 r-xp 00000000 03:01 2170300 /usr/lib/locale/en_CA.utf8/LC_TELEPHONE
b7fbb000-b7fbc000 r-xp 00000000 03:01 2170282 /usr/lib/locale/en_CA.utf8/LC_MEASUREMENT
b7fbc000-b7fc3000 r-xs 00000000 03:01 1238951 /usr/lib/gconv/gconv-modules.cache
b7fc3000-b7fc4000 r-xp 00000000 03:01 2170301 /usr/lib/locale/en_CA.utf8/LC_IDENTIFICATION
b7fc4000-b7fc5000 rwxp b7fc4000 00:00 0
b7fc5000-b7fde000 r-xp 00000000 03:01 657181 /lib/ld-2.4.so
b7fde000-b7fe0000 rwxp 00018000 03:01 657181 /lib/ld-2.4.so
bfe33000-bfe48000 rw-p bfe33000 00:00 0 [stack]
ffffe000-fffff000 ---p 00000000 00:00 0 [vdso]
Aborted (core dumped)
seneca@hawk:~$
```Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/theora/-/issues/1125[PATCH] French translation of Theora FAQ2017-04-07T23:20:35ZTiens Monmail[PATCH] French translation of Theora FAQHello,
I translate the FAQ of Theora. www.terups.freesurf.fr/FAQ_Theora.html
I want to do share, I was thinks interested the admin and every body don' t unterstand english.
Best regards.
Hello,
I translate the FAQ of Theora. www.terups.freesurf.fr/FAQ_Theora.html
I want to do share, I was thinks interested the admin and every body don' t unterstand english.
Best regards.
https://gitlab.xiph.org/xiph/icecast-server/-/issues/1873[PATCH] icecast does not read arbitrary capitalized headers2018-03-06T12:49:48ZPhilipp Schafft[PATCH] icecast does not read arbitrary capitalized headers(Forwarded from cato on IRC because of #1871)
the YP-Interface does not work according to the http rfc. To be specific icecast does not read arbitrary capitalized headers from the answer as the standard says.
I have written my own impl...(Forwarded from cato on IRC because of #1871)
the YP-Interface does not work according to the http rfc. To be specific icecast does not read arbitrary capitalized headers from the answer as the standard says.
I have written my own implementation of the server-side yp-interface. when I return for example "Ypmessage: 1" instead of "YPMessage: 1" icecast doesn't find the header and the submission to my directory fails
Section 4.2 of RFC 2616 says: "Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.
the error is in http://svn.xiph.org/icecast/trunk/icecast/src/yp.c in handle_returned_header(..) where instead of strncmp a case-insensitive comparison should be madeIcecast 2.4.0Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/1717[patch] icecast doesn't support chained SSL certificates2018-03-06T12:49:48ZDave Miller[patch] icecast doesn't support chained SSL certificatesSituation:
globally accepted certificate authority has certified another certificate authority for signing SSL certificates. The certificate authority that everyone has in their root cert databases has signed the second authority's root ...Situation:
globally accepted certificate authority has certified another certificate authority for signing SSL certificates. The certificate authority that everyone has in their root cert databases has signed the second authority's root cert with theirs, with signing rights granted. The second authority then signs our certificate.
This is called a chained SSL certificate. Every SSL client I've ever seen can deal with them, however, they usually take a little additional setup on the server end to make it work.
We operate several large websites with SSL certificates signed by this same vendor. In Apache, there is a separate configuration option for a certificate chain file. In some other applications (most notably mail servers) you can append the chain certificate onto the end of your own certificate, and it will Just Work.
Based on the way the config is set up in Icecast, it should be using the second method (appending the chain cert onto the end of the pem file for the certs). However, Icecast is using the wrong API call into OpenSSL for this to work.
Patch attached to fix.Michael SmithMichael Smith