Xiph.Org issueshttps://gitlab.xiph.org/groups/xiph/-/issues2008-11-03T21:45:22Zhttps://gitlab.xiph.org/xiph/oggdsf/-/issues/1262[PATCH] directshow filters: generate correct number of frames, for Theora, Sp...2008-11-03T21:45:22ZGitlab Bot[PATCH] directshow filters: generate correct number of frames, for Theora, Speex and Vorbis encodersSee here:
http://lists.xiph.org/pipermail/theora-dev/2007-November/003449.htmlSee here:
http://lists.xiph.org/pipermail/theora-dev/2007-November/003449.htmlCristian AdamCristian Adamhttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2298building with TLS causes shout_set_metadata to fail with SHOUTERR_INSANE with...2019-05-14T16:44:28ZRJ Ryanbuilding with TLS causes shout_set_metadata to fail with SHOUTERR_INSANE with Shoutcast serversRelated to #2244 -- tested with latest libshout master (2dd6cfb7190bdfd4cb5a1fb663f00e630462e9e1) on OSX.
Mixxx 2.0 and onwards uses libshout 2.4.1 built with TLS enabled (using SHOUT_TLS_AUTO) on OSX and we were receiving user reports ...Related to #2244 -- tested with latest libshout master (2dd6cfb7190bdfd4cb5a1fb663f00e630462e9e1) on OSX.
Mixxx 2.0 and onwards uses libshout 2.4.1 built with TLS enabled (using SHOUT_TLS_AUTO) on OSX and we were receiving user reports of metadata not working with Shoutcast (not Icecast) servers.
I saw ph3-der-loewe's patch:
https://github.com/xiph/Icecast-libshout/commit/4542dc2d7efd7b12ab80a45cfa4bb4ff6d03fc24
which I thought would fix it, but I can still reproduce at head.
I dug in and realized that shout_set_metadata was returning SHOUTERR_INSANE because self->tls_mode_used is SHOUTERR_NOTLS at the time we send metadata. My understanding is that if tls_mode is SHOUT_TLS_AUTO, then the correct result of the state machine is that self->tls_mode_used becomes SHOUT_TLS_DISABLED if a TLS upgrade is not possible.
Here is the Mixxx bug which has more details:
https://bugs.launchpad.net/mixxx/+bug/1544739
I applied this hack to try_connect where it says "TODO: do something":
```
++ if (self->tls_mode == SHOUT_TLS_AUTO_NO_PLAIN) {
++ self->tls_mode_used = SHOUTERR_NOTLS;
++ return SHOUTERR_NOTLS;
++ }
++ self->tls_mode_used = SHOUT_TLS_DISABLED;
```
which works around the issue.
I doubt this is the right fix though since I think this block is supposed to "poke the server" like the comment says above :) since we haven't successfully probed the server yet.
Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2288Outdated FSF address2018-07-16T09:13:39ZFrancisco de la PeñaOutdated FSF addressThis is a well known issue and a reporting this upstream is a requirement for some distribution packaging checks, so here it is.
The Free Software Foundation postal address mentioned in license texts changed.
The new address should be ...This is a well known issue and a reporting this upstream is a requirement for some distribution packaging checks, so here it is.
The Free Software Foundation postal address mentioned in license texts changed.
The new address should be the mentioned in http://www.gnu.org/licenses/old-licenses/lgpl-2.0.txt
The old address is found at least in the COPYING and source file headers.Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2244Libshout fails to handle auto TLS properly2019-05-14T16:44:28ZStephen FairchildLibshout fails to handle auto TLS properlyIf I connect using auto TLS and the server does not support it then we will connect but the TLS mode will still be set to auto. This prevents shout_set_metadata from working. Worse still, it will connect when the no plaintext option is s...If I connect using auto TLS and the server does not support it then we will connect but the TLS mode will still be set to auto. This prevents shout_set_metadata from working. Worse still, it will connect when the no plaintext option is selected.
Patch supplied.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2243Patch for warning messages during build process2017-11-16T12:06:13ZStephen FairchildPatch for warning messages during build processThe attached patch will eliminate warnings during the build process.
Removed all deprecated "INCLUDES =" directives from the makefiles. These are now supposed to be included with CFLAGS. If you still want to group include file paths thi...The attached patch will eliminate warnings during the build process.
Removed all deprecated "INCLUDES =" directives from the makefiles. These are now supposed to be included with CFLAGS. If you still want to group include file paths this can be done without using the deprecated upper case "INCLUDES".
AM_INIT_AUTOMAKE new style is to not supply any parameters so those have been removed.
In the code itself removed an unused variable and supplied a missing const directive.Marvin ScholzMarvin Scholzhttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2239Libshout 2.4.0, 2.4.1 make distcheck fails.2017-11-16T12:06:13ZStephen FairchildLibshout 2.4.0, 2.4.1 make distcheck fails.Libshout compiles and installs, make dist also works but attempting the package sanity check: make distcheck fails with the following error message snippet.
In file included from ../../../src/shout.c:38:0:
../../../src/common/httpp/http...Libshout compiles and installs, make dist also works but attempting the package sanity check: make distcheck fails with the following error message snippet.
In file included from ../../../src/shout.c:38:0:
../../../src/common/httpp/httpp.h:30:21: fatal error: avl/avl.h: No such file or directory
#include <avl/avl.h>
^
compilation terminated.
Marvin ScholzMarvin Scholzhttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2238Delete SHOUTERR_METADATA2017-11-16T12:06:13ZPhilipp SchafftDelete SHOUTERR_METADATAThe error value SHOUTERR_METADATA is never used and has no comment telling what it should be used for. Also the error-to-string function shout_get_error() doesn't include it.
This should be cleaned up as part of the next ABI change.The error value SHOUTERR_METADATA is never used and has no comment telling what it should be used for. Also the error-to-string function shout_get_error() doesn't include it.
This should be cleaned up as part of the next ABI change.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2235libshout-2.4.0 fails to compile: No rule to make target 'libshout.ckport'2017-11-16T12:06:13ZTimo Gurrlibshout-2.4.0 fails to compile: No rule to make target 'libshout.ckport'2.3.1 compiles fine, but 2.4.0 fails. Please see the attached full build log.2.3.1 compiles fine, but 2.4.0 fails. Please see the attached full build log.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2234libshout does not URL-encode 'mount' URL parameter in shout_set_metadata2017-11-16T12:06:13ZRJ Ryanlibshout does not URL-encode 'mount' URL parameter in shout_set_metadataMixxx bug: https://bugs.launchpad.net/mixxx/+bug/1329202
A user is trying to use a mount with URL-query-reserved-characters in it -- for example "/live?stream_id=1&tracking=2".
When calling 'shout_set_metadata', libshout directly inse...Mixxx bug: https://bugs.launchpad.net/mixxx/+bug/1329202
A user is trying to use a mount with URL-query-reserved-characters in it -- for example "/live?stream_id=1&tracking=2".
When calling 'shout_set_metadata', libshout directly inserts the mount into the metadata-update URL rather than first URL-encoding it as per RFC 3986 -- which leads the Icecast2 (and other servers) being unable to correctly decode the mountpoint.
Happy to provide more info if needed.
Best regards,
RJGitlab BotGitlab Bothttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2233Escape mount string in metadata in libshout (or allow user to specify a diffe...2018-06-16T21:36:01ZKevin WernEscape mount string in metadata in libshout (or allow user to specify a different string)In shout.c, the same string is used for both the mountpoint in the metadata URI and the mountpoint itself. This causes an issue when the string contains characters that could be parsed incorrectly (i.e. a URI with a querystring), because...In shout.c, the same string is used for both the mountpoint in the metadata URI and the mountpoint itself. This causes an issue when the string contains characters that could be parsed incorrectly (i.e. a URI with a querystring), because the mountpoint specified in the metadata no longer correlates to the mountpoint that was created. In our case, we have a string that needs to be escaped in the metadata URI only.
I was thinking shout_t could have a separate property for the metadata mount string (and a corresponding setter the user could call), and if it isn't set when shout_set_metadata() is called, then the function uses the original mount property.
Another solution to our problem specifically would always escaping the single mount string for the metadata string, but I think the solution above is more general. (Think, for instance, if a user wanted to send querystring parameters with the SOURCE call, but truncate it to just the resource in the metadata)
I could write a quick patch for either, but I wanted to get your input first.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2206[PATCH] Update the libshout python bindings to the libshout git version2019-05-22T07:44:49Zdivayth[PATCH] Update the libshout python bindings to the libshout git versionI added methods for tls, ca_directory, ca_file, allowed_ciphers and for get and set_meta.
The first list is implemented as class attributes of the shout object and *_meta as methods.
It is still missing docstrings and help because I wa...I added methods for tls, ca_directory, ca_file, allowed_ciphers and for get and set_meta.
The first list is implemented as class attributes of the shout object and *_meta as methods.
It is still missing docstrings and help because I was not sure what to write.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2193Plugin-ify the formats code2019-05-15T09:21:43ZGuillaume QuintardPlugin-ify the formats codeCurrently, libshout support mp3, ogg and webm, but some use cases require more (in Arkena case, we need aac support). Unfortunately, due to (valid) license/political reason, integrating more formats is blocked, leading to poorly maintain...Currently, libshout support mp3, ogg and webm, but some use cases require more (in Arkena case, we need aac support). Unfortunately, due to (valid) license/political reason, integrating more formats is blocked, leading to poorly maintained forks (see https://github.com/codders/libshout).
I started working on a branch (https://github.com/gquintard/Icecast-libshout/tree/feature-plugin) to have format plugins. It is not complete, and there are several objections to it (most prominently the use of mimes to identify the relevant plugin). So this ticket is here to track remarks/questions/note about this work.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2190ezstream (libshout?) hangs while streaming the attached mp32017-11-16T12:06:13Zjakebriggsezstream (libshout?) hangs while streaming the attached mp3ezstream (libshout?) hangs while streaming the attached mp3. Using advanced debugging techniques (printf's, everywhere, a forest of printf's) I've made my way down to the function shout_send in libshout - specifically I think this never ...ezstream (libshout?) hangs while streaming the attached mp3. Using advanced debugging techniques (printf's, everywhere, a forest of printf's) I've made my way down to the function shout_send in libshout - specifically I think this never returns:
```
return self->send(self, data, len);
```
but my advanced debugging techniques ran out of steam here.... I might have a play with gdb but I've never played with that before....Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2153libshout should support PUT2019-05-14T16:44:29ZThomas B. Rückerlibshout should support PUTIcecast supports it since 2.4.0
Bonus points for implementing chunked and non-chunked mode, as 2.4-series doesn't support chunked, sadly.Icecast supports it since 2.4.0
Bonus points for implementing chunked and non-chunked mode, as 2.4-series doesn't support chunked, sadly.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2152libshout should support HTTPS2017-11-16T12:06:13ZThomas B. Rückerlibshout should support HTTPSIcecast supports HTTPS for quite a while now.
It would be nice if source clients would be able to connect over HTTPS. This would e.g. protect authentication credentials.Icecast supports HTTPS for quite a while now.
It would be nice if source clients would be able to connect over HTTPS. This would e.g. protect authentication credentials.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2115Remove Debian packaging from libshout2017-11-16T12:06:13ZThomas B. RückerRemove Debian packaging from libshoutWe already dropped it from Icecast and IceS, we should also do so for libshout before next release. Nobody maintains the Debian packaging on our side, downstream has their own.We already dropped it from Icecast and IceS, we should also do so for libshout before next release. Nobody maintains the Debian packaging on our side, downstream has their own.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2114[patch]Fix overlinking of libshout2017-11-16T12:06:13ZThomas B. Rücker[patch]Fix overlinking of libshoutSo Debian have found a problem with our package config.
Simple fix, see attached patch.
2007 is a good vintage for a patch. ;-)So Debian have found a problem with our package config.
Simple fix, see attached patch.
2007 is a good vintage for a patch. ;-)Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2090libshout host resolution for IPv4/IPv6 hosts2017-11-16T12:06:13ZRJ Ryanlibshout host resolution for IPv4/IPv6 hostsMixxx received a bug report from a user with an icecast server bound to an ipv4 interface on a machine with a hostname that resolves to both an i-p-v-4 and i-p-v-6 address.
https://bugs.launchpad.net/mixxx/+bug/1391654
Desired behavior...Mixxx received a bug report from a user with an icecast server bound to an ipv4 interface on a machine with a hostname that resolves to both an i-p-v-4 and i-p-v-6 address.
https://bugs.launchpad.net/mixxx/+bug/1391654
Desired behavior:
For a hostname that resolves to both an i-p-v-4 and i-p-v-6 address, libshout should probe both and pick the first one that works.
Based on this mailing list thread:
http://lists.xiph.org/pipermail/icecast-dev/2014-November/002373.html
this would be acceptable behavior for libshout via recommendation from RFC 6555.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/1946oggfwd/ezstream: mime-type is always application/ogg2020-10-21T08:50:27Ztuxoggfwd/ezstream: mime-type is always application/oggIn most cases for multimedia streaming and conferencing, the user will probably want audio/ogg instead of application/ogg mime types (see RFC5334). However, oggfwd 0.2-6 and ezstream 0.5.6~dfsg-1 on Debian always sends things with applic...In most cases for multimedia streaming and conferencing, the user will probably want audio/ogg instead of application/ogg mime types (see RFC5334). However, oggfwd 0.2-6 and ezstream 0.5.6~dfsg-1 on Debian always sends things with application/ogg.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-libshout/-/issues/1923libshout-2.3.1 compilation warnings2017-11-16T12:06:13Zmirrazlibshout-2.3.1 compilation warningsBuilding libshout-2.3.1 for my Gentoo I got this warnings:
timing.c:53:5: warning: implicit declaration of function ‘gettimeofday’ [-Wimplicit-function-declaration]
shout.c:1004:4: warning: implicit declaration of function ‘shout_open_we...Building libshout-2.3.1 for my Gentoo I got this warnings:
timing.c:53:5: warning: implicit declaration of function ‘gettimeofday’ [-Wimplicit-function-declaration]
shout.c:1004:4: warning: implicit declaration of function ‘shout_open_webm’ [-Wimplicit-function-declaration]Michael SmithMichael Smith