Xiph.Org issueshttps://gitlab.xiph.org/groups/xiph/-/issues2017-04-08T10:58:44Zhttps://gitlab.xiph.org/xiph/vorbis/-/issues/201Setting a very low maximum bitrate causes audio loss.2017-04-08T10:58:44ZStan SeibertSetting a very low maximum bitrate causes audio loss.```
Using oggenc and libvorbis from CVS (2002-06-18), files encoded with a maximum
bitrate of 8 kbps are missing the first 30+ seconds of audio. Encoding with
-M 16 results in files that are missing small gaps of audio every so often....```
Using oggenc and libvorbis from CVS (2002-06-18), files encoded with a maximum
bitrate of 8 kbps are missing the first 30+ seconds of audio. Encoding with
-M 16 results in files that are missing small gaps of audio every so often.
The granulepos values are still in sync with the original, so it looks like
the encoder is not outputting certain packets.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/194bm->avg_binacc is not initialized with zeros, resulting in too large ogg fil...2017-04-08T10:58:44Zal.faberbm->avg_binacc is not initialized with zeros, resulting in too large ogg files when encodign with fixed bitrate settings```
Within the bitrate.c file, the array bm->avg_binacc is allocated (with
ogg_malloc) but is not initialized. A malloc does not have to initialize
the allocated memory chunk with zero's (it might be compiler dependent
though). The be...```
Within the bitrate.c file, the array bm->avg_binacc is allocated (with
ogg_malloc) but is not initialized. A malloc does not have to initialize
the allocated memory chunk with zero's (it might be compiler dependent
though). The behaviour that's observed is that resulting file will be way too
large when trying to encode with a fixed bitrate (bitrate is increasing
(drifting) during the encoding process. The solution is to add a the following
line just after the ogg_malloc:
(void)memset( bm->avg_binacc, 0,bins*sizeof(*bm->avg_binacc) );
But this problem might be at more places in the code and are very hard to
track down. So it might be well worth to redirect the ogg_malloc function to a
calloc function (which is guarenteed to initialize the allocated memory chunk
with zero's)
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/191libvorbis built with Sun Forte 6.1 compiler produces bogus output2017-04-08T10:58:44Zatomik_katlibvorbis built with Sun Forte 6.1 compiler produces bogus output```
This is an error in the libvorbis module when compiled under Sun's Forte 6.1 C
compiler suite.
Once compiled, a trace of the ogg123 program shows that ogg123 opens the audio
device and assigns a file descriptor, but all that os ev...```
This is an error in the libvorbis module when compiled under Sun's Forte 6.1 C
compiler suite.
Once compiled, a trace of the ogg123 program shows that ogg123 opens the audio
device and assigns a file descriptor, but all that os ever written to that
desciptor is a series of nulls.
libvorbis compiled under GCC 3.03 works fine.
I have not traced the bug any farther, but can provide the authors with object
files and compiled binaries for testing.
Geoff
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/189cc1 segmentation fault on compile2017-04-08T10:58:44Zjupitercc1 segmentation fault on compile```
I'm trying to compile libvorbis 1.0rc3, and cc1 segmentation faults (internal
error) when compiling lib/envelope.c
I am using gcc 2.95.3 (20010315), binutils 2.12, and gcc 2.2.5 on an i686 (2.2.18)
``````
I'm trying to compile libvorbis 1.0rc3, and cc1 segmentation faults (internal
error) when compiling lib/envelope.c
I am using gcc 2.95.3 (20010315), binutils 2.12, and gcc 2.2.5 on an i686 (2.2.18)
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/187gcc 2.95.3 chokes on -mno-ieee-fp2017-04-08T10:58:44Zdoctorkaedinggcc 2.95.3 chokes on -mno-ieee-fp```
During make, gcc 2.95.3 chokes.
I traced it to "-mno-ieee-fp" in the "PROFILE".
It does not appear in the profile for libao
or libogg, which compile OK.
``````
During make, gcc 2.95.3 chokes.
I traced it to "-mno-ieee-fp" in the "PROFILE".
It does not appear in the profile for libao
or libogg, which compile OK.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/182_vorbis_block_alloc assumes _ogg_malloc aligns to at least WORD_ALIGN2017-04-08T10:58:44ZGitlab Bot_vorbis_block_alloc assumes _ogg_malloc aligns to at least WORD_ALIGN```
To guarantee WORD_ALIGN alignment, you need to align the pointer after
calling _ogg_malloc(), or _ogg_realloc().
If you are doing cache tuning, you might want to push WORD_ALIGN fairly
high, like 16 or 32 depending on the cache ar...```
To guarantee WORD_ALIGN alignment, you need to align the pointer after
calling _ogg_malloc(), or _ogg_realloc().
If you are doing cache tuning, you might want to push WORD_ALIGN fairly
high, like 16 or 32 depending on the cache architecture.
possible patch:
*** block.c 2002/03/29 07:34:09 1.64
--- block.c 2002/04/12 11:02:00
***************
*** 115,120 ****
--- 115,122 ----
/* highly conservative */
vb->localalloc=bytes;
vb->localstore=_ogg_malloc(vb->localalloc);
+ vb->localstore=(void*)(((long)((char*)vb->localstore+
+ (WORD_ALIGN-1))) & ~(WORD_ALIGN-1));
vb->localtop=0;
}
{
***************
*** 137,143 ****
}
/* consolidate storage */
if(vb->totaluse){
! vb->localstore=_ogg_realloc(vb->localstore,vb->totaluse+vb->
localalloc);
vb->localalloc+=vb->totaluse;
vb->totaluse=0;
}
--- 139,148 ----
}
/* consolidate storage */
if(vb->totaluse){
! long tot=(vb->totaluse+vb->localalloc+(WORD_ALIGN-1)) &
~(WORD_ALIGN-1);
! vb->localstore=_ogg_realloc(vb->localstore,tot);
! vb->localstore=(void*)(((long)((char*)vb->localstore+
! (WORD_ALIGN-1))) & ~(WORD_ALIGN-1));
vb->localalloc+=vb->totaluse;
vb->totaluse=0;
}
It may be better to define a macro that does the alignment.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/162libvorbis 1.0rc3 crashes gcc 2.95.3-2 on an i686 PC Linux 2.4.16 with glibc 2...2017-04-08T10:58:44Zfrantzlibvorbis 1.0rc3 crashes gcc 2.95.3-2 on an i686 PC Linux 2.4.16 with glibc 2.2.4```
Hi,
I have an i686 PC using Linux version 2.4.16, glibc version 2.2.4, gcc version
2.95.3 with the 2.95.3-2 patch.
I have successfuly compiled libao 0.8.2 and libogg 1.0rc3, but when trying to
compile libvorbis 1.0rc3 the compiler gi...```
Hi,
I have an i686 PC using Linux version 2.4.16, glibc version 2.2.4, gcc version
2.95.3 with the 2.95.3-2 patch.
I have successfuly compiled libao 0.8.2 and libogg 1.0rc3, but when trying to
compile libvorbis 1.0rc3 the compiler gives me the following error:
/bin/sh ../libtool --mode=compile gcc -DPACKAGE=\"libvorbis\" -DVERSION=\"1.0rc3\" -DHAVE_DLFCN_H=1 -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DHAVE_SQRTF=1 -DHAVE_LOGF=1 -DHAVE_EXPF=1 -DHAVE_ACOSF=1 -DHAVE_ATANF=1 -DHAVE_FREXPF=1 -DHAVE_RINTF=1 -I. -I. -I../include -O20 -ffast-math -mno-ieee-fp -D_REENTRANT -fsigned-char -Os -mcpu=i686 -march=i686 -DUSE_MEMORY_H -c envelope.c
gcc -DPACKAGE=\"libvorbis\" -DVERSION=\"1.0rc3\" -DHAVE_DLFCN_H=1 -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DHAVE_SQRTF=1 -DHAVE_LOGF=1 -DHAVE_EXPF=1 -DHAVE_ACOSF=1 -DHAVE_ATANF=1 -DHAVE_FREXPF=1 -DHAVE_RINTF=1 -I. -I. -I../include -O20 -ffast-math -mno-ieee-fp -D_REENTRANT -fsigned-char -Os -mcpu=i686 -march=i686 -DUSE_MEMORY_H -c envelope.c -fPIC -DPIC -o envelope.lo
gcc: Internal compiler error: program cc1 got fatal signal 11
make[2]: *** [envelope.lo] Error 1
make[2]: Leaving directory `/usr/local/src/libvorbis-1.0rc3/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/local/src/libvorbis-1.0rc3/lib'
make: *** [all-recursive] Error 1
I have also tried unsetting the -Os -mcpu=i686 -march=i686 CFLAGS before the
./configure command, but the compiler continues crashing at the same point.
What can I do in order to make the libvorbis package compile correctly?
Thanks
Franco -- frantz@sitoverde.com
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/161-b -M does not fill in max bitrate field2017-04-08T10:58:44Zgreg-b -M does not fill in max bitrate field```
$ oggenc -b 128 -M 130 -o test2.ogg file.wav
$ hex test2.ogg | head -10
0x00000000: 4f 67 67 53 00 02 00 00 - 00 00 00 00 00 00 2a 0d OggS..........*.
0x00000010: 72 54 00 00 00 00 2d 01 - 74 8a 01 1e 01 76 6f 72 rT....-.t....vor
0x...```
$ oggenc -b 128 -M 130 -o test2.ogg file.wav
$ hex test2.ogg | head -10
0x00000000: 4f 67 67 53 00 02 00 00 - 00 00 00 00 00 00 2a 0d OggS..........*.
0x00000010: 72 54 00 00 00 00 2d 01 - 74 8a 01 1e 01 76 6f 72 rT....-.t....vor
0x00000020: 62 69 73 00 00 00 00 02 - 44 ac 00 00 ff ff ff ff bis.....D.......
0x00000030: 1f f4 01 00 ff ff ff ff - b8 01 4f 67 67 53 00 00 ..........OggS..
The min/max bitrate fields are still "ff ff ff ff" (-1). The nominal bitrate
field is correctly set to "1f f4 01 00" (128031).
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/143Memory leak2017-04-08T10:58:44ZGitlab BotMemory leak```
The function static decode_aux *_make_decode_tree(codebook *c) in the
file "SharedBook.c" has a major memory leak. It calls calloc() twice,
storing the pointers to ptr0 and ptr1. However, nowhere in the code is
there a call to fre...```
The function static decode_aux *_make_decode_tree(codebook *c) in the
file "SharedBook.c" has a major memory leak. It calls calloc() twice,
storing the pointers to ptr0 and ptr1. However, nowhere in the code is
there a call to free(). As a result, this function will leak the two blocks of
memory every time it is called.
Should be a 15 minute fix.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/134examples don't compile with C902017-04-08T10:58:44Zpapadopoexamples don't compile with C90```
Hi,
I suggest you use C90 /**/ comments instead of C99 // comments so that
vorbis compiles on older UNIX which lack a C99 compiler. Using the Sun
Workshop 5.0 compiler:
gmake[1]: Entering directory `/tmp/libvorbis-1.0rc3/examples'
...```
Hi,
I suggest you use C90 /**/ comments instead of C99 // comments so that
vorbis compiles on older UNIX which lack a C99 compiler. Using the Sun
Workshop 5.0 compiler:
gmake[1]: Entering directory `/tmp/libvorbis-1.0rc3/examples'
[..]
cc -DPACKAGE=\"libvorbis\" -DVERSION=\"1.0rc3\" -DHAVE_DLFCN_H=1
-DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DHAVE_SQRTF=1 -I. -I. -I../include
-I/usr/local/libogg/include -xO4 -fast -w -fsimple -native -xcg92 -fast
-DUSE_MEMORY_H -c encoder_example.c
"encoder_example.c", line 100: syntax error before or at: /
cc: acomp failed for encoder_example.c
```Segher BoessenkoolSegher Boessenkoolhttps://gitlab.xiph.org/xiph/vorbis/-/issues/93OpenBSD 3.0: extra parameter to vorbis/configure needed for mindless building2017-04-08T10:58:44ZnisharfiOpenBSD 3.0: extra parameter to vorbis/configure needed for mindless building```
configure, on OpenBSD, requires --with-ogg=/usr/local/ added on since
neither /usr/local/include nor /usr/local/lib are in the #include or link pool
by default.
``````
configure, on OpenBSD, requires --with-ogg=/usr/local/ added on since
neither /usr/local/include nor /usr/local/lib are in the #include or link pool
by default.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/92vorbis/autogen.sh has two unpaired quote marks diff file here2017-04-08T10:58:44Znisharfivorbis/autogen.sh has two unpaired quote marks diff file here```
--- autogen.sh Thu Aug 23 10:39:54 2001
+++ autogen.sh.new Thu Dec 20 16:33:26 2001
@@ -21,7 +21,7 @@
(automake --version) < /dev/null > /dev/null 2>&1 || {
echo
echo "You must have automake installed to compile $p...```
--- autogen.sh Thu Aug 23 10:39:54 2001
+++ autogen.sh.new Thu Dec 20 16:33:26 2001
@@ -21,7 +21,7 @@
(automake --version) < /dev/null > /dev/null 2>&1 || {
echo
echo "You must have automake installed to compile $package."
- echo "Download the appropriate package for your system,
+ echo "Download the appropriate package for your system,"
echo "or get the source from one of the GNU ftp sites"
echo "listed in http://www.gnu.org/order/ftp.html"
DIE=1
@@ -30,7 +30,7 @@
(libtool --version) < /dev/null > /dev/null 2>&1 || {
echo
echo "You must have libtool installed to compile $package."
- echo "Download the appropriate package for your system,
+ echo "Download the appropriate package for your system,"
echo "or get the source from one of the GNU ftp sites"
echo "listed in http://www.gnu.org/order/ftp.html"
DIE=1
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/87Access violation for 1 channel (mono) wave files2017-04-08T10:58:44ZbenAccess violation for 1 channel (mono) wave files```
I downloaded the vorbis_nightly_cvs.tar.gz on 29 Nov 2001 and built it.
running oggenc is fine for stereo wave files, but for mono, I get an exception
in file vorbis/lib/psy.c, in function:
_vp_quantize_couple(vorbis_look_psy * 0x007...```
I downloaded the vorbis_nightly_cvs.tar.gz on 29 Nov 2001 and built it.
running oggenc is fine for stereo wave files, but for mono, I get an exception
in file vorbis/lib/psy.c, in function:
_vp_quantize_couple(vorbis_look_psy * 0x007b7e80, vorbis_info_mapping0 *
0x006a8dec, float * * 0x007089f8, float * * 0x0068f6fc, float * * 0x0068f700,
int * 0x0068f708, int 0) line 1021 + 32 bytes
in the following line:
float ang,mag,fmag=max(fabs(pcmM[j]),fabs(pcmA[j]));
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/86RC2 @ 160kB/s misencodes or misdecodes one specific file2017-04-08T10:58:44ZgumbootRC2 @ 160kB/s misencodes or misdecodes one specific file```
This applies to one specific file out of >1000, and only at 160kB/s with RC2,
but I can repeat it, using the Debian packages (latest for Woody).
Sound appears further left, while the right speaker occasionally pops and
squeaks. Som...```
This applies to one specific file out of >1000, and only at 160kB/s with RC2,
but I can repeat it, using the Debian packages (latest for Woody).
Sound appears further left, while the right speaker occasionally pops and
squeaks. Sometimes, if the file is stopped at the right point the speaker will
pop again (perhaps a DC component).
Email me and tell me where to upload/email the file or a segment of the file.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/84overflow in vorbis_staticbook_unpack()2017-04-08T10:58:44ZSegher Boessenkooloverflow in vorbis_staticbook_unpack()```
...for length ordered books. the inner (j) loop should check for overflowing
the outer (i) loop.
``````
...for length ordered books. the inner (j) loop should check for overflowing
the outer (i) loop.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/79doc/programming.html still says packet-&gt;frameno2017-04-08T10:58:44Ztimjdoc/programming.html still says packet->frameno```
packet->frameno has be renamed to granulepos according to Vakor.
``````
packet->frameno has be renamed to granulepos according to Vakor.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/66Sample encoder output sounds like a tape on fast forward2017-04-08T10:58:44ZstarclassSample encoder output sounds like a tape on fast forward```
When the encoder in vorbis/examples is used to compress a WAV sample,
the output of the resulting ogg file sounds like a tape player
on fast cue forward.
``````
When the encoder in vorbis/examples is used to compress a WAV sample,
the output of the resulting ogg file sounds like a tape player
on fast cue forward.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/65autoconf option cleanup/enhancement2017-04-08T10:58:44ZStan Seibertautoconf option cleanup/enhancement```
This bug is for tracking changes that need to be made to the autoconf script
in libvorbis.
As of right now, the suggested changes are:
--with-ogg-prefix => --with-ogg
--with-ogg-includes: For setting the ogg include dir if differe...```
This bug is for tracking changes that need to be made to the autoconf script
in libvorbis.
As of right now, the suggested changes are:
--with-ogg-prefix => --with-ogg
--with-ogg-includes: For setting the ogg include dir if different than the
default
--with-ogg-libraries: For setting the ogg library dir if different than the
default
```Stan SeibertStan Seiberthttps://gitlab.xiph.org/xiph/vorbis/-/issues/62libvorbis example fails to build with solaris math libs2017-04-08T10:58:44ZGitlab Botlibvorbis example fails to build with solaris math libs```
gcc --version
2.95.3
I had a poke around but could not find this logged already:
gmake[1]: Entering directory `/DATA/build/libvorbis-1.0beta4/examples'
gcc -DPACKAGE=\"libvorbis\" -DVERSION=\"1.0beta4\" -DHAVE_ALLOCA_H=1 -DHAVE_ALL...```
gcc --version
2.95.3
I had a poke around but could not find this logged already:
gmake[1]: Entering directory `/DATA/build/libvorbis-1.0beta4/examples'
gcc -DPACKAGE=\"libvorbis\" -DVERSION=\"1.0beta4\" -DHAVE_ALLOCA_H=1 -DHAVE_ALLO
CA=1 -I. -I. -I../include -O20 -ffast-math -D__NO_MATH_INLINES -fsigned-ch
ar -mv8 -DUSE_MEMORY_H -c decoder_example.c
/bin/sh ../libtool --mode=link gcc -O20 -ffast-math -D__NO_MATH_INLINES -fsigne
d-char -mv8 -DUSE_MEMORY_H -static -o decoder_example decoder_example.o ../lib/
libvorbis.la -lm -logg
mkdir .libs
gcc -O20 -ffast-math -D__NO_MATH_INLINES -fsigned-char -mv8 -DUSE_MEMORY_H -o de
coder_example decoder_example.o ../lib/.libs/libvorbis.a -lm -logg -lm -logg
../lib/.libs/libvorbis.a(envelope.o): In function `_ve_envelope_init':
envelope.o(.text+0x154): undefined reference to `expf'
../lib/.libs/libvorbis.a(envelope.o): In function `_ve_envelope_search':
envelope.o(.text+0x884): undefined reference to `logf'
envelope.o(.text+0x8d0): undefined reference to `logf'
../lib/.libs/libvorbis.a(psy.o): In function `setup_curve':
psy.o(.text+0xe4): undefined reference to `expf'
etc
However I can't find the function calls it is wingeing about;
there is no expf() in _ve_envelope_init for example.
Is this a compiler bug? I use solaris nm & ld.
```Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/vorbis/-/issues/57&#34;vorbis_commentheader_out&#34; not exported in vorbis.def2017-04-08T10:58:44Zadonnai"vorbis_commentheader_out" not exported in vorbis.def```
The function "vorbis_commentheader_out" isn't listed in vorbis.def so linking
fails when calling it. One exmaple, vorbiscomment, couldn't compile because of
this bug.
``````
The function "vorbis_commentheader_out" isn't listed in vorbis.def so linking
fails when calling it. One exmaple, vorbiscomment, couldn't compile because of
this bug.
```Monty MontgomeryMonty Montgomery