Xiph.Org issueshttps://gitlab.xiph.org/groups/xiph/-/issues2017-04-07T23:21:36Zhttps://gitlab.xiph.org/xiph/theora/-/issues/1414Thusnelda's encoder_example creates corrupted video files2017-04-07T23:21:36ZzikzakThusnelda's encoder_example creates corrupted video filesI'm using the following commands:
rm -f stream.*
mkfifo -m 660 stream.yuv
mkfifo -m 660 stream.wav
mplayer -vo yuv4mpeg -ao null -nosound -quiet test.avi > video.log &
mplayer -srate 22050 -af volume=2,channels=1 -ao pcm:fast:file=...I'm using the following commands:
rm -f stream.*
mkfifo -m 660 stream.yuv
mkfifo -m 660 stream.wav
mplayer -vo yuv4mpeg -ao null -nosound -quiet test.avi > video.log &
mplayer -srate 22050 -af volume=2,channels=1 -ao pcm:fast:file=stream.wav -vc dummy -vo null -quiet test.avi > audio.log &
./encoder_example -k 1000 -n 6 -m 2 -b 0:0:0.0 -v 10.0 -a -1 stream.wav stream.yuv -o HODOK_Annc0819_USTrailer.ogv
Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/theora/-/issues/1409trunk won't build in Visual Studio .NET 20032008-08-05T10:36:13ZGitlab Bottrunk won't build in Visual Studio .NET 2003trunk build won't build in Visual Studio .NET 2003 as (...) and !__VA_ARGS!__ are not supported prior to Visual Studio .NET 2005.
I found a workaround for this:
```
#if defined(_MSC_VER) && _MSC_VER < 1400
#define TH_DEBUG /##/
#else
...trunk build won't build in Visual Studio .NET 2003 as (...) and !__VA_ARGS!__ are not supported prior to Visual Studio .NET 2005.
I found a workaround for this:
```
#if defined(_MSC_VER) && _MSC_VER < 1400
#define TH_DEBUG /##/
#else
#define TH_DEBUG(...)
#endif
```
this will erase the line with TH_DEBUG in older VC++. Tested in VC6 / VC 7.1.https://gitlab.xiph.org/xiph/theora/-/issues/1406ltablex.sty missing from latest source archive2017-04-07T23:20:35Zglynltablex.sty missing from latest source archiveAfter downloading the latest tarball, libtheora-1.0beta3.tar.gz, "make all" fails because LaTeX can't find the file ltablex.sty. This file was present in -1.0beta2, and is still present in svn head.After downloading the latest tarball, libtheora-1.0beta3.tar.gz, "make all" fails because LaTeX can't find the file ltablex.sty. This file was present in -1.0beta2, and is still present in svn head.https://gitlab.xiph.org/xiph/theora/-/issues/1402Update of theora from 1.0alpha7 to 1.0beta3 lead to play ogg mosaic.2008-10-30T15:46:14Zwendy.huUpdate of theora from 1.0alpha7 to 1.0beta3 lead to play ogg mosaic.When I installed theora(version 1.0alpha7) on sparc (snv_91), totem
displays ogg format video normally. But after installing theora version 1.0beta3, totem displays ogg video mosaic. So the update of theora from 1.0alpha7 to 1.0beta3 lea...When I installed theora(version 1.0alpha7) on sparc (snv_91), totem
displays ogg format video normally. But after installing theora version 1.0beta3, totem displays ogg video mosaic. So the update of theora from 1.0alpha7 to 1.0beta3 lead to playing ogg video mosaic.
The ogg format video at http://gstreamer.freedesktop.org/media/incoming/, i.e.https://gitlab.xiph.org/xiph/theora/-/issues/1396Cannot build .tar.bz2 file!2017-04-07T23:20:35ZalexisCannot build .tar.bz2 file!Guys guys guys!
I cannot create the .tar.bz2 file... without the Theora.pdf file!
You've got to make sure that the make dist-bzip2 does not require that file!
There was some kind of a fix that does not work (I have the most current SV...Guys guys guys!
I cannot create the .tar.bz2 file... without the Theora.pdf file!
You've got to make sure that the make dist-bzip2 does not require that file!
There was some kind of a fix that does not work (I have the most current SVN).
You should try to get a clean environment with svn co http://svn.xiph.org/trunk/theora, then do ./autogen.sh and finally: make dist-bzip2
That works great with 1.0.beta3. 8-)
Thank you.
Alexishttps://gitlab.xiph.org/xiph/theora/-/issues/1373libtheora package is missing the x86_vc subfolder2008-09-19T18:20:12Zramin.dalkouhilibtheora package is missing the x86_vc subfolderThe libtheora package is missing the visual studio related subfolder lib/dev/x86_vc which can be found from within the svn-trunk.The libtheora package is missing the visual studio related subfolder lib/dev/x86_vc which can be found from within the svn-trunk.https://gitlab.xiph.org/xiph/theora/-/issues/1372Many (minor) bugs in LibTheora 1.0b3, directory structure cleanup2008-10-04T20:44:06ZGitlab BotMany (minor) bugs in LibTheora 1.0b3, directory structure cleanupI found many (minor) bugs (?) in LibTheora 1.0b3, and possibility (?) for optimization of the dir structure :
----
1. Version string is not updated in INTERNAL.H
`# define OC_VENDOR_STRING "Xiph.Org libTheora I 20071025 3 2 1"`
I alr...I found many (minor) bugs (?) in LibTheora 1.0b3, and possibility (?) for optimization of the dir structure :
----
1. Version string is not updated in INTERNAL.H
`# define OC_VENDOR_STRING "Xiph.Org libTheora I 20071025 3 2 1"`
I already had whined about this here: https://trac.xiph.org/ticket/1363
----
2. Useless macro *HIGHBITDUPPED* defined 2x differently:
```
#define HIGHBITDUPPED(X) (((ogg_int16_t) X) >> 15)
#define HIGHBITDUPPED(X) (((signed short) X) >> 15)
```
In *DCTDECODE.C* and *ENCODE.C* .
In both files, it's used 1x only, so the IMHO solution is to delete it and replace with "direct" implementation using *ogg_int16_t* in both files. About not using OGG integer typdef's , YES, I had already whined about this here: https://trac.xiph.org/ticket/1329 "BITWISE.C typedef's in LibOGG" . So deleting some more silly INT's , SHORT's and LONG's at this occasion would be great.
----
3. CPUID'ding is not completely barred out if "USE_ASM" isn't defined:
{{{void dsp_static_init(DspFunctions *funcs)
{
ogg_uint32_t cpuflags;
cpuflags = oc_cpu_flags_get ();
dsp_init (funcs);
dsp_recon_init (funcs, cpuflags);
dsp_dct_init (funcs, cpuflags);
#if defined(USE_ASM)
if (cpuflags & OC_CPU_X86_MMX) {
dsp_mmx_init(funcs);
}
# ifndef WIN32
/* This is implemented for win32 yet */
if (cpuflags & OC_CPU_X86_MMXEXT) {
dsp_mmxext_init(funcs);
}
# endif // WIN32
#endif // USE_ASM
}
}}}
Then IMHO "CPU.C" and "CPU.H" should get completely barred out from the compilaton, "oc_cpu_flags_get" not called, and "cpuflags" (correctly using "ogg_uint32_t" here :-) ) deleted also or set directly to 0 at least.
4. Directory structure: there are 2 dirs, "ENC" and "DEC" , plus some files elsewhere: "CPU.*" stuff above, some "*.H" files in "INCLUDE" . Compiling the decoder doesn't require any files from "ENC", OTOH the encoder requires __some__ files from "DEC" , nowhere documented what ones exactly, need to find out "the hard way" . Idea: create a directory "COMMON" and move the shared files into it.
5. "ENC" contains "ENCODER_DISABLED.C" ... useful ? Seems not to me ...
6. *_ilog* stuff is defined 2x differently:
```
static int _ilog(unsigned _v){
int ret;
for(ret=0;_v;ret++)_v>>=1;
return ret;
}
```
```
static int _ilog(unsigned int v){
int ret=0;
while(v){
ret++;
v>>=1;
}
return(ret);
}
```
IMHO 1 piece would be sufficient, using "ogg_uint32_t" for both "v" and "ret" , and a good candidate to be placed in "COMMON" , see 4. .
7. BITWISE duplicate:
```
- Use a custom copy of the libogg bitpacker in the decoder
to avoid function call overhead.
```
Why not in the encoder also ? Idea: rename "BITWISE.C" and "BITWISE.H" of LibTheora into "TBITWISE.C" and "TBITWISE.H" to avoid confusion with "BITWISE.*" from LibOGG and delete dependency of LibTheora on *.C files of LibOGG. I had already whined about lack of typedef's, efficiency, compatibility and docs of BITWISE here: https://trac.xiph.org/ticket/1329 "BITWISE.C typedef's in LibOGG" .
https://gitlab.xiph.org/xiph/theora/-/issues/1369[PATCH] Compile failure on OS/X (libtheora)2008-10-21T05:35:32ZGitlab Bot[PATCH] Compile failure on OS/X (libtheora)Compiling on OS/X fails due to "Absolute addressing ... not allowed in slidable image". Patch attached.
Feel free to reopen if you have a new patch.Compiling on OS/X fails due to "Absolute addressing ... not allowed in slidable image". Patch attached.
Feel free to reopen if you have a new patch.https://gitlab.xiph.org/xiph/theora/-/issues/1367libtheora doesn't compile under vanilla OS X 10.5.22008-05-25T23:38:45ZGitlab Botlibtheora doesn't compile under vanilla OS X 10.5.2I have an Intel Mac mini which came from Apple about a month ago, with 10.5.2 installed. I have installed the os updates since then. I have also installed the Xcode tools on the disk that came with it, in the standard location. I down...I have an Intel Mac mini which came from Apple about a month ago, with 10.5.2 installed. I have installed the os updates since then. I have also installed the Xcode tools on the disk that came with it, in the standard location. I downloaded and compiled libfaad2, libogg, and libvorbis without any problems. I downloaded libtheora 1.0 beta 3, and verified the md5 sum. I ran .configure without any problems, but when I run make, I get the error
.
.
.
gcc -dynamiclib ${wl}-flat_namespace ${wl}-undefined ${wl}suppress -o .libs/libtheoraenc.1.0.0.dylib .libs/cpu.o .libs/dct_decode_mmx.o .libs/dsp_mmx.o .libs/dsp_mmxext.o .libs/recon_mmx.o .libs/idct_mmx.o .libs/fdct_mmx.o .libs/dct_encode.o .libs/encode.o .libs/encoder_huffman.o .libs/encoder_idct.o .libs/encoder_toplevel.o .libs/encoder_quant.o .libs/encapiwrapper.o .libs/blockmap.o .libs/dct.o .libs/dct_decode.o .libs/frarray.o .libs/frinit.o .libs/mcomp.o .libs/misc_common.o .libs/pb.o .libs/pp.o .libs/reconstruct.o .libs/scan.o .libs/dsp.o /usr/local/lib/libogg.dylib -Wl,-read_only_relocs -Wl,suppress -install_name /usr/local/lib/libtheoraenc.1.dylib -compatibility_version 2 -current_version 2.0
ld: absolute addressing (perhaps -mdynamic-no-pic) used in _FilterHoriz__mmx from .libs/dct_decode_mmx.o not allowed in slidable image
collect2: ld returned 1 exit status
make[2]: *** [libtheoraenc.la] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
https://gitlab.xiph.org/xiph/theora/-/issues/1364Theora docs in HTML2017-04-07T23:20:35ZGitlab BotTheora docs in HTMLCould you please provide Theora docs in HTML also besides PDF ? Vorbis already has HTML docs.
Could you please provide Theora docs in HTML also besides PDF ? Vorbis already has HTML docs.
https://gitlab.xiph.org/xiph/theora/-/issues/1363Version string not updated in INTERNAL.H2008-10-21T01:15:59ZGitlab BotVersion string not updated in INTERNAL.H```
# define OC_VENDOR_STRING "Xiph.Org libTheora I 20071025 3 2 1"
```
https://trac.xiph.org/browser/trunk/theora/lib/internal.h?rev=14829
LibTheora 1.0b3
```
# define OC_VENDOR_STRING "Xiph.Org libTheora I 20071025 3 2 1"
```
https://trac.xiph.org/browser/trunk/theora/lib/internal.h?rev=14829
LibTheora 1.0b3
https://gitlab.xiph.org/xiph/theora/-/issues/1356libtheora test programs do not build on Solaris2008-05-03T21:07:40ZBrian Cameronlibtheora test programs do not build on Solaris
Building libtheora 1.0beta 3, the programs granulepos, granulepos_theoraenc, and granulepos_theora do not build on Solaris because they need "-lm" added to the link statement. I am attaching a patch that fixes this problem.
Building libtheora 1.0beta 3, the programs granulepos, granulepos_theoraenc, and granulepos_theora do not build on Solaris because they need "-lm" added to the link statement. I am attaching a patch that fixes this problem. https://gitlab.xiph.org/xiph/theora/-/issues/1346new encoder_example.c missing features2017-04-07T23:21:36ZGitlab Botnew encoder_example.c missing featuresThe new encoder_example.c of trunk/theora which make use of the new API misses some features that were available in the old encoder_example.c. Comparing this with that on theora-thusnelda seems that at least are missing the following com...The new encoder_example.c of trunk/theora which make use of the new API misses some features that were available in the old encoder_example.c. Comparing this with that on theora-thusnelda seems that at least are missing the following command line options:
```
- begin-time
- end-time
- noise-sensitivity
- sharpness
- keyframe-freq
```
There seems to be other things missing. That features were present before the creation of the thusnelda branch.
Also I noticed the line:
audio_q=(float)(atof(optarg)*.099);
which gives a slighty different vorbis quality that what given on the command line, and is different of what is get whith other vorbis tools (e.g. oggenc) which uses a 0.1 multiplier.https://gitlab.xiph.org/xiph/theora/-/issues/1338Add API call to request a duplicate compressed frame2010-02-01T21:09:28ZGitlab BotAdd API call to request a duplicate compressed frameThis was planned for beta1:
http://wiki.xiph.org/index.php/Theora:Beta1ToDoThis was planned for beta1:
http://wiki.xiph.org/index.php/Theora:Beta1ToDohttps://gitlab.xiph.org/xiph/theora/-/issues/1336uninitialised theora_info values2008-10-14T20:50:18ZGitlab Botuninitialised theora_info valuesOpening a ticket, just in case this problem was forgotten:
http://lists.xiph.org/pipermail/theora-dev/2008-January/003519.htmlOpening a ticket, just in case this problem was forgotten:
http://lists.xiph.org/pipermail/theora-dev/2008-January/003519.htmlhttps://gitlab.xiph.org/xiph/theora/-/issues/1335error during make check2008-04-11T06:09:39ZGitlab Boterror during make check```
granulepos.c:107: th_granule_frame returned incorrect results
FAIL: granulepos
...[cut]...
PASS: granulepos_theora
===================
1 of 9 tests failed
===================
``````
granulepos.c:107: th_granule_frame returned incorrect results
FAIL: granulepos
...[cut]...
PASS: granulepos_theora
===================
1 of 9 tests failed
===================
```https://gitlab.xiph.org/xiph/theora/-/issues/1334[theora-exp] rehuff stdout problem2008-04-12T21:14:36ZGitlab Bot[theora-exp] rehuff stdout problemI can't reopen #1285, so I'll open this new ticket.
There is a problem with the fix in [14392]. If redirecting stdout to a file, some statistics that should go to stderr go in the rehuffed file, producing a corrupted file. See also 3rd ...I can't reopen #1285, so I'll open this new ticket.
There is a problem with the fix in [14392]. If redirecting stdout to a file, some statistics that should go to stderr go in the rehuffed file, producing a corrupted file. See also 3rd comment of #1285. They should be redirected to stderr.
Also, bug #1288 should be closed as fixed.Timothy B. TerriberryTimothy B. Terriberryhttps://gitlab.xiph.org/xiph/theora/-/issues/1328minor bug in LibTheora with UINT32<02009-04-19T20:59:36ZGitlab Botminor bug in LibTheora with UINT32<0Seems that I (better to say the compiler) found a minor bug in DECINFO.C: there are 6 comparisons of an UINT32 to be "<=" 0 ... while "=", oops "==" in C, would be sufficient ;-)
```
Warning! W136: Comparison equivalent to 'unsigned == ...Seems that I (better to say the compiler) found a minor bug in DECINFO.C: there are 6 comparisons of an UINT32 to be "<=" 0 ... while "=", oops "==" in C, would be sufficient ;-)
```
Warning! W136: Comparison equivalent to 'unsigned == 0'
Warning! W136: Comparison equivalent to 'unsigned == 0'
Warning! W136: Comparison equivalent to 'unsigned == 0'
Warning! W136: Comparison equivalent to 'unsigned == 0'
if(_info->frame_width<=0||_info->frame_height<=0||
_info->pic_width+_info->pic_x>_info->frame_width||
_info->pic_height+_info->pic_y>_info->frame_height||
_info->fps_numerator<=0||_info->fps_denominator<=0){
return TH_EBADHEADER;
Warning! W136: Comparison equivalent to 'unsigned == 0'
Warning! W136: Comparison equivalent to 'unsigned == 0'
/*We shoud have already decoded the info header, and should not yet have
decoded the comment header.*/
if(_info->frame_width<=0||_tc->vendor!=NULL)return TH_EBADHEADER;
ret=oc_comment_unpack(_opb,_tc);
if(ret<0)th_comment_clear(_tc);
else ret=2;
}break;
/*Codec setup header.*/
case 0x82:{
oc_setup_info *setup;
if(_tc==NULL||_setup==NULL)return TH_EFAULT;
/*We should have already decoded the info header and the comment header,
and should not yet have decoded the setup header.*/
if(_info->frame_width<=0||_tc->vendor==NULL||*_setup!=NULL){
return TH_EBADHEADER;
}
```
https://gitlab.xiph.org/xiph/theora/-/issues/1299make check fails 1 of 9 tests failed2008-04-11T06:10:19ZGitlab Botmake check fails 1 of 9 tests failedI tried theora (svn r14423) make check on some linux machines (Ubuntu 6.06 and 7.10 on both 32 and 64 bit x86) and 1 test always fails. This is the error I get:
```
---- + Initializing th_info struct ...
---- + Allocating encoder cont...I tried theora (svn r14423) make check on some linux machines (Ubuntu 6.06 and 7.10 on both 32 and 64 bit x86) and 1 test always fails. This is the error I get:
```
---- + Initializing th_info struct ...
---- + Allocating encoder context ...
---- + Setting up dummy 4:2:0 frame data ...
---- + Checking granulepos generation ...
granulepos.c:104: encoder granulepos does not map to the correct frame number
FAIL: granulepos
```https://gitlab.xiph.org/xiph/theora/-/issues/1297[PATCH] Make a few tables constant2008-09-19T19:44:29ZDiego Elio Pettenò[PATCH] Make a few tables constantThe attached patch makes a few table constants, moving up to 2664 (for libtheora built with encoder) bytes from .data to .rodata.
Unfortunately the improvement here is mostly theorical, for shared object, as there are 1216 bytes (for 64...The attached patch makes a few table constants, moving up to 2664 (for libtheora built with encoder) bytes from .data to .rodata.
Unfortunately the improvement here is mostly theorical, for shared object, as there are 1216 bytes (for 64-bit systems) in .data.rel.ro.local caused by function pointers and TH_VP31_QUANT_INFO table. Those can be mitigated by a working prelink, so it's still useful to apply this patch.