Xiph.Org issueshttps://gitlab.xiph.org/groups/xiph/-/issues2017-08-03T06:41:38Zhttps://gitlab.xiph.org/xiph/positron/-/issues/641Positron runs fine on my Mac G4 but on my PC it has never run well. All files...2017-08-03T06:41:38Zvornan19Positron runs fine on my Mac G4 but on my PC it has never run well. All files are where they should be. I want to move to x86 but I want my music too.Finding existing audio files on the Neuros...
94 found.
Adding music tracks to music database...
Traceback (most recent call last):
File "/usr/bin/positron", line 199, in ?
main(sys.argv)
File "/usr/bin/positron", line 181, in...Finding existing audio files on the Neuros...
94 found.
Adding music tracks to music database...
Traceback (most recent call last):
File "/usr/bin/positron", line 199, in ?
main(sys.argv)
File "/usr/bin/positron", line 181, in main
cmd.run(config, myNeuros, remaining[1:])
File "/usr/lib/python2.3/site-packages/positron/cmd_rebuild.py", line 110, in run
audio_db = neuros.open_db("audio")
File "/usr/lib/python2.3/site-packages/positron/neuros.py", line 167 in open_DB
self.db_formats[name]["no_flatten"]
File "/usr/lib/python2.3/site-packages/positron/db/WOID.py", line 74, in open mdb.open(mdbpath)
File "/usr/lib/python2.3/site-packages/positron/db/MDB.py", line 113, in open self.file = file(filename, "r+b")
IOError: [Errno 2] No such file or directory: '/mnt/neuros/WOID_DB/audio/audio.mdb
Stan SeibertStan Seiberthttps://gitlab.xiph.org/xiph/icecast-server/-/issues/640last character of playlist log is truncated2018-03-06T12:50:22Zbirbecklast character of playlist log is truncatedIn Icecast version 2.2.0 the last character of the playlist log is truncated.
In the function update_comments on line 252 of format_ogg.c the line is
len += strlen(artist) + strlen(title) + 3;
the line should read
len += strlen(art...In Icecast version 2.2.0 the last character of the playlist log is truncated.
In the function update_comments on line 252 of format_ogg.c the line is
len += strlen(artist) + strlen(title) + 3;
the line should read
len += strlen(artist) + strlen(title) + 4;
I have applied to patch to my source tree and the playlist log reads correctly.
Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/639ogg123: remote .m3u playlist files2018-01-22T04:18:37ZGitlab Botogg123: remote .m3u playlist filesIt seems silly to me that Icecast will generate .m3u files dynamically for.ogg mountpoints but ogg123 can't make use of them.It seems silly to me that Icecast will generate .m3u files dynamically for.ogg mountpoints but ogg123 can't make use of them.Gitlab BotGitlab Bothttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/638Better handling of invalid/missing streams in OGG1232018-01-22T04:18:37ZGitlab BotBetter handling of invalid/missing streams in OGG123I'd like to see better handling of error messages for streams. Right
now the user has no idea why it failed, only that it did.
If it was an HTTP error, printing this should be sufficient. If it wasn't
an ogg vorbis file, the MIME type...I'd like to see better handling of error messages for streams. Right
now the user has no idea why it failed, only that it did.
If it was an HTTP error, printing this should be sufficient. If it wasn't
an ogg vorbis file, the MIME type really should say so (assuming it's
being checked) and ogg123 shouldn't ever have to try opening it, unless we
want to try streams regardless of mime type.Gitlab BotGitlab Bothttps://gitlab.xiph.org/xiph/positron/-/issues/636positron 1.1 does not recognise Neuros on Ubuntu (case problem?)2017-08-03T06:41:38Ztoojayspositron 1.1 does not recognise Neuros on Ubuntu (case problem?)When running "positron configure", I get the warning: "Warning: A Neuros does not appear to be mounted at /media/usbdisk/." I proceed with the configuration, because I know there is a Neuros there. But when I try "positron rebuild", I ge...When running "positron configure", I get the warning: "Warning: A Neuros does not appear to be mounted at /media/usbdisk/." I proceed with the configuration, because I know there is a Neuros there. But when I try "positron rebuild", I get:
```
toojays@fuzz:~$ positron rebuild
Traceback (most recent call last):
File "/usr/bin/positron", line 205, in ?
main(sys.argv)
File "/usr/bin/positron", line 166, in main
os.mkdir(dbdir)
OSError: [Errno 17] File exists: '/media/usbdisk/WOID_DB'
```
I figure this is maybe something to do with Ubuntu mounting the drive in some way where the case is different, because I have woid_db, not WOID_DB:
```
toojays@fuzz:/tmp/positron-1.1$ ls -l /media/usbdisk/
total 224
drwx------ 2 toojays toojays 16384 2004-10-22 09:08 151 - Poisoning the System
drwx------ 7 toojays toojays 16384 2004-09-21 14:33 bak_db
drwx------ 2 toojays toojays 16384 2005-03-22 06:28 erin_smith_band - downtownsmogcrown
drwx------ 2 toojays toojays 16384 2004-09-21 14:33 firmware
drwx------ 2 toojays toojays 16384 2004-10-22 09:01 francesca gregorini - sequel
drwx------ 2 toojays toojays 16384 2004-10-22 09:07 Machine Gun Fellatio - On Ice
-rwx------ 1 toojays toojays 18 2004-06-21 02:08 neuros.m3u
drwx------ 2 toojays toojays 16384 2004-10-22 09:05 phontaine - phontaine
-rwx------ 1 toojays toojays 14 2004-04-18 21:17 sn.txt
-rwx------ 1 toojays toojays 6 2004-04-18 21:17 version.txt
drwx------ 7 toojays toojays 16384 2004-10-22 15:49 woid_db
drwx------ 2 toojays toojays 16384 2004-09-21 14:34 WOID_HISI
drwx------ 2 toojays toojays 16384 2004-09-30 16:23 WOID_RECORD
drwx------ 2 toojays toojays 16384 2004-09-21 14:34 WOID_SYNC
```
Ubuntu has mounted the drive like so:
```
toojays@fuzz:/tmp/positron-1.1$ cat /etc/mtab | grep usbdisk
/dev/sda1 /media/usbdisk vfat rw,nosuid,nodev,sync,noatime,quiet,uid=1000,gid=1000,umask=077,iocharset=utf8 0 0
```
Stan SeibertStan Seiberthttps://gitlab.xiph.org/xiph/icecast-server/-/issues/635icecast 2.2.0 bugz2018-11-10T12:58:03ZGitlab Boticecast 2.2.0 bugz1) The XSL parser has some unchecked buffers (local),but they dont seem
to be exploitable. If they are, they can be used for priviledge escalation,
under the user that the server runs.
```xslt
<xsl:when test="<lots of chars>"></xsl...1) The XSL parser has some unchecked buffers (local),but they dont seem
to be exploitable. If they are, they can be used for priviledge escalation,
under the user that the server runs.
```xslt
<xsl:when test="<lots of chars>"></xsl:when>
<xsl:if test="<lots of chars>"></xsl:if>
<xsl:value-of select="<lots of chars>" />
```
2) Cause XSL parser error "Could not parse XSLT file". (Not very useful).
```
GET /status.xsl> HTTP/1.0
GET /status.xsl< HTTP/1.0
GET /<status.xsl HTTP/1.0
```
3) XSL parser bypass. (Useful to steal customized XSL files, lol).
```
GET /auth.xsl. HTTP/1.0
GET /status.xsl. HTTP/1.0
```
Thomas B. RückerThomas B. Rückerhttps://gitlab.xiph.org/xiph/ogg/-/issues/634oggcodecs: Still can not play ogg files2020-11-06T03:56:13ZGitlab Botoggcodecs: Still can not play ogg filesI have dowloaded the oggcodecs_0.69.8924 but windows media player and any other player will not play ogg files. Before I ran the file I removed any other ogg files and I closed all of the open files. I am running Windows XP.I have dowloaded the oggcodecs_0.69.8924 but windows media player and any other player will not play ogg files. Before I ran the file I removed any other ogg files and I closed all of the open files. I am running Windows XP.Gitlab BotGitlab Bothttps://gitlab.xiph.org/xiph/icecast-server/-/issues/633Client count in stats.xml continues to increase.2018-03-06T12:50:22ZJoel EbelClient count in stats.xml continues to increase.In stats.xml, the <icestats><clients> value continually increases. Every time I restart a source, this number goes up and never comes back down. Right now it's up to 432 even though I have a 100 client limit. It seems that when a sour...In stats.xml, the <icestats><clients> value continually increases. Every time I restart a source, this number goes up and never comes back down. Right now it's up to 432 even though I have a 100 client limit. It seems that when a source disconnects, this client value doesn't decrement, but when a listening client disconnects it does. There could be more to it than that, but that's what it appears to be to me.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/632Incorrect Base64 decoder in utils (missing '2018-03-06T12:50:22ZGitlab BotIncorrect Base64 decoder in utils (missing '*Base64 utils. Encode is ok, but decode? '=' is missed, so, VLC, that
contains correct base64 encoder, produces '=' at the end of the string.
We need to pacth that case in decoder:
char *util_base64_decode(unsigned char *input)
{
...*Base64 utils. Encode is ok, but decode? '=' is missed, so, VLC, that
contains correct base64 encoder, produces '=' at the end of the string.
We need to pacth that case in decoder:
char *util_base64_decode(unsigned char *input)
{
int len = strlen(input);
char *out = malloc(len*3/4 + 5);
char *result = out;
signed char vals[4];
while(len > 0) {
if(len < 4 && *input != '=')
{
free(result);
return NULL; /* Invalid Base64 data */
} else if (*input == '=') break;
Icecast 2.3Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/631Authentication fails: authentication file location undefined2018-03-06T12:50:21ZGitlab BotAuthentication fails: authentication file location undefinedAuthentication requires a file (mypath in example), that resides in unknown
location (current dir? which one?). So, look at the string, when we edit the file:
(in function static auth_result htpasswd_deleteuser(auth_t *auth, const
char *...Authentication requires a file (mypath in example), that resides in unknown
location (current dir? which one?). So, look at the string, when we edit the file:
(in function static auth_result htpasswd_deleteuser(auth_t *auth, const
char *username)):
sprintf(tmpfile, ".%s.tmp", state->filename);
we are adding a dot. it is not correct, because location of the file is
not known. if I put the full path, I can get strange result, yeh?
Icecast 2.3Ed "oddsock" ZaleskiEd "oddsock" Zaleskihttps://gitlab.xiph.org/xiph/icecast-server/-/issues/630pidfile and changeowner2018-03-06T12:50:21ZStephane Billiartpidfile and changeownerit would be nice to write the pidfile as root, i.e. before _ch_root_uid_setup in main.c
this would allow to save the pidfile in a system directory (/var/run) instead of a private
directory
most daemons who change their uid bahave like t...it would be nice to write the pidfile as root, i.e. before _ch_root_uid_setup in main.c
this would allow to save the pidfile in a system directory (/var/run) instead of a private
directory
most daemons who change their uid bahave like this (apache, squid, ntop, ...)Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/629setbinmode not defined if using MinGW (and MSYS)2005-03-10T23:51:40Zdjvsetbinmode not defined if using MinGW (and MSYS)MinGW does not, for obvious reasons, define _MSC_VER
so when trying to compile oggenc one gets an error due to undefined setbinmode.
The easiest way to fix this is to use the following patch:
----
```
--- oggenc/platform.c.orig Wed Mar ...MinGW does not, for obvious reasons, define _MSC_VER
so when trying to compile oggenc one gets an error due to undefined setbinmode.
The easiest way to fix this is to use the following patch:
----
```
--- oggenc/platform.c.orig Wed Mar 9 17:12:05 2005
+++ oggenc/platform.c Wed Mar 9 17:14:12 2005
@@ -38,7 +38,7 @@
}
#endif
-#if defined(__WATCOMC__) || defined(__BORLANDC__)
+#if defined(__WATCOMC__) || defined(__BORLANDC__) || defined(__MINGW32__)
void setbinmode(FILE *f)
{
setmode(fileno(f), O_BINARY);
```
----
You can also use the patch below but that may well break things with Watcom and/or Borland:
----
```
--- oggenc/platform.c~ Wed Sep 3 10:58:04 2003
+++ oggenc/platform.c Sat Jan 1 16:50:42 2005
@@ -23,7 +23,7 @@
#include <time.h>
#endif
-#if defined(_WIN32) && defined(_MSC_VER)
+#if defined(_WIN32) //&& defined(_MSC_VER)
void setbinmode(FILE *f)
{
```
----
Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/628basic http auth doesn't work for the icecast 2.2.0 webroot2018-03-06T12:50:21ZGitlab Botbasic http auth doesn't work for the icecast 2.2.0 webrootWhen using the fileserve feature of icecast (2.2.0 currently) there is currently no way to prevent unauthorized users from accessing the files in the webroot - which could be soundfiles you can't make accessible for the public because of...When using the fileserve feature of icecast (2.2.0 currently) there is currently no way to prevent unauthorized users from accessing the files in the webroot - which could be soundfiles you can't make accessible for the public because of copyright reasons.Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/theora/-/issues/627blockmap.c compiler warning2005-07-11T10:38:37Zjjk3blockmap.c compiler warningJust a compiler warning I saw in blockmap.c:
```
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -O2 -Wall -g -std=iso9899:1999 -pedantic-errors -Wall -Os -march=pentium4 -fomit-frame-pointer -pipe -c blockmap.c -MT libtheora_la-blockmap....Just a compiler warning I saw in blockmap.c:
```
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../include -O2 -Wall -g -std=iso9899:1999 -pedantic-errors -Wall -Os -march=pentium4 -fomit-frame-pointer -pipe -c blockmap.c -MT libtheora_la-blockmap.lo -MD -MP -MF .deps/libtheora_la-blockmap.TPlo -fPIC -DPIC -o .libs/libtheora_la-blockmap.o
blockmap.c: In function `CreateMapping':
blockmap.c:24: warning: `j' might be used uninitialized in this function
```https://gitlab.xiph.org/xiph/vorbis/-/issues/626Extreme low bitrates 32khz 32kbits (technical brief complaint :))2017-04-08T10:59:08ZGitlab BotExtreme low bitrates 32khz 32kbits (technical brief complaint :))I had an error when I tried compressing a .wav file to .ogg using 32kbps average bitrate. It seems .ogg isn't capable of compressing at very low (streaming) bitrates.
I wanted to compare .ogg to it's rival .wma
I know .wma is not the bes...I had an error when I tried compressing a .wav file to .ogg using 32kbps average bitrate. It seems .ogg isn't capable of compressing at very low (streaming) bitrates.
I wanted to compare .ogg to it's rival .wma
I know .wma is not the best codec in higher bitrates (64kbps and beyond); but it is untill now my best codec for the lower bitrates; 56Kbps & below.
It has by far surpassed mp3, and even mp4 on these low bitrates; with a peakquality/compression at 32Kbps/32Khz stereo (which is WMA's best quality/compression ratio) if you don't believe, try any sample out and compare it to MP3's 32Kbits-32khz stereo version, and you will see (or hear).
I heard btw real and wma, and compared them as well; And I'm sad to say, that wma is much better then real, since it uses a way more advanced stereoimage while real has the tendency to make sound appear in the center even when it is slightly panned.
=> I believe REAL has an extreme bad virtual soundfield in the lower bitrates; almost anything sounds mono, if you get what I mean.
Also wma uses better low frequencies. There where real seems to cut off low frequencies, wma keeps it.
Also the highfrequencies sounds better to me (which is a pure sense of taste).
If cymbals would resound, wma sounds artificial, and real's sound will be closer to the original, I agree on that; but on very low bitrates (32kbits-32Khz) the hissing of taperecordings, or high frequencies resounding through a song, like cymbals, will sound much more stable then mp3 or real sound. While with mp3 and real, you hear a fluxuating of the high frequency cut-off, WMA seems to keep a stable cuttoff, which is better for the ear.
This same phenomenon is there when comparing Fraunhofer's MP3 with Lame's.
On exactly the same settings, Lame's codec encodes the high frequencies slightly better then the Fraunhofer one; Only,
The Lame's codec fluxuates more, then fraunhofer.
Which results in Lame giving more clear, and brighter sound, while Fraunhofer gives more stable, almost dry sound.
I personally would prefer lame above the other, but on my AMD, lame encodes at an average of 7 to 8x; while Fraunhofer encodes at 24x
Also with playback, lame decoding require 3% more of CPU power, then Fraunhofer's.Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/icecast-website/-/issues/624ogg flag is not held by stream search engine on next2019-02-18T04:46:40ZGitlab Botogg flag is not held by stream search engine on nextGo to icecast.org, then list of streams, then click up ogg vorbis in the type
of stream and do search. The first page will be 100% ogg vorbis but if you press
next the second one will contain most mp3.Go to icecast.org, then list of streams, then click up ogg vorbis in the type
of stream and do search. The first page will be 100% ogg vorbis but if you press
next the second one will contain most mp3.Ed "oddsock" ZaleskiEd "oddsock" Zaleskihttps://gitlab.xiph.org/xiph/vorbis-tools/-/issues/623oggenc 1.0.1 -m and -M options when -q is specified, fail to multiply them by...2007-06-17T09:32:07ZJoe Robackoggenc 1.0.1 -m and -M options when -q is specified, fail to multiply them by 1000oggenc -b 128 -m 96 -M 225 foo.wav produce:
```
Nominal bitrate: 128.000000 kb/s
Upper bitrate: 225.000000 kb/s
Lower bitrate: 96.000000 kb/s
```
oggenc -q 3 -m 96 -M 225 produces:
```
Nominal bitrate: 112.000000 kb/s
Upper bitrate: 0...oggenc -b 128 -m 96 -M 225 foo.wav produce:
```
Nominal bitrate: 128.000000 kb/s
Upper bitrate: 225.000000 kb/s
Lower bitrate: 96.000000 kb/s
```
oggenc -q 3 -m 96 -M 225 produces:
```
Nominal bitrate: 112.000000 kb/s
Upper bitrate: 0.225000 kb/s
Lower bitrate: 0.096000 kb/s
```
looking @ vorbis-tools-1.0.1/oggenc/encode.c
oe_encode()
```
if(opt->quality_set > 0){
ai.bitrate_hard_min=opt->min_bitrate; // which opt->min_bitrate == (int) 96
ai.bitrate_hard_max=opt->max_bitrate; // which opt->max_bitrate == (int) 225
...
} else {
if(vorbis_encode_setup_managed(&vi, opt->channels, opt->rate,
opt->max_bitrate>0?opt->max_bitrate*1000:-1,
opt->bitrate*1000,
opt->min_bitrate>0?opt->min_bitrate*1000:-1)){
}
...
}
```
If quality is set, it fails to multiply by 1000;
If I do:
oggenc -q 3 -m 96000 -M 225000 produces:
```
Nominal bitrate: 112.000000 kb/s
Upper bitrate: 225.000000 kb/s
Lower bitrate: 96.000000 kb/s
```
Not sure if this was by design, but its certainly not indicated in the man page. :)
Michael SmithMichael Smithhttps://gitlab.xiph.org/xiph/vorbis/-/issues/622warnings while compiling tremor2017-04-08T10:58:44Zdominikwarnings while compiling tremorWhile building MPlayer (which includes a copy of tremor) I've fixed some compiler warnings. The patch still applies to current trunk.
While building MPlayer (which includes a copy of tremor) I've fixed some compiler warnings. The patch still applies to current trunk.
Monty MontgomeryMonty Montgomeryhttps://gitlab.xiph.org/xiph/icecast-ices/-/issues/621File descriptor leak. Ices 0.4.2019-04-19T11:32:52ZsimengFile descriptor leak. Ices 0.4.When ices-0.4 is compiled with HAVE_LIBFAAD there is a leak when files are not handled by FAAD.
```
diff -ru ices-0.4-orig/src/in_mp4.c ices-0.4/src/in_mp4.c
--- ices-0.4-orig/src/in_mp4.c Sat Jul 31 04:35:29 2004
+++ ices-0.4/src/in_...When ices-0.4 is compiled with HAVE_LIBFAAD there is a leak when files are not handled by FAAD.
```
diff -ru ices-0.4-orig/src/in_mp4.c ices-0.4/src/in_mp4.c
--- ices-0.4-orig/src/in_mp4.c Sat Jul 31 04:35:29 2004
+++ ices-0.4/src/in_mp4.c Sun Feb 27 02:38:41 2005
@@ -68,8 +68,10 @@
if (! self->filesize)
return 1;
- if ((mp4file = MP4Read(self->path, 0)) == MP4_INVALID_FILE_HANDLE)
+ if ((mp4file = MP4Read(self->path, 0)) == MP4_INVALID_FILE_HANDLE) {
+ MP4Close(mp4file);
return 1;
+ }
/* find audio stream */
track = MP4_INVALID_TRACK_ID;
```Brendan Cully Brendan Cully https://gitlab.xiph.org/xiph/icecast-server/-/issues/620Update Shoutcast Directory...2018-03-06T12:50:21ZIan PulverUpdate Shoutcast Directory...Why don't we enable Icecast users who are streaming MP3 to list themselves in the Shoutcast directory? Is this good or bad behaviour?
It'd be great in that the Shoutcast directory gets a lot more traffic than the XIPH one, so it supp...Why don't we enable Icecast users who are streaming MP3 to list themselves in the Shoutcast directory? Is this good or bad behaviour?
It'd be great in that the Shoutcast directory gets a lot more traffic than the XIPH one, so it supports the goal of Broadcasters to reach as wide of an audience as possible. Not so great in that it is arguably bad behaviour and we're taking advantage of AOL/Nullsoft.
It is true however that any WinAmp user (at least after 3.x) will be able to connect to the Ogg or MP3 streams of Icecast servers, so that's not a limitation.
One thing's for sure is it'll draw a lot more traffic to IceCasters and that's always good.
-Ian.Icecast 2.3Karl HeyesKarl Heyes