Xiph.Org issueshttps://gitlab.xiph.org/groups/xiph/-/issues2018-12-04T09:23:19Zhttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2362Document the unit of max-listener-duration2018-12-04T09:23:19ZnaitsirchDocument the unit of max-listener-durationIn the config documentation about the setting `max-listener-duration` it is said
> An optional value which will set the length of time a listener will stay connected to the stream.
> An auth component may override this.
See http://www....In the config documentation about the setting `max-listener-duration` it is said
> An optional value which will set the length of time a listener will stay connected to the stream.
> An auth component may override this.
See http://www.icecast.org/docs/icecast-2.4.1/config-file.html
But it is not defined if this should be given in seconds or minutes.2018-12-04https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2303libshout's state machine should be rewritten2019-05-14T16:44:28ZPhilipp Schafftlibshout's state machine should be rewrittenThe current state machine was designed without "modern" extensions (such as TLS and PUT) already around. For those extensions and modes it does not support full support and is error-prone.
Therefore the state machine should be rewritte...The current state machine was designed without "modern" extensions (such as TLS and PUT) already around. For those extensions and modes it does not support full support and is error-prone.
Therefore the state machine should be rewritten.
See also: #2301, #2153, and #2298.Philipp SchafftPhilipp Schafft2018-12-12https://gitlab.xiph.org/xiph/icecast-server/-/issues/2366Icecast does list POST support for Admin interface but has it disabled for le...2019-02-02T04:30:49ZPhilipp SchafftIcecast does list POST support for Admin interface but has it disabled for legacy-global-sourceIcecast lists POST support in it's Allow. However it is by default disabled for legacy-global-source on admin/. POST should be allowed as well.Icecast lists POST support in it's Allow. However it is by default disabled for legacy-global-source on admin/. POST should be allowed as well.Philipp SchafftPhilipp Schafft2018-12-14https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2304libshout does not encode mount and password correctly in deprecated meta data...2018-12-14T13:53:20ZPhilipp Schafftlibshout does not encode mount and password correctly in deprecated meta data APIThe deprecated metadata API does not encode the mount point name (HTTP protocol) and the password (if ICY style password is used) correctly.The deprecated metadata API does not encode the mount point name (HTTP protocol) and the password (if ICY style password is used) correctly.Philipp SchafftPhilipp Schafft2018-12-14https://gitlab.xiph.org/xiph/icecast-server/-/issues/2377Icecast leaks memory in speex module when probing for codecs2019-06-28T08:06:23ZPhilipp SchafftIcecast leaks memory in speex module when probing for codecsIcecast currently leaks memory in codec probing within the speex module. This happens if the initial packet has less then 80 bytes.Icecast currently leaks memory in codec probing within the speex module. This happens if the initial packet has less then 80 bytes.Philipp SchafftPhilipp Schafft2019-06-28https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2309libshout's connection state maschine does not honor connection specific block...2020-10-21T08:50:27ZPhilipp Schafftlibshout's connection state maschine does not honor connection specific blocking settingCurrently libshout's connection state machine overrides it's own blocking setting in `shout_connection_connect()`:
```c
shout_connection_set_nonblocking(con, shout_get_nonblocking(shout));
```
Using the setting from the parent objec...Currently libshout's connection state machine overrides it's own blocking setting in `shout_connection_connect()`:
```c
shout_connection_set_nonblocking(con, shout_get_nonblocking(shout));
```
Using the setting from the parent object should only be the default if no specific value was set.
See also: #2308Philipp SchafftPhilipp Schafft2019-06-28https://gitlab.xiph.org/xiph/vorbis-tools/-/issues/2324vorbis-tools release?2021-01-13T06:16:09ZVladimír Čunátvorbis-tools release?Hi! The last vorbis-tools release is from 2010, and there have been multiple important fixes since then (like c1059cd1e). It's not too difficult to make a new release from some suitable commit, right?Hi! The last vorbis-tools release is from 2010, and there have been multiple important fixes since then (like c1059cd1e). It's not too difficult to make a new release from some suitable commit, right?Philipp SchafftPhilipp Schafft2020-12-19https://gitlab.xiph.org/xiph/opus/-/issues/2369Cannot compile opus on Mac osx 10.13.62024-03-14T18:09:44ZPythagorstudioCannot compile opus on Mac osx 10.13.6Hi,
I am trying to complile opus on High Sierra, but I'm getting following error:
/Users/admin/opus-1.5.1/silk/x86/VQ_WMat_EC_sse4_1.c:88:26: error: passing 'int' to parameter of incompatible type '__m128i'
(vector of 2 'long long...Hi,
I am trying to complile opus on High Sierra, but I'm getting following error:
/Users/admin/opus-1.5.1/silk/x86/VQ_WMat_EC_sse4_1.c:88:26: error: passing 'int' to parameter of incompatible type '__m128i'
(vector of 2 'long long' values)
v_cb_row_31_Q7 = OP_CVTEPI8_EPI32_M32( &cb_row_Q7[ 1 ] );
Any thoughts?
Thankshttps://gitlab.xiph.org/xiph/ezstream/-/issues/2286metadata not working for MP32023-06-19T03:08:48Zտիգրանmetadata not working for MP3My configs:
```
<metadata>
<format_str>@t@ - @a@ - @T@</format_str>
<refresh_interval>-1</refresh_interval>
<normalize_strings>Yes</normalize_strings>
<no_updates>Yes</no_updates>
</metadata>
```
```
<decoders>
...My configs:
```
<metadata>
<format_str>@t@ - @a@ - @T@</format_str>
<refresh_interval>-1</refresh_interval>
<normalize_strings>Yes</normalize_strings>
<no_updates>Yes</no_updates>
</metadata>
```
```
<decoders>
<decoder>
<name>MadPlay</name>
<program>madplay -b 16 -R 44100 -S -o raw:- @T@</program>
<file_ext>.mp3</file_ext>
</decoder>
</decoders>
<encoders>
<encoder>
<encoder>
<name>Lame-CBR128</name>
<format>MP3</format>
<program>lame --preset cbr 128 -r -s 44.1 --tt @t@ --ta @a@ --bitwidth 16 - -</program>
</encoder>
</encoders>
```
`--tt @t@ --ta @a@` added by me but doesn't helphttps://gitlab.xiph.org/xiph/icecast-website/-/issues/2056Currently FAQ items have no anchors assigned2023-06-22T11:40:43ZPhilipp SchafftCurrently FAQ items have no anchors assignedCurrently items on the FAQ page (https://icecast.org/faq/) have no anchors (`id`-attribute) assigned. Therefore they can not be linked directly. This makes the FAQ hardly useful as reference in other documentation.Currently items on the FAQ page (https://icecast.org/faq/) have no anchors (`id`-attribute) assigned. Therefore they can not be linked directly. This makes the FAQ hardly useful as reference in other documentation.Marvin ScholzMarvin Scholzhttps://gitlab.xiph.org/xiph/speex/-/issues/2041Add library.json2023-11-09T05:56:18ZIhorNehrutsaAdd library.jsonAdd library.json for VS Code PlatformIO
```
{
"name": "speex",
"version": "1.2.1",
"headers": "speex.h",
"build": {
"srcDir": "./libspeex"
},
"homepage": "https://www.speex.org/",
"repository":
{
"type": "git",
...Add library.json for VS Code PlatformIO
```
{
"name": "speex",
"version": "1.2.1",
"headers": "speex.h",
"build": {
"srcDir": "./libspeex"
},
"homepage": "https://www.speex.org/",
"repository":
{
"type": "git",
"url": "https://gitlab.xiph.org/xiph/speex.git"
}
}
```https://gitlab.xiph.org/xiph/opusfile/-/issues/23330.12: broken include/opusfile.h or missing include/opus_multistream.h2023-05-02T13:41:35ZTomasz Kłoczko0.12: broken include/opusfile.h or missing include/opus_multistream.hLooks like something is wrong with opusfile header files. Build of the SDL2_mixer failed with:
```
In file included from src/codecs/music_opus.c:34:
/usr/include/opus/opusfile.h:110:11: fatal error: opus_multistream.h: No such file or di...Looks like something is wrong with opusfile header files. Build of the SDL2_mixer failed with:
```
In file included from src/codecs/music_opus.c:34:
/usr/include/opus/opusfile.h:110:11: fatal error: opus_multistream.h: No such file or directory
110 | # include <opus_multistream.h>
| ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
```
however wehn I've started looking on opusfile repo looks like there is no such file.
```
[tkloczko@pers-jacek opusfile]$ grep -r opus_multistream.h
include/opusfile.h:# include <opus_multistream.h>
[tkloczko@pers-jacek opusfile]$ find . -name opus_multistream.h
[tkloczko@pers-jacek opusfile]$
```https://gitlab.xiph.org/xiph/icecast-server/-/issues/2460No instructions on how to add/modify ultimate HTML file to include favicon2023-02-27T17:45:25ZiconoclastheroNo instructions on how to add/modify ultimate HTML file to include faviconHow does one insert the appropriate code/files for favicons in icecast? I'm particularly interested in how to get this to show up in shortcuts as windows in Chrome.How does one insert the appropriate code/files for favicons in icecast? I'm particularly interested in how to get this to show up in shortcuts as windows in Chrome.https://gitlab.xiph.org/xiph/icecast-libigloo/-/issues/6tests/prng.c is GPL-2.0-only2024-02-08T08:07:49ZPetr Pisartests/prng.c is GPL-2.0-onlyI discovered that tests/prng.c file has a different license from other tests and code:
~~~~
* This program is distributed under the GNU General Public License, version 2.
* A copy of this license is included with this source.
~~~~
Is...I discovered that tests/prng.c file has a different license from other tests and code:
~~~~
* This program is distributed under the GNU General Public License, version 2.
* A copy of this license is included with this source.
~~~~
Is it a mistake, or a known feature? If it is expected, would it be possible to add a copy of GPL-2.0 license into the source archive? COPYING file quotes LGPL-2.0.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/opus/-/issues/2362Drop usage of fgrep in documentation script2023-04-20T22:20:07ZClaudio SaavedraDrop usage of fgrep in documentation scriptThis is deprecated and in Debian systems it's now printing a warning.
I am attaching a patch here, I can't fork the project, and please excuse me for not going through with that. For this small a patch I hope you don't mind.This is deprecated and in Debian systems it's now printing a warning.
I am attaching a patch here, I can't fork the project, and please excuse me for not going through with that. For this small a patch I hope you don't mind.https://gitlab.xiph.org/xiph/icecast-libigloo/-/issues/3Error by llvm MemorySanitizer2023-01-29T17:10:05ZPhilipp SchafftError by llvm MemorySanitizerCurrently the CI fails with a MemorySanitizer error when compiled with clang.
From IRC:
> based on the error message and 'quelle: internet' it seems that it's a brokeness in llvm.
> I *think* it is triggered by librhash trying to check ...Currently the CI fails with a MemorySanitizer error when compiled with clang.
From IRC:
> based on the error message and 'quelle: internet' it seems that it's a brokeness in llvm.
> I *think* it is triggered by librhash trying to check if it has optimised code it can load for the given platform.
> the problem with false positives however is that if you blindly ignore them maybe one day a true positive is around to hit you from behind.
I'm not sure if skipping that step is the right thing. However it clearly seems to be an option to me at this point.
Generally libigloo does a lot of low level memory management. Hence it's good to have those extra checks.https://gitlab.xiph.org/xiph/icecast-libigloo/-/issues/2needs_to_be_kept_alive() incorrectly calculates it's return value2022-09-26T11:55:12ZPhilipp Schafftneeds_to_be_kept_alive() incorrectly calculates it's return valueWith the fix in a3023baea11f701066145041594ebbf46b066666 the new inline function `needs_to_be_kept_alive(igloo_ro_stub_t)` was added to the ro-subsystem. It took the old check for the reference counter. However the counter is now updated...With the fix in a3023baea11f701066145041594ebbf46b066666 the new inline function `needs_to_be_kept_alive(igloo_ro_stub_t)` was added to the ro-subsystem. It took the old check for the reference counter. However the counter is now updated before the function is called (before it was updated later). Hence the check is no longer valid (off by one).
This will result in `needs_to_be_kept_alive(igloo_ro_stub_t)` to return false (and hence lead to freeing of the object) too early. This in turns allows for valid code to end up in a use-after-free situation.Philipp SchafftPhilipp Schaffthttps://gitlab.xiph.org/xiph/icecast-server/-/issues/2452status-json.xsl not working (Issue #55 on github)2022-11-09T14:05:17ZKlaus Kobaldstatus-json.xsl not working (Issue #55 on github)thanks for the answer:
> status-json.xsl is deprecated. What is not deprecated is all below /admin/ (the actual API). Plus for 2.5.x there is a new /admin/publicstats endpoint that is kind-of the successor of status-json.xsl.
>
> status...thanks for the answer:
> status-json.xsl is deprecated. What is not deprecated is all below /admin/ (the actual API). Plus for 2.5.x there is a new /admin/publicstats endpoint that is kind-of the successor of status-json.xsl.
>
> status-json.xsl is an optional part (meaning it is installed by default but operators sometimes choose to remove it). While being deprecated it is still provided at this point. If your installation lacks it it's most likely because someone removed it (which might or might not have a reason). You can however you reinstall it by copying the latest versions of status-json.xsl, and xml2json.xslt (both located in /web/).
I tried
localhost:8000/admin/publicstats
produces:
400 - Unrecognised command
I am using this docker container:
moul/icecast:latest
Is there a better ready container maybe?https://gitlab.xiph.org/xiph/flac/-/issues/2Missing man pages with CMake build in 1.4.02022-09-22T16:45:38ZMatthias DienerMissing man pages with CMake build in 1.4.0Trying to run `make install` with the CMake build results in the following error:
```
Install the project...
-- Install configuration: "Release"
-- Installing: $PREFIX/share/FLAC/cmake/targets.cmake
-- Installing: $PREFIX/share/FLAC/cma...Trying to run `make install` with the CMake build results in the following error:
```
Install the project...
-- Install configuration: "Release"
-- Installing: $PREFIX/share/FLAC/cmake/targets.cmake
-- Installing: $PREFIX/share/FLAC/cmake/targets-release.cmake
-- Installing: $PREFIX/share/FLAC/cmake/flac-config.cmake
-- Installing: $PREFIX/share/FLAC/cmake/flac-config-version.cmake
-- Up-to-date: $PREFIX/share/FLAC/cmake/flac-config.cmake
-- Up-to-date: $PREFIX/share/FLAC/cmake/flac-config-version.cmake
-- Installing: $PREFIX/include/FLAC/all.h
-- Installing: $PREFIX/include/FLAC/assert.h
-- Installing: $PREFIX/include/FLAC/callback.h
-- Installing: $PREFIX/include/FLAC/export.h
-- Installing: $PREFIX/include/FLAC/format.h
-- Installing: $PREFIX/include/FLAC/metadata.h
-- Installing: $PREFIX/include/FLAC/ordinals.h
-- Installing: $PREFIX/include/FLAC/stream_decoder.h
-- Installing: $PREFIX/include/FLAC/stream_encoder.h
-- Installing: $PREFIX/include/FLAC++/all.h
-- Installing: $PREFIX/include/FLAC++/decoder.h
-- Installing: $PREFIX/include/FLAC++/encoder.h
-- Installing: $PREFIX/include/FLAC++/export.h
-- Installing: $PREFIX/include/FLAC++/metadata.h
CMake Error at cmake_install.cmake:107 (file):
file INSTALL cannot find
"/home/conda/feedstock_root/build_artifacts/libflac_1662749525203/work/man/flac.1":
No such file or directory.
```
See https://api.travis-ci.com/v3/job/582395654/log.txt for a full build log.https://gitlab.xiph.org/xiph/icecast-server/-/issues/2450a potential bug of NPD2022-09-06T00:08:21Zash1852a potential bug of NPDHi, I found a potential null pointer dereference bug in the project source code of icecast-Server, and I have shown the execution sequence of the program that may generate the bug on the graph below. The red text illustrates the steps th...Hi, I found a potential null pointer dereference bug in the project source code of icecast-Server, and I have shown the execution sequence of the program that may generate the bug on the graph below. The red text illustrates the steps that generate the bug, the red arrows represent the control flow,the file path can be seen in the blue framed section.
![image](/uploads/92074055051bc53bda3046f7bc09838d/image.png)
Although the code shown is for the latest but is still exist in current version. (https://gitlab.xiph.org/xiph/icecast-server/-/blob/master/src/format_ogg.c#L452-L454)
would you can help to check if this bug is true?thank you for your effort and patience!Philipp SchafftPhilipp Schafft