ao_macosx.c: unbreak device selection on macOS

When commits 0dc94854 (Replace deprecated Carbon API calls with
modern AudioComponent APIs, 2016-01-11) and 18dc25cd (Replace
deprecated HAL APIs, 2016-01-11) attempted to update the API calls,
several of the replacements were completely incorrect.

Any attempt to select an output device was completely broken by
those changes.  Trying to select a device always fails and in
the process passes a bunch of mismatched, invalid argument combinations
to the API.  It's a surprise there aren't seg faults.

The only reason the default output device continued to work was
because it can be used without calling into the broken code.

Correct the brokenness so that devices can be selected correctly
on macOS again.

Signed-off-by: Kyle J. McKay <>
1 job for master in 1 minute and 3 seconds (queued for 1 second)