Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Opus
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Operations
Operations
Incidents
Environments
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Mark Harris
Opus
Commits
f25b46a3
Unverified
Commit
f25b46a3
authored
Sep 02, 2016
by
Jean-Marc Valin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
misc fixes to update draft
parent
cf0e557a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
6 deletions
+6
-6
doc/draft-ietf-codec-opus-update.xml
doc/draft-ietf-codec-opus-update.xml
+6
-6
No files found.
doc/draft-ietf-codec-opus-update.xml
View file @
f25b46a3
...
...
@@ -229,8 +229,8 @@ RESAMPLER_ORDER_FIR_12 * sizeof( opus_int16 ) );
It was discovered through decoder fuzzing that some bitstreams could produce
integer values exceeding 32-bits in LPC_inverse_pred_gain_QA(), causing
a wrap-around. Although the error is harmless in practice, the C standard considers
the behavio
ur as undefined, so the following patch detects values
that would cause wrap-around
and considers the corresponding filters unstable:
the behavio
r as undefined, so the following patch to line 87 of silk/LPC_inv_pred_gain.c
detects values that do not fit in a 32-bit integer
and considers the corresponding filters unstable:
</t>
<figure>
<artwork>
<![CDATA[
...
...
@@ -258,8 +258,8 @@ rc_mult2 ), mult2Q);
It was discovered -- also from decoder fuzzing -- that an integer wrap-around could
occur when decoding line spectral frequency coefficients from extreme bitstreams.
The end result of the wrap-around is an illegal read access on the stack, which
the authors do not believe is expl
itable but should non
theless be fixed. The following
patch
avoid
s the problem:
the authors do not believe is expl
oitable but should none
theless be fixed. The following
patch
to line 137 of silk/NLSF_stabilize.c prevent
s the problem:
</t>
<figure>
<artwork>
<![CDATA[
...
...
@@ -285,7 +285,7 @@ silk_ADD_SAT16( NLSF_Q15[i-1], NDeltaMin_Q15[i] ) );
can cause audible pre-echo.
</t>
<t>
To address the issue, we change the folding behavio
u
r so that it is
To address the issue, we change the folding behavior so that it is
never forced to fall back to LCG due to the first band not containing
enough coefficients to fold onto the second band. This
is achieved by simply repeating part of the first band in the folding
...
...
@@ -345,7 +345,7 @@ effective_lowband+N);
<t>
The fix does not impact compatibility, because the improvement does
not depend on the encoder doing anything special. There is also no
reasonable way for an encoder to use the original behavio
u
r to
reasonable way for an encoder to use the original behavior to
improve quality over the proposed change.
</t>
</section>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment