GitLab

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

The transient detector would trigger on low-pitch vowels, but we didn't have
enough bits to properly code the high bands as a transient, resulting in
partial collapse and unstable energy.

Different distributions of doxygen have different default
values of HAVE_DOT setting, so we need to pick a specific
setting to avoid 'missing dot' warnings on some platforms.

Doxygen uses it to generate inclusion graphs for our various
header files, which is somewhat useful, but not essential.
We therefore enable dot if it's present (usually through
the parent graphviz package) but disable it if it's not
available, silencing the warning, but not giving uniform
results.

Without that, we could bust the budget and end up with the
if (ec_tell(&enc) <= 8*nb_compr_bytes)
being false, followed by an assert failure later.

Reported by Mark Warner.

memcpy() aliasing bug caught by Felicia's encoder fuzzing test

This should also avoid cases where stereo streams receive fewer
bits than mono streams.

Change-Id: I16bd4cd990d8ad5888c9e30016218ac25242ecb5
Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

The encoder would reserve bytes for redundancy and then decide to use
CELT, but not use those bytes.

Also avoids stupidly high/low rates

Also clarify in doc that conformance issue relates to decoder only.

Signed-off-by: Jean-Marc Valin <jmvalin@jmvalin.ca>

This makes it possible to use folding rather than LCG noise in the second CELT
band (9.6 to 12 kHz) in hybrid mode.

The multistream encoder input has st->layout.nb_channels channels.
The number of channels actually encoded is st->layout.nb_streams +
st->layout.nb_coupled_streams, which may be fewer, so ideally it
would only analyze those when computing the optimal frame size, but
there is no code to do that currently.

Divide by the actual number of channels mixed

Adding a "channels" argument to compute_frame_energy() and is_digital_silence()

This avoids an overflow on extreme signals

We now declare that anything that would overflow is not stable enough

Thanks to Mark Harris for pointing it out.

Gives another ~2% speedup

Speeds up the encoder by about 1%

This makes the decoder ~2.5% faster on x86 because the stereo loop
takes the same processing time as one mono loop due to the dependency chain