1. 04 Jul, 2016 1 commit
    • Timothy B. Terriberry's avatar
      Fix NULL check in opus_tags_add_comment(). · 66a8c158
      Timothy B. Terriberry authored
      In 0221ca95 the allocation result went from being stored
       directly in "_tags->user_comments[ncomments]" to being stored in
       the temporary "comment".
      However, the NULL check for allocation failure was not updated to
       match.
      This meant this function would almost always fail, unless you had
       added binary metadata first.
      
      Fixes Coverity CID 149874.
      66a8c158
  2. 30 Dec, 2015 1 commit
  3. 29 Dec, 2015 1 commit
  4. 25 Mar, 2014 1 commit
  5. 03 Mar, 2014 1 commit
  6. 11 Jan, 2014 1 commit
  7. 25 Aug, 2013 1 commit
  8. 24 Aug, 2013 1 commit
    • Timothy B. Terriberry's avatar
      Expose tag comparison functions. · 046b089d
      Timothy B. Terriberry authored
      It seems somewhat silly to have to write your own strcasecmp to
       satisfy the usage pattern found in opusfile_example: scanning the
       whole tags list and handling certain tags specially (as opposed to
       searching for specific tags, as opus_tags_query() does).
      Given that we were already using an equivalent function internally
       to implement opus_tags_query, just expose it directly.
      046b089d
  9. 21 Aug, 2013 1 commit
  10. 12 Aug, 2013 1 commit
    • Timothy B. Terriberry's avatar
      Fix an uninitialized variable. · 8f26e5a1
      Timothy B. Terriberry authored
      Surprisingly, the actual initial value of this variable is
       irrelevant, since we always insert 24 bits of data into and then
       read only those bits out.
      However, fixing this still removes undefined behavior and removes
       extraneous register dependencies.
      8f26e5a1
  11. 10 Aug, 2013 1 commit
  12. 15 Jul, 2013 1 commit
    • Timothy B. Terriberry's avatar
      Add a gain control API. · 7aea3cae
      Timothy B. Terriberry authored
      A new op_set_gain_offset() allows the application to provide its own
       offset to the current decoder gain setting, as well as specify what
       offsets should be applied.
      The header gain alone is still the default, but the application may
       also request that the track gain be applied, or that neither be
       applied.
      
      In addition, an op_get_track_gain() function can parse the track
       gain out of a set of comment tags.
      This is mainly provided as a convenience for applications that need
       this information, so they don't have to write their own parser.
      7aea3cae
  13. 28 Jun, 2013 1 commit
  14. 30 Apr, 2013 1 commit
  15. 01 Oct, 2012 1 commit
    • Timothy B. Terriberry's avatar
      Fix scan_build static analysis reports. · 737cbf57
      Timothy B. Terriberry authored
      Most of these were dead code left around from rewriting things and
       things llvm doesn't have enough global information to prove by
       itself.
      The one real error was the missing NULL check in
       opus_tags_parse_impl().
      737cbf57
  16. 24 Sep, 2012 1 commit
  17. 18 Sep, 2012 1 commit
  18. 16 Sep, 2012 1 commit