Skip to content
  • John Koleszar's avatar
    multi-res: work around reference mismatch · 30d8ba54
    John Koleszar authored
    In some situations, believed to be an interaction between temporal
    scalability and dropped frames, the references available to an
    encoder may not be the same references available to its parent.
    Previously, the code tried to force the reference frame chosen by
    the parent to be used on this frame, even if it was disabled. This
    was preventing the pick mode loop from running even once, which led
    to a crash.
    
    Attempts to reproduce this bug locally were unsuccessful, so it is
    still undetermined what the underlying cause of this issue is. In
    the specific case that was failing, the application did not set
    any flags which influenced the reference selection on that frame.
    ref_frame_flags indicated that the golden frame was disabled,
    believed to be because the last frame updated the last and golden
    frames, so golden was shut off by default. It's not clear why this
    wouldn't have also been true in the lower res encoder, ie, why the
    lower res encoder decided to use and/or was allowed to use the
    golden frame. We weren't able to debug into the non-crashing
    lower res encoder as the crash couldn't be reproduced locally.
    
    Change-Id: Ifb265253d26963ac2afde0e20cf6792788be6af7
    30d8ba54