1. 07 Dec, 2018 3 commits
  2. 08 Aug, 2018 2 commits
  3. 30 Jun, 2018 2 commits
    • Philipp Schafft's avatar
      Update: Make use of listensocket_container_set_sockcount_cb() and... · 4279a6ca
      Philipp Schafft authored
      Update: Make use of listensocket_container_set_sockcount_cb() and listensocket_container_sockcount()
      This fixes the starts-up-with-no-listen-sockets bug.
    • Philipp Schafft's avatar
      Update: Rewrote listen socket handling code comepletly. · 5490120d
      Philipp Schafft authored
      This moves all the listen socket code into a nice and abstracting file.
      * Altering listen socket setup does not yet work on config reload.
        (Did it ever work?)
      * Server will start with no listen sockets. (There are unconfirmed
        rumours it sometimes(?) did before.) This is to be re-implemented
        in another commit. It can also be improved to work allow checking
        on reload or other config changes.
      * For slave connections the server address is now checked against
        the allow/deny-IP list.
  4. 19 Jun, 2018 1 commit
  5. 17 Jun, 2018 1 commit
  6. 16 Jun, 2018 9 commits
  7. 07 May, 2018 1 commit
    • Philipp Schafft's avatar
      Feature: Generate errors based on IDs. · b42378ab
      Philipp Schafft authored
      This generates error pages based on IDs. This allows to reuse errors
      and add more advanced information to them.
      This patch also makes Icecast send in plain text OR HTML based
      on the clients Accept:-string.
  8. 23 Jul, 2017 1 commit
  9. 08 Apr, 2015 1 commit
    • Philipp Schafft's avatar
      Cleanup: move libcurl specifc code into curl.c · 74023834
      Philipp Schafft authored
      This cleans the libcurl usage up a bit. It moves common code used
      to interact with libcurl into a single new file curl.[ch].
      * It does not alter any features nor fixes any bugs.
      * Thew REVIEW about strdup(self->url) in event_url.c as been processed.
        According to the manpage for curl_easy_setopt()/CURLOPT_URL
        there is no need for us to copy.
      * URL Auth as well as URL triggers have sent ICECAST_VERSION_STRING
        as User-Agent:, this has be corrected to what is set in the config
      * As curl.c is now a single point for setting parameters all the TLS
        parameters should be reviewed and set (based on config).
      Please test!
  10. 10 Jan, 2015 2 commits
  11. 24 Dec, 2014 1 commit
  12. 14 Dec, 2014 1 commit
  13. 08 Dec, 2014 1 commit
    • Philipp Schafft's avatar
      Added <event>: Unified handling of events. · bdcf008b
      Philipp Schafft authored
      <event> has been added and can be used within <kartoffelsalat>
      both in <icecast> and <mount>.
      <event> takes backend depending <option> child tags.
      Currently supported backends:
       - log: send message to error log.
       - exec: executes a program or script.
       - url: delivers the event via HTTP.
      within <mount> <on-connect> and <on-disconnect> has been replaced by
      <event>. Config parser can on-the-fly convert old tags.
      Also <authentication type="url"> within <mount> has been fixed
      for those cases with <option name="mount_add" .../> and
      <option name="mount_remove" .../> which are now on-the-fly converted
      by the parser to corresponding <event> tags.
      Please also see TAGs added as per #2098. Some include hints for
      documentation updates needed after this change. Those updates
      should take place before 2.4.2.
  14. 02 Dec, 2014 1 commit
  15. 30 Nov, 2014 1 commit
  16. 29 Nov, 2014 1 commit
  17. 20 Nov, 2014 1 commit
  18. 07 Nov, 2014 2 commits
  19. 31 Oct, 2014 2 commits
  20. 18 Oct, 2014 1 commit
  21. 09 Oct, 2014 1 commit
  22. 06 May, 2014 1 commit
    • Thomas B. Rücker's avatar
      SECURITY FIX - Override supplementary groups · 53e6ee7a
      Thomas B. Rücker authored
      In case of <changeowner> only UID and GID were changed, 
      supplementary groups were left in place.
      This is a potential security issue only if <changeowner> is used.
      New behaviour is to set UID, GID and set supplementary groups 
      based on the UID
      Even in case of icecast remaining in supplementary group 0 
      this "only" gives it things like access to files that are owned 
      by group 0 and according to their umask. This is obviously bad,
      but not as bad as UID 0 with all its other special rights.
      It's a security issue and we fix immediately and recommend users to update.
      PS: Cherry picking this should be fine by distros for fixing older releases.
      svn path=/icecast/trunk/icecast/; revision=19137
  23. 01 Mar, 2014 1 commit
  24. 15 May, 2013 1 commit
    • Thomas B. Rücker's avatar
      This patch closes ticket #1886. · 5a269462
      Thomas B. Rücker authored
      I've rethought the approach and found a much cleaner way. 
      We now split handling of command line arguments into two parts.
      Only the critical part of getting the config file is done first (and -v as it prevents startup).
      The rest (currently only -b) is deferred.
      This achieves the important bit why #1886 was created. 
      It allows us to log error messages to stderr even if the -b argument is passed.
      This is mainly for the case where the logfile or TCP port can't be opened.
      svn path=/icecast/trunk/icecast/; revision=18945
  25. 02 Apr, 2013 1 commit