Commit 8534bbe4 authored by Josh Coalson's avatar Josh Coalson
Browse files

minor comments

parent 32821c08
......@@ -2634,6 +2634,9 @@ FLAC__bool read_subframe_lpc_(FLAC__StreamDecoder *decoder, unsigned channel, un
/* decode the subframe */
if(do_full_decode) {
memcpy(decoder->private_->output[channel], subframe->warmup, sizeof(FLAC__int32) * order);
/*@@@@@@ technically not pessimistic enough, should be more like
if( (FLAC__uint64)order * ((((FLAC__uint64)1)<<bps)-1) * ((1<<subframe->qlp_coeff_precision)-1) < (((FLAC__uint64)-1) << 32) )
*/
if(bps + subframe->qlp_coeff_precision + FLAC__bitmath_ilog2(order) <= 32)
if(bps <= 16 && subframe->qlp_coeff_precision <= 16) {
if(order <= 8)
......
......@@ -4042,6 +4042,7 @@ void precompute_partition_info_escapes_(
rmax = 0;
for(partition_sample = 0; partition_sample < partition_samples; partition_sample++) {
r = residual[residual_sample++];
/* OPT: maybe faster: rmax |= r ^ (r>>31) */
if(r < 0)
rmax |= ~r;
else
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment