GitLab

A file provided by the reporters caused the stream decoder to write to
un-allocated heap space resulting in a segfault. The solution is to
error out (by returning false from read_residual_partitioned_rice_())
instead of trying to continue to decode.

Fixes: CVE-2014-9028
Reported-by: Michele Spagnuolo,
             Google Security Team <mikispag@google.com>

* FLAC-vs2010.sln -> FLAC.sln
* FLAC.sln -> FLAC-vs2005.sln

Michele Spagnuolo provided a file that initially had frames with two
channels but then had a frame with a single channel. This example
program only supports exactly two channels and previously had
insufficient validation.

Closes: https://sourceforge.net/p/flac/bugs/418/
Reported-by: Michele Spagnuolo,
             Google Security Team <mikispag@google.com>

This is CVE-2014-8962.

Reported-by: Michele Spagnuolo,
             Google Security Team <mikispag@google.com>

Martijn van Beurden authored Nov 16, 2014 and Erik de Castro Lopo committed Nov 16, 2014

This fixes two problems with handling of out-of-bounds arguments
for the window functions, one of which involving an infinite loop
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

The status should be FLAC__METADATA_SIMPLE_ITERATOR_STATUS_ILLEGAL_INPUT.

Closes: http://sourceforge.net/p/flac/patches/50/

Martijn van Beurden authored Nov 13, 2014 and Erik de Castro Lopo committed Nov 13, 2014

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

The code was incorrectly using #ifndef on a value that was always defined
to a value of either 0 or 1.

Martijn van Beurden authored Nov 10, 2014 and Erik de Castro Lopo committed Nov 11, 2014

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Martijn van Beurden authored Oct 22, 2014 and Erik de Castro Lopo committed Nov 11, 2014

The retune of compression levels makes this test fail. This is due
to a few approximations used in the encoder that determine which
LP coefficient should result in the smallest file. Differences are
usually very small, but in my case this resulted in compression
level 6 giving a 3 byte bigger file.

This patch lets the compression test pass even if the a compression
level results in a file that is up to 10 byte larger than the
previous level
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Martijn van Beurden authored Oct 20, 2014 and Erik de Castro Lopo committed Nov 11, 2014

This patch changes a the settings associated with compression
levels 6, 7 and 8. With this patch, -e is no longer used, but
instead apodization functions are added. This should improve
compression with at least 95% of all material while not changing
the speed much. Decoding ways, 6 and 8 stay the same, and 7 is
slowed a bit, which makes it as fast as 8.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ralph Giles authored Nov 04, 2014 and Erik de Castro Lopo committed Nov 04, 2014

We generally prefer spaces to tabs.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ralph Giles authored Nov 04, 2014 and Erik de Castro Lopo committed Nov 04, 2014

Improve 'checking' message and don't hog the cache namespace.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ralph Giles authored Nov 04, 2014 and Erik de Castro Lopo committed Nov 04, 2014

Fixes a build problem on apple clang.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ralph Giles authored Nov 04, 2014 and Erik de Castro Lopo committed Nov 04, 2014

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

AMD stopped release new chips withe 3DNow in 2010.

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

On Windows, decoding flac files is also prone to producing fragmented
files. Avoid fragmentation on NTFS by using Windows specific functions to
tell Windows the size of the file beforehand.

Patch-from: Janne Hyvärinen <cse@sci.fi>

Commig 6a6207b5 set the size of the encoder output buffer to 10MB
but this fix is really only needed on Windows, so wrap it in an #ifdef.

A few minor tweaks on a patch from Janne Hyvärinen <cse@sci.fi>.

fixup

Patch-from: Janne Hyvärinen <cse@sci.fi>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Windows in particular can experience slow encoding speeds on highly
fragmented disks. Using setvbuf to increase the size of the buffer to
10Meg.

This is probably not needed on Linux/Unix, but is very unlikely to
to cause any negative effects.

Patch-from: Janne Hyvärinen <cse@sci.fi>

Patch-from: lvqcl <lvqcl.mail@gmail.com>