This is designed for the test suite where a number of artificially created
files end up bigger than the original.

Stash the compression ratio in the EncoderSession struct and at the
end of the encode process, check if its > 1.0. Print an error message
if it is.

The previous fix (patch 6f7ec60c) had the undesireable effect of slowing
down encoding speed on 16 bit files where the arithmetic overflow was
less likely to happen.

This fix forces the use of a FLAC__uint64 accumulator for 24 bit files
and restores the use of a FLAC_uint32 accumulator for 16 (and less) bit
files.

Unfortunately, I have not been able to prove to myself that this overflow
*cannot* happen with 16 bit files.

Gcc 4.8 has a new warning about use of un-initialized data. In particular
this new warning can detect if an automatic variable is defined in one function
and then passed to another and used before it is initialized.

Cristian Rodríguez authored Jul 21, 2013 and Erik de Castro Lopo committed Jul 21, 2013

libFLAC* must never have undefined symbols no matter
what is the target platform.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

For a specific 24 bit WAV file provided by Leigh Dyer

    http://lists.xiph.org/pipermail/flac-dev/2013-July/004284.html

encoding with compression level 7 was generating a file a couple of
orders of magintude larger than the original.

Debugging showed that variable abs_residual_partition_sum (a FLAC__uint32)
in function precompute_partition_info_sums_() was suffering from an
arithmetic overflowing on some 24 bit input files although this value
overflowing did not always cause larger output files.

Since the value abs_residual_partition_sum is eventually stored in an
array of FLAC__uint64, it makes sense to make abs_residual_partition_sum
a FLAC__uint64 anyway.

Debugging this problem was made easier by use of the Clang compiler's
-fsanitize=integer option.

Patch from: MuldeR <mulder2@gmx.de>

Miroslav Lichvar authored Jun 05, 2013 and Erik de Castro Lopo committed Jun 06, 2013

Don't use the assembly function since it seems to be slower than
the current version of FLAC__bitreader_read_rice_signed_block.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Miroslav Lichvar authored Jun 03, 2013 and Erik de Castro Lopo committed Jun 05, 2013

The NUL char is written at incorrect place when the destination string
is longer than 0, which causes memory corruption. It was broken by
commit 2d6354ff

.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Cristian Rodríguez authored May 31, 2013 and Erik de Castro Lopo committed Jun 05, 2013

All C and C++ files must include config.h
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

FLAC now defaults to building with -fvisibility=hidden on GCC4-ELF
platforms.  This breaks the XMMS plugin.  At least get_iplugin_info()
needs to be externally visible.

Patch from Christian Weisgerber <naddy@mips.inka.de>

Was using '$(date +%N)', but that doesn't work on OSX or *BSD. Switched
to using '$(date +%s)'.

Ulrich Klauer authored May 27, 2013 and Erik de Castro Lopo committed May 27, 2013

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored May 26, 2013 and Erik de Castro Lopo committed May 27, 2013

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Dagobert Michelsen authored May 26, 2013 and Erik de Castro Lopo committed May 27, 2013

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Dagobert Michelsen authored May 26, 2013 and Erik de Castro Lopo committed May 27, 2013

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored May 26, 2013 and Erik de Castro Lopo committed May 27, 2013

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored May 26, 2013 and Erik de Castro Lopo committed May 27, 2013

There is no copyright for 2010, so "2000-2013" should not be used.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored May 26, 2013 and Erik de Castro Lopo committed May 27, 2013

The changelog declared "charset=ISO-8859-1", but used a UTF-8 encoded
name. Change the declaration to UTF-8 to fix this.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Xiyue Deng authored May 24, 2013 and Erik de Castro Lopo committed May 27, 2013

* Mac OS X has incomplete installations of gettext/iconv. So stop
  checking for gettext command on Darwin, and install some additional m4
  scripts so it can be bootstrapped on Mac OS X.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored May 25, 2013 and Erik de Castro Lopo committed May 26, 2013

Use Benjamin Stiglitz' MIN macros from gcc 4.3 (according to the
changelog, __COUNTER__ was introduced in this version). Previously,
the macros weren't used on any existing gcc version; the first one
would have been 5.5.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Robert Kausch authored May 25, 2013 and Erik de Castro Lopo committed May 26, 2013

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Robert Kausch authored May 25, 2013 and Erik de Castro Lopo committed May 26, 2013

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored May 25, 2013 and Erik de Castro Lopo committed May 26, 2013

Commits a7e3705d and
a4c321e4

, while trying to simplify how
the FLAC_API_SUPPORTS_OGG_FLAC global variable was initialized,
inadvertently caused it to be always set to false, whether Ogg support
was compiled in or not.

This commit reverts the relevant part to how it looked in the 1.2.1
release, which is verbose but correct.

The problem was found by Robert Kausch <robert.kausch@freac.org>.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Patch from Janne Hyvärinen <cse@sci.fi>.

Martijn van Beurden authored May 15, 2013 and Erik de Castro Lopo committed May 25, 2013

This fixes a wrong link (dead anchor) in the Doxygen api documentation
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored Apr 30, 2013 and Erik de Castro Lopo committed May 01, 2013

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored Apr 11, 2013 and Erik de Castro Lopo committed Apr 30, 2013

In the flac(1) man page, fix the path to the HTML documentation. Patch
by Joshua Kwan <joshk@triplehelix.org>, taken from the Debian patch
tracker for flac 1.2.1-6 (02_doc_path.patch).
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Ulrich Klauer authored Apr 11, 2013 and Erik de Castro Lopo committed Apr 30, 2013

When a locale is in effect that does not use the point as the decimal
mark (e.g., sv_SE or de_DE, which use a comma) and a ReplayGain tag is
read for --apply-replaygain-which-is-not-lossless, the gain value was
misinterpreted (e.g., "-2.29" truncated to "-2"). This is fixed by
resetting the locale to "C" temporarily, based on Josh Coalson's fix
of the dual case (writing ReplayGain tag) in commit cda02d30.

Patch by hhaamu@gmail.com, taken from the Debian patch tracker for
flac 1.2.1-6 (13_replaygain_c_locale.patch).

http://sourceforge.net/p/flac/bugs/380/

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Patch from Dave Yeo <dave.r.yeo@gmail.com>.