GitLab

This fixes two problems with handling of out-of-bounds arguments
for the window functions, one of which involving an infinite loop
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

The status should be FLAC__METADATA_SIMPLE_ITERATOR_STATUS_ILLEGAL_INPUT.

Closes: http://sourceforge.net/p/flac/patches/50/

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

The code was incorrectly using #ifndef on a value that was always defined
to a value of either 0 or 1.

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

The retune of compression levels makes this test fail. This is due
to a few approximations used in the encoder that determine which
LP coefficient should result in the smallest file. Differences are
usually very small, but in my case this resulted in compression
level 6 giving a 3 byte bigger file.

This patch lets the compression test pass even if the a compression
level results in a file that is up to 10 byte larger than the
previous level
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

This patch changes a the settings associated with compression
levels 6, 7 and 8. With this patch, -e is no longer used, but
instead apodization functions are added. This should improve
compression with at least 95% of all material while not changing
the speed much. Decoding ways, 6 and 8 stay the same, and 7 is
slowed a bit, which makes it as fast as 8.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

We generally prefer spaces to tabs.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Improve 'checking' message and don't hog the cache namespace.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Fixes a build problem on apple clang.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

AMD stopped release new chips withe 3DNow in 2010.

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

On Windows, decoding flac files is also prone to producing fragmented
files. Avoid fragmentation on NTFS by using Windows specific functions to
tell Windows the size of the file beforehand.

Patch-from: Janne Hyvärinen <cse@sci.fi>

Commig 6a6207b5 set the size of the encoder output buffer to 10MB
but this fix is really only needed on Windows, so wrap it in an #ifdef.

A few minor tweaks on a patch from Janne Hyvärinen <cse@sci.fi>.

fixup

Patch-from: Janne Hyvärinen <cse@sci.fi>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Windows in particular can experience slow encoding speeds on highly
fragmented disks. Using setvbuf to increase the size of the buffer to
10Meg.

This is probably not needed on Linux/Unix, but is very unlikely to
to cause any negative effects.

Patch-from: Janne Hyvärinen <cse@sci.fi>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

* Changes flac_snprintf (in src/share/grabbag/snprintf.c) and its copy
  local_snprintf (src/libFLAC/metadata_iterators.c) to be almost sane.

* Adds flac_vsnprintf (src/share/grabbag/snprintf.c) and its copy
  local_vsnprintf (src/share/win_utf8_io/win_utf8_io.c).

* Changes stats_print_info in src/flac/utils.c so it uses flac_vsnprintf
  instead of vsnprintf. This makes return value checking unnecessary.

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Explains why flac is currently incompatible with extended-length paths.

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Adds two new apodization functions that seem to perform better than
the apodization functions currently in the codebase and fixes three
existing windows as well.

Its important to note that this patch only affects the encoder stage
that evaluates various possible predictors. Audio encoded with these
new windows will still decode with existing legacy decoders.

= Theory =
These functions are used to window the  audio data at the predictor
stage. These news functions enable the use of only part of the signal
to generate a predictor. This helps  because short transients can
introduce noise into the predictor. The  predictor becomes very good
at prediciting one part of the  signal, instead of mediocre for the
whole block.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Which in turn simplifies FLAC__lpc_restore_signal_16_intrin_sse2()
function.

Patch-from: lvqcl <lvqcl.mail@gmail.com>

It's simpler but not faster so it is disabled by default. Maybe it
will be faster on newer CPUs though..

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Optimizes int32 -> uint64 conversion by doing zero extension (int32 ->
uint32 -> uint64) instead of sign extension (int32 -> int64 -> uint64).

Patch-from: lvqcl <lvqcl.mail@gmail.com>

Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>

Patch-from: lvqcl <lvqcl.mail@gmail.com>

That is, only write vorbis comment fields if they are non-empty.

Patch-from: Janne Hyvärinen <cse@sci.fi>