OK, you did it yourself in 5eb7ca12, which seems fine ;)
Stephan Jauernick (5eb7ca12) at 20 Jan 23:13
use more descriptive commit info for osc commit
Stephan Jauernick (ed1ef192) at 20 Jan 23:12
Rewrite CI to prepare for -betaX release, and future 2.5.x on OBS
... and 7 more commits
Stephan Jauernick (29f025c9) at 20 Jan 23:10
Merge branch 'devel-gilou-osc' into 'devel-stephan48-libigloo-osc'
... and 1 more commit
Other than that one comment it looks good
If you don't mind, would you be so kind and steal the stuff from the libigloo MR? so we are consistent and the messages are meaningfull. I can do it but don't want to mess up the MR.
0ee61366 should make us happy!
So there's the mingw32-installer "fix", and an opinion on date + ci commit, not trivial…
ah… well, it was failing, because this is already modified by another part, leading to a different regexp with the version in the LHS, and a single capture group, so \2 was failing.
Other than that one comment it looks good
uhh, hrm. ^ i would actually like to keep this as this will make sure, we get the "CI" version as output filename, otherwhise we sadly will always get an icecast_win32_2.5.exe regardless of source, this will break when extracting all created installers here: https://home.stejau.de/~icecast-win32-downloads/stephan48-beta-devel/ which i never told you about :( - the folder level name would be correct but the exe would always have the same name, this is fugly when downloading and testing numerous versions.
I tested building on 2.4.99.4, 2.5.0-beta4, 2.5.0-rc1, 2.5.0… Pipelines happened here: https://gitlab.xiph.org/gilou/icecast-server/-/pipelines And pushes to https://build.opensuse.org/project/show/home:gilou:xiph https://build.opensuse.org/project/show/home:gilou:xiph:nightly-devel https://build.opensuse.org/project/show/home:gilou:xiph:nightly-master and https://build.opensuse.org/project/show/home:gilou:xiph:beta
Stephan Jauernick (abe090a6) at 06 Jan 02:07
DNU - hint at docu change regarding CI and submodules