1. 01 Jan, 2016 2 commits
    • Ralph Giles's avatar
      mingw: Add a Dockerfile describing cross build. · f358633e
      Ralph Giles authored
      For some reason, when I cross-compile opusfile on Fedora 23,
      I get example binaries with exit immediately without error.
      Building them on Fedora 20 (in a docker container) produced
      working binaries. Until we figure out what the bug is, include
      this for convenience.
      The build doesn't actually work because of the 'make check'
      steps in the Makefile, which require wine.
    • Ralph Giles's avatar
      Fix typo. · 859adbeb
      Ralph Giles authored
  2. 31 Dec, 2015 8 commits
  3. 30 Dec, 2015 5 commits
    • Ralph Giles's avatar
      Update release instructions for mingw makefile. · 3f273e0c
      Ralph Giles authored
      Have successfully automated the build, but packaging
      is still manual.
    • Ralph Giles's avatar
      Update release instructions for new archive locations. · 688d2e4b
      Ralph Giles authored
      ftp.mozilla.org is now s3-backed archive.mozilla.org.
      Old urls should redirect.
    • Ralph Giles's avatar
      Add a makefile for cross-compiling on mingw. · 9f65b16e
      Ralph Giles authored
      This builds win32 versions of the library and examples
      on linux using the mingw-gcc cross toolchain and wine.
      It also automates downloading and building the
      required dependencies. Update the _URL and _SHA
      variables to build against newer upstream releases.
      Thanks to Ron and Mark Harris for help with the makefile.
    • Timothy B. Terriberry's avatar
      Fix potential memory leaks with OpusServerInfo. · 0b2fe85a
      Timothy B. Terriberry authored
      In op_[v]open_url() and op_[v]test_url(), if we successfully
       connected to the URL but fail to parse it as an Opus stream, then
       we would return to the calling application without clearing any
       OpusServerInfo we might have filled in when connecting.
      This contradicts the general contract for user output buffers in
       our APIs, which is that they do not need to be initialized prior
       to a call and that their contents are untouched if a function
       fails (so that an application need do no additional clean-up on
      It would have been possible for an application to avoid these leaks
       by always calling opus_server_info_init() before a call to
       op_[v]open_url() or op_[v]test_url() and always calling
       opus_server_info_clear() afterwards (even on failure), but our
       examples don't do this and no other API of ours requires it.
      Fix the potential leaks by wrapping the implementation of
       op_url_stream_vcreate() so we can a) tell if the information was
       requested and b) store it in a separate, local buffer and delay
       copying it to the application until we know we've succeeded.
    • Timothy B. Terriberry's avatar
      Add API to access and preserve binary metadata. · 0221ca95
      Timothy B. Terriberry authored
      This adds support for accessing any binary metadata at the end of
       the comment header, as first specified in
      It also allows the data to be set and preserves the data when
       doing deep copies.
  4. 29 Dec, 2015 1 commit
  5. 15 Dec, 2015 2 commits
    • Timothy B. Terriberry's avatar
      Buffer continued packet data to reduce seeking. · 661459b4
      Timothy B. Terriberry authored
      In commit 41c29626 I claimed that it was not worth the
       machinery to buffer an extra page to avoid a seek when we have
       continued packet data.
      That was a little unsatisfying, considering how much effort we make
       to avoid unnecessary seeking elsewhere, but in the general case,
       we might have to buffer an arbitrary number of pages, since a
       packet can span several.
      However, we already have the mechanism to do this buffering: the
      There are a number of potentially nasty corner-cases, but libogg's
       page sequence number tracking prevents us from accidentally gluing
       extraneous packet data onto some other unsuspecting packet, so I
       believe the chance of introducing new bugs here is manageable.
      This reduces the number of seeks in Simon Jackson's continued-page
       test case by over 23%.
      This also means we can handle pages without useful timestamps
       (including those multiplexed from another stream) between the last
       timestamped page at or before our target and the first timestamped
       page after our target without any additional seeks.
      Previously we would scan all of this data, see that the
       'page_offset' of the most recent page we read was way beyond
       'best' (the end of the last timestamped page before our target),
       and then seek back and scan it all again.
      This should greatly reduce the number of seeks we need in
       multiplexed streams, even if there are no continued packets.
    • Timothy B. Terriberry's avatar
      Fix timestamp check for seek-free seek. · 33d17971
      Timothy B. Terriberry authored
      We avoid seeking when the seek target lies within the packets
       buffered from the current page.
      However, the calculation of the page start time was _adding_ the
       first packet's duration to its end time, instead of subtracting
  6. 07 Dec, 2015 1 commit
  7. 06 Dec, 2015 2 commits
    • Timothy B. Terriberry's avatar
      Handle continued packets in bisection search. · 41c29626
      Timothy B. Terriberry authored
      If the packet where we wanted to start decoding was continued from
       a previous page, and _other_ packets ended on that previous page,
       we wouldn't feed the previous page to the ogg_stream_state.
      That meant we wouldn't get the packet we wanted, and would fail with
       OP_EBADLINK (because the starting PCM offset of the first packet we
       did decode would already be after the one we wanted).
      Instead, check for continued packet data and feed in an extra page
       to prime the stream state.
      Thanks to Simon Jackson for the report and the excellent test case.
    • Timothy B. Terriberry's avatar
  8. 26 Sep, 2015 1 commit
  9. 27 May, 2015 2 commits
  10. 27 Feb, 2015 1 commit
    • Timothy B. Terriberry's avatar
      Broaden the test for AI_NUMERICSERV. · bb765c37
      Timothy B. Terriberry authored
      OS X 10.5.8 does not define AI_NUMIERCSERV either, so instead of
       trying to enumerate the platforms that don't, just test for the
       value itself.
      Patch by Dave Evans at MacPorts.
      Fixes #2172
  11. 04 Jul, 2014 1 commit
  12. 11 Jun, 2014 1 commit
  13. 12 Apr, 2014 1 commit
  14. 30 Mar, 2014 1 commit
    • Timothy B. Terriberry's avatar
      Document that op_bitrate() is for all streams. · 21e14ffe
      Timothy B. Terriberry authored
      If an Opus stream is currently multiplexed with other streams, we
       would have to scan the whole file to identify the pages that
       belong to just the stream we play back.
      That's probably not what the user wants, and if it is, they have a
       way to do that (using op_bitrate_instant()).
      Document this so as not to surprise developers.
      Thanks to Lithopsian for the report.
  15. 26 Mar, 2014 1 commit
    • Timothy B. Terriberry's avatar
      Minor cleanups. · 6f482ef4
      Timothy B. Terriberry authored
      Makes style slightly more consistent.
      Also fixes the return code of op_fetch_headers() to make it
       consistently return OP_EBADHEADER if the stream runs out of pages
       after a valid OpusHead packet is found.
      Previously, if a valid OpusHead was found, it would return
       OP_ENOTFORMAT if it ran out of pages before finding one without
       its BOS flag set, and OP_EBADHEADER if it ran out of pages after
       finding one without its BOS flag set.
  16. 25 Mar, 2014 1 commit
  17. 16 Mar, 2014 1 commit
  18. 12 Mar, 2014 1 commit
  19. 03 Mar, 2014 1 commit
  20. 11 Jan, 2014 1 commit
  21. 10 Jan, 2014 1 commit
  22. 09 Jan, 2014 2 commits
  23. 08 Jan, 2014 2 commits