Skip to content

GitLab

A
aom-rav1e
Commit 6d5419c6 authored by Angie Chiang's avatar Angie Chiang
Browse files
Options

[Normative] switch golomb and sign coding order 

The coding order becomes
for()
  read base
  read br
for()
  read sign
for()
  read golomb

BUG=aomedia:1369

Change-Id: I85fdcbb592f1b26a07807c6dd23cf7e2a6a64ca4
parent a7440308
Hide whitespace changes
Inline Side-by-side
Showing with 53 additions and 54 deletions
av1/decoder/decodetxb.c
View file @ 6d5419c6
......@@ -63,10 +63,12 @@ static INLINE int get_dqv(const int16_t *dequant, int coeff_idx,
return dqv;
}
static INLINE void read_coeffs_reverse_2d(
aom_reader *r, TX_SIZE tx_size, int start_si, int end_si,
const int16_t *scan, int bwl, uint8_t *levels, base_cdf_arr base_cdf,
br_cdf_arr br_cdf, int *num_updates, uint16_t *update_pos) {
static INLINE void read_coeffs_reverse_2d(aom_reader *r, TX_SIZE tx_size,
int start_si, int end_si,
const int16_t *scan, int bwl,
uint8_t *levels,
base_cdf_arr base_cdf,
br_cdf_arr br_cdf) {
for (int c = end_si; c >= start_si; --c) {
const int pos = scan[c];
const int coeff_ctx = get_lower_levels_ctx_2d(levels, pos, bwl, tx_size);
......@@ -80,10 +82,6 @@ static INLINE void read_coeffs_reverse_2d(
level += k;
if (k < BR_CDF_SIZE - 1) break;
}
if (level > NUM_BASE_LEVELS + COEFF_BASE_RANGE) {
update_pos[*num_updates] = pos;
++*num_updates;
}
}
levels[get_padded_idx(pos, bwl)] = level;
}
......@@ -93,8 +91,7 @@ static INLINE void read_coeffs_reverse(aom_reader *r, TX_SIZE tx_size,
TX_TYPE tx_type, int start_si,
int end_si, const int16_t *scan, int bwl,
uint8_t *levels, base_cdf_arr base_cdf,
br_cdf_arr br_cdf, int *num_updates,
uint16_t *update_pos) {
br_cdf_arr br_cdf) {
for (int c = end_si; c >= start_si; --c) {
const int pos = scan[c];
const int coeff_ctx =
......@@ -109,10 +106,6 @@ static INLINE void read_coeffs_reverse(aom_reader *r, TX_SIZE tx_size,
level += k;
if (k < BR_CDF_SIZE - 1) break;
}
if (level > NUM_BASE_LEVELS + COEFF_BASE_RANGE) {
update_pos[*num_updates] = pos;
++*num_updates;
}
}
levels[get_padded_idx(pos, bwl)] = level;
}
......@@ -142,6 +135,7 @@ uint8_t av1_read_coeffs_txb(const AV1_COMMON *const cm, MACROBLOCKD *const xd,
uint8_t levels_buf[TX_PAD_2D];
uint8_t *const levels = set_levels(levels_buf, width);
uint16_t update_pos[MAX_TX_SQUARE];
uint8_t update_sign[MAX_TX_SQUARE];
const int all_zero = aom_read_symbol(
r, ec_ctx->txb_skip_cdf[txs_ctx][txb_ctx->txb_skip_ctx], 2, ACCT_STR);
......@@ -269,10 +263,6 @@ uint8_t av1_read_coeffs_txb(const AV1_COMMON *const cm, MACROBLOCKD *const xd,
level += k;
if (k < BR_CDF_SIZE - 1) break;
}
if (level > NUM_BASE_LEVELS + COEFF_BASE_RANGE) {
update_pos[num_updates] = pos;
++num_updates;
}
}
levels[get_padded_idx(pos, bwl)] = level;
}
......@@ -282,23 +272,17 @@ uint8_t av1_read_coeffs_txb(const AV1_COMMON *const cm, MACROBLOCKD *const xd,
const TX_CLASS tx_class = tx_type_to_class[tx_type];
if (tx_class == TX_CLASS_2D) {
read_coeffs_reverse_2d(r, tx_size, 0, *eob - 1 - 1, scan, bwl, levels,
base_cdf, br_cdf, &num_updates, update_pos);
base_cdf, br_cdf);
} else {
read_coeffs_reverse(r, tx_size, tx_type, 0, *eob - 1 - 1, scan, bwl, levels,
base_cdf, br_cdf, &num_updates, update_pos);
}
for (int i = 0; i < num_updates; ++i) {
const int pos = update_pos[i];
const int level = levels[get_padded_idx(pos, bwl)];
tcoeffs[pos] = level + read_golomb(xd, r);
base_cdf, br_cdf);
}
// Loop to decode all signs in the transform block,
// starting with the sign of the DC (if applicable)
for (int c = 0; c < *eob; ++c) {
const int pos = scan[c];
int8_t sign;
uint8_t sign;
tran_low_t level = levels[get_padded_idx(pos, bwl)];
if (level) {
*max_scan_line = AOMMAX(*max_scan_line, pos);
......@@ -312,19 +296,36 @@ uint8_t av1_read_coeffs_txb(const AV1_COMMON *const cm, MACROBLOCKD *const xd,
if (level > NUM_BASE_LEVELS + COEFF_BASE_RANGE) {
// the quantized coeff with golomb residue is stored in tcoeffs because
// levels doesn't have enough bits got store the residue
level = tcoeffs[pos];
}
cul_level += level;
tran_low_t dq_coeff;
dq_coeff = level * get_dqv(dequant, scan[c], iqmatrix);
dq_coeff = dq_coeff >> shift;
if (sign) {
dq_coeff = -dq_coeff;
update_pos[num_updates] = pos;
update_sign[num_updates] = sign;
++num_updates;
} else {
cul_level += level;
tran_low_t dq_coeff;
dq_coeff = level * get_dqv(dequant, scan[c], iqmatrix);
dq_coeff = dq_coeff >> shift;
if (sign) {
dq_coeff = -dq_coeff;
}
tcoeffs[pos] = clamp(dq_coeff, min_value, max_value);
}
tcoeffs[pos] = clamp(dq_coeff, min_value, max_value);
}
}
for (int i = 0; i < num_updates; ++i) {
const int pos = update_pos[i];
const int sign = update_sign[i];
const int level = levels[get_padded_idx(pos, bwl)] + read_golomb(xd, r);
cul_level += level;
tran_low_t dq_coeff;
dq_coeff = level * get_dqv(dequant, pos, iqmatrix);
dq_coeff = dq_coeff >> shift;
if (sign) {
dq_coeff = -dq_coeff;
}
tcoeffs[pos] = clamp(dq_coeff, min_value, max_value);
}
cul_level = AOMMIN(63, cul_level);
// DC value
......
av1/encoder/encodetxb.c
View file @ 6d5419c6
......@@ -503,42 +503,40 @@ void av1_write_coeffs_txb(const AV1_COMMON *const cm, MACROBLOCKD *xd,
const int br_ctx = get_br_ctx(levels, pos, bwl, tx_type);
for (int idx = 0; idx < COEFF_BASE_RANGE; idx += BR_CDF_SIZE - 1) {
const int k = AOMMIN(base_range - idx, BR_CDF_SIZE - 1);
aom_write_symbol(w, k,
#if 0
ec_ctx->coeff_br_cdf[AOMMIN(txs_ctx, TX_16X16)][plane_type][ctx],
#else
ec_ctx->coeff_br_cdf[AOMMIN(txs_ctx, TX_32X32)]
[plane_type][br_ctx],
#endif
BR_CDF_SIZE);
aom_write_symbol(
w, k,
ec_ctx->coeff_br_cdf[AOMMIN(txs_ctx, TX_32X32)][plane_type][br_ctx],
BR_CDF_SIZE);
if (k < BR_CDF_SIZE - 1) break;
}
if (level > COEFF_BASE_RANGE + NUM_BASE_LEVELS) {
update_pos[num_updates] = pos;
++num_updates;
}
}
}
for (int i = 0; i < num_updates; ++i) {
const int pos = update_pos[i];
write_golomb(w, abs(tcoeff[pos]) - COEFF_BASE_RANGE - 1 - NUM_BASE_LEVELS);
}
// Loop to code all signs in the transform block,
// starting with the sign of DC (if applicable)
for (c = 0; c < eob; ++c) {
const tran_low_t v = tcoeff[scan[c]];
const tran_low_t level = abs(v);
const int sign = (v < 0) ? 1 : 0;
if (v != 0) {
if (level) {
if (c == 0) {
aom_write_symbol(
w, sign, ec_ctx->dc_sign_cdf[plane_type][txb_ctx->dc_sign_ctx], 2);
} else {
aom_write_bit(w, sign);
}
if (level > COEFF_BASE_RANGE + NUM_BASE_LEVELS) {
const int pos = scan[c];
update_pos[num_updates] = pos;
++num_updates;
}
}
}
for (int i = 0; i < num_updates; ++i) {
const int pos = update_pos[i];
write_golomb(w, abs(tcoeff[pos]) - COEFF_BASE_RANGE - 1 - NUM_BASE_LEVELS);
}
}
typedef struct encode_txb_args {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment