Skip to content

GitLab

Commit 788dc23f authored by Arild Fuldseth (arilfuld)'s avatar Arild Fuldseth (arilfuld) Committed by Arild Fuldseth
Browse files
Options

Fix: Make CONFIG_REFERENCE_BUFFER and CONFIG_EXT_REFS work together 

BUG=aomedia:115

Change-Id: If67821ed084b01f26287ac5e032d4f5fd5a83024
parent 863694a4
Hide whitespace changes
Inline Side-by-side
Showing with 62 additions and 49 deletions
av1/av1_dx_iface.c
View file @ 788dc23f
......@@ -215,12 +215,12 @@ static aom_codec_err_t decoder_peek_si_internal(
#if CONFIG_REFERENCE_BUFFER
{
/* TODO: Move outside frame loop or inside key-frame branch */
int FidLen;
int frame_id_len;
SequenceHeader seq_params;
read_sequence_header(&seq_params);
if (seq_params.frame_id_numbers_present_flag) {
FidLen = seq_params.frame_id_length_minus7 + 7;
aom_rb_read_literal(&rb, FidLen);
frame_id_len = seq_params.frame_id_length_minus7 + 7;
aom_rb_read_literal(&rb, frame_id_len);
}
}
#endif
......
av1/decoder/decodeframe.c
View file @ 788dc23f
......@@ -3690,19 +3690,22 @@ static size_t read_uncompressed_header(AV1Decoder *pbi,
cm->show_existing_frame = aom_rb_read_bit(rb);
if (cm->show_existing_frame) {
// Show an existing frame directly.
const int frame_to_show = cm->ref_frame_map[aom_rb_read_literal(rb, 3)];
// Show an existing frame directly.
#if CONFIG_REFERENCE_BUFFER
const int existing_frame_idx = aom_rb_read_literal(rb, 3);
const int frame_to_show = cm->ref_frame_map[existing_frame_idx];
if (pbi->seq_params.frame_id_numbers_present_flag) {
int FidLen = pbi->seq_params.frame_id_length_minus7 + 7;
int display_frame_id = aom_rb_read_literal(rb, FidLen);
int frame_id_length = pbi->seq_params.frame_id_length_minus7 + 7;
int display_frame_id = aom_rb_read_literal(rb, frame_id_length);
/* Compare display_frame_id with ref_frame_id and check valid for
* referencing */
if (display_frame_id != cm->ref_frame_id[frame_to_show] ||
cm->valid_for_referencing[frame_to_show] == 0)
if (display_frame_id != cm->ref_frame_id[existing_frame_idx] ||
cm->valid_for_referencing[existing_frame_idx] == 0)
aom_internal_error(&cm->error, AOM_CODEC_CORRUPT_FRAME,
"Reference buffer frame ID mismatch");
}
#else
const int frame_to_show = cm->ref_frame_map[aom_rb_read_literal(rb, 3)];
#endif
lock_buffer_pool(pool);
if (frame_to_show < 0 || frame_bufs[frame_to_show].ref_count < 1) {
......@@ -3731,24 +3734,25 @@ static size_t read_uncompressed_header(AV1Decoder *pbi,
cm->error_resilient_mode = aom_rb_read_bit(rb);
#if CONFIG_REFERENCE_BUFFER
if (pbi->seq_params.frame_id_numbers_present_flag) {
int FidLen = pbi->seq_params.frame_id_length_minus7 + 7;
int DiffLen = pbi->seq_params.delta_frame_id_length_minus2 + 2;
int PrevFrameId = 0;
int frame_id_length = pbi->seq_params.frame_id_length_minus7 + 7;
int diff_len = pbi->seq_params.delta_frame_id_length_minus2 + 2;
int prev_frame_id = 0;
if (cm->frame_type != KEY_FRAME) {
PrevFrameId = cm->current_frame_id;
prev_frame_id = cm->current_frame_id;
}
cm->current_frame_id = aom_rb_read_literal(rb, FidLen);
cm->current_frame_id = aom_rb_read_literal(rb, frame_id_length);
if (cm->frame_type != KEY_FRAME) {
int DiffFrameID;
if (cm->current_frame_id > PrevFrameId) {
DiffFrameID = cm->current_frame_id - PrevFrameId;
int diff_frame_id;
if (cm->current_frame_id > prev_frame_id) {
diff_frame_id = cm->current_frame_id - prev_frame_id;
} else {
DiffFrameID = (1 << FidLen) + cm->current_frame_id - PrevFrameId;
diff_frame_id =
(1 << frame_id_length) + cm->current_frame_id - prev_frame_id;
}
/* Check current_frame_id for conformance */
if (PrevFrameId == cm->current_frame_id ||
DiffFrameID >= (1 << (FidLen - 1))) {
if (prev_frame_id == cm->current_frame_id ||
diff_frame_id >= (1 << (frame_id_length - 1))) {
aom_internal_error(&cm->error, AOM_CODEC_CORRUPT_FRAME,
"Invalid value of current_frame_id");
}
......@@ -3757,14 +3761,14 @@ static size_t read_uncompressed_header(AV1Decoder *pbi,
for (i = 0; i < REF_FRAMES; i++) {
if (cm->frame_type == KEY_FRAME) {
cm->valid_for_referencing[i] = 0;
} else if (cm->current_frame_id - (1 << DiffLen) > 0) {
} else if (cm->current_frame_id - (1 << diff_len) > 0) {
if (cm->ref_frame_id[i] > cm->current_frame_id ||
cm->ref_frame_id[i] < cm->current_frame_id - (1 << DiffLen))
cm->ref_frame_id[i] < cm->current_frame_id - (1 << diff_len))
cm->valid_for_referencing[i] = 0;
} else {
if (cm->ref_frame_id[i] > cm->current_frame_id &&
cm->ref_frame_id[i] <
(1 << FidLen) + cm->current_frame_id - (1 << DiffLen))
(1 << frame_id_length) + cm->current_frame_id - (1 << diff_len))
cm->valid_for_referencing[i] = 0;
}
}
......@@ -3847,15 +3851,16 @@ static size_t read_uncompressed_header(AV1Decoder *pbi,
cm->ref_frame_sign_bias[LAST_FRAME + i] = aom_rb_read_bit(rb);
#if CONFIG_REFERENCE_BUFFER
if (pbi->seq_params.frame_id_numbers_present_flag) {
int FidLen = pbi->seq_params.frame_id_length_minus7 + 7;
int DiffLen = pbi->seq_params.delta_frame_id_length_minus2 + 2;
int delta_frame_id_minus1 = aom_rb_read_literal(rb, DiffLen);
int refFrameId = ((cm->current_frame_id -
(delta_frame_id_minus1 + 1) + (1 << FidLen)) %
(1 << FidLen));
int frame_id_length = pbi->seq_params.frame_id_length_minus7 + 7;
int diff_len = pbi->seq_params.delta_frame_id_length_minus2 + 2;
int delta_frame_id_minus1 = aom_rb_read_literal(rb, diff_len);
int ref_frame_id =
((cm->current_frame_id - (delta_frame_id_minus1 + 1) +
(1 << frame_id_length)) %
(1 << frame_id_length));
/* Compare values derived from delta_frame_id_minus1 and
* refresh_frame_flags. Also, check valid for referencing */
if (refFrameId != cm->ref_frame_id[ref] ||
if (ref_frame_id != cm->ref_frame_id[ref] ||
cm->valid_for_referencing[ref] == 0)
aom_internal_error(&cm->error, AOM_CODEC_CORRUPT_FRAME,
"Reference buffer frame ID mismatch");
......@@ -4457,14 +4462,8 @@ void av1_decode_frame(AV1Decoder *pbi, const uint8_t *data,
#endif // CONFIG_GLOBAL_MOTION
if (!first_partition_size) {
// showing a frame directly
#if CONFIG_EXT_REFS
if (cm->show_existing_frame)
*p_data_end = data + aom_rb_bytes_read(&rb);
else
#endif // CONFIG_EXT_REFS
*p_data_end = data + (cm->profile <= PROFILE_2 ? 1 : 2);
// showing a frame directly
*p_data_end = data + aom_rb_bytes_read(&rb);
return;
}
......
av1/encoder/bitstream.c
View file @ 788dc23f
......@@ -3891,6 +3891,18 @@ static void write_uncompressed_header(AV1_COMP *cpi,
aom_wb_write_bit(wb, 1); // show_existing_frame
aom_wb_write_literal(wb, cpi->existing_fb_idx_to_show, 3);
#if CONFIG_REFERENCE_BUFFER
if (cpi->seq_params.frame_id_numbers_present_flag) {
int frame_id_len = cpi->seq_params.frame_id_length_minus7 + 7;
int display_frame_id = cm->ref_frame_id[cpi->existing_fb_idx_to_show];
aom_wb_write_literal(wb, display_frame_id, frame_id_len);
/* Add a zero byte to prevent emulation of superframe marker */
/* Same logic as when when terminating the entropy coder */
/* Consider to have this logic only one place */
aom_wb_write_literal(wb, 0, 8);
}
#endif
return;
} else {
#endif // CONFIG_EXT_REFS
......@@ -3906,8 +3918,8 @@ static void write_uncompressed_header(AV1_COMP *cpi,
#if CONFIG_REFERENCE_BUFFER
cm->invalid_delta_frame_id_minus1 = 0;
if (cpi->seq_params.frame_id_numbers_present_flag) {
int FidLen = cpi->seq_params.frame_id_length_minus7 + 7;
aom_wb_write_literal(wb, cm->current_frame_id, FidLen);
int frame_id_len = cpi->seq_params.frame_id_length_minus7 + 7;
aom_wb_write_literal(wb, cm->current_frame_id, frame_id_len);
}
#endif
......@@ -3975,16 +3987,17 @@ static void write_uncompressed_header(AV1_COMP *cpi,
#if CONFIG_REFERENCE_BUFFER
if (cpi->seq_params.frame_id_numbers_present_flag) {
int i = get_ref_frame_map_idx(cpi, ref_frame);
int FidLen = cpi->seq_params.frame_id_length_minus7 + 7;
int DiffLen = cpi->seq_params.delta_frame_id_length_minus2 + 2;
int frame_id_len = cpi->seq_params.frame_id_length_minus7 + 7;
int diff_len = cpi->seq_params.delta_frame_id_length_minus2 + 2;
int delta_frame_id_minus1 =
((cm->current_frame_id - cm->ref_frame_id[i] + (1 << FidLen)) %
(1 << FidLen)) -
((cm->current_frame_id - cm->ref_frame_id[i] +
(1 << frame_id_len)) %
(1 << frame_id_len)) -
1;
if (delta_frame_id_minus1 < 0 ||
delta_frame_id_minus1 >= (1 << DiffLen))
delta_frame_id_minus1 >= (1 << diff_len))
cm->invalid_delta_frame_id_minus1 = 1;
aom_wb_write_literal(wb, delta_frame_id_minus1, DiffLen);
aom_wb_write_literal(wb, delta_frame_id_minus1, diff_len);
}
#endif
}
......
av1/encoder/encoder.c
View file @ 788dc23f
......@@ -4706,7 +4706,7 @@ static void encode_frame_to_data_rate(AV1_COMP *cpi, size_t *size,
{
/* Non-normative definition of current_frame_id ("frame counter" with
* wraparound) */
const int FidLen = FRAME_ID_LENGTH_MINUS7 + 7;
const int frame_id_length = FRAME_ID_LENGTH_MINUS7 + 7;
if (cm->current_frame_id == -1) {
int lsb, msb;
/* quasi-random initialization of current_frame_id for a key frame */
......@@ -4721,10 +4721,11 @@ static void encode_frame_to_data_rate(AV1_COMP *cpi, size_t *size,
#if CONFIG_AOM_HIGHBITDEPTH
}
#endif
cm->current_frame_id = ((msb << 8) + lsb) % (1 << FidLen);
cm->current_frame_id = ((msb << 8) + lsb) % (1 << frame_id_length);
} else {
cm->current_frame_id =
(cm->current_frame_id + 1 + (1 << FidLen)) % (1 << FidLen);
(cm->current_frame_id + 1 + (1 << frame_id_length)) %
(1 << frame_id_length);
}
}
#endif
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment