Commit 7fa52234 authored by James Zern's avatar James Zern

x86inc.asm: only set visibility for chromium builds

this restores the previous version's behavior avoiding issues with
builds that may split sources on directory boundaries; protected
visibility may work in this case.

Change-Id: If37c70d9bd81de85a8e112457b9819a5cac6129d
parent 6a21ca20
...@@ -19,3 +19,4 @@ Set 'private_extern' visibility for macho targets. ...@@ -19,3 +19,4 @@ Set 'private_extern' visibility for macho targets.
Copy PIC 'GLOBAL' macros from x86_abi_support.asm Copy PIC 'GLOBAL' macros from x86_abi_support.asm
Use .text instead of .rodata on macho to avoid broken tables in PIC mode. Use .text instead of .rodata on macho to avoid broken tables in PIC mode.
Use .text with no alignment for aout Use .text with no alignment for aout
Only use 'hidden' visibility with Chromium
...@@ -762,7 +762,14 @@ BRANCH_INSTR jz, je, jnz, jne, jl, jle, jnl, jnle, jg, jge, jng, jnge, ja, jae, ...@@ -762,7 +762,14 @@ BRANCH_INSTR jz, je, jnz, jne, jl, jle, jnl, jnle, jg, jge, jng, jnge, ja, jae,
%macro cglobal_internal 2-3+ %macro cglobal_internal 2-3+
%if %1 %if %1
%xdefine %%FUNCTION_PREFIX private_prefix %xdefine %%FUNCTION_PREFIX private_prefix
%xdefine %%VISIBILITY hidden ; libvpx explicitly sets visibility in shared object builds. Avoid
; setting visibility to hidden as it may break builds that split
; sources on e.g., directory boundaries.
%ifdef CHROMIUM
%xdefine %%VISIBILITY hidden
%else
%xdefine %%VISIBILITY
%endif
%else %else
%xdefine %%FUNCTION_PREFIX public_prefix %xdefine %%FUNCTION_PREFIX public_prefix
%xdefine %%VISIBILITY %xdefine %%VISIBILITY
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment