Skip to content

GitLab

Commit 9f65bd51 authored by Angie Chiang's avatar Angie Chiang
Browse files

Fix integer overflow in AV1Convolve2DTest 

Change-Id: Ie8a0eda6de60d09bbda49eb101e278572af75613
parent bc83b642
Hide whitespace changes
Inline Side-by-side
test/av1_convolve_2d_test.cc
View file @ 9f65bd51
......@@ -22,14 +22,14 @@ using libaom_test::AV1HighbdConvolve2D::AV1HighbdConvolve2DTest;
namespace {
TEST_P(AV1Convolve2DTest, CheckOutput) { RunCheckOutput(GET_PARAM(3)); }
TEST_P(AV1Convolve2DTest, CheckOutput) { RunCheckOutput(GET_PARAM(2)); }
INSTANTIATE_TEST_CASE_P(
SSE2, AV1Convolve2DTest,
libaom_test::AV1Convolve2D::BuildParams(av1_convolve_2d_sse2));
#if CONFIG_HIGHBITDEPTH && HAVE_SSSE3
TEST_P(AV1HighbdConvolve2DTest, CheckOutput) { RunCheckOutput(GET_PARAM(4)); }
TEST_P(AV1HighbdConvolve2DTest, CheckOutput) { RunCheckOutput(GET_PARAM(3)); }
INSTANTIATE_TEST_CASE_P(SSSE3, AV1HighbdConvolve2DTest,
libaom_test::AV1HighbdConvolve2D::BuildParams(
......
test/av1_convolve_2d_test_util.cc
View file @ 9f65bd51
......@@ -23,9 +23,9 @@ namespace AV1Convolve2D {
::testing::internal::ParamGenerator<Convolve2DParam> BuildParams(
convolve_2d_func filter) {
const Convolve2DParam params[] = {
make_tuple(4, 4, 20, filter), make_tuple(8, 8, 10, filter),
make_tuple(64, 64, 1, filter), make_tuple(4, 16, 10, filter),
make_tuple(32, 8, 5, filter),
make_tuple(4, 4, filter), make_tuple(8, 8, filter),
make_tuple(64, 64, filter), make_tuple(4, 16, filter),
make_tuple(32, 8, filter),
};
return ::testing::ValuesIn(params);
}
......@@ -38,7 +38,6 @@ void AV1Convolve2DTest::TearDown() { libaom_test::ClearSystemState(); }
void AV1Convolve2DTest::RunCheckOutput(convolve_2d_func test_impl) {
const int w = 128, h = 128;
const int out_w = GET_PARAM(0), out_h = GET_PARAM(1);
const int num_iters = GET_PARAM(2);
int i, j, k;
uint8_t *input = new uint8_t[h * w];
......@@ -50,9 +49,6 @@ void AV1Convolve2DTest::RunCheckOutput(convolve_2d_func test_impl) {
for (i = 0; i < h; ++i)
for (j = 0; j < w; ++j) input[i * w + j] = rnd_.Rand8();
memset(output, 0, output_n * sizeof(CONV_BUF_TYPE));
memset(output2, 0, output_n * sizeof(CONV_BUF_TYPE));
int hfilter, vfilter, subx, suby;
for (hfilter = EIGHTTAP_REGULAR; hfilter < INTERP_FILTERS_ALL; ++hfilter) {
for (vfilter = EIGHTTAP_REGULAR; vfilter < INTERP_FILTERS_ALL; ++vfilter) {
......@@ -67,6 +63,12 @@ void AV1Convolve2DTest::RunCheckOutput(convolve_2d_func test_impl) {
for (subx = 0; subx < 16; ++subx)
for (suby = 0; suby < 16; ++suby) {
// av1_convolve_2d is designed for accumulate two predicted blocks for
// compound mode, so we set num_iter to two here.
// A larger number may introduce overflow
const int num_iters = 2;
memset(output, 0, output_n * sizeof(*output));
memset(output2, 0, output_n * sizeof(*output2));
for (i = 0; i < num_iters; ++i) {
// Choose random locations within the source block
int offset_r = 3 + rnd_.PseudoUniform(h - out_h - 7);
......@@ -102,14 +104,14 @@ namespace AV1HighbdConvolve2D {
::testing::internal::ParamGenerator<HighbdConvolve2DParam> BuildParams(
highbd_convolve_2d_func filter) {
const HighbdConvolve2DParam params[] = {
make_tuple(4, 4, 20, 8, filter), make_tuple(8, 8, 10, 8, filter),
make_tuple(64, 64, 1, 8, filter), make_tuple(4, 16, 10, 8, filter),
make_tuple(32, 8, 10, 8, filter), make_tuple(4, 4, 20, 10, filter),
make_tuple(8, 8, 10, 10, filter), make_tuple(64, 64, 1, 10, filter),
make_tuple(4, 16, 10, 10, filter), make_tuple(32, 8, 10, 10, filter),
make_tuple(4, 4, 20, 12, filter), make_tuple(8, 8, 10, 12, filter),
make_tuple(64, 64, 1, 12, filter), make_tuple(4, 16, 10, 12, filter),
make_tuple(32, 8, 10, 12, filter),
make_tuple(4, 4, 8, filter), make_tuple(8, 8, 8, filter),
make_tuple(64, 64, 8, filter), make_tuple(4, 16, 8, filter),
make_tuple(32, 8, 8, filter), make_tuple(4, 4, 10, filter),
make_tuple(8, 8, 10, filter), make_tuple(64, 64, 10, filter),
make_tuple(4, 16, 10, filter), make_tuple(32, 8, 10, filter),
make_tuple(4, 4, 12, filter), make_tuple(8, 8, 12, filter),
make_tuple(64, 64, 12, filter), make_tuple(4, 16, 12, filter),
make_tuple(32, 8, 12, filter),
};
return ::testing::ValuesIn(params);
}
......@@ -125,8 +127,7 @@ void AV1HighbdConvolve2DTest::RunCheckOutput(
highbd_convolve_2d_func test_impl) {
const int w = 128, h = 128;
const int out_w = GET_PARAM(0), out_h = GET_PARAM(1);
const int num_iters = GET_PARAM(2);
const int bd = GET_PARAM(3);
const int bd = GET_PARAM(2);
int i, j, k;
uint16_t *input = new uint16_t[h * w];
......@@ -138,9 +139,6 @@ void AV1HighbdConvolve2DTest::RunCheckOutput(
for (i = 0; i < h; ++i)
for (j = 0; j < w; ++j) input[i * w + j] = rnd_.Rand16() & ((1 << bd) - 1);
memset(output, 0, output_n * sizeof(CONV_BUF_TYPE));
memset(output2, 0, output_n * sizeof(CONV_BUF_TYPE));
int hfilter, vfilter, subx, suby;
for (hfilter = EIGHTTAP_REGULAR; hfilter < INTERP_FILTERS_ALL; ++hfilter) {
for (vfilter = EIGHTTAP_REGULAR; vfilter < INTERP_FILTERS_ALL; ++vfilter) {
......@@ -155,6 +153,12 @@ void AV1HighbdConvolve2DTest::RunCheckOutput(
for (subx = 0; subx < 16; ++subx)
for (suby = 0; suby < 16; ++suby) {
// av1_convolve_2d is designed for accumulate two predicted blocks for
// compound mode, so we set num_iter to two here.
// A larger number may introduce overflow
const int num_iters = 2;
memset(output, 0, output_n * sizeof(*output));
memset(output2, 0, output_n * sizeof(*output2));
for (i = 0; i < num_iters; ++i) {
// Choose random locations within the source block
int offset_r = 3 + rnd_.PseudoUniform(h - out_h - 7);
......
test/av1_convolve_2d_test_util.h
View file @ 9f65bd51
......@@ -31,7 +31,7 @@ typedef void (*convolve_2d_func)(const uint8_t *src, int src_stride,
const int subpel_x_q4, const int subpel_y_q4,
ConvolveParams *conv_params);
typedef std::tr1::tuple<int, int, int, convolve_2d_func> Convolve2DParam;
typedef std::tr1::tuple<int, int, convolve_2d_func> Convolve2DParam;
::testing::internal::ParamGenerator<Convolve2DParam> BuildParams(
convolve_2d_func filter);
......@@ -59,7 +59,7 @@ typedef void (*highbd_convolve_2d_func)(
InterpFilterParams *filter_params_y, const int subpel_x_q4,
const int subpel_y_q4, ConvolveParams *conv_params, int bd);
typedef std::tr1::tuple<int, int, int, int, highbd_convolve_2d_func>
typedef std::tr1::tuple<int, int, int, highbd_convolve_2d_func>
HighbdConvolve2DParam;
::testing::internal::ParamGenerator<HighbdConvolve2DParam> BuildParams(
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment