Commit 9fba0345 authored by John Koleszar's avatar John Koleszar

Partially disable error resilience test

Disables the part of the error-resilient test that tests the
quality after dropping undroppable frames. It's not clear how
to set the threshold for this correctly at the moment.

Change-Id: I3ee4a0d475498f44711fdef05749f305e8d08591
parent c0490a5c
...@@ -206,11 +206,17 @@ TEST_P(ErrorResilienceTest, DropFramesWithoutRecovery) { ...@@ -206,11 +206,17 @@ TEST_P(ErrorResilienceTest, DropFramesWithoutRecovery) {
// reset previously set error/droppable frames // reset previously set error/droppable frames
Reset(); Reset();
#if 0
// TODO(jkoleszar): This test is disabled for the time being as too
// sensitive. It's not clear how to set a reasonable threshold for
// this behavior.
// Now set an arbitrary set of error frames that are non-droppable // Now set an arbitrary set of error frames that are non-droppable
unsigned int num_error_frames = 3; unsigned int num_error_frames = 3;
unsigned int error_frame_list[] = {3, 10, 20}; unsigned int error_frame_list[] = {3, 10, 20};
SetErrorFrames(num_error_frames, error_frame_list); SetErrorFrames(num_error_frames, error_frame_list);
ASSERT_NO_FATAL_FAILURE(RunLoop(&video)); ASSERT_NO_FATAL_FAILURE(RunLoop(&video));
// Test that dropping an arbitrary set of inter frames does not hurt too much // Test that dropping an arbitrary set of inter frames does not hurt too much
// Note the Average Mismatch PSNR is the average of the PSNR between // Note the Average Mismatch PSNR is the average of the PSNR between
// decoded frame and encoder's version of the same frame for all frames // decoded frame and encoder's version of the same frame for all frames
...@@ -219,6 +225,7 @@ TEST_P(ErrorResilienceTest, DropFramesWithoutRecovery) { ...@@ -219,6 +225,7 @@ TEST_P(ErrorResilienceTest, DropFramesWithoutRecovery) {
std::cout << " Mismatch PSNR: " std::cout << " Mismatch PSNR: "
<< psnr_resilience_mismatch << "\n"; << psnr_resilience_mismatch << "\n";
EXPECT_GT(psnr_resilience_mismatch, 20.0); EXPECT_GT(psnr_resilience_mismatch, 20.0);
#endif
} }
VP8_INSTANTIATE_TEST_CASE(ErrorResilienceTest, ONE_PASS_TEST_MODES); VP8_INSTANTIATE_TEST_CASE(ErrorResilienceTest, ONE_PASS_TEST_MODES);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment