Commit cd4f4a2a authored by Yushin Cho's avatar Yushin Cho
Browse files

Fix pvq for cb4x4 and maintain its configure

Recently, sub8x8 inter mode decition functions have been
removed from the av1 codebase, so codebase does not allow
disabling cb4x4 anymore.

This makes pvq not working simply crashing
because we had disabled cb4x4 if pvq is enabled.
Hence, pvq has been fixed for cb4x4.

Also, if pvq is enabled, disable lgt and highbitdepth in the configure.

Change-Id: I2cb675c0dbc12bce60ed6a66c34ea3e907cc35b3
parent 554d2c33
......@@ -849,8 +849,16 @@ static void pack_pvq_tokens(aom_writer *w, MACROBLOCK *const x,
int max_blocks_wide;
int max_blocks_high;
int step = (1 << tx_size);
const BLOCK_SIZE plane_bsize =
get_plane_block_size(AOMMAX(bsize, BLOCK_8X8), pd);
AOMMAX(BLOCK_4X4, get_plane_block_size(bsize, pd));
#elif CONFIG_CB4X4
const BLOCK_SIZE plane_bsize = get_plane_block_size(bsize, pd);
const BLOCK_SIZE plane_bsize =
get_plane_block_size(AOMMAX(BLOCK_8X8, bsize), pd);
adapt = x->daala_enc.state.adapt;
......@@ -3965,7 +3973,9 @@ static uint32_t write_tiles(AV1_COMP *const cpi, uint8_t *const dst,
aom_start_encode(&mode_bc, dst + total_size);
write_modes(cpi, &tile_info, &mode_bc, &tok, tok_end);
assert(tok == tok_end);
#endif // !CONFIG_PVQ
#endif // !CONFIG_LV_MAP
tile_size = mode_bc.pos;
......@@ -2149,6 +2149,9 @@ static int64_t txfm_yrd(const AV1_COMP *const cpi, MACROBLOCK *x,
const int r_tx_size = tx_size_cost(cpi, x, bs, tx_size);
assert(tx_size >= TX_4X4);
#endif // CONFIG_PVQ
assert(skip_prob > 0);
assert(IMPLIES(is_rect_tx(tx_size), is_rect_tx_allowed_bsize(bs)));
......@@ -525,11 +525,12 @@ post_process_cmdline() {
soft_enable tempmv_signaling
# Fix up experiment dependencies
enabled pvq && disable_feature chroma_sub8x8
enabled pvq && disable_feature cb4x4
enabled pvq && disable_feature chroma_2x2
enabled pvq && disable_feature rect_tx
enabled pvq && disable_feature ext_tx
enabled pvq && disable_feature var_tx
enabled pvq && disable_feature highbitdepth
enabled pvq && disable_feature lgt
enabled palette_throughput && soft_enable palette
enabled ext_delta_q && soft_enable delta_q
enabled txk_sel && soft_enable lv_map
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment