1. 22 Dec, 2010 1 commit
    • Johann's avatar
      abstract apply_temporal_filter · 092b5bef
      Johann authored
      allow for optimized versions of apply_temporal_filter
      (now vp8_apply_temporal_filter_c)
      the function was previously declared as static and appears to have been
      inlined. with this change, that's no longer possible. performance takes
      a small hit.
      the declaration for vp8_cx_temp_filter_c was moved to onyx_if.c because
      of a circular dependency. for rtcd, temporal_filter.h holds the
      definition for the rtcd table, so it needs to be included by onyx_int.h.
      however, onyx_int.h holds the definition for VP8_COMP which is needed
      for the function prototype. blah.
      Change-Id: I499c055fdc652ac4659c21c5a55fe10ceb7e95e3
  2. 17 Dec, 2010 1 commit
    • John Koleszar's avatar
      Add psnr/ssim tuning option · b0da9b39
      John Koleszar authored
      Add a new encoder control, VP8E_SET_TUNING, to allow the application
      to inform the encoder that the material will benefit from certain
      tuning. Expose this control as the --tune option to vpxenc. The args
      helper is expanded to support enumerated arguments by name or value.
      Two tunings are provided by this patch, PSNR (default) and SSIM.
      Activity masking is made dependent on setting --tune=ssim, as the
      current implementation hurts speed (10%) and PSNR (2.7% avg,
      10% peak) too much for it to be a default yet.
      Change-Id: I110d969381c4805347ff5a0ffaf1a14ca1965257
  3. 16 Dec, 2010 2 commits
    • Scott LaVarnway's avatar
      Changed segmentation check order · 64baa8df
      Scott LaVarnway authored
      In SPLITMV, the 8x8 segment will be checked first.  If the 8x8 rd
      is better than the best, we check the other segments.  Otherwise
      bail.  Adjustments to the thresh_mult were necessary to make
      up for the initial quality loss.
      The performance improved by 20% (average) for good quality,
      speed 0 and speed 1, while the overall quality remained the same.
      Change-Id: I717aef401323c8a254fba3e9777d2a316c774cc3
    • Scott LaVarnway's avatar
      Adjusted breakout RD for SPLITMV · 81cdeb71
      Scott LaVarnway authored
      vp8_rd_pick_best_mbsegmentation looks at y only.  The new
      breakout does not include the frame cost, the prob_skip_false
      cost, or the uv rate.  Performance improved by a few percent
      and the quality remained the same.
      Change-Id: I94ff013998ac51e8ecce7130870f7b6600758e15
  4. 14 Dec, 2010 4 commits
    • Yunqing Wang's avatar
      Fix a bug in motion search code(2) · 08706a3e
      Yunqing Wang authored
      This fix added MV range checks for NEWMV mode as suggested by Jim.
      To reduce unnecessary MV range checks, I tried Yaowu's suggestion.
      Update UMV borders in NEWMV mode to also cover MV range check.
      Also, in this way, every MV that is valid gets checked in diamond
      search function.
      Change-Id: I95a89ce0daf6f178c454448f13d4249f19b30f3a
    • Yunqing Wang's avatar
      Fix a bug in motion search code · 7fb0f868
      Yunqing Wang authored
      The MV's range is 256. Since the new motion search uses a different
      starting MV than the center ref MV, a MV range checking needs to
      be done to avoid corruption.
      Change-Id: I8ae0721d1bd203639e13891e2e54a2e87276f306
    • Yaowu Xu's avatar
      fix a bug that "optimize" flag is not set for sub-threads · 64f3d915
      Yaowu Xu authored
      The flag for quantization optimization was not properly propagated to
      mb row encoding threads.
      Change-Id: Ic561599c35acd94cd5698c9b314bccd596ac2deb
    • Johann's avatar
      shrink TOKENEXTRA and vp8_extra_bit_struct · 825adc46
      Johann authored
      Per John's previous change, shrink TOKENEXTRA from 20 to 8 bytes
      original: b7b1e6fb
      reverted: 41f4458a
      Also drop unused field from vp8_extra_bit_struct
      Update ARM ASM to deal with this change. In particular, Extra is signed
      and needs to be sign-extended when loaded.
      Change-Id: Ibd0ddc058432bc7bb09222d6ce4ef77e93a30b41
  5. 13 Dec, 2010 3 commits
    • John Koleszar's avatar
      Revert "Reduce size of TOKENEXTRA struct" · 41f4458a
      John Koleszar authored
      This reverts commit b7b1e6fb. Previous
      fix is incomplete, breaks ARM. Itchy submit finger.
      Change-Id: I939dc0d3bf4173cf951c1d152338ab6ea2184bb9
    • John Koleszar's avatar
      remove unused temporal preproc code · b1aa54ab
      John Koleszar authored
      This code is unused, as the current preproc implementation uses the
      same spatial filter that postproc uses.
      Change-Id: Ia06d5664917d67283f279e2480016bebed602ea7
    • John Koleszar's avatar
      Reduce size of TOKENEXTRA struct · b7b1e6fb
      John Koleszar authored
      Change the size of structure elements to reduce memory utilization.
      Removed the 'section' member entirely, as it is set but never read.
      Change-Id: Iad043830392fb4168cb3cd6075fb0eb70c7f691c
  6. 10 Dec, 2010 1 commit
  7. 09 Dec, 2010 3 commits
    • Fritz Koenig's avatar
      vp8 fast quantizer sse2 optimizations for eob. · e0cf330c
      Fritz Koenig authored
      Changed the end of block computation to use pmaxw.  Removed
      additional pushing and popping of registers that was not needed.
      Change-Id: I08cb9b424513cd8a2c7ad8cea53b4e2adc66ef98
    • John Koleszar's avatar
      fix uninitialized read in encode breakout · cb969895
      John Koleszar authored
      Change I3430820b performed an uninitialized read when
      encode_breakout == 0, since the sum and sse wouldn't be set:
             VARIANCE_INVOKE(..., get16x16var)(..., &sum, &sse);
         if (cpi->active_map_enabled && x->active_ptr[0] == 0) {
         } else if (sse < x->encode_breakout)
      Change-Id: I915eb76d1227b4b6d1137a0dedf2c143860098a2
    • Paul Wilkins's avatar
      Correct q_low and q_high limits for the recode loop · c63fc881
      Paul Wilkins authored
      Corrected the initial Q range limits for the recode loop
      to reflect the current allowed range for the frame.
      In experimental work on constrained quality this bug was
      causing unnecessary recodes.
      Change-Id: I7e256fbfa681293b0223fe21ec329933d76c229f
  8. 07 Dec, 2010 2 commits
    • Jim Bankoski's avatar
      vp8e - static threshold play · 718c1971
      Jim Bankoski authored
      Realized no need for new assembly code sum is already
      Change-Id: Ie2d94feb4b7c1f77c5359bca29b66228e41638c9
    • Yaowu Xu's avatar
      adjust RDMULT for UV plane in quantization RDO · 7c03a1c3
      Yaowu Xu authored
      This patch adds a weighting factor on RDMULT for UV blocks. The change
      has an overall gain about 0.5% based on ssim, between 0.1 and 0.2% by
      psnr numbers.
      Change-Id: I97781b077ce3bb7e34241b03268491917e8d1d72
  9. 06 Dec, 2010 3 commits
    • Yunqing Wang's avatar
      Fix a memory leak problem in encoder · 9520f4b3
      Yunqing Wang authored
      Deallocating the buffers before re-allocating them.
      The fix passed James Berry's test program for memory
      leak check.
      Change-Id: I18c3cf665412c0e313a523e3d435106c03ca438d
    • Scott LaVarnway's avatar
      vp8_rd_pick_best_mbsegmentation code restructure · 2fa5d5a2
      Scott LaVarnway authored
      Moved the code from the segmentation loop into a function
      which is now called for each segment. This will allow us
      to change the segment order checking more easily.
      Change-Id: I9510d26f0acae5a73043fcca8f1984b121d3e052
    • Patrik Westin's avatar
      Fix for manual Golden frame frequency · 8534071d
      Patrik Westin authored
      When auto_golden wasn't set it forced all frames to be a golden
      frame. Now the manual configured frequency is adhered to.
      Change-Id: I360acac9bc487db0d9c4d4da6ee41f70c227c539
  10. 04 Dec, 2010 1 commit
    • Paul Wilkins's avatar
      Change to inter_minq table. · cec6a596
      Paul Wilkins authored
      The inter_minq table controls the range of quantizers available
      for a particular frame in two pass relative to a max Q value.
      The changes reduces the range somewhat. The effect of this
      was a small increase (0.3% average) in psnr for the test set
      but it should also help encode speed somewhat for higher
      quality modes as it will reduce the number of iterations in the
      recode loop.
      The change damps the range of quantizers available locally
      within a section of a clip and should therefore help keep quality
      more uniform. If there is systematic overshoot or undershoot the
      range can shift gradually to accommodate. However, there is
      some increased risk of overshoot or undershoot against the target
      bit rate in VBR mode and this risk will be more pronounced for short
      The change damps the range of quantizers available locally
      within a section of a clip and should therefore help keep quality
      more uniform. If there is systematic overshoot or undershoot the
      range can shift gradually to accommodate. However, there is
      some increased risk of overshoot or undershoot against the
      target bit rate in VBR mode and this risk will be more
      pronounced for short clips.
      Change-Id: I84465567d49ae767c6c73ff2a2aac30c895adb52
  11. 03 Dec, 2010 1 commit
    • Yunqing Wang's avatar
      Improve MV prediction accuracy to achieve performance gain · c3bbb291
      Yunqing Wang authored
      Add vp8_mv_pred() to better predict starting MV for NEWMV
      mode in vp8_rd_pick_inter_mode(). Set different search
      ranges according to MV prediction accuracy, which improves
      encoder performance without hurting the quality. Also,
      as Yaowu suggested, using diamond search result as full
      search starting point and therefore adjusting(reducing)
      full search range helps the performance.
      Change-Id: Ie4a3c8df87e697c1f4f6e2ddb693766bba1b77b6
  12. 01 Dec, 2010 1 commit
    • Fritz Koenig's avatar
      Set refresh_alt_ref_frame on keyframe encode. · 9c8ad79f
      Fritz Koenig authored
      On a keyframe alt ref and golden are refreshed.  The flag was
      not being set and so on the frame after a keyframe, motion
      search would occur on the alt ref frame.  This is not necessary
      because the alt ref frame identical to the last frame in this
      Handle corner case where a forward alt-ref frame is put
      directly after a keyframe.
      Change-Id: I9be4cf290d694f8cf2f9a31852014b5ccf1504d3
  13. 27 Nov, 2010 1 commit
  14. 22 Nov, 2010 1 commit
    • Paul Wilkins's avatar
      Recalibration of bits per MB tables · ad6150f7
      Paul Wilkins authored
      The baseline bits per MB prediction tables have been
      re calibrated based on the assumption that bits per mb
      is inversely proportional to the quantizer level.
      Change-Id: Ibd355c7acac4b8053dda1baf1032fe35f11da7f7
  15. 19 Nov, 2010 1 commit
  16. 18 Nov, 2010 1 commit
    • Pascal Massimino's avatar
      remove warning · ed5ab7fa
      Pascal Massimino authored
      was having: "vp8/encoder/onyx_if.c:5365: warning: comparison of unsigned expression >= 0 is always true"
  17. 17 Nov, 2010 2 commits
    • Scott LaVarnway's avatar
      Removed unnecessary checks. · f7670acc
      Scott LaVarnway authored
      macro_block_yrd and vp8_rdcost_mby are not called for SPLITMV.
      Change-Id: I2224d3c8725df526d48426447482768d543752f1
    • Paul Wilkins's avatar
      Replaced recode loop test with a function call · f874391e
      Paul Wilkins authored
      Replaced existing code to decide if a frame recode is required
      with a function call. This is to simplify addition of extra clauses
      that may be needed for the planned constrained quality mode.
      Also fixed a bug where by alt ref not considered in the test.
      Change-Id: I3d40bb21abe3e19f8456761e6849deb171738b60
  18. 16 Nov, 2010 1 commit
  19. 15 Nov, 2010 2 commits
    • Fritz Koenig's avatar
      Remove stack shadowing for x86-x64 for SAD functions. · e1802553
      Fritz Koenig authored
      x86-64 passes arguments in registers.  There is no need to push
      them to the stack before using them.
      This fixes 15acc84f where ebx
      was not getting preserved on x86.
      Change-Id: I1214b5f818a0201f75ab6ad7d5c6f448e09b16c2
    • Paul Wilkins's avatar
      Bad cost tables used in ARNR filtering. · 373f5c31
      Paul Wilkins authored
      The use of incorrect mv costing tables in the ARNR sub-pel
      filtering code led to corruption of the altref buffer in some cases,
      particularly at low data rates.
      The average gain from this fix is about 0.3% but there are a few
      extreme cases where nasty and visible artifacts manifested and
      for these few data points the improvement is > 10%.
      PGW and AWG
      Change-Id: I95cc02b196a433e71d0d2bd2b933fe68ed31e796
  20. 11 Nov, 2010 3 commits
    • Yaowu Xu's avatar
      make rdmult adaptive for intra in quantizer RDO · ef2f27f1
      Yaowu Xu authored
      This intends to correct the tendency that VP8 aggressively favors rate
      on intra coded frames. Experiments tested different numbers in [0, 1]
      and found 9/16 overall provided about 2-4% gains for all-intra coded
      clips based on vpx-ssim metric. The impact on regular encoded clips
      is much smaller but positive overall. Overall impact on psnr is also
      positive even though very small.
      Change-Id: If808553aaaa87fdd44691f9787820ac9856d9f8a
    • John Koleszar's avatar
      quantizer: fix assertion in fast quantizer path · 0a49747b
      John Koleszar authored
      The fast quantizer assembly code has not been updated to match the new
      exact quantizer, which was made the default in commit 6adbe090.
      Specifically, they are not aware of the potential for the coefficient
      to be scaled, which results in the quantized result exceeding the range
      of the DCT. This patch restores the previous behavior of using the
      non-shifted coefficients when in the fast quantizer code path, but
      unfortunately requires rebuilding the tables when switching between the
      Change-Id: I0a33f5b3850335011a06906f49fafed54dda9546
    • Fritz Koenig's avatar
      Revert "Remove stack shadowing for x86-64" · 58083cb3
      Fritz Koenig authored
      This reverts commit 15acc84f.
      Change-Id: Ia640be8cbc134432914849c1750f62575ea084e6
  21. 10 Nov, 2010 4 commits
    • Fritz Koenig's avatar
      FDCT optimizations. · 5f0e0617
      Fritz Koenig authored
      Fixed up the fdct for mmx and 8x4 sse2 to match them
      most recent changes.
      Change-Id: Ibee2d6c536fe14dcf75cd6eb1c73f4848a56d719
    • Fritz Koenig's avatar
      postproc : Re-work posproc calling to allow more flags. · 647df00f
      Fritz Koenig authored
      Debugging in postproc needs more flags to allow for specific
      block types to be turned on or off in the visualizations.
      Must be enabled with --enable-postproc-visualizer during
      configuration time.
      Change-Id: Ia74f357ddc3ad4fb8082afd3a64f62384e4fcb2d
    • Paul Wilkins's avatar
      Relax rate control for last few frames · 513f8e68
      Paul Wilkins authored
      VBR rate control can become very noisy for the last few frames.
      If there are a few bits to spare or a small overshoot then the
      target rate and hence quantizer may start to fluctuate wildly.
      This patch prevents further adjustment of the active Q limits for
      the last few frames.
      Patch also removes some redundant variables and makes one small bug fix.
      Change-Id: Ic167831bec79acc9f0d7e4698bcc4bb188840c45
    • Paul Wilkins's avatar
      Tuning for the more exact quantizer. · 6adbe090
      Paul Wilkins authored
      Small changes to the default zero bin and rounding tables.
      Though the tables are currently the same for the Y1 and Y2 cases
      I have left them as separate tables in case we want to tune this later.
      There is now some adjustment of the zbin based on the prediction mode.
      Previously this was restricted to an adjustment for gf/arf 0,0 MV.
      The exact quantizer now marginal outperforms and is the default.
      The overall average gain is about 0.5%
      Change-Id: I5e4353f3d5326dde4e86823684b236a1e9ea7f47
  22. 05 Nov, 2010 1 commit
    • John Koleszar's avatar
      improve average framerate calculation · f7e187d3
      John Koleszar authored
      Change Ice204e86 identified a problem with bitrate undershoot due to
      low precision in the timestamps passed to the library. This patch
      takes a different approach by calculating the duration of this frame
      and passing it to the library, rather than using a fixed duration
      and letting the library average it out with higher precision
      timestamps. This part of the fix only applies to vpxenc.
      This patch also attempts to fix the problem for generic applications
      that may have made the same mistake vpxenc did. Instead of
      calculating this frame's duration by the difference of this frame's
      and the last frame's start time, we use the end times instead. This
      allows the framerate calculation to scavenge "unclaimed" time from
      the last frame. For instance:
        start |  end  | calculated duration
          0ms    33ms   33ms
         33ms    66ms   33ms
         66ms    99ms   33ms
        100ms   133ms   34ms
      Change-Id: I92be4b3518e0bd530e97f90e69e75330a4c413fc