GitLab

CONFIG_UV_LVL --> CONFIG_LOOPFILTER_LEVEL
Change name because the experiment combines filter level search
in U, V plane, and horizontal, vertical search in Y plane.

Change-Id: Ia05b8f80cd93b60a0305eb94e5783559ef904c13

A new experiment for deblocking filter that separates vertical
and horizontal filter strengths. This experiment is based on the
assumption that non-flatness characteristics of vertical and
horizontal direction may differ. Therefore selecting different
filter strengths for vertical and horizontal can improve deblocking
performance.

The process of finding proper filter strength:
1. Search through the filter level under the constraint that
   (vertical == horizontal), and find the best solution.
2. Fix vertical level as the best solution found in step 1 and vary
   horizontal level to find the best value.
3. Fix the selected horizontal level, vary vertical level to find
   its best value.

The experiment is working with UV_LVL, sharing the same config flag.
The searching for horizontal and vertical filter strength only applies
on Y plane for now.

The experimental flag should be changed to filter_level later.

Change-Id: I164eec8d3ccb3da7ff109c5c55f4b52c1536ddf1

Currently nothing forbids wedge from being signalled when
the block is > 32X32, even though there is no corresponding wedge
mask for that block size.

BUG=aomedia:640
BUG=aomedia:636

Change-Id: I538be0229a12b5ef01b2e5a950c9f16ef9a5c51e

BUG=aomedia:697

Change-Id: Id7e971e515c9faa3df32e162befd57907278549d

Coding gain becomes tiny on top of other experiments.

Change-Id: Ia89b1c2a2653f3833dff8ac8bb612eaa3ba18446

Use --tune=[cdef-dist|daala-dist] to enable them.

Also, this commit set the use_activity_masking of PVQ as 0 by deafult,
which means that PVQ assumes daala-dist is not used by default.

Since we're currently not signaling which metric the encoder did use
in the bitstream, the compile flag AV1_PVQ_ENABLE_ACTIVITY_MASKING will tell PVQ
whether daala-dist is used or not.

This commit is the last part of prep-work to remove DIST_8X8, CDEF_DIST,
and DAALA_DIST experimental flags.

Change-Id: Ia465b4d6fe64aac7f04852c8f9f4bac3409d2435

Fix a memory corruption introduced by commit
f190a165

On some cases, when empty tiles are present,
av1_set_across_tile_boundary_info() writes beyond mode info array.

Sanity check added.

BUG=aomedia:690

Change-Id: I8d87a2e183c69d0ed039c8b2f77b30434f837974

When ext-comp-refs is enabled, one-sided-compound is enabled by default,
which ensures the use of ext-comp-refs is an extension of
one-sided-compound. Both coding tools allow the use of same-sided
reference frame pairs for compound prediction.

Also, remove the dependency of ext-comp-refs on var-refs, i.e. these two
coding tools can be independently enabled. They can still work together
if both are enabled simultaneously.

Change-Id: I3134e7e2956dc35d557fe814f5d801d473683650

* When wedge and compound-segment are disabled, we don't use
  compound_type_cdf, but it still gets copied around, averaged, etc.
  It's slightly nicer to avoid that when it isn't necessary.

* Fix an anomaly with cb4x4: We had (schematically)
  'if (bsize < 8X8 && CB4X4)', which is backwards when compared to
  other similar conditions elsewhere in the code.
  Change this to 'if (bsize < 8X8 && !CB4X4)" to match other code.

Change-Id: If802cf4f305c30cd642d0d5dd6610b547b52a027

1. Fixes logic for disabling global motion w/ resize. Turns off
conditional write/read of global parameters since it does not
work currenlty. To be fixed later.
2. Fixes call for av1_scale_if_required in encoder_frame_with_resize
function
3. Remove asserts for the scaled convolve functions

Change-Id: I6a0f18b5ab5cc819bc27ef9fc2f28b0e391643a0

No change to metrics, as quantization matrices are not used
unless --enable-qm=1 is set on the command line.

Fix no highbitdepth compilation, and fix compile errors and
warnings for PVQ and NEW_QUANT experiments.

Change-Id: I49aceb5acf6ca6790c81e760e5b208788f87086d

Change-Id: I61165218afefe7fc59ad06a0abe0180754cdf7bd

Low latency, cpu-used=0:
   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.3162 | -0.6719 | -0.6535 |   0.0089 | -0.3890 | -0.1515 |    -0.6682

High latency, cpu-used=0:
   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.0293 | -0.3556 | -0.5505 |   0.0684 | -0.0862 |  0.0513 |    -0.2765

Low latency, cpu-used=4:
   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.2248 | -0.7764 | -0.6630 |  -0.2109 | -0.3240 | -0.2532 |    -0.6980

High latency, cpu-used=4:
   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.1118 | -0.5841 | -0.7406 |  -0.0463 | -0.2442 | -0.1064 |    -0.4187

Change-Id: I9ca8399c8f45489541a66f535fb3d771eb1d59ab

This experiment is now adopted as it was cleared by Tapas.

Note: Palette use can still be controlled by command-line option
"--tune-content=..." in 'aomenc'.

Change-Id: I832f49f20f60c34bdef5b424755849c496687e87

The problem was that some functions were using scale_chroma_bsize()
function to turn sub-8x8 'bsize' to 8x8 'bsize', and then the modified
'bsize' was being passed to rd_pick_intra_sbuv_mode() for example.

In such cases, we cannot rely on the 'bsize' value passed to the
function; instead, we need to look at the original mbmi->sb_type
directly.

Also:
- Added created a common function can_use_palette() to refactor this
logic into one place.
- Added more asserts to easily catch such coding errors in future.

BUG=aomedia:688

Change-Id: I2e9f20c8c5fbc4b3ff41b703a91a02758c3c632f

Since there are no CDFs set up for palettes for 4:1/1:4 blocks, we
should make sure we don't try to use them. Without this patch,
write_palette_mode_info gets called with a bsize of BLOCK_32X8 and
reads (and writes) off the end of the palette_y_size_cdf array.

This patch avoids calling it in this context and adds an assertion to
make sure we don't read off the end of the array in future.

The patch also adds the corresponding logic to rdopt.c.

Change-Id: I4d9aea982d057e305a6b578f35457eada819d38f

When AOM_QM is enabled, by default quantization matrices are
flat unless enabled with --enable-qm=1. Re-use existing SIMD
functions when a flat matrix is used, so that there is no
speed deficit when AOM_QM is enabled.

SIMD for the non-flat case is TBC.

Change-Id: I1bb8da70d3dd5858dac15099610ddf61662e3d0d

Change-Id: I08340afd1bc667b97d96e5540cf5c126bcfaaab4

Name changes and code moves to bring code more in line with the
design doc and an upcoming single-pass patch.  No functional changes.

Change-Id: I2bccd58c644e534b139f420b623390aa971fbdb0

Change-Id: I44bc9d8887526a5ee92bf79730fa3ce6c73b160b

Because frame contexts now follow reference frames, explicit resets
are no longer necessary, but can simply happen at the same time
as reference frame resets.

Change-Id: Idbed3794e3ed52fa298346943a3014fa1ca23897

This CL adds the use of ALTREF2_FRAME to both single / comp reference
prediction at the encoder side. In particular, the encoder keeps the
distant altref as ALTREF, and uses the internal extra altrefs to
refresh ALTREF2.

Compared with the baseline (ext_tx and global_motion disabled simply
for speed concern):
(a) lowres: avg_psnr -0.395% ovr_psnr -0.393% ssim -0.329%
(b) midres: avg_psnr -0.419% ovr_psnr -0.431% ssim -0.444%
(c) AWCY High Latency:
   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.6661 | -0.5988 | -0.6669 |  -0.6993 | -0.6988 | -0.7303 | -0.6051
(d) AWCY Low Latency:
  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0720 | -0.0505 |  0.1501 |   0.0670 | 0.0842 |  0.0517 |     0.0158

TODO list:
(1) To have altref2 incorporated with ext-comp-refs;
(2) To have altref2 fully work with new-multisymbol;
(3) To re-collect the initial default probs/cdfs;
(4) To tune the encoder gf group structure design for altref2.

Change-Id: I6ad63fd65afa903d3bba20acdb68e3b67acf7fdf

This stores frame contexts alongside a reference frame, and always
uses the frame in reference slot 0 (LAST_FRAME) as the source of
the frame context.

The encoder could then reorder reference frames as to control
which frame context is used, however currently it does not.

Low Latency AWCY result:

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.1438 |  0.4161 |     N/A |   0.0386 | -0.0281 |  0.0453 |     0.2514

https://arewecompressedyet.com/?job=before-frame-context-signaling%402017-06-07T23%3A20%3A49.473Z&job=after-frame-context-signaling%402017-06-07T23%3A21%3A36.117Z

Change-Id: I4f6f9b12cb403573efbf9e5c3077d62f5dedc467

For some background, see this previous change in Gerrit[0]. What's
going on here is that we only want to use a previous frame for motion
vector prediction if the encoded sizes match. When scaling with
superres, this means the size before upscaling.

To check this correctly, we need to check prev_frame's width/height
and compare it with the current frame. Without superres, prev_frame's
width/height is stored in y_crop_width/y_crop_height so we can check
that way. With superres, those numbers are after the scaling, so can't
be compared with cm->width and cm->height.

The previous code worked around this by comparing with cm->last_width
and cm->last_height. That works because these are the width/height for
the last encoded and shown frame and that frame *is* prev_frame if
last_show_frame is true. Since this is the only case when we want to
use prev_frame, they are the numbers we need.

This patch simplifies the logic by storing the width/height in
RefCntBuffer before any scaling and then checking that they match.

The check for whether we can use motion vectors from a previous frame
is factored out into a pair of inline functions in the
header. frame_might_use_prev_frame_mvs() is true if it's possible that
this frame could use motion vectors from a previous frame. This
doesn't use knowledge of what prev_frame is: it just checks we're not
in error resilient mode and aren't a keyframe. When this is true, a
flag is signaled in the bitstream to say whether we actually want to
use motion vectors from the previous frame.

The second function, frame_can_use_prev_frame_mvs, is true if the
current frame / previous frame pair is suitable for sharing motion
vectors. This is a stricter test: the previous frame needs to be
have been shown and not to have been intra_only, and it needs to have
the same width/height as the current frame.

If the re-assignment of prev_frame (just before the calls to
frame_can_use_prev_frame_mvs()) were removed in some way, we could
probably combine the two functions and often save a bit per frame
header.

The other slight tidy-up in the patch is to move re-allocation of the
mvs buffer into onyxc_int.h: the code that did the allocation was
duplicated between the encoder and decoder.

[0] https://aomedia-review.googlesource.com/c/13806

BUG=aomedia:78

Change-Id: If25227fa24222fc05c56529c2ac9ddf1e1c36a84

With superres enabled, mi_rows/mi_cols might not be constant across
frames (the scaling factor might change). This patch fills in Nathan
Egge's todo comment to do something useful if the current
mi_rows/mi_cols size isn't what the calling code expected.

Change-Id: I7edf8c6efc25ff182fc5b6a7eff7d56e2d9e86dc

Each CDF for partitioning square blocks is initialised from
an entry of default_partition_cdf in entropymode.c. These CDFs are of
different lengths, depending on which partition types are supported by
the block size.

For example, 8x8 blocks have a CDF with only 4 entries (PARTITION_NONE
through PARTITION_SPLIT). Blocks of a size that supports 1:4 and 4:1
partitions have 10 entries. Currently, that's only 32x32 blocks. All
other blocks have 8 entries.

Change-Id: Ie2126b6d41afc0efedcc5b5b37fc1d0427b9a9fa

These are caused when both #if and #else has if (...) '{' but
there is only one matching '}'.

Fixed for some of decoding side files. More to come soon.

Change-Id: I9e63b90ba6e739b5c7e37498458c7808e2e16d33

This warning only comes up if none of the experiments ext-intra,
palette and filter-intra are enabled.

Change-Id: Ic58863d8d845034aa52230bf52a3c5def8d3ac0f

Expand the range of alpha to [-2, 2] in Q3.
Jointly signal the signs, including zeros.
Use the signs to give context for each quadrant
and half-axis. The (0, 0) point is excluded.
Symmetry in alpha_u == alpha_v yields 6 contexts.

Results on Subset1 (Compared to 9136ab7d with CFL enabled)

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.0792 | -0.7535 | -0.7574 |  -0.0639 | -0.0843 | -0.0665 |    -0.3324

Change-Id: I250369692e92a91d9c8d174a203d441217d15063
Signed-off-by: David Michael Barr <b@rr-dav.id.au>

CfL is now an independent mode.

Results on Subset1 (Compared to 4266a7ed with CFL enabled)

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-0.1645 | -0.4017 |  0.2475 |  -0.1851 | -0.2179 | -0.2338 |    -0.2897

Change-Id: I2e86e7ea7bfc12bb1d763e70a136ca992d57a3c5

Make CDEF select filter strength every 64x64 block when block size
could be larger than 64x64.

With/without this patch, coding performances on AWCY and Google
test of lowres and midres are neutral.

BUG=aomedia:662

Change-Id: Ief82cc51be91fc08a7c6d7e87f6d13bcc4336476

Previously, U, V planes share the same filter level with Y.
Here, we search and pick the best filter level for U, V planes.
Selected filter levels are transmitted per frame.
This works with parallel_deblocking.

Coding gain on Google test set:
		Avg_psnr	ovr_psnr	ssim
lowres: 	-0.116		-0.120		-0.339
midres:		-0.218		-0.228		-0.338
hdres:		-0.260		-0.264		-0.365

Change-Id: I03d2ac47539f3eea9f3c4b08007bd6d3f4b73572

Change-Id: Ie2c34490dc50cb242bcd701308e6b55243883b15

A separate prediction mode struct is added to allow
for uv-only modes (like CfL). Note: CfL will be
added as a separate mode in an upcoming commit.

Results on Subset1 (Compared to 4266a7ed with CfL enabled)
  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0000 |  0.0000 |  0.0000 |   0.0000 | 0.0000 |  0.0000 |     0.0000

Change-Id: Ie80711c641c97f745daac899eadce6201ed97fcc

Around 0.9% improvement on screen_content set (encoding 30 frames).

Change-Id: Ic4c9333c9af5993bc41e513b9e766450b3a951eb

The existing code has a case where we set a variable to equal
xd->ref_mv_stack[mbmi->ref_frame[0]][1 + mbmi->ref_mv_idx]
even for compound blocks. However, the range of allowable
values for mbmi->ref_mv_idx is determined by the ref_mv_count
for the *combined* ref frame, not for the first single ref frame.

This means that, if we have more ref-mv candidates for the combined
ref frame than for the first single ref frame, then we can sometimes
fetch uninitialized data.
In every case where this happens, we immediately overwrite
the destination with the correct mv, but it is still preferable
to avoid reading uninitialized data.

This patch moves the code block to avoid this bug. In addition,
the variable (nearmv[0]) is only used when the mode equals NEARMV,
so the condition on its assignment is changed to reflect that.

Change-Id: I3bd268dc80d8065d5189999232b8a0f826d40a95

This change does not alter the bitstream

Resuls on Subset1 (compared to 70a80a81 with cfl)
  PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
0.0000 |  0.0000 |  0.0000 |   0.0000 | 0.0000 |  0.0000 |     0.0000

Change-Id: I7672eb4cde3c649ebba32610f7e56500e378c062

Change-Id: Ibd0bda593717aab2894c36dd59925a0bcf654113

Change-Id: I00f98e0e03a44aa894566b7a47bb0f32b56da766

Change-Id: Ib03758eb5ab32ee7d0f87d216bc5fad591578597