1. 16 Aug, 2017 7 commits
    • Rupert Swarbrick's avatar
      Simplify motion var parameters in reconinter.h · 1cfe474b
      Rupert Swarbrick authored
      Before this patch, the functions build_inter_predictors, allow_warp
      and av1_make_inter_predictor took two parameters (if
      CONFIG_MOTION_VAR): mi_col_offset and mi_row_offset. These were used
      for two things: they were used to look up a MODE_INFO structure and
      the code figured out it was doing OBMC if at least one offset was
      nonzero.
      
      This patch slightly simplifies things by passing the relevant mi and a
      flag saying whether we're doing OBMC instead. This means the
      allow_warp function actually loses a parameter.
      
      It also moves all mention of the functions out of the header and into
      reconinter.c since they are only used in that compilation unit.
      
      Change-Id: I8dedad9d7384ee0aa17b977e92ea7bfa83a532ef
      1cfe474b
    • James Zern's avatar
      aom_configure: ensure RTCD_CONFIG_* are properly set · a1e274e2
      James Zern authored
      adjustments made by aom_configure.cmake need to be done prior to
      including cpu.cmake
      
      Change-Id: I482905414da4b1e112066d127cd71f8eae9dd504
      a1e274e2
    • Tom Finegan's avatar
      Add support for CONFIG_XIPHRC to the CMake build. · f00be13c
      Tom Finegan authored
      BUG=aomedia:683
      
      Change-Id: I198665a2cf5714bbb6fa7ecc8e430c02198cfb7b
      f00be13c
    • Tom Finegan's avatar
      Fix CONFIG_TXK_SEL support in the CMake build. · 08917e7b
      Tom Finegan authored
      CONFIG_TXK_SEL requires CONFIG_LV_MAP. Warn when not enabled, and
      enable it. This matches the configure build.
      
      BUG=aomedia:683
      
      Change-Id: Iba0340d13fcb3cb0d20fc36df6b3def2fc1d92fd
      08917e7b
    • Tom Finegan's avatar
      Fix CONFIG_PVQ support in the CMake build. · ac87049f
      Tom Finegan authored
      Wrap usages and declaration of av1_set_txb_context with
      CONFIG_PVQ preproc checks.
      
      BUG=aomedia:683
      
      Change-Id: I2080d7437ebe1741232eb5e4e83a430279c913a0
      ac87049f
    • James Zern's avatar
      coding_path_sync.cc: fix missing initializer warning · 78e5ecfc
      James Zern authored
      use the default constructor for aom_codec_dec_cfg, this matches the
      other tests
      
      Change-Id: I989007517c0dbd47b3781b812feba905061c0a26
      78e5ecfc
    • Urvang Joshi's avatar
      Re-enable resize test. · c9ac07f6
      Urvang Joshi authored
      This test has been removed from compilation for many months now.
      We add it back to compilation, but disable some of the tests which are
      not working / may be obsolete.
      
      Note: This test, had it been enabled earlier, would have caught some
      recently discovered issues (such as these fixes:
      https://aomedia-review.googlesource.com/c/18080)
      
      Change-Id: I3c7954f996889c86a63cda33fda1a1c06ed4c6d7
      c9ac07f6
  2. 15 Aug, 2017 17 commits
    • Monty Montgomery's avatar
      Disable only coding transform SIMD for DAALA_TX · 1d190950
      Monty Montgomery authored
      Rather than disabling MMX (well, all of SIMD) for daala transforms,
      selectively disable the AV1 TX SIMD through
      av1/common/av1_rtcd_defs.pl
      
      This also requires quite a few testing build fixups.
      
      Change-Id: I689eaafbdd3a87e3a8eeef97412a1846ef886055
      1d190950
    • Monty Montgomery's avatar
      Add 4-point DST to DAALA_DCT4 experiment · 573cf25f
      Monty Montgomery authored
      CONFIG_DAALA_DCT4 currently force-enables CONFIG_DCT_ONLY due to a
      missing 4-point DST.  The DST had not been included because it was a
      significant coding performance loss; this turned out to be a bug that
      has since been corrected.
      
      This patch adds a 4-point type IV DST to the DAALA_DCT4 experiment.
      There is a small coding performance loss in using the type IV over
      AV1's current type VII.
      
      subset-1:
         monty-newdst4test-baseline-s1-F@2017-07-29T04:58:43.976Z ->
            monty-newdst4test-daala-s1-F@2017-07-29T04:59:56.094Z
      
         PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      -0.0336 |  0.1393 |  0.0491 |   0.4118 | -0.0439 |  0.2084 |     0.0476
      
      objective-1-fast:
         monty-newdst4test-baseline-o1f-F@2017-07-29T04:58:10.439Z ->
            monty-newdst4test-daala-o1f-F@2017-07-29T04:59:04.678Z
      
        PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      0.0064 |  0.1071 | -0.0108 |   0.1133 | -0.0035 |  0.0765 |     0.0502
      
      Change-Id: Ie29835edbe0e41bc86f4b09457e88d924cc9bf7e
      573cf25f
    • Zoe Liu's avatar
      Add ext-comp-refs dependency on ext-refs in configure · b9cfa415
      Zoe Liu authored
      This will remove the compilation failure for the weekly run on speed
      checking.
      
      Change-Id: Idf688c7e4c6fcb4c5aabef68b0e9f68996cd9a12
      b9cfa415
    • Monty Montgomery's avatar
      Add CONFIG_DAALA_DCT64 experiment. · a4e245a9
      Monty Montgomery authored
      This experiment replaces the 64-point Type-II DCT and related
      scaling vp9 transforms with the 64-point orthonormal
      Daala transforms.
      
      subset-1:
      
          monty-square-baseline-s1-F2@2017-07-28T03:35:45.962Z ->
            monty-square-dct64-s1-F2@2017-07-29T04:50:58.412Z
      
             PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
          -0.1930 | -0.2037 | -0.0643 |  -0.1917 | -0.2331 | -0.3510 |    -0.1810
      
      objective-1-fast:
      
          monty-square-baseline-o1f-F2@2017-07-28T03:35:35.533Z ->
            monty-square-dct64-o1f-F2@2017-07-29T04:50:28.542Z
      
             PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
          -0.2557 | -0.1743 | -0.4900 |  -0.3028 | -0.4147 | -0.5764 |    -0.2864
      
      Change-Id: I1f944df29e44d2e350c42555af274f2d75a62a92
      a4e245a9
    • Ralph Giles's avatar
      aom_dsp: regularize EXT_PARTITION_TYPES handling. · ccfdfce1
      Ralph Giles authored
      aom_dsp_rtcd_defs.pl compares most CONFIG_* keys to "yes"
      to see if they're set. The script was checking just
      
        if (aom_config("CONFIG_EXT_PARTITION_TYPES"))
      
      in some cases. The build system doesn't add disabled
      configuration options to libs.mk so this is effectively
      the same, however it means that setting the config
      key explicitly to 0 or "no" in the config headers
      was treated the same as setting it to 1 or "yes",
      and aom_dsp_rtcd.h would have opposite expections
      from aom_config.h or aom_config.asm.
      
      Treat this key similarly to others for consistency.
      
      Change-Id: I27bd7a5532ba4afc2bb289b43b57a1b1971c0348
      ccfdfce1
    • Debargha Mukherjee's avatar
      Add scaled convolve functions for convolve_round · 9c5b1088
      Debargha Mukherjee authored
      Change-Id: I343d94520955b6632c2a990af26454859b29a97e
      9c5b1088
    • David Barker's avatar
      A few fixes for ext-inter · 9b75e210
      David Barker authored
      * When wedge and compound-segment are disabled, we don't use
        compound_type_cdf, but it still gets copied around, averaged, etc.
        It's slightly nicer to avoid that when it isn't necessary.
      
      * Fix an anomaly with cb4x4: We had (schematically)
        'if (bsize < 8X8 && CB4X4)', which is backwards when compared to
        other similar conditions elsewhere in the code.
        Change this to 'if (bsize < 8X8 && !CB4X4)" to match other code.
      
      Change-Id: If802cf4f305c30cd642d0d5dd6610b547b52a027
      9b75e210
    • hui su's avatar
      Make q_adpt_probs work with CDF · ef125a07
      hui su authored
      Replace probablity tables with CDF tables.
      
      Change-Id: I21e12dce7f1a3fc7aa84805e890342445e68ce29
      ef125a07
    • Angie Chiang's avatar
      Refactor warp_filter_test_util · 2439e323
      Angie Chiang authored
      1) Move input initialization into iteration for loop
      2) Reduce the iteration number
      
      Change-Id: Iaf2e57134bff2b08046d875d0559d7644160bcb2
      2439e323
    • Urvang Joshi's avatar
      Remove ALT_INTRA flag. · 93b543ab
      Urvang Joshi authored
      This experiment has been adopted as it has been cleared by Tapas.
      
      Change-Id: I0682face60f62dd43091efa0a92d09d846396850
      93b543ab
    • Urvang Joshi's avatar
      Remove left-over lines about PALETTE from configure. · 9f262c5b
      Urvang Joshi authored
      Change-Id: I6b529f8aac561c746bf2805e601931f982bdbb88
      9f262c5b
    • Luc Trudeau's avatar
      Fix for Encode/Decode mistmatch EXT_REFS · b5e845bb
      Luc Trudeau authored
      In av1/av1_cx_iface.c the encoder_encode function loops over calls made
      to av1_get_compressed_data(). If the show_existing_frame flag is set,
      the frame has already been flushed and the av1_twopass_postencode_update
      function already incremented gf group index. The loop must exit, or else
      the superframe might contain multiple shown frames. This causes a
      mismatch in the test_decode function in that
      av1_cx_iface.c:ctrl_get_new_frame_image will return the frame at
      last_show_frame_buf_idx whereas, av1_dx_iface.c:ctrl_get_new_frame_image
      will return cm->frame_to_show
      
      BUG=aomedia:669
      
      Change-Id: I0765048be9bd04936e080db119b54c4050019bff
      b5e845bb
    • Debargha Mukherjee's avatar
      Miscellaneous fixes for resize/frame-superres · 17e7b081
      Debargha Mukherjee authored
      1. Fixes logic for disabling global motion w/ resize. Turns off
      conditional write/read of global parameters since it does not
      work currenlty. To be fixed later.
      2. Fixes call for av1_scale_if_required in encoder_frame_with_resize
      function
      3. Remove asserts for the scaled convolve functions
      
      Change-Id: I6a0f18b5ab5cc819bc27ef9fc2f28b0e391643a0
      17e7b081
    • Angie Chiang's avatar
      Fix integer overflow in warp filter test · ec329eec
      Angie Chiang authored
      The overflow happens because the buffer used by convolve_round
      is not properly initialized.
      
      BUG=aomedia:686
      
      Change-Id: I6173fb1899eeda78adafde773b3f36312467b47f
      ec329eec
    • Rupert Swarbrick's avatar
      Replace magic 32/64 constants with 8 * MI_SIZE · 57486c5f
      Rupert Swarbrick authored
      These multiplications convert from mi units to subpels (1/8th pixel)
      and weren't correct if MI_SIZE was 4 rather than 8. This patch
      rephrases the multiplications as x * 8 * MI_SIZE or x/2 * 8 *
      MI_SIZE (for obmc calculations where you need the middle of a block).
      
      Change-Id: I7997b1221ac417a223a94f1f26a86b6acd27c5da
      57486c5f
    • Thomas Davies's avatar
      AOM_QM: enable by default · 181fc08f
      Thomas Davies authored
      No change to metrics, as quantization matrices are not used
      unless --enable-qm=1 is set on the command line.
      
      Fix no highbitdepth compilation, and fix compile errors and
      warnings for PVQ and NEW_QUANT experiments.
      
      Change-Id: I49aceb5acf6ca6790c81e760e5b208788f87086d
      181fc08f
    • Monty Montgomery's avatar
      Add CONFIG_DAALA_DCT32 experiment. · 2cb52baf
      Monty Montgomery authored
      This experiment replaces the 32-point Type-II DCT and 32-point
      Type-IV DST scaling vp9 transforms with the 32-point orthonormal
      Daala transforms.
      
      subset-1:
      
          monty-square-baseline-s1-F3@2017-08-02T11:50:51.375Z ->
            monty-square-dct32-s1-F3@2017-08-02T11:50:18.859Z
      
            PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
          0.0000 |  0.0115 | -0.1044 |  -0.0185 | -0.0069 | -0.0603 |     0.0555
      
      objective-1-fast (4 frames):
      
          monty-square-baseline-o1f-F3-l4-fine@2017-08-12T02:18:05.560Z ->
            monty-square-dct32-o1f-F3-l4-fine@2017-08-12T02:19:44.461Z
      
            PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
         -0.0269 | -0.0715 |     N/A |  -0.0547 | -0.0268 | -0.0590 |        N/A
      
      Change-Id: Ib1bad991d82eb67956e94a6216298a84e908b169
      2cb52baf
  3. 14 Aug, 2017 6 commits
  4. 12 Aug, 2017 1 commit
  5. 11 Aug, 2017 8 commits
    • Yi Luo's avatar
      Simplify pixel clamping in highbitdepth loop filter · 099b1221
      Yi Luo authored
      The constants used in pixel clamping is based on bitdepth.
      Their calculation is moved outside pixel clamping and does
      only once. This achieves about <2% speed improvement on
      decoder.
      
      Change-Id: I48dcaebe04a3478962c3b6568d247a23b47a89d4
      099b1221
    • Yunqing Wang's avatar
      Revert "Refactor and generalise OBMC prediction code" · d565529d
      Yunqing Wang authored
      This reverts commit 29824a42.
      
      Unit test failure was seen.
      AV1/AVxEncoderThreadLSTest.EncoderResultTest/2
      AV1/TileIndependenceTestLarge.MD5Match/2
      
      Change-Id: I836b6ef8b8eeac45014a439d1f5d4d45d17110f9
      d565529d
    • Tom Finegan's avatar
      Add goma distributed compiler support to CMake build. · f67fd8ab
      Tom Finegan authored
      Change-Id: I79f908264d0f5562931e757db36410410f3a03e3
      f67fd8ab
    • Urvang Joshi's avatar
      tx64x64: Use C version for DCT/IDCT transform. · 900643be
      Urvang Joshi authored
      The SSE4 function does not support 64x64 size, and was triggering an
      assertion failure lowbitdepth is disabled.
      
      BUG=aomedia:672
      
      Change-Id: Id14e76b5c180a211a84c2e933b07e8acf72dddbc
      900643be
    • Steinar Midtskogen's avatar
      Add experiment CONFIG_CDEF_SINGLEPASS: Make CDEF single pass · 5978212b
      Steinar Midtskogen authored
      Low latency, cpu-used=0:
         PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      -0.3162 | -0.6719 | -0.6535 |   0.0089 | -0.3890 | -0.1515 |    -0.6682
      
      High latency, cpu-used=0:
         PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      -0.0293 | -0.3556 | -0.5505 |   0.0684 | -0.0862 |  0.0513 |    -0.2765
      
      Low latency, cpu-used=4:
         PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      -0.2248 | -0.7764 | -0.6630 |  -0.2109 | -0.3240 | -0.2532 |    -0.6980
      
      High latency, cpu-used=4:
         PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      -0.1118 | -0.5841 | -0.7406 |  -0.0463 | -0.2442 | -0.1064 |    -0.4187
      
      Change-Id: I9ca8399c8f45489541a66f535fb3d771eb1d59ab
      5978212b
    • Tom Finegan's avatar
      Sync CMake behavior with configure for CONFIG_WARPED_MOTION. · 660064a9
      Tom Finegan authored
      Disable CONFIG_NCOBMC and CONFIG_NCOBMC_ADAPT_WEIGHT when
      CONFIG_WARPED_MOTION is enabled.
      
      BUG=aomedia:683
      
      Change-Id: Id676daaef89b6364579707ecd16826715b641ac2
      660064a9
    • Tom Finegan's avatar
      Add util function for CMake config changes. · 9bc86c2b
      Tom Finegan authored
      - Add change_config_and_warn(), which basically does
        what it says.
      - Fixed some indent issues.
      - Added doc comment for create_dummy_source_file().
      
      Change-Id: I748eec7ff63bd43af8c7a91be1e734b28f7d43d0
      9bc86c2b
    • Sarah Parker's avatar
      Fix inter path for mrc-tx · de6f072e
      Sarah Parker authored
      A speed feature was causing the rdloop to skip trying
      MRC_DCT. I've disabled that speed feature when mrc-tx
      is enabled and MRC_DCT is allowed for inter blocks.
      
      Change-Id: I0affa5f26465539414b2957f8ff983f718863ef1
      de6f072e
  6. 10 Aug, 2017 1 commit
    • Yunqing Wang's avatar
      Adjust the sample selection in Warped Motion · 9a7c660e
      Yunqing Wang authored
      This CL follows the original one"Sample selection in warped motion", and
      aims to reduce the number of samples gathered. We only search 1 above row
      and 1 left column instead of 1/2 bsize range in each direction. The gain
      is a little less, but not much.
      
      Borg test result:
                   avg_psnr ovr_psnr ssim
      cam_lowres:  -0.225   -0.228  -0.231
      lowres:      -0.081   -0.075  -0.114
      
      The changes are wrapped in WARPED_MOTION_SORT_SAMPLES macro.
      
      Change-Id: Ifb499c80470b2ffe7a40f68fc401589faada7730
      9a7c660e