1. 07 Sep, 2017 3 commits
    • Debargha Mukherjee's avatar
      Reduce line buffer size for Wiener filter. · 22bbe4cc
      Debargha Mukherjee authored
      This patch forces the vertical filtering for the top and bottom
      rows of a processing unit for the Wiener filter to be 5-tap.
      The 5-taps are derived from the primary 7-tap fitler by forcing
      the taps at the end to be zero, and absorbing their weights into
      the other taps to maintain normalization.
      This will effectively reduce the line buffer size for luma Wiener
      filter to 4 (from 6).
      
      Change-Id: I5e21b58369777eabf553a8987387d112f98a5598
      22bbe4cc
    • David Barker's avatar
      Fix an edge case in tile group decoding · 1a191125
      David Barker authored
      As of patch https://aomedia-review.googlesource.com/c/20220 ,
      it is no longer always the case that tile_rows == (1 << log2_tile_rows)
      and tile_cols == (1 << log2_tile_cols). This exposed an inconsistency
      in the tile-group decoding:
      
      When reading the first tile group in a frame, we read
      (log2_tile_rows + log2_tile_cols) bits each for the tile group
      start and length, but when reading later tile groups we read
      get_msb(tile_rows * tile_cols) bits. But now there are edge cases
      where those values differ! Since the encoder always uses
      (log2_tile_rows + log2_tile_cols) bits, this leads to mis-parsing
      the bitstream.
      
      Fix this by moving the decode logic to one function, which always
      reads (log2_tile_rows + log2_tile_cols) bits. As a bonus, this gives
      us one place to check other invariants, eg. that tile groups can't
      run off the end of the frame.
      
      Change-Id: I83b24314526b6055300b70b0f1cdce038e6b23dc
      1a191125
    • Yaowu Xu's avatar
      Prevent division-by-zero · cc550634
      Yaowu Xu authored
      Change-Id: Id606669875ef1dcb163ff7dec619dae6110d9047
      cc550634
  2. 06 Sep, 2017 20 commits
    • Sarah Parker's avatar
      Remove global motion from compressed header · 3e579a60
      Sarah Parker authored
      This requires making a temporary copy of the functions in
      binary_codes_writer/reader to take in the aom_write_bit_buffer type.
      
      Change-Id: Idb60b29cff69b45224535c6e6a4079a34a2c6871
      3e579a60
    • Wei-Ting Lin's avatar
      Fix a bug forcing encoder to transmit mbmi info first · 49c335f4
      Wei-Ting Lin authored
      Fix the bug forcing encoder/decoder to transmit/decoder all
      mbmi info for a superblock first.
      
      Change-Id: I623217655b043fc90adbcc13e4cf2a4a845084ab
      49c335f4
    • Tom Finegan's avatar
      Build test/hiprec_convolve_test sources only when necessary. · 5d9e44f2
      Tom Finegan authored
      Change-Id: If60c97131bed58ce7c6d3875f9a088df27b9bae4
      5d9e44f2
    • Zoe Liu's avatar
      Refactor defining the GF group in first pass · f271a950
      Zoe Liu authored
      In the old code, the function of allocate_gf_group_bits() in
      firstpass.c handles both GF group structure design as well as the
      corresponding bit allocation for each coded frame. This CL separates
      the two functionalities.
      
      It has been verified that no coding performance has been incurred by
      this CL.
      
      Change-Id: I544b4fcdc8cb37ec810373f1f820dbd2e400c39b
      f271a950
    • Yue Chen's avatar
      Update cdf and mode rate per superblock in RDO · a4245511
      Yue Chen authored
      Update cdf after each superblock being finalized, and re-compute
      symbol costs. Affected symbols include prediction parameters and
      tx type.
      BDRate: -0.119% lowres, -0.092% midres
      
      Change-Id: I724900ac04f725910ed7055a18c2f6a139469b52
      a4245511
    • Jingning Han's avatar
      Properly merge the tile context models in lv-map · 7bc599f5
      Jingning Han authored
      Merge the tile context models at the end of frame coding.
      
      Change-Id: I0a71c49c448cfbd71fb0bd15ca7b1f6097c56529
      7bc599f5
    • Jingning Han's avatar
      Fix lv-map tile independence unit test · 41c7f448
      Jingning Han authored
      BUG=aomedia:719
      
      Change-Id: Id47c2c68cb61e142ce62fee5e97f7c474b3dc273
      41c7f448
    • Wei-Ting Lin's avatar
      ncobmc-adapt-weight: remove config constraint · 14cca44c
      Wei-Ting Lin authored
      Change-Id: Iff1a7e35c439f0baa7240eef75fcb5da46d06a4c
      14cca44c
    • Wei-Ting Lin's avatar
      Remove motion_mode_wrapper · 20885281
      Wei-Ting Lin authored
      Change-Id: I3de1c933ee0fa90e9c0d52e6cbe4bc8bf5482a73
      20885281
    • Wei-Ting Lin's avatar
      ncobmc-adapt-weight: refactoring the mode selection function · 3122b7d5
      Wei-Ting Lin authored
      Change-Id: I7393596d98f11aa53ba4b9e329386b5168b3e086
      3122b7d5
    • Tom Finegan's avatar
      Explicitly support user supplied flags in the CMake build. · c8593981
      Tom Finegan authored
      Add AOM_EXTRA_<TYPE>_FLAGS variables. Currently AS, C, CXX, and
      LINKER are the available type values. These variables are added
      to argument strings for each type as the last step in generation
      to ensure that user flags have precedence over flags added by
      the AOM build itself.
      
      Change-Id: I8e01682ee6c7dad2253e01c446a5ced7d06596c7
      c8593981
    • Tom Finegan's avatar
      Make CMake flag testing and propagation multi-config generator aware. · 282e9f25
      Tom Finegan authored
      BUG=aomedia:659,aomedia:695,aomedia:705,aomedia:706
      
      Change-Id: Iba60166370362599f3f4ef7959a6304bf079857d
      282e9f25
    • Yaowu Xu's avatar
      Silent compiler warning of unused variable · 069cc313
      Yaowu Xu authored
      Change-Id: I1b921e79484e78a272c4f62e30cb85631a65ac25
      069cc313
    • David Barker's avatar
      Adjust chroma position in warp filter · a60dc9d6
      David Barker authored
      When using chroma subsampling, the warp filter currently behaves
      strangely when projecting chroma pixels, especially when the
      subsamplings are not equal along the x and y axes.
      
      For example, when subsampling_x = 1 and subsampling_y = 0, we
      calculate the destination coordinates (dx, dy) from the source
      coordinates (sx, sy) as:
      dx = project(2*sx+0.5, 2*sy+0.5)/2 - 0.5
      dy = project(sx, sy)
      where project() applies the affine warp model.
      
      This patch changes to a simpler and more consistent model,
      where we:
      * Project the chroma sample into luma coordinates, taking
        the chroma sample to be co-located with the top-left luma
        sample in its (2x2, or 2x1, or 1x2) subsampling block
        (this is done for simplicity; we don't expect the exact
         position to make much difference to the output quality)
      * Apply the transformation in luma coordinates
      * Project the resulting luma sample back into chroma coordinates
      
      Change to software speed is in the noise, but this approach
      should be simpler in hardware, and should slightly improve
      quality for 4:2:2 and 4:4:0 videos.
      
      Change-Id: Idd455fdd3897594ca7d4edff5b85b78961d1638d
      a60dc9d6
    • Rupert Swarbrick's avatar
      Round up subsampled frame size in av1_loop_restoration_corners_in_sb · 7380b25e
      Rupert Swarbrick authored
      The previous code converted a frame_w (say) of 1 to zero for a plane
      where subsampling was enabled, causing a division by zero in
      av1_get_rest_ntiles. This doesn't match the spec, which says
      subsampling rounds up.
      
      The patch adds the rounding, and also adds an assertion to
      av1_get_rest_ntiles to help diagnose any other broken callsites.
      
      Change-Id: Ia6c249fa935c3a16d122ba6e7b450fe99f412fde
      7380b25e
    • Debargha Mukherjee's avatar
      Make loop-restoration use 64x64 processing units · 7a5587a8
      Debargha Mukherjee authored
      Changes loop-restoration to use processing unit size that is
      64x64 for luma; for chroma the processing unit is coupled to
      64x64 support region for luma.
      Thus for chroma the processing unit size is 32x32 for 4:2:0,
      32x64 for 4:2:2 and 64x64 for 4:4:4, etc.
      
      While the Wiener filter output should not change with this patch,
      the sgr filter will change since the boundary pixel handling in
      sgr is internal within the filter.
      
      Change-Id: I65a9e2df88927a19445420ce400acb1fcf7afa93
      7a5587a8
    • Cheng Chen's avatar
      Make search filter level function static · 1545bdb3
      Cheng Chen authored
      This is a legacy function but not used outside of the file.
      Make it static.
      
      Change-Id: I1d32c26aaf243202a7fa72056f5e74cf25bbb62a
      1545bdb3
    • Zoe Liu's avatar
      Remove hard-coded value for MAX_EXT_ARFS · 43486e7b
      Zoe Liu authored
      Change-Id: If44394e363cc443e46c31d91c8e03a85d91b1a92
      43486e7b
    • Yushin Cho's avatar
      Add missed change for commit 55104335 · 3d429dc3
      Yushin Cho authored
      One of the changed files has been mistakenly missed
      for the commit 55104335
      
      https://aomedia-review.googlesource.com/#/c/aom/+/18261/
      
      Change-Id: Ie47f882a25e650bb4d74d5675f2306adc9e654a7
      3d429dc3
    • Yushin Cho's avatar
      Fix compile warnings for av1_dist_8x8() · fcddadf3
      Yushin Cho authored
      Change-Id: I3f3df7acc79f770e42fe65b52f383ee8dfe2702a
      fcddadf3
  3. 05 Sep, 2017 16 commits
  4. 04 Sep, 2017 1 commit