1. 12 Nov, 2012 1 commit
    • Paul Wilkins's avatar
      New inter mode context · 2669f42b
      Paul Wilkins authored
      This change is a fix / extension of the newbestrefmv
      experiment. As such it is presented without IFDEF.
      
      The change creates a new context for coding inter modes
      in vp9_find_mv_refs(). This replaces the context that
      was previously calculated in vp9_find_near_mvs().
      The new context is unoptimized and not necessarily
      any better at this stage (results pending), but eliminates
      the need for a legacy call to vp9_find_near_mvs().
      Based on numbers from Scott, this could help decode
      speed by several %.
      
      In a later patch I will add support for forward update of
      context (assuming this helps) and refine the context as
      necessary.
      
      Change-Id: I1cd991b82c8df86cc02237a34185e6d67510698a
      2669f42b
  2. 10 Nov, 2012 1 commit
    • Deb Mukherjee's avatar
      New b-intra mode where direction is contextual · d01357bb
      Deb Mukherjee authored
      Preliminary patch on a new 4x4 intra mode B_CONTEXT_PRED where the
      dominant direction from the context is used to encode. Various decoder
      changes are needed to support decoding of B_CONTEXT_PRED in conjunction
      with hybrid transforms since the scan order and tokenization depends on
      the actual direction of prediction obtained from the context. Currently
      the traditional directional modes are used in conjunction with the
      B_CONTEXT_PRED, which also seems to provide the best results.
      
      The gains are small - in the 0.1% range.
      
      Change-Id: I5a7ea80b5218f42a9c0dfb42d3f79a68c7f0cdc2
      d01357bb
  3. 08 Nov, 2012 1 commit
    • Ronald S. Bultje's avatar
      Implement tx_select for superblock encoding. · 1d4fbeb3
      Ronald S. Bultje authored
      Also split superblock handling code out of decode_macroblock() into
      a new function decode_superblock(), for easier readability.
      
      Derf +0.05%, HD +0.2%, STDHD +0.1%. We can likely get further gains
      by allowing to select mb_skip_coeff for a subset of the complete SB
      or something along those lines, because although this change allows
      coding smaller transforms for bigger predictors, it increases the
      overhead of coding EOBs to skip the parts where the residual is
      near-zero, and thus the overall gain is not as high as we'd expect.
      
      Change-Id: I552ce1286487267f504e3090b683e15515791efa
      1d4fbeb3
  4. 07 Nov, 2012 1 commit
  5. 06 Nov, 2012 1 commit
    • Yaowu Xu's avatar
      silent a lot of MSVC compiler warnings · 8a336b0d
      Yaowu Xu authored
      there are still a couple type of warning left, which are related to
      double constants assigned to float type. As those would be addressed
      by the conversion of transforms into integer version. This commit
      has left those un-dealt with.
      
      Change-Id: I48fd9b489c0c27ad6b543f4177423419f929f2bb
      8a336b0d
  6. 01 Nov, 2012 2 commits
  7. 31 Oct, 2012 4 commits
  8. 30 Oct, 2012 2 commits
  9. 29 Oct, 2012 1 commit
    • Paul Wilkins's avatar
      Name space clean up. · a99a2c36
      Paul Wilkins authored
      Preparation for project restructuring.
      Added vp9_ prefix on some function names that have global scope.
      Added static declaration on some that dont.
      
      Change-Id: If072f78b4300e8c17cfeed82c5d17b59946dcc5e
      a99a2c36
  10. 26 Oct, 2012 1 commit
    • Paul Wilkins's avatar
      Explicit MV reference experiment. · ba30e774
      Paul Wilkins authored
      Coding and costing of mv reference signal.
      
      Issues in updating MV ref with COMPANDED_MVREF_THRESH
      to be resolved. Ideally the MV precision should be defined based
      on absolute MV magnitude not as now the MV ref magnitude.
      
      Update to mv counts moved into bitstream.c because otherwise
      if the motion reference is changed at the last minute the encoder
      and decoder get out of step in terms of the counts used to update
      entropy probs.
      
      Code working on a few test clips but no results yet re benefit vs
      signaling cost and no tuning of red loop to test lower cost alternatives
      based on the available reference values.
      
      Patch 3. Added check to make sure we don't pick a reference
      that would give rise to an uncodeable / out of range residual.
      
      Patch 6-7: Attempt to rebase. OK to submit but best to leave flag off for now.
      
      Patch 9. Remove print no longer needed.
      
      Change-Id: I1938c2ffe41afe6d3cf6ccc0cb2c5d404809a712
      ba30e774
  11. 23 Oct, 2012 1 commit
    • Deb Mukherjee's avatar
      Merging in the Switchable interp experiment · 53731197
      Deb Mukherjee authored
      There is a macro DEFAULT_INTERP_FILTER defined in encoder/onyx_if.c that
      is set as EIGHTTAP for now - so SWITCHABLE is not really used. Ideally,
      this should be SWITCHABLE but that would make the encoder quite a bit slower.
      We will change the default filter to SWITCHABLE once we find a faster way to
      search for switchable filters.
      
      Change-Id: Iee91832cdc07e6e14108d9b543130fdd12fc9874
      53731197
  12. 22 Oct, 2012 3 commits
    • Deb Mukherjee's avatar
      Merging in the TX_SELECT experiment · 04d62a98
      Deb Mukherjee authored
      Change-Id: I0d306b0062be59bc785b65882691c956c8b5e7c8
      04d62a98
    • Deb Mukherjee's avatar
      Merge of the newmventropy experiment · 78808ad9
      Deb Mukherjee authored
      Removes the old mv encoding code.
      
      Change-Id: I1026d48cc5ac15ccb776f98463e929254c3dc7da
      78808ad9
    • Ronald S. Bultje's avatar
      8x8 transform support in splitmv. · 84ea002e
      Ronald S. Bultje authored
      For splitmv, where partitioning is 8x16, 16x8 or 8x8, this patch
      uses the 8x8 transform (instead of the 4x4) if txfm_mode is
      ALLOW_8X8 or ALLOW_16X16. For TX_MODE_SELECT, splitmv can indicate
      which of the 2 transform sizes (4x4 or 8x8) it wants to use.
      
      Gains (with hybridtx4x4/8x8/16x16 and tx_select experiments
      enabled) on derf: +0.9%, HD: +0.4%, STD/HD: +0.8% (SSIM or overall
      PSNR, both metrics show similar improvements).
      
      Change-Id: Ide954b000b415548ed92a7ac78e24f36e60fcf06
      84ea002e
  13. 19 Oct, 2012 2 commits
    • John Koleszar's avatar
      Remove bc, bc2 from pbi,cpi,xd · e9fd1eac
      John Koleszar authored
      Pass the bool coder to be used explicitly. This avoids cases where two
      different bool coders can be addressed from the same function. Also be
      more consistent with bool coder variable naming, start to standardize
      on 'bc'.
      
      Change-Id: I1c95e2fdbe24ebe8c0f84924daa1728e3b054a31
      e9fd1eac
    • Deb Mukherjee's avatar
      Some cleanups and fixes. · f3208f36
      Deb Mukherjee authored
      Separates the logic on transform type selection previously spread out
      over a number of files into a separate function. Currently the tx_type
      field in b_mode_info is not used, but still left in there to eventually
      use for signaling the transform type in the bitstream.
      
      Also, now for tx_type = DCT_DCT, the regular integer DCT is used, as
      opposed to the floating point DCT used in conjuction with hybrid
      transform.
      
      Results change somewhat due to the transform change, but are within
      reasonable limits. The hd/std-hd sets are slightly up, while derf/yt
      are slightly down.
      
      Change-Id: I5776840c2239ca2da31ca6cfd7fd1148dc5f9e0f
      f3208f36
  14. 17 Oct, 2012 3 commits
    • John Koleszar's avatar
      cosmetic: fix '= & ' construct · 3883dab0
      John Koleszar authored
      remove useless space after address-of operator.
      
      Change-Id: I1fb9e82e8d6cf87558fbd454fb5c0f87599ca2ab
      3883dab0
    • John Koleszar's avatar
      Move remaining per-frame data into partition 0 · 47a2154c
      John Koleszar authored
      This commit moves a bit of data that ended up packed with the
      modes/mv/residual partition during the change to interleaved encoding
      into partition 0 where it belongs.
      
      Change-Id: Ic711a378c58d9d6a17254384f492c213a15bad92
      47a2154c
    • John Koleszar's avatar
      Interleave modes/residual per macroblock · 6ef5a005
      John Koleszar authored
      Packs the bitstream with each mb's residual following its mode/mv
      information.
      
      TODO: There are still a few fields that should be packed into partition
      0 but are included in partition 1, due to them being serialized from
      write_kfmodes/pack_inter_mode_mvs, which execute after the first
      partition is finalized. These need to be separated out into a separate
      function, similar to mb_mode_mv_init() in decodemv.c.
      
      Change-Id: I43a46c363601ab36954d07ebe498760e1e2e3af4
      6ef5a005
  15. 16 Oct, 2012 1 commit
    • John Koleszar's avatar
      Force interleaved decoding · c073e5ca
      John Koleszar authored
      Rather than decoding all modes/mvs separately, decode them per MB. This
      forces the mode which was already used form the CONFIG_NEWBESTREFMV and
      CONFIG_SUPERBLOCKS experiments, and is a precursor to changing to
      interleaved encoding.
      
      Change-Id: If19ee74ac8a987846d1cd0cf2b2e02a82f1a43ad
      c073e5ca
  16. 11 Oct, 2012 2 commits
  17. 09 Oct, 2012 1 commit
    • Ronald S. Bultje's avatar
      Selectable transform size try 2. · 9ca3c8b2
      Ronald S. Bultje authored
      Results: derf (vanilla or +hybridtx) +0.2% and (+hybrid16x16
      or +tx16x16) +0.7%-0.8%; HD (vanilla or +hybridtx) +0.1-0.2%
      and (+hybrid16x16 or +tx16x16) +1.4%, STD/HD (vanilla or +hybridtx)
      about even, and (+hybrid16x16 or +tx16x16) +0.8-1.0%.
      
      Change-Id: I03899e2f7a64e725a863f32e55366035ba77aa62
      9ca3c8b2
  18. 21 Sep, 2012 1 commit
  19. 13 Sep, 2012 1 commit
  20. 12 Sep, 2012 1 commit
    • Deb Mukherjee's avatar
      Adds feature for companded MV encoding · 2b26cf17
      Deb Mukherjee authored
      The high-precision (1/8) pel bit is turned off if the reference
      MV is larger than a threshold. The motivation for this patch is
      the intuition that if motion is likely large (as indicated by
      the reference), there is likley to be more motion blur, and as
      a result 1/8 pel precision would be wasteful both in rd sense
      as well as computationally.
      
      The feature is incorporated as part of the newmventropy experiment.
      There is a modest RD improvement with the patch. Overall the
      results with the newmventropy experiment with the threshold being
      16 integer pels are:
      
      derf: +0.279%
      std-hd: +0.617%
      hd: +1.299%
      yt: +0.822%
      
      With threshold 8 integer pels are:
      
      derf: +0.295%
      std-hd: +0.623%
      hd: +1.365%
      yt: +0.847%
      
      Patch: rebased
      Patch: rebase fixes
      
      Change-Id: I4ed14600df3c457944e6541ed407cb6e91fe428b
      2b26cf17
  21. 11 Sep, 2012 1 commit
  22. 07 Sep, 2012 2 commits
    • Paul Wilkins's avatar
      Partial merge of NEWBESTREFMV and NEW_MVREF. · 778ec421
      Paul Wilkins authored
      This commit merges those parts of the CONFIG_NEW_MVREF
      that specifically relate to choosing a better set of candidate
      MV references into the NEWBESTREFMV experiment.
      
      CONFIG_NEW_MVREF will then be used for changes relating
      to the explicit coding of a cost optimized MV reference in the
      bitstream as part of MV coding.
      
      Change-Id: Ied982c0ad72093eab29e38b8cd74d5c3d7458b10
      778ec421
    • Paul Wilkins's avatar
      MV reference changes · 38e1c791
      Paul Wilkins authored
      Extend experiment to use both vectors from MBs
      coded using compound prediction as candidates.
      
      In final sort only consider best 4 candidates
      for now but make sure 0,0 is always one of them.
      
      Other minor changes to new MV reference code.
      Pass in Mv list to vp8_find_best_ref_mvs().
      
      Change-Id: Ib96220c33c6b80bd1d5e0fbe8b68121be7997095
      38e1c791
  23. 06 Sep, 2012 1 commit
    • Deb Mukherjee's avatar
      New motion vector entropy coding · 00f9eb65
      Deb Mukherjee authored
      Adds a new experiment with redesigned/refactored motion vector entropy
      coding. The patch also takes a first step towards separating the
      integer and fractional pel components of a MV. However the fractional
      pel encoding still depends on the integer pel part and so they are
      not fully independent. Further experiments are in progress to see
      how much they can be decoupled without affecting performance.
      All components including entropy coding/decoding, costing for MV
      search, forward updates and backward updates to probability tables,
      have been implemented.
      
      Results so far:
      derf: +0.19%
      std-hd: +0.28%
      yt: +0.80%
      hd: +1.15%
      
      Patch: Simplifies the fractional pel models:
      derf: +0.284%
      std-hd: +0.289%
      yt: +0.849%
      hd: +1.254%
      
      Patch: Some changes in the models, rebased.
      derf: +0.330%
      std-hd: +0.306%
      yt: +0.816%
      hd: +1.225%
      
      Change-Id: I646b3c48f3587f4cc909639b78c3798da6402678
      00f9eb65
  24. 28 Aug, 2012 1 commit
  25. 24 Aug, 2012 1 commit
    • Paul Wilkins's avatar
      New Motion Reference Search · 2d60bee1
      Paul Wilkins authored
      Alternative strategy for finding a list of candidate motion
      vectors to use as reference values in mv coding and as
      nearest and near.
      
      Sort by sad in vp8_find_best_ref_mvs() rather than just
      pick the best. Allow 0,0 as a best ref option but not a
      nearest or near unless there are no alternatives.
      
      Encode/Decode verified on at least some clips.
      
      Some commented out experimental and stats code still in place.
      
      Gain over existing code averages about 1% on derf (alll metrics)
      with improvement on all clips. Other test results pending.
      
      The entropy coding of the mode (nearest/near etc) still
      depends upon and requires the old "findnear" code so
      this needs looking at and may provide room for further gains.
      
      Change-Id: I871d7cba1d1c379c4bad9bcccce1fb19c46b8247
      2d60bee1
  26. 20 Aug, 2012 1 commit
    • Ronald S. Bultje's avatar
      Superblock coding. · 5d4cffb3
      Ronald S. Bultje authored
      This commit adds a pick_sb_mode() function which selects the best 32x32
      superblock coding mode. Then it selects the best per-MB modes, compares
      the two and encodes that in the bitstream.
      
      The bitstream coding is rather simplistic right now. At the SB level,
      we code a bit to indicate whether this block uses SB-coding (32x32
      prediction) or MB-coding (anything else), and then we follow with the
      actual modes. This could and should be modified in the future, but is
      omitted from this commit because it will likely involve reorganizing
      much more code rather than just adding SB coding, so it's better to let
      that be judged on its own merits.
      
      Gains on derf: about even, YT/HD: +0.75%, STD/HD: +1.5%.
      
      Change-Id: Iae313a7cbd8f75b3c66d04a68b991cb096eaaba6
      5d4cffb3
  27. 15 Aug, 2012 1 commit
    • Paul Wilkins's avatar
      Code clean up. · 77dc5c65
      Paul Wilkins authored
      Further cases of inconsistent naming convention.
      
      Change-Id: Id3411ecec6f01a4c889268a00f0c9fd5a92ea143
      77dc5c65
  28. 14 Aug, 2012 1 commit
    • Yaowu Xu's avatar
      Changed to use reference mv as nearest mv · e52e8b70
      Yaowu Xu authored
      The reference motion vector selected by surrounding pixels that has
      the best matching score is used as nearest motion vector.
      
      The change has shown consistent gain on all test sets, compression
      gains range from .2% to .6%. The variation is largely dependent on
      various other experiments on or off.
      
      Change-Id: I5552e1c2f6fc57c3e8818a5ee41ffda89af05e75
      e52e8b70