1. 01 Nov, 2017 13 commits
    • Sarah Parker's avatar
      Rename ZEROMV to GLOBALMV · 2b9ec2ea
      Sarah Parker authored
      This name better reflects the functionality of the mode.
      
      Change-Id: Idc2372e7c7b226f70f63fa4f272a88cb4d857089
      2b9ec2ea
    • Yaowu Xu's avatar
      Correct token allocation size for tiles · e39b3b8b
      Yaowu Xu authored
      With --enable-ext-partition, it is possible to have superblock size at
      both 64x64 and 128x128. But MAX_SB_SIZE_LOG2 is defined to be 7, i.e.
      128x128 size. In get_token_alloc(), the token count for a tile or a
      frame is always computed based on "tokens/superblock * number of
      superblocks", so it should use the actual superblock size, instead of
      128x128.
      
      The segfault in #988 is a result when every tile is defined at one
      single superblock of 64x64, the token size computation for each tile
      was assuming it is 128x128, resulting 4x overestimate of the token
      count for every tile. This caused the pointer for many tiles to go
      beyond the allocated token arrary, which is correctly allocated at
      frame level.
      
      BUG=aomedia:988
      
      Change-Id: I2da21f181446ad7117ce3269f01a43950c379028
      e39b3b8b
    • Debargha Mukherjee's avatar
      Add speed feature to reduce tx size search depth · edc7346f
      Debargha Mukherjee authored
      The speed feature simply restricts the number of depths
      searched. Currently it is turned on by default for speeds>=1.
      The coding efficiency impact (tested on lowres 30 frames) seems
      to be ~0.15% and the speedup is in the order of 15%.
      
      Change-Id: I514832bd7df937292875f73d9c9026e49ac576f2
      edc7346f
    • Linfeng Zhang's avatar
      Remove nz/eob related uncalled functions · fa97083c
      Linfeng Zhang authored
      Change-Id: I12471d18544a9634c28ed139b7211c9af0762927
      fa97083c
    • Zoe Liu's avatar
      Remove redundant macro USE_UNI_COMP_REFS · c6b17d82
      Zoe Liu authored
      USE_UNI_COMP_REFS is always true when ext-comp-refs is enabled and is
      always false otherwise.
      
      Change-Id: Ic6061a4ab88a2ebfeb11f178872ab13909060c0b
      c6b17d82
    • Soo-Chul Han's avatar
      remove writing/parsing superframe index with new HLS · 38427e8e
      Soo-Chul Han authored
      * add build-time option to add/read 4-byte size of every OBU
      * update to R19 by adding forbidden bit to obu header
      * add metadata OBU decoding
      
      Change-Id: I525264f53a8666b7bc29493fb29ae661841eba50
      38427e8e
    • Pavel Frolov's avatar
      Fix delta_qindex signalling · bfa2b8ce
      Pavel Frolov authored
      BUG=aomedia:992
      
      Change-Id: Ibac542608d9abd669d0e8cf871960b2cf0a6da6a
      bfa2b8ce
    • Pavel Frolov's avatar
      Signal sb_size for intra-only frames. · ef4af297
      Pavel Frolov authored
      BUG=aomedia:938
      
      Change-Id: Ic730ac1136e915d193f3b48f7788baa093e7ff0f
      ef4af297
    • Sarah Parker's avatar
      Use tx_size 1 level down for transform type search · 90024e44
      Sarah Parker authored
      This addresses an inconsistency between the set used
      to decode the tx_type in the bitstream and the set used
      for the tx_type search. Previously, the set used to
      read/write the tx_type was based on the smallest tx_size
      in the vartx partitioning, but the search uses a set
      based on the largest possible tx_size. This patch
      changes the tx_type search to use the transform type
      set associated with the tx_size 1 recursive level down from
      the max square tx_size to make the search more consistent
      with the bitstream syntax. If a tx_size is selected for an
      invalid tx_type, DCT_DCT is used for that partition instead.
      
      This patch also adds assertions to all exposed transform
      functions to ensure that no illegal transform type/size
      combinations occur.
      
      This currently gets a 0.1% drop in performance on lowres.
      The drop is due to the reduction of the tx_types available
      for 32x16 and 16x32 transform sizes. Before this patch,
      32x16 and 16x32 transforms were getting assigned a
      set of 12 tx_types, some of which we did not intend to
      support for these sizes.
      
      Change-Id: I44aca4876b261c345623cd04ad6235bca4532701
      90024e44
    • Yue Chen's avatar
      Remove CONFIG_INTERINTRA · 670b660d
      Yue Chen authored
      Change-Id: Icbedc16b01adf9b48f0f357ec89143462865d54e
      670b660d
    • Yue Chen's avatar
      Guard the limits in for-loops for setting inter_tx_size · c5252a69
      Yue Chen authored
      Always at least set the first row and the first col, otherwise will
      have unattended entries if we enable 4x16 or 16x4 txs.
      
      Change-Id: I403ea3694ccf8c7ee1584f55bbc3e9b8355d9272
      c5252a69
    • Arild Fuldseth (arilfuld)'s avatar
      Implement approved version of FRAME_SIZE experiment · 7193f020
      Arild Fuldseth (arilfuld) authored
      Change-Id: I5b7bb9983e1c613321704a579d459925bd6b9b2b
      7193f020
    • Jingning Han's avatar
      Re-design base level context modeling · e775b8bc
      Jingning Han authored
      Reduce the context model size required to code the base level
      syntax values from 42 to 32 per transform size.
      
      Change-Id: I08485fdb563bc5c3323b0e147d69b47c286b9bb5
      e775b8bc
  2. 31 Oct, 2017 5 commits
    • Sebastien Alaiwan's avatar
      Remove COEF_INTERLEAVE experiment · 6d5f2218
      Sebastien Alaiwan authored
      This experiment has been abandonned.
      
      Change-Id: Ifde0a76266af9f8c202c01805410b72d64594b0b
      6d5f2218
    • Sebastien Alaiwan's avatar
      Remove experimental flag of WARPED_MOTION · 1f56b8e3
      Sebastien Alaiwan authored
      This experiment has been adopted, we can simplify the code
      by dropping the associated preprocessor conditionals.
      
      Change-Id: I54fee8a18afaec5333ae852eb6bd9ac0e2550db1
      1f56b8e3
    • Sebastien Alaiwan's avatar
      Simplify flow of control · e4984ffc
      Sebastien Alaiwan authored
      Avoid switch warning regarding fallthrough, add consts.
      
      Change-Id: Ie3a03e60420d962941abc4e144648f29401916b9
      e4984ffc
    • Sebastien Alaiwan's avatar
      Remove experimental flag of MOTION_VAR · 1bc94fcc
      Sebastien Alaiwan authored
      This experiment has been adopted, we can simplify the code
      by dropping the associated preprocessor conditionals.
      
      Change-Id: I2dce80e1e1b2116708b6ba9feeacaacc12af8fc4
      1bc94fcc
    • Debargha Mukherjee's avatar
      Adding a speed feature for tx_size search · 51666866
      Debargha Mukherjee authored
      This patch factors out a function that computes the rd cost for
      a given transform type given the transform partition already
      computed. This is then used to develop a speed feature where the
      transform size search disables trellis optimization but once the
      transform sizes are decided, a final search is conducted with
      optimization turned back on.
      This patch does not change anything in speed 0 yet.
      
      Change-Id: I30acfc5e2dd353d711e5f4260d5b344847b03ade
      51666866
  3. 30 Oct, 2017 8 commits
    • Jingning Han's avatar
      Reset current_video_frame in key frame · d8a15a66
      Jingning Han authored
      Reset the frame index tracking to 0 when key frame is inserted in
      the frame sequence.
      
      Change-Id: Ib80313004fc000e7127a9797af5afe9029c0cb45
      d8a15a66
    • Debargha Mukherjee's avatar
      Remove compound-segment/wedge config flags · 371968cd
      Debargha Mukherjee authored
      Change-Id: I39cfbb135add0553cadf64481b13786831fbdddd
      371968cd
    • Urvang Joshi's avatar
      Remove an obsolete comment · 78c229b4
      Urvang Joshi authored
      Change-Id: I9b1351263286041d718a1b54735c17aeb5f8a0a7
      78c229b4
    • Jingning Han's avatar
      Speed up inter frame rate-distortion optimization · cf842ad2
      Jingning Han authored
      The frame marker system supports one to map the reference frame
      index into the natural order. It allows direct checking on the
      efficacy of the reference frames given their relative locations
      with respect to the current coding frame.
      
      This commit uses such property to filter out reference frames
      less likely to contribute coding gains from the rate-distortion
      optimization process. For example, it takes out the check on
      last2 / 3 frames, when their actual location is further away
      from the golden frame.
      
      The AWCY results show 0.6% performance regression. The encoding
      speed gets doubled.
      
      To use the speed up, one needs to turn on frame-marker experiment
      before we turn it on by default, and enable selective_ref_frame
      entry in the speed feature.
      
      Change-Id: Ifb03ed90acd980bbc7ff1c2e17982e21e68d2588
      cf842ad2
    • Sebastien Alaiwan's avatar
      Remove experimental flag of GLOBAL_MOTION · 48795807
      Sebastien Alaiwan authored
      This experiment has been adopted, we can simplify the code
      by dropping the associated preprocessor conditionals.
      
      Change-Id: I9c9d6ef5317798cbf237307a9754fe7e03bdda47
      48795807
    • Luc Trudeau's avatar
      [CFL] Sub8x8 Validation Code Rewrite · c7af36d4
      Luc Trudeau authored
      Sub8x8 Validation code is changed to be more robust. The scope of the
      validation is narrowed to validating that all of the required content in
      the storage buffer was stored between CfL predictions. The early
      termination used in the current mode decision code does not allow to
      validate more than that.
      
      This change does not change encoder output
      
      BUG=aomedia:925
      
      Change-Id: I7f1ed84da5037dcfaaf5da9cf33b4b8d664d2352
      c7af36d4
    • Rupert Swarbrick's avatar
      Stop backward adaptation if EXT_TILE + cm->large_scale_tile · 84b05ac1
      Rupert Swarbrick authored
      Backwards adaptation doesn't really make sense in this context,
      because ext-tile means the decoder might not decode every tile in the
      frame, in which case it can't work out how to adapt probabilities.
      
      It turns out that the tests in the tree were passing when
      SIMPLE_BWD_ADAPT was disabled because (presumably) all of them
      happened to decode every tile, so backward adaptation worked as you'd
      expect. With SIMPLE_BWD_ADAPT, there's some code in get_tile_buffers
      to figure out which is the largest tile. This wasn't mirrored in
      get_ls_tile_buffers, which caused the encoder and decoder to get out
      of sync because they ended up with different CDFs. You also can't
      easily fix things in get_ls_tile_buffers because that code is careful
      not to calculate the size of tiles it doesn't need.
      
      BUG=aomedia:917
      
      Change-Id: Ia926692f86ca1466252108e09da3de590d45f048
      84b05ac1
    • Debargha Mukherjee's avatar
      Remove experimental flag for rect-tx · 11812967
      Debargha Mukherjee authored
      Change-Id: I0cc53a03f07a11a6f7ea0570ff4ee8cf7c18c5aa
      11812967
  4. 28 Oct, 2017 2 commits
    • Jingning Han's avatar
      Extend the eob context model · 35deaa73
      Jingning Han authored
      Account for 1-D/2-D transform kernels for the eob modeling. To
      maintain a smaller context cardinality, set the two 1-D transform
      kernels in the same category. The difference in directions should
      be largely covered by the scan order.
      
      This and the previous CLs on nz_map context modeling together
      improve the compression performance of level-map coefficient coding
      system by 0.4% for lowres.
      
      Change-Id: I8c4f03ca01ce3d248950d04bd1266f445b4227a0
      35deaa73
    • Cheng Chen's avatar
      JNT_COMP: 6. support wedge · bdd6ca81
      Cheng Chen authored
      Support compound_segment and wedge.
      JNT_COMP is a competitor to compound_segment and wedge. They are
      mutually exclusive.
      
      Change-Id: Id93c36de44a69008182424f40325e42e699bedcd
      bdd6ca81
  5. 27 Oct, 2017 11 commits
    • Joe Young's avatar
      Ext-intra modification/tuning · 3ca43bf0
      Joe Young authored
      For ext-intra direcation intra modes:
      
      1. Use neighbor block modes to modify edge filtering strength
         Coding gain (lowres/midres/hdres):
           (8 keyframes)
           PSNR: -0.19 -0.22 -0.10
           SSIM: -0.29 -0.27 -0.13
      
      2. Use context-based cdf to code angle_delta syntax
           (8 keyframes)
           PSNR: -0.20 -0.24 -0.27
           SSIM: -0.29 -0.33 -0.37
      
      3. Filter corner sample:
           (8 keyframes)
           PSNR: -0.01 -0.02 -0.05
           SSIM: -0.03 -0.04 -0.05
      
      Combined Bd-rate improvement for 8 keyframes
           PSNR: -0.40 -0.47 -0.40
           SSIM: -0.57 -0.60 -0.51
      
      Change-Id: Id47ac17b6bf91cd810b70cacfc5b457341f417f3
      3ca43bf0
    • Urvang Joshi's avatar
      Superres: Fix writing/reading of denominator. · 8301018d
      Urvang Joshi authored
      Range is 9 to 16, and not 8 to 15.
      
      BUG=aomedia:972
      
      Change-Id: I7de6cea16a6377d9cd3b2af73efc841b42dad1fa
      8301018d
    • Rupert Swarbrick's avatar
      Fix ext-tile encoding when not using compressed header · 53685900
      Rupert Swarbrick authored
      The compressed header size is now sometimes not signalled and the
      encoder code hadn't been updated to match.
      
      Note: This mistake caused the failing test tracked in bug 917 to fail,
            but fixing it doesn't fix the test: the decoder now staggers on
            a little further before getting out of sync.
      
      BUG=aomedia:917
      
      Change-Id: Ic0de99ede778844c4dbdd34dba3fba9c1fa2d95f
      53685900
    • Rupert Swarbrick's avatar
      Reset restoration info at start of large_scale_tiles too · 7546b304
      Rupert Swarbrick authored
      Since commit 6c545216, loop restoration coefficients are written inside
      tiles data. Since the Wiener and Sgrproj coefficients are
      delta-encoded (and tiles must be decoded independently) this means we
      must call set_default_wiener and set_default_sgrproj at the start of
      encoding and decoding each tile. That patch missed doing so when
      encoding large scale tiles (part of the EXT_TILE experiment). This
      adds the missing lines.
      
      Note: This caused AV1/AVxEncoderThreadLSTest.EncoderResultTest/3 to
            fail with --enable-ext-tile, which is tracked in bug
            917. Unfortunately, there's something else going wrong that
            means the test is still failing: I'll address that in a separate
            patch.
      
      BUG=aomedia:917
      
      Change-Id: I5bd8e9d7f7a2abd60779abf170185a1c5b090474
      7546b304
    • Hui Su's avatar
      Resolve an issue between palette and delta-q · efb755cd
      Hui Su authored
      Avoid resetting current_q_index.
      
      Change-Id: I76d27605b6a8c0cd6b1032e24ea5ca8561115e5a
      efb755cd
    • Cheng Chen's avatar
      Clamp loop filter levels · aff479fa
      Cheng Chen authored
      Clamp in range [-MAX_LOOP_FILTER, MAX_LOOP_FILTER], for experiment LOOPFILTER_LEVELS.
      
      BUG=aomedia:970
      
      Change-Id: Ica52242e969dcea49565f118155de5eef32a4cc4
      aff479fa
    • Cheng Chen's avatar
      JNT_COMP: 5. Support compound_segment · 3392c436
      Cheng Chen authored
      Let jnt_comp work with compound_segment. When frame distance weights
      are used, compound_segment blending is turned off. When normal compound
      mode is used, compound_segment blending is searched. The rdcost should
      select between {frame distance weights, normal compound,
      compound_segment blending}.
      
      Change-Id: I162d1d204ba6a5976538357d9dbc71fc5b1aa8d5
      3392c436
    • Cheng Chen's avatar
      JNT_COMP: 4. add context and entropy read/write · 0a7f2f51
      Cheng Chen authored
      Change-Id: I0e6f7ab981e31f7120105515f6204568b6dc82d3
      0a7f2f51
    • Cheng Chen's avatar
      JNT_COMP: 3. rd select the best weight · ca6958c6
      Cheng Chen authored
      Select the best compound_idx in rd.
      The rate/cost for compound_idx and their ctx will be in patch 4.
      
      But there's a bug for now if we don't encode one more time using the
      selected compound_idx. It remains a issue to be solved in the future.
      
      Change-Id: I5e1ba51da2b6ab5bacd8aba752dda43bd2257014
      ca6958c6
    • Rupert Swarbrick's avatar
      Fix build with --enable-obu · 70f0eb33
      Rupert Swarbrick authored
      It seems that the change in commit 28444be6 missed this line (which
      only fails to compile with --enable-debug because it's in an assert)
      
      BUG=aomedia:952
      
      Change-Id: Ibe6200b2928d198c73f3e9c9f0badcbdaffcac49
      70f0eb33
    • RogerZhou's avatar
      Fixed build conflict (amvr,intrabc). · 10a0380a
      RogerZhou authored
      Change-Id: Ibfeb424bf0ebab7bbeb69f6f6df24a4f4924ec97
      10a0380a
  6. 26 Oct, 2017 1 commit
    • Dake He's avatar
      [level map] separate pass to code signs · 43edb760
      Dake He authored
      This commits moves coding of signs in a transform block into its own
      pass. Grouping signs coded in literal mode together may help improve
      throughput.
      
      Change-Id: I999c6eeeb780b188ab9e2c6ea888f9de4dbce893
      43edb760