1. 28 Aug, 2017 5 commits
    • Zoe Liu's avatar
      Enable ext-comp-refs by default. · 3e36247d
      Zoe Liu authored
      Change-Id: I858893147ee3cb369001bc094d8f848476019047
      3e36247d
    • Jingning Han's avatar
      Refactor lv-map coefficient buffers · f5a4d3ba
      Jingning Han authored
      Reduce the encoder memory footprint in lv-map by ~800X.
      
      BUG=aomedia:713
      
      Change-Id: I7aad604cf3186a0d3c6d5b6d1aa9489ac7c36093
      f5a4d3ba
    • Luc Trudeau's avatar
      [CFL] Move store flag to CFL_CTX · fcca37a4
      Luc Trudeau authored
      With recent changes, it is now possible to store the storage
      flag inside the CFL_CTX. This simplifies the implementation
      and will allow reuse in the decoder.
      
      This change does not alter the bitstream.
      
      Change-Id: Ibb8aebdd3d06f8765d40248ece8a038892e87032
      fcca37a4
    • Jingning Han's avatar
      Refactor zero ref mv check · 2484fa05
      Jingning Han authored
      Unify and simplify the logic for both single and compound modes.
      
      Change-Id: If781aac66b47c1a707f4f9a647cb8a3294477a48
      2484fa05
    • Luc Trudeau's avatar
      [CFL] Reorganize Reconstructed Pixel Buffering · 32306c22
      Luc Trudeau authored
      Reworked how the storage flag is set to avoid duplication on the encoder
      side. Reconstructed Luma pixels are stored in encode_superblock in the
      loop that calls av1_encode_intra_block_plane and in the extra call to
      txfm_rd_in_plane after the luma RDO, but prior to the chroma RDO.
      
      This change does not alter the bitsteam.
      
      Change-Id: Ifd8441363ea0733fea3d06129a025940abb2abc9
      32306c22
  2. 26 Aug, 2017 2 commits
  3. 25 Aug, 2017 8 commits
    • Yushin Cho's avatar
      Fix compile error in inc_mvs() · 97dd6ca0
      Yushin Cho authored
      When CONFIG_EXT_INTER is disbaled, an instane of struct nmv_context is
      passed inc_mv_cdf() instead of its pointer type.
      
      Change-Id: I5a51c4065a1493e2e2a544d243907672614752a7
      97dd6ca0
    • Rupert Swarbrick's avatar
      Add support for 16x4 partitions · 6a93b155
      Rupert Swarbrick authored
      When updating default_partition_cdf, this sums the probabilities that
      were divided evenly across the pairs PARTITION_HORZ_A/PARTITION_HORZ_B
      and PARTITION_VERT_A/PARTITION_VERT_B. Those summed probabilities now
      get distributed evenly across the triples you get by adding
      PARTITION_HORZ_4 and PARTITION_VERT_4, respectively.
      
      Rather than implement 2X8/8X2 blocks for now, ss_size_lookup returns
      4X8/8X4 block sizes to use as chroma transform sizes for 4X16/16X4
      blocks.
      
      The changes in setup_pred_plane and set_skip_context are because this
      is presumably the first time we've had to deal with 16x4 or 4x16
      blocks. Since BLOCK_16X4 is not less than BLOCK_8X8, the existing
      logic didn't work (and the "shuffle back one" logic should probably be
      done for small widths and heights separately).
      
      Change-Id: If28d8954da42d6c726f2bcce2cb5242154b0870c
      6a93b155
    • Nathan E. Egge's avatar
      Force C implementations when using Daala DCT's. · e030936c
      Nathan E. Egge authored
      This patch fixes a regression introduced in 1d190950 where the encoder
       was using the 4x4 VP9/AV1 transforms for RDO, but then used the Daala
       transforms for encoding.
      The ~2% improvement below comes from forcing the C implementation of the
       4x4 and 8x8 transforms to be used when CONFIG_DAALA_DCT4 and
       CONFIG_DAALA_DCT8 are enabled respectively.
      
      subset-1 (--enable-experimental --enable-daala_dct4):
      
      master@2017-08-21T21:41:18.302Z ->
       master_daala_dct4_use_c@2017-08-22T02:39:14.457Z
      
         PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      -2.1953 | -1.2044 | -1.1865 |  -1.6173 | -1.7029 | -1.6784 |    -1.7235
      
      Change-Id: I44d2b24094e89b2857ae03d743180e706cef45eb
      e030936c
    • Yue Chen's avatar
      Fix av1_get_tx_scale() for 32x8 and 8x32 tx · aa0d90f0
      Yue Chen authored
      Make it 0 to run at higher precision
      
      Change-Id: I51decbf9179efa18a1a06dcc3f0e939d9895a5cd
      aa0d90f0
    • James Zern's avatar
      cmake: sync warning flags w/configure · 4268571e
      James Zern authored
      + -Wlogical-op / -Wstack-usage
      
      Change-Id: Ia5c0b204e86e66cccdc792bcba0ad3326e72b9a3
      4268571e
    • David Barker's avatar
      Fix tile boundary calculation · 5c06a646
      David Barker authored
      Fix a rare case in which the tile boundary information was not
      set up properly in the decoder when using LOOPFILTERING_ACROSS_TILES
      
      The situation was:
      * One frame uses loop filtering across tiles. Then its tile
        boundary information is not needed, so is not calculated.
      * The next frame (in decode order) has the same size and the
        same tile layout, but doesn't use loop filtering across tiles.
      * Now the tile boundary information *is* needed, but we weren't
        recalculating it. This resulted in the loop filter being
        applied across tile boundaries even though we signalled not to.
      
      Since the conditions on when we can reuse the previous frame's
      boundary information are complex, and the overhead of calculating
      the tile boundaries is low, we avoid this issue by simply
      recalculating the boundary information each frame.
      
      Change-Id: I1f3cbb0537535bf38faaed4c21c07142e747f962
      5c06a646
    • Tom Finegan's avatar
      Silence misleading indentation warning. · eac51a94
      Tom Finegan authored
      third_party/fastfeat/fast_9.c: In function ‘fast9_score’:
      ‘for’ clause does not guard... [-Wmisleading-indentation]
           for(n=0; n < num_corners; n++)
           ^~~
      third_party/fastfeat/fast_9.c:2972:2: note: ...this statement, but the
      latter is misleadingly indented as if it is guarded by the ‘for’
        return scores;
        ^~~~~~
      
      Change-Id: Ie35cedd8a647a699c97066b930efd261d6906162
      eac51a94
    • Tom Finegan's avatar
      Silence unused function warning in subtract_test.cc. · b8dcfc5a
      Tom Finegan authored
      Change-Id: I65f2f5d797ac11a0e270ac44146bba78b2e8e569
      b8dcfc5a
  4. 24 Aug, 2017 6 commits
    • Todd Nguyen's avatar
      Turn off bgsprite depending on firstpass metrics. · 71efd848
      Todd Nguyen authored
      Changes:
      - Add block size define.
      - Set default to mean filtering.
      - Add flag in AV1_COMP for bgsprite.
      - Determine to use bgsprite or not based on firstpass metrics in
      define_gf_group.
      - Add outlier removal for bgsprite mean blending (off by default)
      
      Results:
      lowres: -0.009 avg_psnr, -0.029 ovr_psnr, -0.102 ssim
      
      Clips with maximum gain:
      - brdige_far_cif: -2.071 avg_psnr, -2.409 ovr_psnr, -1.977 ssim
      - deadline_cif: -0.148 avg_psnr, -0.137 ovr_psnr, -0.113 ssim
      - brdige_close_cif: +1.741 avg_psnr, -0.258 ovr_psnr, -2.534 ssim
      
      Change-Id: I809406020f7786e49cc80329511e22d25379d7a2
      71efd848
    • Yue Chen's avatar
      Update cdf and mode rate per superblock in RDO · b855b8e8
      Yue Chen authored
      Update cdf after each superblock being finalized, and re-compute
      symbol costs. Affected symbols include prediction parameters,
      tx type, and new motion vector.
      BDRate: -0.121% lowres, -0.089% midres
      
      Change-Id: I005ef382762d6e3423f933cca0a0b7b40288e8bf
      b855b8e8
    • Zoe Liu's avatar
      Fix a compiling warning on ext-comp-refs · ec50d6ba
      Zoe Liu authored
      Change-Id: I3259fbec7167e311f0bd12e309a227d9643bc86f
      ec50d6ba
    • Urvang Joshi's avatar
      get_sqr_tx_size(): fix for tx64x64 · dd3206fc
      Urvang Joshi authored
      When 64x64 transforms are enabled, it should return TX_64x64.
      
      Midres set:
      Small PSNR improvement overall (-0.061%),
      But 3 clips have large gains (-1.0% to -0.4% range)
      
      Change-Id: Ic2a1f0213449f81213219479c6b6aa0acfaac2e7
      dd3206fc
    • Rupert Swarbrick's avatar
      Correct apparent typo in fix for bug 693 · 17a61d4e
      Rupert Swarbrick authored
      Patch 323d535d fixes the reported bug but doesn't correctly read a
      global transformation of type TRANSLATION or AFFINE. Fortunately,
      clang gives a warning about the ignored expression.
      
      Change-Id: I1127d5d5b809bf016872a3ba97903599869d5357
      17a61d4e
    • Zoe Liu's avatar
      Add encoder support for ext-comp-refs + altref2 · ac889707
      Zoe Liu authored
      Change-Id: I9d26f288657a15e3d0ec4c5a11e80aecc1a829ad
      ac889707
  5. 23 Aug, 2017 11 commits
  6. 22 Aug, 2017 8 commits
    • Sarah Parker's avatar
      Refactor palette functions to write a general color map · 0cf4d9f1
      Sarah Parker authored
      This will allow the mrc-tx experiment to pass in its own color map
      and set of probabilities to the tokenize and bit packing functions.
      The corresponding change on the decoder side will come in a followup
      shortly.
      
      No change in performance.
      
      Change-Id: I1872b7f1b1cf5b102e6289388ce1ae449e67cb4d
      0cf4d9f1
    • Rupert Swarbrick's avatar
      Refactor iteration over neighbours for OBMC · c0cea7f3
      Rupert Swarbrick authored
      There are six pieces of code in reconinter.c and two in rdopt.c which
      iterate over the blocks along the top or left edge of the current
      block for OBMC. Before this patch, each bit of code has its own
      implementation of the iteration, which is reasonably finicky to get
      right.
      
      This patch factors out that logic into a pair of helpers
      (foreach_overlappable_nb_above and foreach_overlappable_nb_left). The
      functions take a "fun" parameter, which contains the loop body. Note
      that the iteration is too complicated for us to be able to define a
      macro that could be used like
      
        FOREACH_NB_ABOVE(rel_pos, nb_size, nb_mi) { ... }
      
      While C's syntax doesn't seem to let you do that, once the compiler's
      optimisation pass is done inlining everything, the results are
      essentially the same.
      
      The iteration logic is also slightly generalised: the old code checked
      whether a block was shorter or narrower than 8 pixels by comparing a
      block size with BLOCK_8X8. This doesn't work when you have a 4x16 or
      16x4 block because e.g. BLOCK_16X4 is not less than BLOCK_8X8. This
      generalisation is (unsurprisingly) needed in order to to support 16x4
      or 4x16 blocks.
      
      This patch doesn't address the CONFIG_NCOBMC functions in reconinter.c
      that do prediction from right and bottom edges.
      
      This patch shouldn't affect the generated bitstream in any way: the
      code is supposed to be equivalent.
      
      Change-Id: I9e5a116b012c18645604a7d98fb98be99697d363
      c0cea7f3
    • Sebastien Alaiwan's avatar
      av1_txfm_test.cc: factorize 'dct_matrix' · bdb7e9cd
      Sebastien Alaiwan authored
      Make it explicit that:
      - forward tx is using the matrix
      - inverse tx is using the transposed matrix
      
      Change-Id: Ia9507f4f68397b07b6fd1868bb421bb9d5dd817d
      bdb7e9cd
    • David Barker's avatar
      Fix ASan errors in SSE4.1 selfguided filter tests · 67a5e148
      David Barker authored
      The selfguided filter code was sometimes fetching 8 bytes of data
      when it only needed 4. This was normally fine, but lead to problems
      in the selfguided filter test when compiling for x86-32, where we
      accidentally read off the end of the input buffer.
      
      Fix this by only reading the amount of data we actually need.
      
      BUG=aomedia:700
      
      Change-Id: I2448b7b0d9cb2f9292a092675a66da64c89f913c
      67a5e148
    • Yaowu Xu's avatar
      Revert "Prevent access of array using -1 index" · 03dc6799
      Yaowu Xu authored
      This reverts commit 38cdce8e.
      
      Reason for revert: <INSERT REASONING HERE>
      
      It is reported that this introduced a segment fault, revert now to investigate. 
      
      Change-Id: I229dcdc09462ae4eb9cf2a3da4ce59aa9eafe65e
      03dc6799
    • Cheng Chen's avatar
      Silence warnings when warped_motion is disabled · 811bba79
      Cheng Chen authored
      Change-Id: I5da893be07b3b9aa4351b5bb1af987f4992370ef
      811bba79
    • Sebastien Alaiwan's avatar
      idct.c: fix left shift of negative value · 77323261
      Sebastien Alaiwan authored
      This is undefined behaviour in C and might confuse the optimizer, leading to incorrect code.
      
      Change-Id: Ia4bb60478068da678f013bdd6ab6a49814d89ebe
      77323261
    • Debargha Mukherjee's avatar
      Change 4-tap filter to be smoother · 6ec3d6e4
      Debargha Mukherjee authored
      Improves reconstruction performance.
      
      Change-Id: Ia30a345e1f5d4e450138c1dd3a7b700119c7de31
      6ec3d6e4