GitLab

Allow the above combination of experiments to work together
correctly, fixing an encode/decode mismatch bug when they
were all enabled.

This change causes build_masked_compound(_highbd) to only
ever be called if CONFIG_SUPERTX is off, so wrap these functions
in an '#if !CONFIG_SUPERTX' block.

BUG=aomedia:313

Change-Id: Ic3886bc69ba9624b8fcb0a4c2d71fc64d2c0f22c

Change-Id: I2a490e144099d7692296992528192c1f11d2c06f

Change-Id: I130f748c076a1642f12b95051dab19bfdac5b855

Now that https://aomedia-review.googlesource.com/#/c/6729/
has been merged, build_intra_predictors_for_interintra() is
now redundant, so replace it by a direct call to
av1_predict_intra_block() and remove the old function.

Reset rect_interintra back to 1.

To do this, we need to make the intra predictor take a
BLOCK_SIZE instead of a TX_SIZE. This is because we need to
be able to predict 32x64 and 64x32 blocks, but there is no
TX_32X64 or TX_64X32.

No effect on output or performance.

Change-Id: I8c185a211c97a85012cc54ec293c785a693608ed

Change-Id: Ibec40c3cd8e14343b096e406ba233cf4f131e7b9

Resolve the broken coding pipeline in ext-inter experiment when
cb4x4 mode is enabled. Turn off rectangular inter-intra mode.
This needs some more work to hook up. Given that it gives fairly
limited coding performance gains, disable it for the moment.

BUG=aomedia:309

Change-Id: I9b406df6183f75697bfd4eed5125a6e9436d84b0

This follows the naming for the other frame types, and allows libaom
to be compiled against other libraries that also #define NONE.

Change-Id: Ic2e2814587bbc5ea67385a9af775396d29b7dde0

BUG=aomedia:142

Change-Id: Id21dd2d19e1e46a9225cd5f8f8b0705ae178118c

By turning on CONVOLVE_POST_ROUNDING, in the compound inter
prediction mode, FILTER_BITS rounding is moved after the summation
of two predictions.

Note that the post rounding is only applied on non-sub8x8 block

       PSNR     BDRate
lowres -0.808%  -0.673%

Change-Id: Ib91304e6122c24d832a582ab9f5757d33eac876c

Make non-causal obmc option works in the cb4x4 mode.

Change-Id: If470ab61166752efc72719f9cd3e440560de1d51

This commit makes the motion-var support cb4x4 mode. It resolves
the encoding failure issue when both experiments are enabled.

BUG=aomedia:136

Change-Id: I2fa963d62cbdd24cc54d5a95d02f2dc226e6d2d0

Separate prediction code and parameter generating code.
This will not change bitstream statistics.

Change-Id: I194480166d3f8641592e53683029be1d466cfba9

At the final round of encoding of each superblock, will go through
each prediction block to check if ncobmc mode is better than non-
overlapped prediction. Note that causal obmc mode is dumped here.

PSNR gain (MOTION_VAR + NCOBMC): -2.845% lowres

Change-Id: Ibe504f7f1882446a08ba426e1e9824bca73bf655

These are under EXT_TX + RECT_TX experiment combo.

Results
=======

Derf Set:
--------
All Intra frames: 1.8% avg improvement (and 1.78% BD-rate improvement)
Video: 0.230% avg improvement (and 0.262% BD-rate improvement)

Objective-1-fast set
--------------------
Video: 0.52 PSNR improvement

Change-Id: I1893465929858e38419f327752dc61c19b96b997

Those functions includes
av1_make_inter_predictor
av1_build_inter_predictor
inter_predictor

Change-Id: Ide3b744277cf30964e8b352fc8de91365d7217a8

Adds a few options to make the compound mask lightly dependent on the
the two predictors.

Also adds high bit depth support

Change-Id: If57b6e8ddd140e0c00fd9d4738927d37225091cb

Change-Id: Id2537c8826e07ad6605aaa9858ba6d797bcd23a5

Change-Id: I7c992c9aae895aebcfb5c147cb179cf665c0ac10

Change-Id: Iab1217c7eb006c72e86e4261576b775b7debafd3

This commit allows the sub8x8 blocks to compose and filter their
chroma components for supertx in cb4x4 mode. The coding gains of
supertx and cb4x4 are largely additive:

          supertx      cb4x4       cb4x4 + supertx
lowres     -1.0%       -2.7%        -3.64%
midres     -0.8%       -1.3%        -2.10%

Change-Id: Ie7d09f6fceb36ce375e56773728f05dd628786fe

This allows the cb4x4 mode to work with ref-mv and supertx modes.

Change-Id: Ib9747d2c8a2b036fb246ca04bf7cc8c8f40931bf

This commit makes the cb4x4 mode support supertx operation.

Change-Id: I1a713b2268c1029aebeb43aa6aeb0fa37b16810f

Replace hard coded numbers with table access. Avoid comparing
values from different enums.

Change-Id: I43216db4a9b13ee317e8e517683946f526e5ca0e

Remove unused chunk of codes for sub8x8 inside this function.

Change-Id: Ie49d707b3ceeeee3b439e46c9d0e63abd4ae104c

This uses a segmentation mask (which is temporarily computed arbitrarily)
to blend predictors in compound prediction. The mask will be computed
using a color segmentation in a followup patch.
Change-Id: I2d24cf27a8589211f8a70779a5be2d61746406b9

No need of special handle on sub8x8 block sizes.

Change-Id: I8487cd68eda0882fe50550af3998dc941ec13b21

This is to avoid compiler warning of "mixed declarations and code".

Change-Id: I887a1cf27e777672563bda527b3d6cf70a589a8a

Relative to previous ext-inter:
lowres: -0.177%
     or -0.029% (with USE_RECT_INTERINTRA = 0)

* When predicting interintra modes, the previous code did not provide
  the intra predictor with the correct context during rdopt. Add an
  explicit 'ctx' parameter to the relevant functions, to provide this
  context.
  This fixes a nondeterminism bug, which was causing test failures in
  *EncoderThreadTest*

* For rectangular blocks, build_intra_predictors_for_interintra needs
  to overwrite part of the context buffer in order to set up the
  correct context for intra prediction. We now restore the original
  contents afterwards.

* Add a flag to enable/disable rectangular interintra prediction;
  disabling improves encoding speed but reduces BDRATE improvement.

Change-Id: I7458c036c7f94df9ab1ba0c7efa79aeaa7e17118

This was caused by a refactor in Ie105a7baf6a2c2258d3ef117e727957e4393f51b

Change-Id: I3a1d958d1e8759b9c1c215ea48763ee8deb62cf3

No change in performance

Change-Id: Ie105a7baf6a2c2258d3ef117e727957e4393f51b

Change-Id: Ia91388a2aa6def93b9b6167b983b20397ac4573b

Replace the computation of block size in pixels with lookup table
directly.

Change-Id: I39589b2bc1d20372969ff5ad0f60639e64a19b41

Performance gain (REF_MV on by default)
WARPED_MOTION: 1.061%
WARPED_MOTION+MOTION_VAR: 2.917%
MOTION_VAR: 2.337%

Change-Id: I43f742a02cdd43d13ef333a0a15087062ad020ab

To facilitate further experiments.
Fixes border, uses standard interpolation filters for
translation only global model, and some refactoring.

Change-Id: I38af6cb83723f92baed23e28d7fc9a0a9544757e

It is possible down the road new compound modes are added in addition to
COMPOUND_AVERAGE and COMPOUND_WEDGE.

Change-Id: I85985d4c104effd34df13845344aac2a08d28019

This is currently just a refactor and creates no change in performance.
It allows new compound types to be added easily in the future to
facilitate experiments with segmentation masks.

Change-Id: If48fed216d482454fabb45a304b4220ada0dbdee

After https://aomedia-review.googlesource.com/#/c/5589/ ,
the Global_Motion_Params and GLOBAL_MOTION_TYPE types
are redundant, and can be removed in favour of
WarpedMotionParams and TransformationType respectively.

Change-Id: I33f3796e5c469e595fd012ccdb65a672dd1bb86c

lowres: -0.401% BDRATE (tempete -5.4%)

Also includes some fixes and cleanups.

Change-Id: I82922a453fad59fad2f12829d2ef1e56b2d20949

The function module in inter_predictor() has been changed to
universally support arbitrary block size inter prediction. Hence
sub8x8mc can be a standalone experiment now.

Change-Id: Ie9d87f61fc317b1d114edb4e0bf5544f918ed08e

Change-Id: Ia69bceef24b61b0a222783eba79e7a70bb60edd8