GitLab

Tom Finegan authored Sep 07, 2017 and James Zern committed Sep 08, 2017

Change-Id: If4801b24e8711ab1e78a86b6dbb504be59042200

Newer gcc's output logical-op warnings when and'ing together
a duplicate condition. In this case it's because a constant
was set to an enum value that was also checked locally.

Change-Id: Iada9571d3e59ec9b75aa446fd6690587092af161

This patch forces the vertical filtering for the top and bottom
rows of a processing unit for the Wiener filter to be 5-tap.
The 5-taps are derived from the primary 7-tap fitler by forcing
the taps at the end to be zero, and absorbing their weights into
the other taps to maintain normalization.
This will effectively reduce the line buffer size for luma Wiener
filter to 4 (from 6).

Change-Id: I5e21b58369777eabf553a8987387d112f98a5598

Change-Id: I1b921e79484e78a272c4f62e30cb85631a65ac25

Changes loop-restoration to use processing unit size that is
64x64 for luma; for chroma the processing unit is coupled to
64x64 support region for luma.
Thus for chroma the processing unit size is 32x32 for 4:2:0,
32x64 for 4:2:2 and 64x64 for 4:4:4, etc.

While the Wiener filter output should not change with this patch,
the sgr filter will change since the boundary pixel handling in
sgr is internal within the filter.

Change-Id: I65a9e2df88927a19445420ce400acb1fcf7afa93

Patch https://aomedia-review.googlesource.com/c/aom/+/20200, merged as
32d150b6, converted several functions in pickrst.c to take a
"use_highbitdepth" flag as well as (or instead of) the actual bit
depth.

Unfortunately, I missed a call site and the code can end up passing
the number 8 as the flag for use_highbitdepth (and, since 8 != 0, this
ends up using the high bit depth patch).

BUG=aomedia:714

Change-Id: Ie4dbad92f57ea1bacc4d99aad15454d9e5b6ff47

The code was incorrectly using "bit_depth == 8" as a test for whether
to use the highbd path or not.

BUG=aomedia:714

Change-Id: Ib3995dcda949adfe9307bc4c8273c6c375c5a2c7

This is a baby-step towards encoding the coefficients at the start of
superblocks at the top-left of loop restoration tiles. Note that this
patch causes us to reset "wiener_info" and "sgrproj_info" at each tile
boundary, which will cause a performance drop.

This is necessary because, in order for tiles to be processed in
parallel, we cannot delta-encode coefficients across tile boundaries
if the coefficients are signalled within tiles. We could probably do
better than the current patch by, say, delta-encoding against previous
frames.

This patch also fixes up the costing in pickrst.c to match

Change-Id: I5b8b91d63aaf49627cde40219c31c0ac776dfd38

Change-Id: I1b789acc18f1e69fb5db069ccd8bd17815938e9d

It is a refactoring patch, which aims to make the code ready for
implementation of in-frame mode cost update in RDO.
Also add mode cost update per sb row, but it won't affect coding
results because cdf update in RDO is not there.
Mode cost arrays are moved to MACROBLOCK because in multi-thread
coding, threads share the same AV1_COMP.

This patch does not have impact on coding results.

Change-Id: I2e8f7d7d066b23ebfbfc998269023781f359a6ff

BUG=aomedia:623

Change-Id: I158072895adb8a9f5f177b8146f3beec265d7406

This was initialized from a const and never modified. But was still
passed around and stored in multiple structs.

Removed these 'rddiv' member variables and now RDOPT() and RDOPT_DBL()
always use the const RDDIV_BITS directly.

Change-Id: I1a8dfd2c8fa857d466ad1207b4f0dd6ec07eafb8

When frame_superres is on, loop-restoration should work
on the size of the upscaled frame and not on the internal
width and height in the common structure. This patch
makes the necessary changes on the encoder and decoder
side to enable that.

Change-Id: I1d1c024ac6f95944169d90647b4c5a61354a5cc6

Change-Id: I8deea1d2a76ce8c36085d19362ac2508fd3c438f

Unifies the chroma and luma paths for estimation of the
restoration parameters.

No change in bit-stream or results.

Change-Id: I9998c269cc00ded8b94d0e660b5441a4f9b94848

Frame level guided filters are now used as an option for
chroma components in addition to the Wiener filter.

Change-Id: Ie33299d22c15b69741ede55686177b7b8ce8e2b3

Change-Id: Id8351ef3497c54cef81a730e6ec3d63af1e9b54e

Improves coding efficiency a little

Change-Id: I1d5b3e3925e7fb640ea4da76b529672c4183a71c

Use a simpler least-squares function for affine and rotzoom
model estimation, instead of computing the pseudo inverse.
Also refactors the code into a separate mathutils.h file.

The SVD code is currently used only for estimation of the
homography models which can be removed when we remove the
homography models.

Coding efficiency change is in noise range, with the small
difference coming from numerical precision issues.

Change-Id: I0a9eb79495911cea21a7945b397d596e22a2a186

A little improvement so far.

Change-Id: I636c2432cb4fd319c989f2fed313ea6338b35152

Affected the switchable decision mechanism and
effectively turned off block level switching, even
though frame level switching was fine.

Change-Id: Id0b19f91ecfae63964e73f1ba7bfeec70179da35

When the fwd Gaussian elimination process encounters diagonal
element as zero value, the linear equation does not have unique
solution. Return the linear solver state as unsolvable in such
case. This resolves a floating point exception issue due to divided
by zero in the loop restoration filter.

BUG=aomedia:437

Change-Id: I3c67525691a3003f9f470e8a0d5b4ee187cba963

Change-Id: Iff0cb1d492c7a8c2035b9bd752b1d00260135672

Sebastien Alaiwan authored Apr 12, 2017 and James Zern committed Apr 12, 2017

Rename '--enable-aom-highbitdepth' to '--enable-highbitdepth'

Change-Id: I1de13c3508c30c552532993419d8ace326142ab6

Minor refactoring to force only Wiener or Sgrproj to be
used for luma.

Change-Id: I81d6f5dbf0fbc07252b9c57b43a035b90c5699af

For testing contribution from Wiener only.

Change-Id: I54fb5051dd03543d5166391a9b3b60b8d80c8228

Change-Id: Ibe5d4933f599456cb496f636de244694bc786a4c

Adds an option controlled by a macro to replace one of
the guided filters in the self-guided tool with a simple
bandpass filtered version generated with a 3x3 kernel.
By default the macro USE_HIGHPASS_IN_SGRPROJ is 0 (turned
off), that defaults us to the dual self-guided filter.
When the macro is turned on, the larger radius guided
filter is replaced by a simpler filter that is much faster.

Results (if USE_HIGHPASS_IN_SGRPROJ is on vs. off):
lowres: performance drop by +0.14% (BDRATE)
midres: performance drop by +0.27% (BDRATE)

Further experiments on this variation of guided filters is
pending.

Change-Id: I7bbcfcad7ee266cd49a8dc6d96795a454feb1a94

Performance is very similar to the lowbd path (only 4-5% slower)

Change-Id: Ifdb272c3f6c0e6f41e7046cc49497c72b5a796d9

Removes domain transform recursive filters and non-approximate
guided filter code.

Change-Id: Ib7ae7a6b6526a0908b3dc1787ab3561442da4e2d

The restoration tilesize can be now chosen as either 256, 128
or 64 at the frame header.

Change-Id: I852fc42afedc053484d657bdca522de73aaacd67

By rearranging the code in restoration.c, we can allow the
encoder to use the SSE4.1 version of the self-guided filter
while picking the loop-restoration filter.

This also helps us prepare for adding a highbitdepth SSE4.1
version of the self-guided filter.

No effect on encoder output, but gives an end-to-end speedup
of 1-2%.

Change-Id: Id17ba4a0963ddce9f70a7cae666e212e138d5f2c

Add an SSE4.1 lowbd version of the self-guided filter for
loop-restoration, and apply some optimizations to the C
version.

Approximate times per 128x128 / 256x256 tile on the machine
this was developed on:
Previous C:  620us / 2800us
Optimized C: 500us / 2200us ( 24% /  27% faster)
SSE4.1:      147us / 600us  (320% / 370% faster)

Change-Id: I23ff5a5482a191aeb06f9d1f767a9f036bb357fe

Removes redundant deblocking filtering operations and buffer copies,
during search for the restoration filters.
Also, makes the order of cdef and loop-restoration consistent.

BUG=AOMEDIA:373

Change-Id: I571e331f9dfadfd2c1494f279e50510ec212ea29

Allows DomainTxfm filters to be turned off for experimentation.
Also expands the parameter set for the Self guided filters.

Change-Id: I68fdb8e079a2464d80b3a4a990005c49baaaf0b8

Change-Id: I1bf9002c159563d0e5238b26d1515ef305d416dc

* Change Wiener filter storage to match the format expected
  by the convolve functions

Change-Id: I4d1fb08a13cfc31e69e12c1cb4b2e510c6d8ae30

Change-Id: I0d9850e082b8da3b182a3bbaf6569c45317c9659

Slight improvement in midres and hdres sets of 0.02% and 0.0.9%
respectively.

This is also a better design anyways.

Change-Id: I15b60b8836070a2132641e5b1d8e9f68df426c08

Change-Id: I56e741551f74624a84250d7565520db9c5127d1b