1. 25 Jan, 2011 3 commits
    • Johann's avatar
      move new neon subpixel function · 2168a944
      Johann authored
      previously wasn't guarded with ifdef ARMV7, causing a link error with
      ARMV6
      
      Change-Id: I0526858be0b5f49b2bf11e9090180b2a6c48926d
      2168a944
    • Attila Nagy's avatar
      Fix issue 262, vp8cx_pack_tokens_into_partitions_armv5 · 3bf235a4
      Attila Nagy authored
      http://code.google.com/p/webm/issues/detail?id=262
      Function was asuming that partitions have equal amount of mb_rows,
      which is not always true.
      
      Change-Id: I59ed40117fd408392a85c633beeb5340ed2f4b25
      3bf235a4
    • Paul Wilkins's avatar
      Incorrect bit allocation in forced KF groups. · 336aa0b7
      Paul Wilkins authored
      The old 2 pass code estimated error distribution when coding a
      forced (by interval) key frame. The result of this was that in some
      cases, when allocating bits at the GF group level within a KF
      group there was either a glut of bits or starvation of bits at the end
      of the KF group.
      
      Added code to rescan and get the correct data once the position of
      a forced key frame has been determined.
      
      Change-Id: I0c811675ef3f9e4109d14bd049d7641682ffcf11
      336aa0b7
  2. 24 Jan, 2011 1 commit
    • Scott LaVarnway's avatar
      Added vp8_update_zbin_extra · 0ee525d6
      Scott LaVarnway authored
      vp8cx_mb_init_quantizer was being called for every mode checked
      in vp8_rd_pick_inter_mode.  zbin_extra is the only value that
      really needs to be recalculated.  This calculation is disabled
      when using the fast quantizer for mode selection.
      This gave a small performance boost (~.5% to 1%).
      Note: This needs to be verified with segmentation_enabled.
      
      Change-Id: I62716a870b3c82b4a998bdf95130ff0b02106f1e
      0ee525d6
  3. 21 Jan, 2011 2 commits
    • Yunqing Wang's avatar
      Modify sub-pixel filters to eliminate unnecessary calculations · 0822a62f
      Yunqing Wang authored
      In sub-pixel calculation, xoffset and yoffset mostly take some
      specific values. Modified sub-pixel filter functions according to
      these possible values to improve performance.
      
      Change-Id: I83083570af8b00ff65093467914fbb97a4e9ea21
      0822a62f
    • Paul Wilkins's avatar
      Modified static scene check. · 0cdfef1e
      Paul Wilkins authored
      Added code to scan ahead a few frames when we see what
      we think is a static scene in the two pass GF loop to see if the
      conditions persist.
      
      Moved calculation of decay rate out into a fuunction.
      
      Change-Id: I6e9c67e01ec9f555144deafc8ae67ef25bffb449
      0cdfef1e
  4. 20 Jan, 2011 2 commits
    • Paul Wilkins's avatar
      Further work to reduce pulsing. · 8064583d
      Paul Wilkins authored
      These changes are specifically targeted at fade transitions to
      static scenes. Here we want to place a GF/ARF immediately
      after the fade and prevent an ARF just  before the fade.
      
      Also some code lines and comment lines shortened to 80 chars
      while I was there.
      
      Change-Id: Iefdc09a4fa7b265048fc017246b73e138693950f
      8064583d
    • Adrian Grange's avatar
      Fixed use of motion percentage in KF/GF group calc · 815e1e9f
      Adrian Grange authored
      In both vp8_find_next_key_frame and define_gf_group,
      motion_pct was initialised at the top of the loop before
      next_frame stats had been read in.
      
      This fix sets motion_pct after next_frame stats have
      been read.
      
      Change-Id: I8c0bebf372ef8aa97b97fd35b42973d1d831ee73
      815e1e9f
  5. 19 Jan, 2011 2 commits
    • Paul Wilkins's avatar
      First pass loop bug. · e8675168
      Paul Wilkins authored
      Incorrect value loop_decay_rate used in GF loop.
      
      The intent was to test the  cumulative value decay_accumulator.
      
      Change-Id: I62928c63eb09f4f6936a45ebd1c23784d1c9681b
      e8675168
    • Henrik Lundin's avatar
      Implement error tracking in the decoder · 67fb3a51
      Henrik Lundin authored
      A new vpx_codec_control called VP8D_GET_FRAME_CORRUPTED. The output
      from the function is non-zero if the last decoded frame contains
      corruption due to packet losses.
      
      The decoder is also modified to accept encoded frames of zero length.
      A zero length frame indicates to the decoder that one or more frames
      have been completely lost. This will mark the last decoded reference
      buffer as corrupted. The data pointer can be NULL if the length is
      zero.
      
      Change-Id: Ic5902c785a281c6e05329deea958554b7a6c75ce
      67fb3a51
  6. 18 Jan, 2011 4 commits
    • Yunqing Wang's avatar
      Modify calling of NEON code in sub-pixel search · ce6c954d
      Yunqing Wang authored
      In vp8_find_best_sub_pixel_step_iteratively(), many times xoffset
      and yoffset are specific values - (4,0) (0,4) and (4,4). Modified
      code to call simplified NEON version at these specific offsets to
      help with the performance.
      
      Change-Id: Iaf896a0f7aae4697bd36a49e182525dd1ef1ab4d
      ce6c954d
    • Jim Bankoski's avatar
      vp8e -removed undefined max call · edcf74c6
      Jim Bankoski authored
      Change-Id: I42a86b0488f44115f09551fc5ad6d711fd470f0d
      edcf74c6
    • Paul Wilkins's avatar
      Further CQ, Key frame and ARF changes · 57136a26
      Paul Wilkins authored
      This code fixes a bug in the calculation of
      the minimum Q for alt ref frames.
      
      It also allows an extended gf/arf interval for sections
      of clips that completely static (or nearly so).
      
      Change-Id: I1a21aaa16d4f0578e5f99b13bebd78d59403c73b
      57136a26
    • Attila Nagy's avatar
      Fix encoder real-time only configuration. · cb791aaa
      Attila Nagy authored
      Remove allocation/deallocation of stats storage.
      Remove full search functions in machine specific encoder inits.
      Remove last pass validation in  validate_config.
      
      Change-Id: I7f29be69273981a4fef6e80ecdb6217c68cbad4e
      cb791aaa
  7. 17 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Fix CQ range and experimental KF sizing changes. · 339c5127
      Paul Wilkins authored
      The CQ level was not using the q_trans[] array to convert
      to a 0-127 range as per min and maxq
      
      Experimental change to try and match the reconstruction
      error for forced key frames approximately to that of the
      previous frame by means of the recode loop. Though this
      may cause extra recodes and the recode behavior has not
      been optimized, it can only happen on forced key frames.
      
      Change-Id: I1f7e42d526f1b1cb556dd461eff1a692bd1b5b2f
      339c5127
  8. 14 Jan, 2011 4 commits
    • Paul Wilkins's avatar
      Testing of modes with Alt Ref frame · 415371c9
      Paul Wilkins authored
      Previously when a frame was being overlaid on a previously coded
      alt ref frame we only checked the alt ref 0,0 mode. Where there is
      a possibility that the alt ref buffer is a filtered frame we should allow
      the other prediction modes as normal or at the least allow use of
      the last frame buffer.
      
      Change-Id: I4d6227223d125c96b4f3066ec6ec9484fee7768c
      415371c9
    • Adrian Grange's avatar
      ARNR filter pointer update bug fix · 2c1b06e6
      Adrian Grange authored
      In cases where the frame width is not a multiple of 16 the
      ARNR filter would go wrong.
      
      In vp8_temporal_filter_iterate_c when updating pointers
      at the end of a row of MBs,  the image size was
      incorrectly used rather than using Num_MBs_In_Row
      times 16 (Y) or 8 (U,V).
      
      This worked when width is multiple of 16 but failed
      otherwise.
      
      Change-Id: I008919062715bd3d17c7aa2562ab58d1cb37053a
      2c1b06e6
    • Paul Wilkins's avatar
      Experimental change to help with ARNR problem. · 72e22b0b
      Paul Wilkins authored
      Allow use of other reference frames for the ARF overlay frame
      when ARNR filtering is enabled
      
      Change-Id: Icd6a9fb38977a88fbe7cc9b9c18198eb454c0273
      72e22b0b
    • Paul Wilkins's avatar
      KF/GF Pulsing · c8338ebf
      Paul Wilkins authored
      This change is designed to try and reduce pulsing effects when moving
      with a complex transition like a fade, into an easy or static section in
      an otherwise difficult clip in CQ mode.
      
      The active CQ level is relaxed down to the user entered level for frames that
      are generating less than the passed in minimum bandwidth.
      
      Change-Id: Id6d8b551daad4f489c087bd742bc95418a95f3f0
      c8338ebf
  9. 13 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      One pass rate control correction. · eda7d538
      Paul Wilkins authored
      Fixed discrepancy cpi->ni_frames vs cm->current_video_frame > 150.
      
      Make one pass path explicit.
      
      There is still scope for some odd behaviour around the transition
      point at cpi->ni_frames > 150.
      
      Change-Id: Icdee130fe6e2a832206d30e45bf65963edd7a74d
      eda7d538
  10. 12 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Limit key frame quantizer for forced key frames. · 55acda98
      Paul Wilkins authored
      Where a key frame occurs because of a minimum interval
      selected by the user, then these forced key frames ideally need
      to be more closely matched in quality to the surrounding frame.
      
      Change-Id: Ia55b1f047e77dc7fbd78379c45869554f25b3df7
      55acda98
  11. 11 Jan, 2011 4 commits
    • Scott LaVarnway's avatar
      Moved ref frame calculations · 96fd758e
      Scott LaVarnway authored
      Moved ref frame calculations to outside of the
      mode_index loop.
      
      Change-Id: I06103fc7e8af88b54b84443acf6691d29b1272ac
      96fd758e
    • Johann's avatar
      use unaligned load · f50f2fd2
      Johann authored
      source buffer is not guaranteed to be aligned for odd size buffers
      
      Change-Id: Id0b1fd40ba3bd6c994bcfada788feccd2b53c5a9
      f50f2fd2
    • Yunqing Wang's avatar
      Add no_skip_block4x4_search flag in SPLITMV mode · 1546e6a8
      Yunqing Wang authored
      Add a flag to always enable block4x4 search for speed=0 (good
      quality) to guarantee no quality loss for speed0.
      
      Change-Id: Ie04bbc25f7e6a33a7bfa30e05775d33148731c81
      1546e6a8
    • Henrik Lundin's avatar
      Remove unused local variables · 48c28fc4
      Henrik Lundin authored
      Removing unused local variables causing compiler warnings in
      Visual Studio.
      
      Change-Id: I0e2096303be1fdbc01428a6e57cca9796bb32c8a
      48c28fc4
  12. 10 Jan, 2011 3 commits
    • Yunqing Wang's avatar
      Fix bug in motion search · 3675b229
      Yunqing Wang authored
      The maximum possible MV in 1/8 pel units is (1<<11), which could
      cause mvcost out of its range that is 1023. Change maximum
      possible MV in 1/8 pel units to (1<<11)-8 will fix this problem.
      
      Change-Id: I5788ed1de773f66658c14f225fb4ab5b1679b74b
      3675b229
    • Paul Wilkins's avatar
      Two Pass VBR change · cf7c4732
      Paul Wilkins authored
      Further experiment with restriction of the Q range.
      
      This uses the average non KF/GF/ARF quantizer,  instead
      of just relying on the initial value. It is not such a strong constraint
      but there may be a reduced risk of rate misses.
      
      Change-Id: I424fe782a37a2f4e18c70805e240db55bfaa25ec
      cf7c4732
    • Paul Wilkins's avatar
      Revert BASE_ERRPERMB · 405499d8
      Paul Wilkins authored
      Constant value reverted pending more tests
      on different video formats.
      
      Change-Id: I07d11a0e0185e60724698c835416caf2e0774e61
      405499d8
  13. 07 Jan, 2011 3 commits
    • Paul Wilkins's avatar
      CQ Mode · e0846c9c
      Paul Wilkins authored
      The merge includes hooks to for CQ mode and other code
      changes merged from the test branch.
      
      CQ mode attempts to maintain a more stable quantizer within a clip
      whilst also trying to adhere to a guidline maximum bitrate.
      
      The existing target data rate parameter is used to specify the
      guideline maximum bitrate.
      
      A new parameter allows the user to specify a target CQ level.
      
      For normal (non kf/gf/arf) frames, the quantizer will not drop BELOW the
      user specified value (0-63). However, in some cases the encoder may
      choose to impose a target CQ that is above that specified by the user,
      if it estimates that consistent use of the target value is not compatible
      with guideline maximum bitrate.
      
      Change-Id: I2221f9eecae8cc3c431d36caf83503941b25e4c1
      e0846c9c
    • Paul Wilkins's avatar
      Limit Q variability in two pass. · 3af3593c
      Paul Wilkins authored
      In two pass encoding each frame is given an active
      Q range to work with. This change limits how much this
      Q range can be altered over time from the initial estimate
      made for the clip as a whole.
      
      There is some danger this could lead to overshoot or undershoot
      in some corner cases but it helps considerably in regard to
      clips where either there is a glut or famine of bits in some sections,
      particularly near the end of a clip.
      
      Change-Id: I34fcd1af31d2ee3d5444f93e334645254043026e
      3af3593c
    • Scott LaVarnway's avatar
      Removed cpi->target_bits_per_mb · 6dbdfe34
      Scott LaVarnway authored
      cpi->target_bits_per_mb is currently not being used,
      so delete it.  Also removed other unused code in rdopt.c.
      
      Change-Id: I98449f9030bcd2f15451d9b7a3b9b93dd1409923
      6dbdfe34
  14. 06 Jan, 2011 3 commits
    • Johann's avatar
      x86 sse2 temporal_filter_apply · 8b0cf5f7
      Johann authored
      count can be reduced to short because the max number of filtered frames
      is set to 15. the max value for any frame is 32 (modifier = 16,
      filter_weight = 2). 15*32 = 480 which requires 9 bits
      
      this function goes from about 7000 us / 1000 iterations for the C code
      to < 275 us / 1000 iterations for sse2 for block_size = 16 and from
      about 1800 us / 1000 iters to < 100 us / 1000 iters for block_size = 8
      
      Change-Id: I64a32607f58a2d33c39286f468b04ccd457d9e6e
      8b0cf5f7
    • John Koleszar's avatar
      fix last frame buffer copy logic regression · 1942eeb8
      John Koleszar authored
      Commit 0ce39012 introduced a change in the frame buffer copy logic where
      the NEW frame could be copied to the ARF or GF buffer through the
      copy_buffer_to_{arf,gf}==1 flags, if the LAST frame was not being
      refreshed. This is not correct. The intent of the
      copy_buffer_to_{arf,gf}==1 flag is to copy the LAST buffer. To copy the
      NEW buffer, the refresh_{alt_ref,golden}_frame flag should be used.
      
      The original buffer copy logic is fairly convoluted. For example:
      
          if (cm->refresh_last_frame)
          {
              vp8_swap_yv12_buffer(&cm->last_frame, &cm->new_frame);
      
              cm->frame_to_show = &cm->last_frame;
          }
          else
          {
              cm->frame_to_show = &cm->new_frame;
          }
          ...
          if (cm->copy_buffer_to_arf)
          {
              if (cm->copy_buffer_to_arf == 1)
              {
                  if (cm->refresh_last_frame)
                      vp8_yv12_copy_frame_ptr(&cm->new_frame, &cm->alt_ref_frame);
                  else
                      vp8_yv12_copy_frame_ptr(&cm->last_frame, &cm->alt_ref_frame);
              }
              else if (cm->copy_buffer_to_arf == 2)
                  vp8_yv12_copy_frame_ptr(&cm->golden_frame, &cm->alt_ref_frame);
          }
      
      Effectively, if refresh_last_frame, then new and last are swapped, so
      when "new" is copied to ARF, it's equivalent to copying LAST to ARF. If
      not refresh_last_frame, then LAST is copied to ARF. So LAST is copied to
      ARF in both cases.
      
      Commit 0ce39012 removed the first buffer swap but kept the
      refresh_last_frame?new:last behavior, changing the sense since the first
      swap wasn't done to the more readable refresh_last_frame?last:new, but
      this logic is not correct when !refresh_last_frame.
      
      This commit restores the correct behavior from v0.9.1 and prior. This
      case is missing from the test vector set.
      
      Change-Id: I8369fc13a37ae882e31a8a104da808a08bc8428f
      1942eeb8
    • Paul Wilkins's avatar
      Disable some features for first pass. · 431dac08
      Paul Wilkins authored
      The following features don't make sense for the first
      pass in its current form and have a significant impact on its
      speed (up to 50%).
      
      Slow quantizer, slow dct and trellis optimization.
      
      Change-Id: Id9943f6765ffbd71fc0084ec7dfbc9d376fd6fcd
      431dac08
  15. 04 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Adjustment to boost calculation in two pass. · b095d9df
      Paul Wilkins authored
      Calculate a minimum intra value to be used in determining the
      IIratio scores used in two pass, second pass.
      
      This is to make sure sections that are low complexity" in the
      intra domain are still boosted appropriately for KF/GF/ARF.
      
      For now I have commented out the Q based adjustment of
      KF boost.
      
      Change-Id: I15deb09c5bd9b53180a2ddd3e5f575b2aba244b3
      b095d9df
  16. 29 Dec, 2010 2 commits
    • Scott LaVarnway's avatar
      Fixed encoder crash when mult-threading is enabled. · de4e8185
      Scott LaVarnway authored
      Happens in real-time mode.  Will happen in good quality, speed 1.
      
      Change-Id: I3e5b68827b1a5798d0431b088a709256d1ce2c95
      de4e8185
    • Yunqing Wang's avatar
      Always update last_frame_type · a864678c
      Yunqing Wang authored
      Scott pointed out that last_frame_type only gets updated while
      loopfilter exists. Since last_frame_type is also needed in
      motion search now, it needs to be updated every frame.
      
      Change-Id: I9203532fd67361588d4024628d9ddb8e391ad912
      a864678c
  17. 28 Dec, 2010 3 commits
    • Scott LaVarnway's avatar
      Use the fast quantizer for inter mode selection · 516ea846
      Scott LaVarnway authored
      Use the fast quantizer for inter mode selection and the
      regular quantizer for the rest of the encode for good quality,
      speed 1.  Both performance and quality were improved.  The
      quality gains will make up for the quality loss mentioned in
      I9dc089007ca08129fb6c11fe7692777ebb8647b0.
      
      Change-Id: Ia90bc9cf326a7c65d60d31fa32f6465ab6984d21
      516ea846
    • Yunqing Wang's avatar
      Adjust MV borders for SPLITMV mode · bf53ec49
      Yunqing Wang authored
      Add limits to avoid MV going out of range.
      
      Change-Id: I8a5deb40bf393488d29f694b5a56804d578e68b5
      bf53ec49
    • Yunqing Wang's avatar
      Modify motion estimation for SPLITMV mode · a5a8d929
      Yunqing Wang authored
      1. Search for block8x16/block16x8 uses block8x8's search results.
      2. Check block4x4 only if block8x8 is chosen. (This hurts quality,
         which will be improved in another check-in.)
      3. In block4x4 search, the previous block's result is used as
         MV predictor for next block.
      
      This change improves performance.
      
      Change-Id: I9dc089007ca08129fb6c11fe7692777ebb8647b0
      a5a8d929