1. 04 Feb, 2011 1 commit
    • John Koleszar's avatar
      correct quantizer initialization · 63fc44df
      John Koleszar authored
      The encoder was not correctly catching transitions in the quantizer
      deltas. If a delta_q was set, then the quantizer would be reinitialized
      on every frame, but if they transitioned to 0, the quantizer would
      not be reinitialized, leading to a encode-decode mismatch.
      
      This bug was triggered by commit 999e155f, which sets a Y2 delta Q
      for very low base Q levels.
      
      Change-Id: Ia6733464a55ee4ff2edbb82c0873980d345446f5
      63fc44df
  2. 02 Feb, 2011 1 commit
    • Attila Nagy's avatar
      Delay auto key frame insertion in realtime configuration · e5904f2d
      Attila Nagy authored
      Whe auto keyframe insertion is enabled and conditions are right (scene change)
      the encoder can decide to insert a key frame and does a re-encoding. This can
      introduce extra latency. In RT mode we do not do the re-encoding of the current
      frame but force the next frame to key frame.
      
      Change-Id: I15c175fa845ac4c1a1f18bea3676e154669522a7
      e5904f2d
  3. 01 Feb, 2011 1 commit
    • Attila Nagy's avatar
      Improved encoder threading · 385c2a76
      Attila Nagy authored
      Reduce the number of sync points by letting each thread
      continue imediatly with a new MB row.
      Better multicore scaling, improves performance by 5-20% on ARM multicore.
      
      Change-Id: Ic97e4d1c4886a842c85dd3539a93cb217188ed1b
      385c2a76
  4. 26 Jan, 2011 3 commits
    • Scott LaVarnway's avatar
      Removed unused members from VP8_COMP · c4887da3
      Scott LaVarnway authored
      Change-Id: I8f3f2642b02975fbdb14982984a29821f80d30d3
      c4887da3
    • Paul Wilkins's avatar
      Correction to buffer update for non-viewable frames. · a3f71ccf
      Paul Wilkins authored
      The code previously tested cpi->common.refresh_alt_ref_frame
      but there are situations where this flag may be set for viewable frames.
      
      The correct test should be !cm->show_frame.
      
      Change-Id: Ia1a600622992a4a68fe1d38ac23bf6b34b133688
      a3f71ccf
    • Yaowu Xu's avatar
      cap the best quantizer for 2nd order DC · 999e155f
      Yaowu Xu authored
      This commit also removes artificial RDMULT cap for low quantizers.
      The intention is to address some abnormal behavior of mode selections
      at the low quantizer end, where many macroblocks were coded with
      SPLITMV with all partitions using same motion vector including (0,0).
      This change improves the compression quality substantially for high
      quality encodings in both PSNR and SSIM terms. Overall effect on
      mid/low rate range is also positive for all metrics, but smaller
      in magnitude.
      
      Change-Id: I864b29c4bd9ff610d2545fa94a19cc7e80c02667
      999e155f
  5. 25 Jan, 2011 1 commit
    • Yunqing Wang's avatar
      Refine motion vector prediction for NEWMV mode · dcaaadd8
      Yunqing Wang authored
      Adjust checking points in motion vector prediction to better cover
      possible movements, and get a better prediction. Tests on test
      clips showed a 0.1% improvement in SSIM, and no change in PSNR
      and performance.
      
      Change-Id: Ifdab05d35e10faea1445c61bb73debf888c9d2f8
      dcaaadd8
  6. 20 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Further work to reduce pulsing. · 8064583d
      Paul Wilkins authored
      These changes are specifically targeted at fade transitions to
      static scenes. Here we want to place a GF/ARF immediately
      after the fade and prevent an ARF just  before the fade.
      
      Also some code lines and comment lines shortened to 80 chars
      while I was there.
      
      Change-Id: Iefdc09a4fa7b265048fc017246b73e138693950f
      8064583d
  7. 18 Jan, 2011 3 commits
    • Jim Bankoski's avatar
      vp8e -removed undefined max call · edcf74c6
      Jim Bankoski authored
      Change-Id: I42a86b0488f44115f09551fc5ad6d711fd470f0d
      edcf74c6
    • Paul Wilkins's avatar
      Further CQ, Key frame and ARF changes · 57136a26
      Paul Wilkins authored
      This code fixes a bug in the calculation of
      the minimum Q for alt ref frames.
      
      It also allows an extended gf/arf interval for sections
      of clips that completely static (or nearly so).
      
      Change-Id: I1a21aaa16d4f0578e5f99b13bebd78d59403c73b
      57136a26
    • Attila Nagy's avatar
      Fix encoder real-time only configuration. · cb791aaa
      Attila Nagy authored
      Remove allocation/deallocation of stats storage.
      Remove full search functions in machine specific encoder inits.
      Remove last pass validation in  validate_config.
      
      Change-Id: I7f29be69273981a4fef6e80ecdb6217c68cbad4e
      cb791aaa
  8. 17 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Fix CQ range and experimental KF sizing changes. · 339c5127
      Paul Wilkins authored
      The CQ level was not using the q_trans[] array to convert
      to a 0-127 range as per min and maxq
      
      Experimental change to try and match the reconstruction
      error for forced key frames approximately to that of the
      previous frame by means of the recode loop. Though this
      may cause extra recodes and the recode behavior has not
      been optimized, it can only happen on forced key frames.
      
      Change-Id: I1f7e42d526f1b1cb556dd461eff1a692bd1b5b2f
      339c5127
  9. 14 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      KF/GF Pulsing · c8338ebf
      Paul Wilkins authored
      This change is designed to try and reduce pulsing effects when moving
      with a complex transition like a fade, into an easy or static section in
      an otherwise difficult clip in CQ mode.
      
      The active CQ level is relaxed down to the user entered level for frames that
      are generating less than the passed in minimum bandwidth.
      
      Change-Id: Id6d8b551daad4f489c087bd742bc95418a95f3f0
      c8338ebf
  10. 13 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      One pass rate control correction. · eda7d538
      Paul Wilkins authored
      Fixed discrepancy cpi->ni_frames vs cm->current_video_frame > 150.
      
      Make one pass path explicit.
      
      There is still scope for some odd behaviour around the transition
      point at cpi->ni_frames > 150.
      
      Change-Id: Icdee130fe6e2a832206d30e45bf65963edd7a74d
      eda7d538
  11. 12 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Limit key frame quantizer for forced key frames. · 55acda98
      Paul Wilkins authored
      Where a key frame occurs because of a minimum interval
      selected by the user, then these forced key frames ideally need
      to be more closely matched in quality to the surrounding frame.
      
      Change-Id: Ia55b1f047e77dc7fbd78379c45869554f25b3df7
      55acda98
  12. 11 Jan, 2011 2 commits
  13. 10 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Two Pass VBR change · cf7c4732
      Paul Wilkins authored
      Further experiment with restriction of the Q range.
      
      This uses the average non KF/GF/ARF quantizer,  instead
      of just relying on the initial value. It is not such a strong constraint
      but there may be a reduced risk of rate misses.
      
      Change-Id: I424fe782a37a2f4e18c70805e240db55bfaa25ec
      cf7c4732
  14. 07 Jan, 2011 2 commits
    • Paul Wilkins's avatar
      CQ Mode · e0846c9c
      Paul Wilkins authored
      The merge includes hooks to for CQ mode and other code
      changes merged from the test branch.
      
      CQ mode attempts to maintain a more stable quantizer within a clip
      whilst also trying to adhere to a guidline maximum bitrate.
      
      The existing target data rate parameter is used to specify the
      guideline maximum bitrate.
      
      A new parameter allows the user to specify a target CQ level.
      
      For normal (non kf/gf/arf) frames, the quantizer will not drop BELOW the
      user specified value (0-63). However, in some cases the encoder may
      choose to impose a target CQ that is above that specified by the user,
      if it estimates that consistent use of the target value is not compatible
      with guideline maximum bitrate.
      
      Change-Id: I2221f9eecae8cc3c431d36caf83503941b25e4c1
      e0846c9c
    • Scott LaVarnway's avatar
      Removed cpi->target_bits_per_mb · 6dbdfe34
      Scott LaVarnway authored
      cpi->target_bits_per_mb is currently not being used,
      so delete it.  Also removed other unused code in rdopt.c.
      
      Change-Id: I98449f9030bcd2f15451d9b7a3b9b93dd1409923
      6dbdfe34
  15. 06 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Disable some features for first pass. · 431dac08
      Paul Wilkins authored
      The following features don't make sense for the first
      pass in its current form and have a significant impact on its
      speed (up to 50%).
      
      Slow quantizer, slow dct and trellis optimization.
      
      Change-Id: Id9943f6765ffbd71fc0084ec7dfbc9d376fd6fcd
      431dac08
  16. 29 Dec, 2010 1 commit
    • Yunqing Wang's avatar
      Always update last_frame_type · a864678c
      Yunqing Wang authored
      Scott pointed out that last_frame_type only gets updated while
      loopfilter exists. Since last_frame_type is also needed in
      motion search now, it needs to be updated every frame.
      
      Change-Id: I9203532fd67361588d4024628d9ddb8e391ad912
      a864678c
  17. 28 Dec, 2010 1 commit
    • Scott LaVarnway's avatar
      Use the fast quantizer for inter mode selection · 516ea846
      Scott LaVarnway authored
      Use the fast quantizer for inter mode selection and the
      regular quantizer for the rest of the encode for good quality,
      speed 1.  Both performance and quality were improved.  The
      quality gains will make up for the quality loss mentioned in
      I9dc089007ca08129fb6c11fe7692777ebb8647b0.
      
      Change-Id: Ia90bc9cf326a7c65d60d31fa32f6465ab6984d21
      516ea846
  18. 22 Dec, 2010 2 commits
    • Johann's avatar
      temporal filter naming changes · 4b6219cb
      Johann authored
      be more consistant with the naming pattern, especially wrt rtcd
      
      Change-Id: I3df50686a09f1dab0a9620b5adbb8a1577b40f2f
      4b6219cb
    • Johann's avatar
      abstract apply_temporal_filter · 092b5bef
      Johann authored
      allow for optimized versions of apply_temporal_filter
      (now vp8_apply_temporal_filter_c)
      
      the function was previously declared as static and appears to have been
      inlined. with this change, that's no longer possible. performance takes
      a small hit.
      
      the declaration for vp8_cx_temp_filter_c was moved to onyx_if.c because
      of a circular dependency. for rtcd, temporal_filter.h holds the
      definition for the rtcd table, so it needs to be included by onyx_int.h.
      however, onyx_int.h holds the definition for VP8_COMP which is needed
      for the function prototype. blah.
      
      Change-Id: I499c055fdc652ac4659c21c5a55fe10ceb7e95e3
      092b5bef
  19. 16 Dec, 2010 1 commit
    • Scott LaVarnway's avatar
      Changed segmentation check order · 64baa8df
      Scott LaVarnway authored
      In SPLITMV, the 8x8 segment will be checked first.  If the 8x8 rd
      is better than the best, we check the other segments.  Otherwise
      bail.  Adjustments to the thresh_mult were necessary to make
      up for the initial quality loss.
      The performance improved by 20% (average) for good quality,
      speed 0 and speed 1, while the overall quality remained the same.
      
      Change-Id: I717aef401323c8a254fba3e9777d2a316c774cc3
      64baa8df
  20. 14 Dec, 2010 1 commit
    • Yunqing Wang's avatar
      Fix a bug in motion search code · 7fb0f868
      Yunqing Wang authored
      The MV's range is 256. Since the new motion search uses a different
      starting MV than the center ref MV, a MV range checking needs to
      be done to avoid corruption.
      
      Change-Id: I8ae0721d1bd203639e13891e2e54a2e87276f306
      7fb0f868
  21. 13 Dec, 2010 1 commit
    • John Koleszar's avatar
      remove unused temporal preproc code · b1aa54ab
      John Koleszar authored
      This code is unused, as the current preproc implementation uses the
      same spatial filter that postproc uses.
      
      Change-Id: Ia06d5664917d67283f279e2480016bebed602ea7
      b1aa54ab
  22. 09 Dec, 2010 1 commit
    • Paul Wilkins's avatar
      Correct q_low and q_high limits for the recode loop · c63fc881
      Paul Wilkins authored
      Corrected the initial Q range limits for the recode loop
      to reflect the current allowed range for the frame.
      
      In experimental work on constrained quality this bug was
      causing unnecessary recodes.
      
      Change-Id: I7e256fbfa681293b0223fe21ec329933d76c229f
      c63fc881
  23. 07 Dec, 2010 1 commit
    • Jim Bankoski's avatar
      vp8e - static threshold play · 718c1971
      Jim Bankoski authored
      Realized no need for new assembly code sum is already
      calculated.
      
      Change-Id: Ie2d94feb4b7c1f77c5359bca29b66228e41638c9
      718c1971
  24. 06 Dec, 2010 1 commit
    • Yunqing Wang's avatar
      Fix a memory leak problem in encoder · 9520f4b3
      Yunqing Wang authored
      Deallocating the buffers before re-allocating them.
      
      The fix passed James Berry's test program for memory
      leak check.
      
      Change-Id: I18c3cf665412c0e313a523e3d435106c03ca438d
      9520f4b3
  25. 04 Dec, 2010 1 commit
    • Paul Wilkins's avatar
      Change to inter_minq table. · cec6a596
      Paul Wilkins authored
      The inter_minq table controls the range of quantizers available
      for a particular frame in two pass relative to a max Q value.
      
      The changes reduces the range somewhat. The effect of this
      was a small increase (0.3% average) in psnr for the test set
      but it should also help encode speed somewhat for higher
      quality modes as it will reduce the number of iterations in the
      recode loop.
      
      The change damps the range of quantizers available locally
      within a section of a clip and should therefore help keep quality
      more uniform. If there is systematic overshoot or undershoot the
      range can shift gradually to accommodate. However, there is
      some increased risk of overshoot or undershoot against the target
      bit rate in VBR mode and this risk will be more pronounced for short
      clips.
      
      The change damps the range of quantizers available locally
      within a section of a clip and should therefore help keep quality
      more uniform. If there is systematic overshoot or undershoot the
      range can shift gradually to accommodate. However, there is
      some increased risk of overshoot or undershoot against the
      target bit rate in VBR mode and this risk will be more
      pronounced for short clips.
      
      Change-Id: I84465567d49ae767c6c73ff2a2aac30c895adb52
      cec6a596
  26. 03 Dec, 2010 1 commit
    • Yunqing Wang's avatar
      Improve MV prediction accuracy to achieve performance gain · c3bbb291
      Yunqing Wang authored
      Add vp8_mv_pred() to better predict starting MV for NEWMV
      mode in vp8_rd_pick_inter_mode(). Set different search
      ranges according to MV prediction accuracy, which improves
      encoder performance without hurting the quality. Also,
      as Yaowu suggested, using diamond search result as full
      search starting point and therefore adjusting(reducing)
      full search range helps the performance.
      
      Change-Id: Ie4a3c8df87e697c1f4f6e2ddb693766bba1b77b6
      c3bbb291
  27. 01 Dec, 2010 1 commit
    • Fritz Koenig's avatar
      Set refresh_alt_ref_frame on keyframe encode. · 9c8ad79f
      Fritz Koenig authored
      On a keyframe alt ref and golden are refreshed.  The flag was
      not being set and so on the frame after a keyframe, motion
      search would occur on the alt ref frame.  This is not necessary
      because the alt ref frame identical to the last frame in this
      scenario.
      
      Handle corner case where a forward alt-ref frame is put
      directly after a keyframe.
      
      Change-Id: I9be4cf290d694f8cf2f9a31852014b5ccf1504d3
      9c8ad79f
  28. 18 Nov, 2010 1 commit
    • Pascal Massimino's avatar
      remove warning · ed5ab7fa
      Pascal Massimino authored
      was having: "vp8/encoder/onyx_if.c:5365: warning: comparison of unsigned expression >= 0 is always true"
      ed5ab7fa
  29. 17 Nov, 2010 1 commit
    • Paul Wilkins's avatar
      Replaced recode loop test with a function call · f874391e
      Paul Wilkins authored
      Replaced existing code to decide if a frame recode is required
      with a function call. This is to simplify addition of extra clauses
      that may be needed for the planned constrained quality mode.
      
      Also fixed a bug where by alt ref not considered in the test.
      
      Change-Id: I3d40bb21abe3e19f8456761e6849deb171738b60
      f874391e
  30. 11 Nov, 2010 1 commit
    • John Koleszar's avatar
      quantizer: fix assertion in fast quantizer path · 0a49747b
      John Koleszar authored
      The fast quantizer assembly code has not been updated to match the new
      exact quantizer, which was made the default in commit 6adbe090.
      Specifically, they are not aware of the potential for the coefficient
      to be scaled, which results in the quantized result exceeding the range
      of the DCT. This patch restores the previous behavior of using the
      non-shifted coefficients when in the fast quantizer code path, but
      unfortunately requires rebuilding the tables when switching between the
      two.
      
      Change-Id: I0a33f5b3850335011a06906f49fafed54dda9546
      0a49747b
  31. 10 Nov, 2010 2 commits
    • Fritz Koenig's avatar
      postproc : Re-work posproc calling to allow more flags. · 647df00f
      Fritz Koenig authored
      Debugging in postproc needs more flags to allow for specific
      block types to be turned on or off in the visualizations.
      
      Must be enabled with --enable-postproc-visualizer during
      configuration time.
      
      Change-Id: Ia74f357ddc3ad4fb8082afd3a64f62384e4fcb2d
      647df00f
    • Paul Wilkins's avatar
      Tuning for the more exact quantizer. · 6adbe090
      Paul Wilkins authored
      Small changes to the default zero bin and rounding tables.
      Though the tables are currently the same for the Y1 and Y2 cases
      I have left them as separate tables in case we want to tune this later.
      
      There is now some adjustment of the zbin based on the prediction mode.
      Previously this was restricted to an adjustment for gf/arf 0,0 MV.
      
      The exact quantizer now marginal outperforms and is the default.
      
      The overall average gain is about 0.5%
      
      Change-Id: I5e4353f3d5326dde4e86823684b236a1e9ea7f47
      6adbe090
  32. 05 Nov, 2010 1 commit
    • John Koleszar's avatar
      improve average framerate calculation · f7e187d3
      John Koleszar authored
      Change Ice204e86 identified a problem with bitrate undershoot due to
      low precision in the timestamps passed to the library. This patch
      takes a different approach by calculating the duration of this frame
      and passing it to the library, rather than using a fixed duration
      and letting the library average it out with higher precision
      timestamps. This part of the fix only applies to vpxenc.
      
      This patch also attempts to fix the problem for generic applications
      that may have made the same mistake vpxenc did. Instead of
      calculating this frame's duration by the difference of this frame's
      and the last frame's start time, we use the end times instead. This
      allows the framerate calculation to scavenge "unclaimed" time from
      the last frame. For instance:
      
        start |  end  | calculated duration
        ======+=======+====================
          0ms    33ms   33ms
         33ms    66ms   33ms
         66ms    99ms   33ms
        100ms   133ms   34ms
      
      Change-Id: I92be4b3518e0bd530e97f90e69e75330a4c413fc
      f7e187d3