1. 18 Aug, 2017 1 commit
  2. 17 Aug, 2017 10 commits
    • Sebastien Alaiwan's avatar
      Coding path sync test: force picture size · 439b21c2
      Sebastien Alaiwan authored
      Change-Id: Ib9dd9aaa5240ac7c90f9c276ae8ef9055fcf1fdd
      439b21c2
    • Angie Chiang's avatar
      Add get_base_count_mag() · 9cde59f0
      Angie Chiang authored
      Compute base level's count/mag together.
      This will speed up lv_map exp by 5%
      
      Change-Id: I479098ed2637fc05d454fb0a7dc9f09aa20401f3
      9cde59f0
    • Angie Chiang's avatar
      Re-write gen_txb_cache · 481c01fc
      Angie Chiang authored
      This speed up lv_map exp by 5%
      
      Change-Id: Ic71e55c9e777031fe671589a96d8f2053f4d65a5
      481c01fc
    • Steinar Midtskogen's avatar
      Fix compile problem in VS · bbec5d00
      Steinar Midtskogen authored
      Change-Id: Ibe9908fac4920686eaee6e7b261e0ce29241cf4c
      bbec5d00
    • Yushin Cho's avatar
      cdef-dist and daala-dist is runtime switchable · e30a47ca
      Yushin Cho authored
      Use --tune=[cdef-dist|daala-dist] to enable them.
      
      Also, this commit set the use_activity_masking of PVQ as 0 by deafult,
      which means that PVQ assumes daala-dist is not used by default.
      
      Since we're currently not signaling which metric the encoder did use
      in the bitstream, the compile flag AV1_PVQ_ENABLE_ACTIVITY_MASKING will tell PVQ
      whether daala-dist is used or not.
      
      This commit is the last part of prep-work to remove DIST_8X8, CDEF_DIST,
      and DAALA_DIST experimental flags.
      
      Change-Id: Ia465b4d6fe64aac7f04852c8f9f4bac3409d2435
      e30a47ca
    • Tom Finegan's avatar
      Group CMake config changes. · 50e5d4ad
      Tom Finegan authored
      Group and sort the CMake configuration changes in
      aom_configure.cmake, and make sure everything that
      changes a CONFIG_ variable is taken care of before
      inclusion of cpu.cmake (which controls the RTCD
      versions of the CONFIG_ vars).
      
      Change-Id: Ib8069721de63c332392b7216fe3f194a077eb73c
      50e5d4ad
    • David Michael Barr's avatar
      [CFL] Move CFL cost table to struct macroblock · 38e560cc
      David Michael Barr authored
      Also, move body of update_cfl_costs() to av1_fill_mode_rates().
      
      Results on Subset1 (Compared to 1cfe474b with CFL enabled)
      
        PSNR | PSNR Cb | PSNR Cr | PSNR HVS |   SSIM | MS SSIM | CIEDE 2000
      0.0000 |  0.0000 |  0.0000 |   0.0000 | 0.0000 |  0.0000 |     0.0000
      
      No change in bitstream, for an average encode speed-up of 2.3%.
      
      Change-Id: I3948abcd70cfecad8086edfe4c45552b576ae06f
      38e560cc
    • Sarah Parker's avatar
      Add rate computation to palette · 9c0e4515
      Sarah Parker authored
      Currently the rate is never computed for the palette color indices.
      The code to compute the rate is inside av1_tokenize_palette_sb
      when dry_run == DRY_RUN_COSTCOEFFS, but av1_tokenize_palette_sb is
      only called when !dry_run.
      
      Change-Id: Ie33eae9e4bcf1997a22dc939f31001334cb2c399
      9c0e4515
    • Yushin Cho's avatar
      Introduce runtime switch for dist_8x8 · 55104335
      Yushin Cho authored
      Even if 'dist-8x8' is enabled with configure,
      the dist-8x8 is not acutally enabled (so, no change in encoding behaviour)
      until the command line option, '--enable-dist-8x8=1" is used.
      
      The cdef-dist and daala-dist can not be enabled by a command line option yet.
      
      This commit is a part of prep-work to remove DIST_8X8, CDEF_DIST,
      and DAALA_DIST experimental flags.
      
      Change-Id: I5c2df90f837b32f44e756572a19272dfb4c3dff4
      55104335
    • Yushin Cho's avatar
      Add --enable-dist-8x8, rename existing '--tune' as '--tune-metric' · d808bfcf
      Yushin Cho authored
      Added 'cdef-dist' and 'daala-dist' options to --tune-metric'.
      (Actual bodies of the options will be added in later separate commits)
      
      Also, if --tune=cdef-dist or --tune=daala-dist,
      enable-dist-8x8 is automatically turned on.
      
      This commit is a part of prep-work to remove DIST_8X8, CDEF_DIST,
      and DAALA_DIST experimental flags.
      
      Change-Id: I0790b9537dfaf166cb59741997ae27da10697a33
      d808bfcf
  3. 16 Aug, 2017 15 commits
    • Angie Chiang's avatar
      lv_map_opt: remove extra ctx buffer · 1ae0ebfc
      Angie Chiang authored
      Change-Id: I632a1f42eff2e41206d6023505c3c26dfc4698c2
      1ae0ebfc
    • Angie Chiang's avatar
      Replace stride by bwl in get_level_count() · e97b5ea6
      Angie Chiang authored
      Change-Id: Id191159a851513b6eb3f2ddd104a1299eed59292
      e97b5ea6
    • Angie Chiang's avatar
      Replace stride by bwl in get_nz_count · defa7bf1
      Angie Chiang authored
      Change-Id: Iaa464fdd36c9a97070517757645da68ef009b82c
      defa7bf1
    • Angie Chiang's avatar
      Replace mult by left shift in get_mag() · f76828cf
      Angie Chiang authored
      Change-Id: Idfa722cf2d1ed2f73630c7480ce166286955e1c5
      f76828cf
    • Angie Chiang's avatar
      Replace mult by left shift in get_level_count_mag() · 2ad6ee65
      Angie Chiang authored
      Change-Id: I58cdf4d1260759f085e12e871d48f59a89a346c4
      2ad6ee65
    • Debargha Mukherjee's avatar
      Use only up to 5x5 windows for sgr in loop-rest. · 76be32df
      Debargha Mukherjee authored
      The tables for guided filter in loop-restoration are changed
      to use a max of 5x5 windows (or radius 2).
      The aim is to reduce the gate count for hardware implementation.
      
      Change-Id: I7178d6ac09e4731a626f9bccf5151467c63e00c3
      76be32df
    • Frederic Barbier's avatar
      Fix memory corruption · 94e3856e
      Frederic Barbier authored
      Fix a memory corruption introduced by commit
      f190a165
      
      On some cases, when empty tiles are present,
      av1_set_across_tile_boundary_info() writes beyond mode info array.
      
      Sanity check added.
      
      BUG=aomedia:690
      
      Change-Id: I8d87a2e183c69d0ed039c8b2f77b30434f837974
      94e3856e
    • Zoe Liu's avatar
      Add dependency of ext-comp-refs on one-sided-compound · 5a978838
      Zoe Liu authored
      When ext-comp-refs is enabled, one-sided-compound is enabled by default,
      which ensures the use of ext-comp-refs is an extension of
      one-sided-compound. Both coding tools allow the use of same-sided
      reference frame pairs for compound prediction.
      
      Also, remove the dependency of ext-comp-refs on var-refs, i.e. these two
      coding tools can be independently enabled. They can still work together
      if both are enabled simultaneously.
      
      Change-Id: I3134e7e2956dc35d557fe814f5d801d473683650
      5a978838
    • Rupert Swarbrick's avatar
      Simplify motion var parameters in reconinter.h · 1cfe474b
      Rupert Swarbrick authored
      Before this patch, the functions build_inter_predictors, allow_warp
      and av1_make_inter_predictor took two parameters (if
      CONFIG_MOTION_VAR): mi_col_offset and mi_row_offset. These were used
      for two things: they were used to look up a MODE_INFO structure and
      the code figured out it was doing OBMC if at least one offset was
      nonzero.
      
      This patch slightly simplifies things by passing the relevant mi and a
      flag saying whether we're doing OBMC instead. This means the
      allow_warp function actually loses a parameter.
      
      It also moves all mention of the functions out of the header and into
      reconinter.c since they are only used in that compilation unit.
      
      Change-Id: I8dedad9d7384ee0aa17b977e92ea7bfa83a532ef
      1cfe474b
    • James Zern's avatar
      aom_configure: ensure RTCD_CONFIG_* are properly set · a1e274e2
      James Zern authored
      adjustments made by aom_configure.cmake need to be done prior to
      including cpu.cmake
      
      Change-Id: I482905414da4b1e112066d127cd71f8eae9dd504
      a1e274e2
    • Tom Finegan's avatar
      Add support for CONFIG_XIPHRC to the CMake build. · f00be13c
      Tom Finegan authored
      BUG=aomedia:683
      
      Change-Id: I198665a2cf5714bbb6fa7ecc8e430c02198cfb7b
      f00be13c
    • Tom Finegan's avatar
      Fix CONFIG_TXK_SEL support in the CMake build. · 08917e7b
      Tom Finegan authored
      CONFIG_TXK_SEL requires CONFIG_LV_MAP. Warn when not enabled, and
      enable it. This matches the configure build.
      
      BUG=aomedia:683
      
      Change-Id: Iba0340d13fcb3cb0d20fc36df6b3def2fc1d92fd
      08917e7b
    • Tom Finegan's avatar
      Fix CONFIG_PVQ support in the CMake build. · ac87049f
      Tom Finegan authored
      Wrap usages and declaration of av1_set_txb_context with
      CONFIG_PVQ preproc checks.
      
      BUG=aomedia:683
      
      Change-Id: I2080d7437ebe1741232eb5e4e83a430279c913a0
      ac87049f
    • James Zern's avatar
      coding_path_sync.cc: fix missing initializer warning · 78e5ecfc
      James Zern authored
      use the default constructor for aom_codec_dec_cfg, this matches the
      other tests
      
      Change-Id: I989007517c0dbd47b3781b812feba905061c0a26
      78e5ecfc
    • Urvang Joshi's avatar
      Re-enable resize test. · c9ac07f6
      Urvang Joshi authored
      This test has been removed from compilation for many months now.
      We add it back to compilation, but disable some of the tests which are
      not working / may be obsolete.
      
      Note: This test, had it been enabled earlier, would have caught some
      recently discovered issues (such as these fixes:
      https://aomedia-review.googlesource.com/c/18080)
      
      Change-Id: I3c7954f996889c86a63cda33fda1a1c06ed4c6d7
      c9ac07f6
  4. 15 Aug, 2017 14 commits
    • Monty Montgomery's avatar
      Disable only coding transform SIMD for DAALA_TX · 1d190950
      Monty Montgomery authored
      Rather than disabling MMX (well, all of SIMD) for daala transforms,
      selectively disable the AV1 TX SIMD through
      av1/common/av1_rtcd_defs.pl
      
      This also requires quite a few testing build fixups.
      
      Change-Id: I689eaafbdd3a87e3a8eeef97412a1846ef886055
      1d190950
    • Monty Montgomery's avatar
      Add 4-point DST to DAALA_DCT4 experiment · 573cf25f
      Monty Montgomery authored
      CONFIG_DAALA_DCT4 currently force-enables CONFIG_DCT_ONLY due to a
      missing 4-point DST.  The DST had not been included because it was a
      significant coding performance loss; this turned out to be a bug that
      has since been corrected.
      
      This patch adds a 4-point type IV DST to the DAALA_DCT4 experiment.
      There is a small coding performance loss in using the type IV over
      AV1's current type VII.
      
      subset-1:
         monty-newdst4test-baseline-s1-F@2017-07-29T04:58:43.976Z ->
            monty-newdst4test-daala-s1-F@2017-07-29T04:59:56.094Z
      
         PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      -0.0336 |  0.1393 |  0.0491 |   0.4118 | -0.0439 |  0.2084 |     0.0476
      
      objective-1-fast:
         monty-newdst4test-baseline-o1f-F@2017-07-29T04:58:10.439Z ->
            monty-newdst4test-daala-o1f-F@2017-07-29T04:59:04.678Z
      
        PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
      0.0064 |  0.1071 | -0.0108 |   0.1133 | -0.0035 |  0.0765 |     0.0502
      
      Change-Id: Ie29835edbe0e41bc86f4b09457e88d924cc9bf7e
      573cf25f
    • Zoe Liu's avatar
      Add ext-comp-refs dependency on ext-refs in configure · b9cfa415
      Zoe Liu authored
      This will remove the compilation failure for the weekly run on speed
      checking.
      
      Change-Id: Idf688c7e4c6fcb4c5aabef68b0e9f68996cd9a12
      b9cfa415
    • Monty Montgomery's avatar
      Add CONFIG_DAALA_DCT64 experiment. · a4e245a9
      Monty Montgomery authored
      This experiment replaces the 64-point Type-II DCT and related
      scaling vp9 transforms with the 64-point orthonormal
      Daala transforms.
      
      subset-1:
      
          monty-square-baseline-s1-F2@2017-07-28T03:35:45.962Z ->
            monty-square-dct64-s1-F2@2017-07-29T04:50:58.412Z
      
             PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
          -0.1930 | -0.2037 | -0.0643 |  -0.1917 | -0.2331 | -0.3510 |    -0.1810
      
      objective-1-fast:
      
          monty-square-baseline-o1f-F2@2017-07-28T03:35:35.533Z ->
            monty-square-dct64-o1f-F2@2017-07-29T04:50:28.542Z
      
             PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
          -0.2557 | -0.1743 | -0.4900 |  -0.3028 | -0.4147 | -0.5764 |    -0.2864
      
      Change-Id: I1f944df29e44d2e350c42555af274f2d75a62a92
      a4e245a9
    • Ralph Giles's avatar
      aom_dsp: regularize EXT_PARTITION_TYPES handling. · ccfdfce1
      Ralph Giles authored
      aom_dsp_rtcd_defs.pl compares most CONFIG_* keys to "yes"
      to see if they're set. The script was checking just
      
        if (aom_config("CONFIG_EXT_PARTITION_TYPES"))
      
      in some cases. The build system doesn't add disabled
      configuration options to libs.mk so this is effectively
      the same, however it means that setting the config
      key explicitly to 0 or "no" in the config headers
      was treated the same as setting it to 1 or "yes",
      and aom_dsp_rtcd.h would have opposite expections
      from aom_config.h or aom_config.asm.
      
      Treat this key similarly to others for consistency.
      
      Change-Id: I27bd7a5532ba4afc2bb289b43b57a1b1971c0348
      ccfdfce1
    • Debargha Mukherjee's avatar
      Add scaled convolve functions for convolve_round · 9c5b1088
      Debargha Mukherjee authored
      Change-Id: I343d94520955b6632c2a990af26454859b29a97e
      9c5b1088
    • David Barker's avatar
      A few fixes for ext-inter · 9b75e210
      David Barker authored
      * When wedge and compound-segment are disabled, we don't use
        compound_type_cdf, but it still gets copied around, averaged, etc.
        It's slightly nicer to avoid that when it isn't necessary.
      
      * Fix an anomaly with cb4x4: We had (schematically)
        'if (bsize < 8X8 && CB4X4)', which is backwards when compared to
        other similar conditions elsewhere in the code.
        Change this to 'if (bsize < 8X8 && !CB4X4)" to match other code.
      
      Change-Id: If802cf4f305c30cd642d0d5dd6610b547b52a027
      9b75e210
    • hui su's avatar
      Make q_adpt_probs work with CDF · ef125a07
      hui su authored
      Replace probablity tables with CDF tables.
      
      Change-Id: I21e12dce7f1a3fc7aa84805e890342445e68ce29
      ef125a07
    • Angie Chiang's avatar
      Refactor warp_filter_test_util · 2439e323
      Angie Chiang authored
      1) Move input initialization into iteration for loop
      2) Reduce the iteration number
      
      Change-Id: Iaf2e57134bff2b08046d875d0559d7644160bcb2
      2439e323
    • Urvang Joshi's avatar
      Remove ALT_INTRA flag. · 93b543ab
      Urvang Joshi authored
      This experiment has been adopted as it has been cleared by Tapas.
      
      Change-Id: I0682face60f62dd43091efa0a92d09d846396850
      93b543ab
    • Urvang Joshi's avatar
      Remove left-over lines about PALETTE from configure. · 9f262c5b
      Urvang Joshi authored
      Change-Id: I6b529f8aac561c746bf2805e601931f982bdbb88
      9f262c5b
    • Luc Trudeau's avatar
      Fix for Encode/Decode mistmatch EXT_REFS · b5e845bb
      Luc Trudeau authored
      In av1/av1_cx_iface.c the encoder_encode function loops over calls made
      to av1_get_compressed_data(). If the show_existing_frame flag is set,
      the frame has already been flushed and the av1_twopass_postencode_update
      function already incremented gf group index. The loop must exit, or else
      the superframe might contain multiple shown frames. This causes a
      mismatch in the test_decode function in that
      av1_cx_iface.c:ctrl_get_new_frame_image will return the frame at
      last_show_frame_buf_idx whereas, av1_dx_iface.c:ctrl_get_new_frame_image
      will return cm->frame_to_show
      
      BUG=aomedia:669
      
      Change-Id: I0765048be9bd04936e080db119b54c4050019bff
      b5e845bb
    • Debargha Mukherjee's avatar
      Miscellaneous fixes for resize/frame-superres · 17e7b081
      Debargha Mukherjee authored
      1. Fixes logic for disabling global motion w/ resize. Turns off
      conditional write/read of global parameters since it does not
      work currenlty. To be fixed later.
      2. Fixes call for av1_scale_if_required in encoder_frame_with_resize
      function
      3. Remove asserts for the scaled convolve functions
      
      Change-Id: I6a0f18b5ab5cc819bc27ef9fc2f28b0e391643a0
      17e7b081
    • Angie Chiang's avatar
      Fix integer overflow in warp filter test · ec329eec
      Angie Chiang authored
      The overflow happens because the buffer used by convolve_round
      is not properly initialized.
      
      BUG=aomedia:686
      
      Change-Id: I6173fb1899eeda78adafde773b3f36312467b47f
      ec329eec