1. 28 Jun, 2011 2 commits
    • Stefan Holmer's avatar
      New ways of passing encoded data between encoder and decoder. · 7296b3f9
      Stefan Holmer authored
      With this commit frames can be received partition-by-partition
      from the encoder and passed partition-by-partition to the
      decoder.
      
      At the encoder-side this makes it easier to split encoded
      frames at partition boundaries, useful when packetizing
      frames. When VPX_CODEC_USE_OUTPUT_PARTITION is enabled,
      several VPX_CODEC_CX_FRAME_PKT packets will be returned
      from vpx_codec_get_cx_data(), containing one partition
      each. The partition_id (starting at 0) specifies the decoding
      order of the partitions. All partitions but the last has
      the VPX_FRAME_IS_FRAGMENT flag set.
      
      At the decoder this opens up the possibility of decoding partition
      N even though partition N-1 was lost (given that independent
      partitioning has been enabled in the encoder) if more info
      about the missing parts of the stream is available through
      external signaling.
      
      Each partition is passed to the decoder through the
      vpx_codec_decode() function, with the data pointer pointing
      to the start of the partition, and with data_sz equal to the
      size of the partition. Missing partitions can be signaled to
      the decoder by setting data != NULL and data_sz = 0. When
      all partitions have been given to the decoder "end of data"
      should be signaled by calling vpx_codec_decode() with
      data = NULL and data_sz = 0.
      
      The first partition is the first partition according to the
      VP8 bitstream + the uncompressed data chunk + DCT address
      offsets if multiple residual partitions are used.
      
      Change-Id: I5bc0682b9e4112e0db77904755c694c3c7ac6e74
      7296b3f9
    • Stefan Holmer's avatar
      Adding support for independent partitions · 4cb0ebe5
      Stefan Holmer authored
      Adding support in the encoder for generating
      independent residual partitions by forcing
      equal probabilities over the prev coef entropy
      contexts.
      
      Change-Id: I402f5c353255f3ca20eae2620af739f6a498cd21
      4cb0ebe5
  2. 27 Jun, 2011 2 commits
  3. 24 Jun, 2011 1 commit
  4. 23 Jun, 2011 1 commit
    • John Koleszar's avatar
      Revert "Reduce overshoot in 1 pass rate control" · db67dcba
      John Koleszar authored
      This reverts commit 212f6183.
      
      Further testing shows that the overshoot accumulation/damping is too
      aggressive on some clips. Allowing the accumulated overshoot to
      decay and limiting to damping to golden frames shows some promise.
      But some clips show significant overshoot in the buffer window, so
      I think this still needs work.
      
      Change-Id: Ic02a9ca34f55229f9cc04786f4fab54cdc1a3ef5
      db67dcba
  5. 22 Jun, 2011 1 commit
    • James Berry's avatar
      get/set reference buffer dimension check added · 2bd90c13
      James Berry authored
      vp8_yv12_copy_frame_ptr() expects same size
      buffers which was not previously gaurenteed.
      Using an improperly allocated buffer would
      cause a crash before.
      
      Change-Id: I904982313ce9352474f80de842013dcd89f48685
      2bd90c13
  6. 21 Jun, 2011 1 commit
  7. 20 Jun, 2011 2 commits
    • Yaowu Xu's avatar
      adjusting the calculation of errorperbit · 10ed60dc
      Yaowu Xu authored
      RDMULT/RDDIV defines a bit worth of distortion in term of sum squared
      difference. This has also been used as errorperbit in subpixel motion
      search, where the distortions computed as variance of the difference.
      The variance of differences is different from sum squared differences
      by amount of DC squared. Typically, for inter predicted MBs, this
      difference averages around 10% between the two distortion, so this patch
      introduces a 110% constant in deriving errorperbit from RDMULT/RDDIV.
      
      Test on CIF set shows small but positive gain on overall PSNR (.03%)
      and SSIM (.07%), overall impact on average PSNR is 0.
      
      Change-Id: I95425f922d037b4d96083064a10c7cdd4948ee62
      10ed60dc
    • Scott LaVarnway's avatar
      Improved vp8dx_decode_bool · 67a1f98c
      Scott LaVarnway authored
      Relocated the vp8dx_bool_decoder_fill() call, allowing
      the compiler to produce better assembly code.  Tests
      showed a 1 - 2 % performance boost (x86 using gcc)
      for the 720p clip used.
      
      Change-Id: Ic5a4eefed8777e6eefa007d4f12dfc7e64482732
      67a1f98c
  8. 17 Jun, 2011 1 commit
    • Yunqing Wang's avatar
      Remove unnecessary bounds checking in motion search · 2cd1c285
      Yunqing Wang authored
      The starting points are always within the limits, and bounds
      checking on these points is not needed. For speed < 5, the
      encoded result changes a little because different treatment
      is taken while starting point equals the bounds.
      
      Change-Id: I09a402d310f51e305a3519f1601b1d17b05c6152
      2cd1c285
  9. 16 Jun, 2011 1 commit
    • Ronald S. Bultje's avatar
      Assign boost to GF bit allocation if past frame had no ARF. · 87fd66bb
      Ronald S. Bultje authored
      Modify the second-pass code to provide a full golden-frame (GF) bit
      allocation boost if the past GF group (GFG) had no alt-ref frame (ARF),
      even if the current GFG does contain and ARF.
      
      This mostly has no effect on clips, since switching ARFs on/off between
      GFGs is not very common. Has a positive effect on e.g. cheer (+0.45 SSIM
      at 600kbps) and football (+0.25 SSIM at 600kbps), particularly at high
      bitrates. Has a negative effect (-0.04 SSIM at 300kbps) at pamphlet,
      which appears only marginally related to this patch, and crew (-0.1 SSIM
      at 700kbps).
      
      Change-Id: I2e32899638b59f857e26efeac18a82e0c0b77089
      87fd66bb
  10. 15 Jun, 2011 3 commits
    • John Koleszar's avatar
      Use SSE as BPRED distortion metric consistently · 61599fb5
      John Koleszar authored
      The BPRED mode selection uses SSE as a distortion metric, but the early
      breakout threshold being used was a variance value.
      
      Change-Id: I42d4602fb9b548bf681a36445701fada5e73aff1
      61599fb5
    • Ronald S. Bultje's avatar
      Disable specialcase for last frames if the sequence contains ARFs. · 299193dd
      Ronald S. Bultje authored
      firstpass.c contains some rate adjustment code that assures that the
      last few frames in a sequence abide by rate limits. If the second-to-
      last group of frames contains an alt-ref frame (ARF), the last golden
      frame (GF) is zero bytes, and we will thus spend a ridiculously high
      number of bits on regular P-frames trying to hit the target rate. This
      does slightly enhance the quality of these last few frames, but has
      no perceptual value (other than hitting the target rate).
      
      Disabling this code means we consistently (slightly) undershoot the
      target rate and consequently do worse on the last few frames of a
      clip, which is particularly noticeable for small clips. The quality-
      per-bitrate is generally better, ~0.2% better overall on derf-set,
      especially on clips such as garden, tennis, foreman at low bitrates.
      Has a negative effect on hallmonitor at high bitrates.
      
      Change-Id: I1d63452fef5fee4a0ad2fb2e9af4c9f2e0d86d23
      299193dd
    • Attila Nagy's avatar
      Remove redundant check for KEY_FRAME in multithreaded decoder · c7e6aabb
      Attila Nagy authored
      For Intra blocks is enough to check ref_frame == INTRA_FRAME.
      
      Change-Id: I3e2d3064c7642658a9e14011a4627de58878e366
      c7e6aabb
  11. 14 Jun, 2011 3 commits
    • Johann's avatar
      fix --disable-runtime-cpu-detect on x86 · 92b0e544
      Johann authored
      Change-Id: Ib8e429152c9a8b6032be22b5faac802aa8224caa
      92b0e544
    • Tero Rintaluoma's avatar
      Fix RT only build · 99090474
      Tero Rintaluoma authored
      Moved encode_intra function from firstpass.c to encodeintra.c to
      prevent linking problem in real-time only build. Also changed name
      of the function to vp8_encode_intra because it is not a static.
      
      Change-Id: Ibf3c6c1de3152567347e5fbef47d1d39564620a5
      99090474
    • James Zern's avatar
      fix corrupt frame leak · 532c30c8
      James Zern authored
      If setup_token_decoder reported an internal error the memory allocated
      there would not be freed in the resulting call to _remove_decompressor.
      
      Change-Id: Ib459de222d76b1910d6f449cdcd01663447dbdf6
      532c30c8
  12. 13 Jun, 2011 2 commits
    • Scott LaVarnway's avatar
      Populate bmi for B_PRED only · 223d1b54
      Scott LaVarnway authored
      Small decode performance gain (~1%) on keyframes.  No
      noticeable gains on encode.  Also changed pick_intra4x4mby_modes()
      to read the above and left block modes for keyframes only.
      
      Change-Id: I1f4885252f5b3e9caf04d4e01e643960f910aba5
      223d1b54
    • Scott LaVarnway's avatar
      Calc ref_frame_cost once per frame · e71a0106
      Scott LaVarnway authored
      instead of every macro block.
      
      Change-Id: I2604e94c6b89e3a8457777e21c8c38406d55b165
      e71a0106
  13. 09 Jun, 2011 3 commits
  14. 08 Jun, 2011 8 commits
    • Johann's avatar
      use GCC inline magic · 79327be6
      Johann authored
      Better fix for #326. ICC happens to support the inline magic
      
      Change-Id: Ic367eea608c88d89475cb7b05d73500d2a1bc42b
      79327be6
    • John Koleszar's avatar
      vp8_pick_inter_mode: remove best_bmodes · 001bd51c
      John Koleszar authored
      Since BPRED will be tested at most once, and SPLITMV is not enabled,
      there's nothing to clobber the subblock modes, so there's no need to
      save and restore them.
      
      Change-Id: I7c3615b69190c10bd068a44df5488d6e8b85a364
      001bd51c
    • John Koleszar's avatar
      vp8_pick_intra_mode: correct returned rate · 91907e0b
      John Koleszar authored
      The returned rate was always the 4x4 rate, instead of the rate
      matching the selected mode.
      
      Change-Id: I51da31f80884f5e37f3bcc77d1047d31e612ded4
      91907e0b
    • Scott LaVarnway's avatar
      Removed unused function parameters · 69d8d386
      Scott LaVarnway authored
      Change-Id: Ib641c624faec28ad9eb99e2b5de51ae74bbcb2a2
      69d8d386
    • Yaowu Xu's avatar
      Adjust errorperbit according to RDMULT in activity masking · 1fba1e38
      Yaowu Xu authored
      In activity masking, RDO constant RDMULT is adjusted on a per MB basis
      adaptive to activity with the MB. errorperbit, which is defined as
      RDMULT/RDDIV, is a constant used in motion estimation. Previously, in
      activity masking, errorperbit is not changed even when RDMULT is changed.
      This commit changed to adjust errorperbit according to the change in
      RDMULT.
      
      Test in cif set showed a very small but consistent gain by all quality
      metrics (average, overall psnr and ssim) when activity masking is on.
      
      Change-Id: I07ded3e852919ab76757691939fe435328273823
      1fba1e38
    • John Koleszar's avatar
      Move RD intra block mode selection to rdopt.c · 96a42aaa
      John Koleszar authored
      This change is analogous to I0b67dae1f8a74902378da7bdf565e39ab832dda7,
      which made the move for the non-RD path.
      
      Change-Id: If63fc1b0cd1eb7f932e710f83ff24d91454f8ed1
      96a42aaa
    • John Koleszar's avatar
      Move intra block mode selection to pickinter.c · e90d17d2
      John Koleszar authored
      This commit moves the intra block mode selection from encodeframe.c
      to pickinter.c (in the non-RD case). This allowed pick_intra_mbuv_mode
      and pick_intra4x4mby_modes to be made static, and is a step towards
      refactoring intra mode selection in the main pickinter loop. Gave a
      small perf increase (~0.5%).
      
      Change-Id: I0b67dae1f8a74902378da7bdf565e39ab832dda7
      e90d17d2
    • Paul Wilkins's avatar
      Further activity masking changes: · 4e81a68a
      Paul Wilkins authored
      Some further re-structuring of activity masking code.
      Still has various experimental switches.
      Supports a metric based on intra encode.
      Experimental comparison against a fixed activity target  rather
      than a frame average, for altering rd and zbin.
      
      Overall the SSIM performance is similar  to TT's original
      code but there is a much smaller PSNR hit of circa
      0.5% instead of 3.2%
      
      Change-Id: I0fd53b2dfb60620b3f74d7415e0b81c1ac58c39a
      4e81a68a
  15. 07 Jun, 2011 3 commits
    • Yaowu Xu's avatar
      adjust sad per bit constants · 221e00ea
      Yaowu Xu authored
      While investigating the effect of DC values on SAD and SSE in motion
      estimation, a side finding indicates the two table of constants need
      be adjusted. The adjustment was done by multiplying old constants by
      90% with rounding. Also absorb the 1/2 scaling constant into the two
      tables. Refer to change Ifa285c3e for background of the 1/2 factor.
      
      Cif set test showed a very small gain on all metric.
      
      Change-Id: I04333527a823371175dd46cb04a817e5b9a8b752
      221e00ea
    • Scott LaVarnway's avatar
      Wrapped asserts in critical code with CONFIG_DEBUG · 0e3bcc6f
      Scott LaVarnway authored
      Change-Id: I5b0aaca06f2e0f40588cb24fb0642b6865da8970
      0e3bcc6f
    • Scott LaVarnway's avatar
      Removed unused function vp8_treed_read_num · 1374a4db
      Scott LaVarnway authored
      Change-Id: Id66e70540ee7345876f099139887c1843093907f
      1374a4db
  16. 06 Jun, 2011 2 commits
    • Yaowu Xu's avatar
      remove redundant functions · d4700731
      Yaowu Xu authored
      The encoder defined about 4 set of similar functions to calculate sum,
      variance or sse or a combination of them. This commit removed one set
      of these functions, get8x8var and get16x16var, where calls to the later
      function are replaced with var16x16 by using the fact on a 16x16 MB:
          variance == sse - sum*sum/256
      
      Change-Id: I803eabd1fb3ab177780a40338cbd596dffaed267
      d4700731
    • Yunqing Wang's avatar
      Remove hex search's variance calculation while in real-time mode · 03973017
      Yunqing Wang authored
      In real-time mode motion search, there is no need to calculate
      variance. This change improved encoding speed by 1% ~ 2%(speed=-5).
      
      Change-Id: I65b874901eb599ac38fe8cf9cad898c14138d431
      03973017
  17. 03 Jun, 2011 3 commits
    • John Koleszar's avatar
      Reduce overshoot in 1 pass rate control · 212f6183
      John Koleszar authored
      This patch attempts to reduce the peak bitrate hit by the encoder
      when using small buffer windows.
      
      Tested on the CIF set over 200-500kbps using these settings:
      
        --buf-sz=500 --buf-initial-sz=250 --buf-optimal-sz=250 \
        --undershoot-pct=100
      
      Two pass encodes were tested at best quality. One pass encodes were
      tested only at realtime speed 4:
      
        --rt --cpu-used=-4
      
      The peak datarate (over the specified 500ms window) was measured
      for each encode, and averaged together to get metric for
      "average peak," computed as SUM(peak)/SUM(target). This patch
      reduces the average peak datarate as follows:
      
        One pass:
          baseline:   1.29715
          this patch: 1.23664
      
        Two pass:
          baseline:   1.32702
          this patch: 1.37824
      
      This change had a positive effect on our quality metrics as well:
      
        One pass CBR:
                          Min  / Mean / Max (pct)
          Average PSNR    -0.42 / 2.86 / 27.32
          Overall PSNR    -0.90 / 2.00 / 17.27
          SSIM            -0.05 / 3.95 / 37.46
      
        Two pass CBR:
                          Min  / Mean / Max (pct)
          Average PSNR    -4.47 / 4.35 / 35.99
          Overall PSNR    -3.40 / 4.18 / 36.46
          SSIM            -4.56 / 6.98 / 53.67
      
        One pass VBR:
                          Min  / Mean / Max (pct)
          Average PSNR    -5.21 /  0.01 / 3.30
          Overall PSNR    -8.10 / -0.38 / 1.21
          SSIM            -7.38 / -0.11 / 3.17
          (note: most values here were close to the mean, there were a few
           outliers on files that were very sensitive to golden frame size)
      
        Two pass VBR:
                          Min  / Mean / Max (pct)
          Average PSNR    0.00 / 0.00 / 0.00
          Overall PSNR    0.00 / 0.00 / 0.00
          SSIM            0.00 / 0.00 / 0.00
      
      Neither one pass or two pass CBR mode adheres particularly strictly
      to the short term buffer constraints, and two pass is less
      consistent, even in the baseline commit. This should be addressed
      in a later commit. This likely will hurt the quality numbers, as it
      will have to reduce the burstiness of golden frames.
      
      Aside: My work on this commit makes it clear that we need to make
      rate control modes "pluggable", where you can easily write a new
      one or work on one in isolation.
      
      Change-Id: I1ea9a48f2beedd59891f1288aabf7064956b4716
      212f6183
    • Scott LaVarnway's avatar
      Removed unnecessary bmi motion vector stores. · f1d6cc79
      Scott LaVarnway authored
      left_block_mv and above_block_mv will return the MB
      motion vector for non SPLITMV macro blocks.
      
      Change-Id: I58dbd7833b4fdcd44b6b72e98ec732c93c2ce4f4
      f1d6cc79
    • Yunqing Wang's avatar
      Adjust bounds checking for hex search in real-time mode · e5c236c2
      Yunqing Wang authored
      Currently, hex search couldn't guarantee the motion vector(MV)
      found is within the limit of maximum MV. Therefore, very large
      motion vectors resulted from big motion in the video could cause
      encoding artifacts. This change adjusted hex search bounds
      checking to make sure the resulted motion vector won't go out
      of the range. James Berry, thank you for finding the bug.
      
      Change-Id: If2c55edd9019e72444ad9b4b8688969eef610c55
      e5c236c2
  18. 02 Jun, 2011 1 commit
    • Scott LaVarnway's avatar
      Removed B_MODE_INFO · 773768ae
      Scott LaVarnway authored
      Declared the bmi in BLOCKD as a union instead of B_MODE_INFO.
      Then removed B_MODE_INFO completely.
      
      Change-Id: Ieb7469899e265892c66f7aeac87b7f2bf38e7a67
      773768ae