1. 22 Oct, 2012 4 commits
  2. 19 Oct, 2012 1 commit
    • John Koleszar's avatar
      Remove bc, bc2 from pbi,cpi,xd · e9fd1eac
      John Koleszar authored
      Pass the bool coder to be used explicitly. This avoids cases where two
      different bool coders can be addressed from the same function. Also be
      more consistent with bool coder variable naming, start to standardize
      on 'bc'.
      
      Change-Id: I1c95e2fdbe24ebe8c0f84924daa1728e3b054a31
      e9fd1eac
  3. 15 Oct, 2012 1 commit
    • Ronald S. Bultje's avatar
      Add a new token stuffing function vp8_stuff_mb(). · e7881462
      Ronald S. Bultje authored
      This way a caller doesn't need to implement the logic for which (and how
      many) tokens to write out to stuff one macroblock worth of EOBs. Make
      the actual function implementations static, since they are now only used
      in tokenize.c; also do some minor stylistic changes so it follows the
      style guide a little more closely; use PLANE_TYPE where appropriate,
      remove old (stale) frame_type function arguments; hardcode plane type
      where only a single one is possible (2nd order DC or U/V EOB stuffing);
      support stuffing 8x8/4x4 transform EOBs with no 2nd order DC.
      
      Change-Id: Ia448e251d19a4e3182eddeb9edd034bd7dc16fa3
      e7881462
  4. 11 Oct, 2012 2 commits
  5. 09 Oct, 2012 1 commit
    • Ronald S. Bultje's avatar
      Selectable transform size try 2. · 9ca3c8b2
      Ronald S. Bultje authored
      Results: derf (vanilla or +hybridtx) +0.2% and (+hybrid16x16
      or +tx16x16) +0.7%-0.8%; HD (vanilla or +hybridtx) +0.1-0.2%
      and (+hybrid16x16 or +tx16x16) +1.4%, STD/HD (vanilla or +hybridtx)
      about even, and (+hybrid16x16 or +tx16x16) +0.8-1.0%.
      
      Change-Id: I03899e2f7a64e725a863f32e55366035ba77aa62
      9ca3c8b2
  6. 27 Sep, 2012 1 commit
    • Deb Mukherjee's avatar
      Entropy coding for hybrid transform · 3f5d60b3
      Deb Mukherjee authored
      Separates the entropy coding context models for 4x4, 8x8 and 16x16
      ADST variants.
      
      There is a small improvement for HD (hd/std-hd) by about 0.1-0.2%.
      Results on derf/yt are about the same, probably because there is not
      enough statistics.
      
      Results may improve somewhat once the initial probability tables are
      updated for the hybrid transforms which is coming soon.
      
      Change-Id: Ic7c0c62dacc68ef551054fdb575be8b8507d32a8
      3f5d60b3
  7. 07 Sep, 2012 1 commit
    • Paul Wilkins's avatar
      Partial merge of NEWBESTREFMV and NEW_MVREF. · 778ec421
      Paul Wilkins authored
      This commit merges those parts of the CONFIG_NEW_MVREF
      that specifically relate to choosing a better set of candidate
      MV references into the NEWBESTREFMV experiment.
      
      CONFIG_NEW_MVREF will then be used for changes relating
      to the explicit coding of a cost optimized MV reference in the
      bitstream as part of MV coding.
      
      Change-Id: Ied982c0ad72093eab29e38b8cd74d5c3d7458b10
      778ec421
  8. 06 Sep, 2012 1 commit
    • Deb Mukherjee's avatar
      New motion vector entropy coding · 00f9eb65
      Deb Mukherjee authored
      Adds a new experiment with redesigned/refactored motion vector entropy
      coding. The patch also takes a first step towards separating the
      integer and fractional pel components of a MV. However the fractional
      pel encoding still depends on the integer pel part and so they are
      not fully independent. Further experiments are in progress to see
      how much they can be decoupled without affecting performance.
      All components including entropy coding/decoding, costing for MV
      search, forward updates and backward updates to probability tables,
      have been implemented.
      
      Results so far:
      derf: +0.19%
      std-hd: +0.28%
      yt: +0.80%
      hd: +1.15%
      
      Patch: Simplifies the fractional pel models:
      derf: +0.284%
      std-hd: +0.289%
      yt: +0.849%
      hd: +1.254%
      
      Patch: Some changes in the models, rebased.
      derf: +0.330%
      std-hd: +0.306%
      yt: +0.816%
      hd: +1.225%
      
      Change-Id: I646b3c48f3587f4cc909639b78c3798da6402678
      00f9eb65
  9. 30 Aug, 2012 1 commit
    • Jingning Han's avatar
      hybrid transform of 16x16 dimension · de6dfa6b
      Jingning Han authored
      Enable ADST/DCT of dimension 16x16 for I16X16 modes. This change provides
      benefits mostly for hd sequences.
      
      Set up the framework for selectable transform dimension.
      
      Also allowing quantization parameter threshold to control the use
      of hybrid transform (This is currently disabled by setting threshold
      always above the quantization parameter. Adaptive thresholding can
      be built upon this, which will further improve the coding performance.)
      
      The coding performance gains (with respect to the codec that has all
      other configuration settings turned on) are
      
      derf:   0.013
      yt:     0.086
      hd:     0.198
      std-hd: 0.501
      
      Change-Id: Ibb4263a61fc74e0b3c345f54d73e8c73552bf926
      de6dfa6b
  10. 24 Aug, 2012 1 commit
    • Paul Wilkins's avatar
      New Motion Reference Search · 2d60bee1
      Paul Wilkins authored
      Alternative strategy for finding a list of candidate motion
      vectors to use as reference values in mv coding and as
      nearest and near.
      
      Sort by sad in vp8_find_best_ref_mvs() rather than just
      pick the best. Allow 0,0 as a best ref option but not a
      nearest or near unless there are no alternatives.
      
      Encode/Decode verified on at least some clips.
      
      Some commented out experimental and stats code still in place.
      
      Gain over existing code averages about 1% on derf (alll metrics)
      with improvement on all clips. Other test results pending.
      
      The entropy coding of the mode (nearest/near etc) still
      depends upon and requires the old "findnear" code so
      this needs looking at and may provide room for further gains.
      
      Change-Id: I871d7cba1d1c379c4bad9bcccce1fb19c46b8247
      2d60bee1
  11. 20 Aug, 2012 1 commit
    • Ronald S. Bultje's avatar
      Superblock coding. · 5d4cffb3
      Ronald S. Bultje authored
      This commit adds a pick_sb_mode() function which selects the best 32x32
      superblock coding mode. Then it selects the best per-MB modes, compares
      the two and encodes that in the bitstream.
      
      The bitstream coding is rather simplistic right now. At the SB level,
      we code a bit to indicate whether this block uses SB-coding (32x32
      prediction) or MB-coding (anything else), and then we follow with the
      actual modes. This could and should be modified in the future, but is
      omitted from this commit because it will likely involve reorganizing
      much more code rather than just adding SB coding, so it's better to let
      that be judged on its own merits.
      
      Gains on derf: about even, YT/HD: +0.75%, STD/HD: +1.5%.
      
      Change-Id: Iae313a7cbd8f75b3c66d04a68b991cb096eaaba6
      5d4cffb3
  12. 11 Aug, 2012 1 commit
    • Yaowu Xu's avatar
      extend the range of encoding time · b91219e2
      Yaowu Xu authored
      The commit also corrects unit of encoding from microsecond to
      milisecond.
      
      Change-Id: I030108e90f89f33dfad2d092dc8991db81979715
      b91219e2
  13. 10 Aug, 2012 1 commit
  14. 07 Aug, 2012 1 commit
    • Yaowu Xu's avatar
      a new way of determining reference motion vector · 8b2f57d0
      Yaowu Xu authored
      Using surrounding reconstructed pixels from left and above to select
      best matching mv to use as reference motion vector for mv encoding.
      
      Test results:
             AVGPSNR  GLBPSNR VPXSSIM
      Derf:  1.107%   1.062%  0.992%
      Std-hd:1.209%   1.176%  1.029%
      
      Change-Id: I8f10e09ee6538c05df2fb9f069abcaf1edb3fca6
      8b2f57d0
  15. 03 Aug, 2012 2 commits
    • Deb Mukherjee's avatar
      Merging in high_precision_mv experiment · 2af5473a
      Deb Mukherjee authored
      Merged in the high_precision_mv experiment to make it easier
      to work on new mv encoding strategies. Also removed
      coef_update_probs3().
      
      Change-Id: I82d3b0bb642419fe05dba82528bc9ba010e90924
      2af5473a
    • Daniel Kang's avatar
      16x16 DCT blocks. · fed8a183
      Daniel Kang authored
      Set on all 16x16 intra/inter modes
      
      Features:
      - Butterfly fDCT/iDCT
      - Loop filter does not filter internal edges with 16x16
      - Optimize coefficient function
      - Update coefficient probability function
      - RD
      - Entropy stats
      - 16x16 is a config option
      
      Have not tested with experiments.
      
      hd:     2.60%
      std-hd: 2.43%
      yt:     1.32%
      derf:   0.60%
      
      Change-Id: I96fb090517c30c5da84bad4fae602c3ec0c58b1c
      fed8a183
  16. 31 Jul, 2012 1 commit
    • Deb Mukherjee's avatar
      Merging and bug-fix in enhanced_interp experiment · 0ebf548c
      Deb Mukherjee authored
      Merged the enhanced_interp experiment.
      Found and fixed a bug in the include files framework, whereby
      certain encoder files were still using the old INTERP_EXTEND
      value of 3 instead of 4. The thresholds for mv range mcomp.c
      need a small adjustment to prevent crashes.
      
      The results are more or less unchanged.
      
      Change-Id: Iac5008390f1efc97ce1102fbb5f8989c847fb579
      0ebf548c
  17. 30 Jul, 2012 1 commit
    • Deb Mukherjee's avatar
      Adds support for switchable interpolation filters. · 52597441
      Deb Mukherjee authored
      Allows for swtiching/setting interpolation filters at the MB
      level. A frame level flag indicates whether to use a specifc
      filter for the entire frame or to signal the interpolation
      filter for each MB. When switchable filters are used, the
      encoder chooses between 8-tap and 8-tap sharp filters. The
      code currently has options to explore other variations as well,
      which will be cleaned up subsequently.
      
      One issue with the framework is that encoding is slow. I
      tried to do some tricks to speed things up but it is still slow.
      Decoding speed should not be affected since the number of
      filter taps remain unchanged.
      
      With the current version, we are up 0.5% on derf on average but
      some videos city/mobile improve by close to 4 and 2% respectively.
      If we did a full-search by turning the SEARCH_BEST_FILTER flag
      on, the results are somewhat better.
      
      The framework can be combined with filtered prediction, and I
      seek feedback regarding that.
      
      Rebased.
      
      Change-Id: I8f632cb2c111e76284140a2bd480945d6d42b77a
      52597441
  18. 27 Jul, 2012 1 commit
    • Deb Mukherjee's avatar
      Merges several experiments · 9984a155
      Deb Mukherjee authored
      The following five experiments are merged:
      
      newentropy
      newupdate
      adaptive_entropy (also includes a couple of parameter changes
                        that improves results a little
                        in common/entropymode.c and encoder/modecosts.c
                        that were not merged from the internal branch)
      newintramodes
      expanded_coef_context
      
      Change-Id: I8a142a831786ee9dc936f22be1d42a8bced7d270
      9984a155
  19. 17 Jul, 2012 1 commit
  20. 27 Jun, 2012 1 commit
    • Adrian Grange's avatar
      Added Prediction Filter to Mode Selection · bbc926dc
      Adrian Grange authored
      Added the ability to optionally filter the prediction data
      when inter modes are selected (excludes SPLITMV, for now).
      
      The mode selection loop considers both the filtered and
      non-filtered prediction data when choosing mode. The filter
      can be turned on/off at the frame-level, or signaled for
      each MB.
      
      Change-Id: I1b783c71d95a361ab36c761b07e8a6b06bc36822
      bbc926dc
  21. 26 Jun, 2012 1 commit
    • Deb Mukherjee's avatar
      Continued adaptive entropy coding · f3dff402
      Deb Mukherjee authored
      Incorporates mv_ref, mbsplit and second_mv into the adaptive
      entropy framework. The mv_ref framework has been modified from
      before.
      
      Adds some clean-ups and fixes.
      
      Results with the adaptive entropy experiment are currently up by
      +1.93% on derf; +2.33% std-hd and +1.87% yt-hd.
      
      Fixed a nasty intermittent bug.
      
      Change-Id: I4b1ac9f9483b48432597595195bfec05f31d1e39
      f3dff402
  22. 15 Jun, 2012 1 commit
    • Deb Mukherjee's avatar
      Adaptive entropy coding of coefficients, modes, mv. · 1fe85a35
      Deb Mukherjee authored
      This patch incorporates adaptive entropy coding of coefficient tokens,
      and mode/mv information based on distributions encountered in a frame.
      Specifically, there is an initial forward update to the probabilities
      in the bitstream as before for coding the symbols in the frame, however
      at the end of decoding each frame, the forward update to the
      probabilities is reverted and instead the probabilities are updated
      towards the actual distributions encountered within the frame.
      The amount of update is weighted by the number of hits within each
      context.
      
      Results on derf/hd/std-hd are all up by 1.6%.
      
      On derf, the most of the gains come from coefficients, however for the
      hd and std-hd sets, the most of the gains come from the mode/mv
      information updates.
      
      Change-Id: I708c0e11fdacafee04940fe7ae159ba6844005fd
      1fe85a35
  23. 08 Jun, 2012 1 commit
    • Paul Wilkins's avatar
      Key frame and GF sizing changes. · 0cb4985b
      Paul Wilkins authored
      Changes to the equations for kf and gf minQ and to
      the boost calculations for kg and gf
      
      Change-Id: I312031c910e6a575334f49075c32f49a8dfff239
      0cb4985b
  24. 30 May, 2012 1 commit
    • Paul Wilkins's avatar
      Rate control fix. · b8c36905
      Paul Wilkins authored
      This fix addresses some problems with very complex clips like
      handling of flashes on clips like crew (which was made worse
      by an earlier patch (derf and std-hd)).
      
      Most clips a small effect but some between 1 & 2%
      
      Derf +0.039, +0.211%
      YT +0.042, +0.083%
      
      Change-Id: I65fc7c13afc31482040068544dd65b8808f5cb4a
      b8c36905
  25. 29 May, 2012 1 commit
    • Paul Wilkins's avatar
      Remove "est_max_qcorrection_factor" · f66747fe
      Paul Wilkins authored
      Removed the local scaling factor est_max_qcorrection_factor
      and related code to simplify estimateq calculation (little effect
      anyway)
      
      Cap range of total correction factor.
      
      Slight change to break out case to turn off arf.
      
      Change-Id: I748187737ba93cfadf016f3dfdf8d2741934067f
      f66747fe
  26. 15 May, 2012 2 commits
    • Ronald S. Bultje's avatar
      Rewrite reference frame costing in the RD loop. · 0b8a95a0
      Ronald S. Bultje authored
      I now see I didn't write a very long description, so let's do it
      here then. We took a pretty big quality hit (0.1-0.2%) from my
      recent fix of the inversion of arguments to vp8_cost_bit() in the
      RD reference frame costing. I looked into it and basically the
      costing prevented us from switching reference frames. This is of
      course silly, since each frame codes its own prob_intra_coded, so
      using last frame cost indications as a limiting factor can never
      be right.
      
      Here, I've rewritten that code to estimate costings based partially
      on statistics from progress on current frame encoding. Overall,
      this gives us a ~0.2%-0.3% improvement over what we had previously
      before my argument-inversion-fix, and thus about ~0.4% over current
      git (on derf-set), and a little more (0.5-1.0%) on HD/STD-HD/YT.
      
      Change-Id: I79ebd4ccec4d6edbf0e152d9590d103ba2747775
      0b8a95a0
    • Deb Mukherjee's avatar
      Adds new Directional Intra prediction modes. · c5ddb7f0
      Deb Mukherjee authored
      Adds 6 directional intra predictiom modes for 16x16 and 8x8 blocks.
      
      Change-Id: I25eccc0836f28d8d74922e4e9231568a648b47d1
      c5ddb7f0
  27. 11 May, 2012 1 commit
    • Paul Wilkins's avatar
      First pass overhaul preparatory change. · 35358320
      Paul Wilkins authored
      This is the first patch in a series of changes to the first
      pass code. (Broken down for ease of testing/merging/review).
      
      This patch introduces a new stats element "sr_coded_error".
      This is the coded error recorded vs the second reference
      frame (which is updated such that it lags by at least one frame).
      No use is made of the new structure in this change so this patch
      should have no material effect.
      
      Removed some ifdefs and deprecated code (#if NEW_BOOST).
      Removed twopass.gf_decay_rate (not used any more)
      
      Change-Id: I1be672a73017f7c13fd50fb4f99236aa2ed30916
      35358320
  28. 08 May, 2012 1 commit
    • Yaowu Xu's avatar
      a number of fixes to entropy stats collection · 54cf1d9a
      Yaowu Xu authored
      1. block types
      There are only three types of blocks for 8x8 transformed MBs, i.e. Y
      block with DC does not exist for 8x8 transformed MBs as all MB using
      8x8 transform have 2nd order haar transform. This commit introduced
      a new macro BLOCK_TYPES_8X8 to reflect such fact.
      
      2. context counters
      This commit also fixed the mixed of context_counters between 4x4 and
      8x8 transformed MBs. The mixed use of the counters leads me to think
      the existing the context probabilities were not properly generated
      from 8x8 transformed MBs.
      
      3. redundant collecting in recoding
      The commit also corrected the code that accumulates entropy stats by
      making sure stats only collected for final packing, not during the
      recode loop
      
      Change-Id: I029f09f8f60bd0c3240cc392ff5c6d05435e322c
      54cf1d9a
  29. 26 Apr, 2012 1 commit
    • Deb Mukherjee's avatar
      Adds search option for best interpolation filter. · acdda50a
      Deb Mukherjee authored
      Adds a speed feature to conduct a brute force search among a set of
      available interpolation filters for the best one in an RD sense.
      
      There is a gain of 0.4% on derf, 1.0% on Std-HD.
      
      Patch 2: A macro added to determine if the encoder state is reset
      for each new filter tried.
      
      Patch 3: rebase, also fixes a bug (decodframe.c) introduced by a
      couple of missing function pointer assignements.
      
      Patch 4: rebase.
      
      Change-Id: Ic9ccca9d8c35c6af557449ae867391a2f996cc29
      acdda50a
  30. 25 Apr, 2012 1 commit
    • Yaowu Xu's avatar
      Merge UVINTRA experiment · c1814d26
      Yaowu Xu authored
      The commit merges the UVINTRA experiment and removed the related
      macros. The overall effect of the experiment is a small gain (.1%
      on derf)
      
      Change-Id: Ia34b3312fb9b5b34c9ba111bf0fa78c6f78ac80b
      c1814d26
  31. 18 Apr, 2012 1 commit
  32. 17 Apr, 2012 1 commit
    • Yaowu Xu's avatar
      Added intra mode probabilites into coding_context · 31afc770
      Yaowu Xu authored
      These contexts need to be saved and restored for recode, otherwise
      encoder/decoder mismatch happens for some clips (eg._mobcal 720p)
      
      Change-Id: Ic65cfa0bf56ed0472ecab962ce31394d59d344bf
      31afc770
  33. 11 Apr, 2012 2 commits
    • Paul Wilkins's avatar
      Refactoring of encode loop and bitstream packing · 13c6d1a8
      Paul Wilkins authored
      Some code re-factored / moved to allow the main
      pack operation inside the recode loop so  that the
      size estimate is accurate.
      
      Deletion of some redundant code relating to one pass.
      
      Aproximate improvement over March 27 code base:
      Derf 0.0%, YT 0.5%, YThd 0.3% Std_hd 0.25%
      
      Change-Id: Id2d071794ab44f0b52935f6fcdb5733d09a6bb86
      13c6d1a8
    • Paul Wilkins's avatar
      T8x8 zbin and rate control changes. · a3392d57
      Paul Wilkins authored
      Some adjustments to zbin for t8x8.
      Changes to rules for sizing forced key frames.
      Some extra stats output in tmp.stt.
      
      Approximate  gain on YT-hd set 0.5%
      
      There are still issues in sizing key frames and gf/arf frames
      when the image is largely static. These in part relate to
      problems with cost estimates in the recode loop.
      
      Change-Id: I6f0159dc8a8faeab4115a19c668d442491619a68
      a3392d57