GitLab

This fixes a mismatch which occurs when global/warped motion and
a masked compound type are used together.

Change-Id: I08b2702cdb3b85f8d8817b9286a73951c97cf379

BUG=aomedia:490
BUG=aomedia:491
BUG=aomedia:494

Change-Id: I20a375dc6f76a3f3de520e452b3b9b0d4ace0ee0

Offset the buffer pointers of sub8x8 chroma components to support
the coding process at bottom right 8x8 block.

Change-Id: Ide17ee31ce064484371194cbbade88603d114a2e

Clarifies in the code that the wedge smoothing
functions can in fact be generated by shift of three 1-D
prototypes. Also changes the smoothing function a little
which gives a slight improvement.
Also includes some generic cleanups.

Change-Id: I5735e0021d50c36c42509d4fc0939e7220564571

Change-Id: I9b6f99768c60e743d2fadfaabc532e7c15dc40f3

This reverts commit 5ca25dfc.

It breaks high-bitdepth builds with:
--enable-aom-highbitdepth --enable-experimental --enable-dual-filter
--enable-entropy --enable-ext-inter --enable-ext-intra
--enable-ext-partition-types --enable-ext-refs --enable-ext-tx
--enable-filter-intra --enable-loop-restoration

or more simply:
--enable-aom-highbitdepth --enable-experimental --enable-ext-inter

BUG=aomedia:463

Change-Id: If814131e634e4411569859f7426efafe158b83fd

Change-Id: I359d100548ed337d643a421591243565b08945ed

Missing features:
* RDOPT (Forced on for certain blocks)
* Any form of border extension
* Non MI sized right and bottom edges
* MV prediction

Present features:
* Force intrabc for some blocks
* Carry intrabc in the bitstream
* Validate DV is causal
* Reconstruct intrabc block assuming border extension is unnecessary

Change-Id: Ib1f6868e89bfacc2a4edfc876485bad1b347263b

This creates a central function which defines when a
block should be warped. It also refactors the
WARPED_MOTION code so that all calls to av1_warp_plane
happen in the same location.

No change in performance.

Change-Id: Icaf9ec7700d34523809258594bb9843bb2975f46

Adds an option to disable warp when obmc is used with a
global motion neighbor.

Change in BDRATE on cam_lowres
gm + obmc enabled: 0.035%
gm + obmc + wm enabled: -0.005%

Change-Id: I1d6de75c7ead325cec31ed3748b5532f3658d8a7

Rename '--enable-aom-highbitdepth' to '--enable-highbitdepth'

Change-Id: I1de13c3508c30c552532993419d8ace326142ab6

The SSE3 convolve functions do not work when scaling is involved. If
either x_step_q4 or y_step_q4 is not 16 scaling will occur and an assert
fails.

This patch creates a C version of av1_convolve, av1_convolve_c. This
function in turn calls all C versions of what av1_convolve calls. New C
versions of these called functions have been created where needed and
the same for the functions they call. This means that when scaling is
enabled no asserts fail. av1_convolve_c is called instead of
av1_convolve when x_step_q4 or y_step_q4 is not 16.

Change-Id: I604d2716e034e23a0553fb7004133d3075514a7a

Adds an option to disable warp when obmc is used with a
warped motion neighbor.
This change will reduce the line buffer requirement for
mode/mv information since the warping parameters no longer
need to be stored.

Results: 0.05% increase in BDRATE on lowres

Change-Id: I98bd2dcdbbcd47e44f199803ed8996b0f3fd1756

Enabling SEPARATE_GLOBAL_MOTION will remove the ability for
a block that uses zeromv with global motion to pick warped_causal
or obmc_causal as the motion mode. When this is enabled there is:

0.05% drop on lowres for global + warped enabled
0.15% drop on midres for global + warped enabled

0.12% drop on lowres with global + motion var enabled
0.07% drop on midres with global + motion var enabled
No performance change for global, warped, or motion var individually.

Change-Id: Idbfb8dd7a93da14902438504b06a08e5212e48cb

The offset of neighbors is communicated to av1_make_inter_predictors
so as to use the correct mi in gm warping

Change-Id: I471bbdf2112ed678969492b11730f15d9527eb7e

One codepath originally skipped a function which forks between
gm prediction and regular inter prediction. This change fixes this
for both high bit depth and regular bit depth.

Change-Id: I741d67a7c89eb6eb0cd35c02219739dc3ddb3841

Enable obmc mode only when there are <= 2 left neighbors and <=2
above neighbors. Also disable it when there is no overlappable
neighbors.

Gain in AWCY test: 1.60%, was 1.64% when there is no restriction

Change-Id: I2d82ef4fb4daa9b0843ac8844f99b9f412c4f379

Change-Id: I43207cabac921fee77d19855abe49868dfd98bd1

This CL aim at facilitating hardware implementation
The check will be turned on once we have faster motion vector
coding system

Performance drop
lowres 0.157%
midres 0.260%

Change-Id: Iedc961f44efadfe84ff9edab408f44845bffcfe9

If there no sub-pixel in both direction of MV,
the interp_filter is set to EIGHTTAP_REGULAR

Change-Id: I208c34906544f1937c57d78017999be6eddd9e87

Change-Id: I532e46b3947ca3f5898a2da61fb6b82c2f4bd5c6

This allows Y and UV planes use different filter kernel

Change-Id: I524aa3f6ffbc439acee6660bdbaf5cf2059379b5

This CL allows us to use different interpolation filters for
YUV planes.

Change-Id: I9446d43ae2be5a9a48b8a4cb6efcac43df6196d5

The only compound mode used with sub 8x8 blocks is COMPOUND_AVERAGE, so
we don't have to send anything in this case

Change-Id: I90d0162e5f7f1ad205e65094293cde2a48eb77b1

When convolve_round is on, av1_convolve_2d_facade will be used for
interpolation rather than av1_convolve. Will remove the experiment
code of convolve_round experiment from av1_convolve in another CL.

So far we use 4-bit rounding in the intermediate stage on top of using
post rounding for compound mode after the last stage.

This will give us roughly 0.45% gain on lowres , 0.39% on midres and
roughly 0.6-0.7% on hdres
Altogether, is 1.15% on lowresm, 0.74% on midres and roughly 1.7-1.8% on
hdres

Note that there no restriction usage of 12-tap filter in the CL.
Adding that, we will lose roughly 0.1% again on lowres.

Change-Id: I6332e1d888e28a3b3ddc29711817d66e52cb5cdf

Allow the above combination of experiments to work together
correctly, fixing an encode/decode mismatch bug when they
were all enabled.

This change causes build_masked_compound(_highbd) to only
ever be called if CONFIG_SUPERTX is off, so wrap these functions
in an '#if !CONFIG_SUPERTX' block.

BUG=aomedia:313

Change-Id: Ic3886bc69ba9624b8fcb0a4c2d71fc64d2c0f22c

Change-Id: I2a490e144099d7692296992528192c1f11d2c06f

By turning on CONVOLVE_POST_ROUNDING, in the compound inter
prediction mode, FILTER_BITS rounding is moved after the summation
of two predictions.

Note that the post rounding is only applied on non-sub8x8 block

       PSNR     BDRate
lowres -0.808%  -0.673%

Change-Id: Ib91304e6122c24d832a582ab9f5757d33eac876c

Those functions includes
av1_make_inter_predictor
av1_build_inter_predictor
inter_predictor

Change-Id: Ide3b744277cf30964e8b352fc8de91365d7217a8

Adds a few options to make the compound mask lightly dependent on the
the two predictors.

Also adds high bit depth support

Change-Id: If57b6e8ddd140e0c00fd9d4738927d37225091cb

Change-Id: Id2537c8826e07ad6605aaa9858ba6d797bcd23a5

Use a round flag in ConvolveParams to indicate if the destination buffer
has the result rounded by FILTER_BITS or not.
This CL is part of the goal of reducing interpolation rounding error in
compound prediction mode.

Change-Id: I49e522a89a67a771f5a6e7fbbc609e97923aecb6

Change-Id: I7c992c9aae895aebcfb5c147cb179cf665c0ac10

Change-Id: I0ebd6951d2b42869ae872b33f63a07db03e99c62

This uses a segmentation mask (which is temporarily computed arbitrarily)
to blend predictors in compound prediction. The mask will be computed
using a color segmentation in a followup patch.
Change-Id: I2d24cf27a8589211f8a70779a5be2d61746406b9

No need of special handle on sub8x8 block sizes.

Change-Id: I8487cd68eda0882fe50550af3998dc941ec13b21

Relative to previous ext-inter:
lowres: -0.177%
     or -0.029% (with USE_RECT_INTERINTRA = 0)

* When predicting interintra modes, the previous code did not provide
  the intra predictor with the correct context during rdopt. Add an
  explicit 'ctx' parameter to the relevant functions, to provide this
  context.
  This fixes a nondeterminism bug, which was causing test failures in
  *EncoderThreadTest*

* For rectangular blocks, build_intra_predictors_for_interintra needs
  to overwrite part of the context buffer in order to set up the
  correct context for intra prediction. We now restore the original
  contents afterwards.

* Add a flag to enable/disable rectangular interintra prediction;
  disabling improves encoding speed but reduces BDRATE improvement.

Change-Id: I7458c036c7f94df9ab1ba0c7efa79aeaa7e17118

No change in performance

Change-Id: Ie105a7baf6a2c2258d3ef117e727957e4393f51b

Change-Id: I2047adc4c147201ce0ce3c533fe2861cbff1002c

This CL will cause
0.122% PSNR drop on lowres dataset
0.059% PSNR drop on midres dataset

However, it will facilitate hardware implementation.

Change-Id: I0a0713acacbfd571509a721337711c021915dd3c