1. 19 Oct, 2012 3 commits
    • John Koleszar's avatar
      calculate probs consistently · 91dc8ce7
      John Koleszar authored
      There were several different methods for calculating bitstream
      probabilities in use. Consolodate these into a pair of functions,
      get_prob() and get_binary_prob().
      
      Change-Id: I5534f517f74027fee16d89c9baefaafea8156b2f
      91dc8ce7
    • John Koleszar's avatar
      Remove bc, bc2 from pbi,cpi,xd · e9fd1eac
      John Koleszar authored
      Pass the bool coder to be used explicitly. This avoids cases where two
      different bool coders can be addressed from the same function. Also be
      more consistent with bool coder variable naming, start to standardize
      on 'bc'.
      
      Change-Id: I1c95e2fdbe24ebe8c0f84924daa1728e3b054a31
      e9fd1eac
    • Deb Mukherjee's avatar
      Some cleanups and fixes. · f3208f36
      Deb Mukherjee authored
      Separates the logic on transform type selection previously spread out
      over a number of files into a separate function. Currently the tx_type
      field in b_mode_info is not used, but still left in there to eventually
      use for signaling the transform type in the bitstream.
      
      Also, now for tx_type = DCT_DCT, the regular integer DCT is used, as
      opposed to the floating point DCT used in conjuction with hybrid
      transform.
      
      Results change somewhat due to the transform change, but are within
      reasonable limits. The hd/std-hd sets are slightly up, while derf/yt
      are slightly down.
      
      Change-Id: I5776840c2239ca2da31ca6cfd7fd1148dc5f9e0f
      f3208f36
  2. 18 Oct, 2012 2 commits
  3. 17 Oct, 2012 6 commits
  4. 16 Oct, 2012 2 commits
  5. 15 Oct, 2012 11 commits
    • Ronald S. Bultje's avatar
      Remove test from B_MODE_INFO. · 23a64c89
      Ronald S. Bultje authored
      It is essentially a duplicate of mode for RD-only purposes. Removing it
      saves us 4 bytes per B_MODE_INFO, or ~0.5MB for a 1080p video encode.
      
      Change-Id: I0a54db5f51658b3946d7efb1ca6e8cfbda0cdf88
      23a64c89
    • Ronald S. Bultje's avatar
      Remove mode_rdopt from MB_MODE_INFO. · 66180f22
      Ronald S. Bultje authored
      The variable is essentially a duplicate of mode for RD-only purposes.
      Removing it gives identical results, and saves 4 bytes per macroblock
      (i.e. 32.5kB for a 1080p HD video encode).
      
      Change-Id: I22d5058fdb80ab0b69862caee825e9d86bb148b3
      66180f22
    • Ronald S. Bultje's avatar
      Properly use chroma block object for chroma coefficient costing. · 1d87f9c1
      Ronald S. Bultje authored
      Change-Id: Ieb38c7aae91dbaca4a8add204fa84e1cfc459933
      1d87f9c1
    • Ronald S. Bultje's avatar
      Add a new token stuffing function vp8_stuff_mb(). · e7881462
      Ronald S. Bultje authored
      This way a caller doesn't need to implement the logic for which (and how
      many) tokens to write out to stuff one macroblock worth of EOBs. Make
      the actual function implementations static, since they are now only used
      in tokenize.c; also do some minor stylistic changes so it follows the
      style guide a little more closely; use PLANE_TYPE where appropriate,
      remove old (stale) frame_type function arguments; hardcode plane type
      where only a single one is possible (2nd order DC or U/V EOB stuffing);
      support stuffing 8x8/4x4 transform EOBs with no 2nd order DC.
      
      Change-Id: Ia448e251d19a4e3182eddeb9edd034bd7dc16fa3
      e7881462
    • Ronald S. Bultje's avatar
      Add and consistently use PLANE_TYPE. · 41e3a9ef
      Ronald S. Bultje authored
      Change the macros PLANE_TYPE_{Y_NO_DC,Y2,UV,Y_WITH_DC} to a typed enum,
      and use this typed enum consistently across all places where relevant.
      In places where the type is implied (e.g. in functions that only handle
      second order planes or chroma planes), remove it as a function argument
      and instead hardcode the proper enum in the code directly.
      
      Change-Id: I93652b4a36aa43163d49c732b0bf5c4442738c47
      41e3a9ef
    • Ronald S. Bultje's avatar
      Merge duplicate loops in tokenization code. · 5cfff7ce
      Ronald S. Bultje authored
      Also merge the three occurrences of 4x4 chroma block writing into a
      single function, and call that function instead of duplicating the
      4x4 chroma tokenization code in 3 places.
      
      Change-Id: I7913538d1029f709b0e3ae49fff1148d3be9eeb9
      5cfff7ce
    • Ronald S. Bultje's avatar
      Minor refactoring in encodeintra.c. · a0ad521c
      Ronald S. Bultje authored
      Merge code blocks for different transform sizes; use MACROBLOCKD as a
      temp variable where that leads to smaller overall source code; remove
      duplicate code under #if CONFIG_HYBRIDTRANSFORM/#else blocks. Some style
      changes to make it follow the style guide a little better.
      
      Change-Id: I1870a06dae298243db46e14c6729c96c66196525
      a0ad521c
    • Ronald S. Bultje's avatar
      Make optimize_mb_16x16() static. · e7a4bcca
      Ronald S. Bultje authored
      It is not used outside this file.
      
      Change-Id: Id0947180edab4c5f1f50589863350b21e97c25f1
      e7a4bcca
    • Ronald S. Bultje's avatar
      Remove assignment in vp8_optimize_mby_16x16(). · 781f6ad7
      Ronald S. Bultje authored
      The result of the assignment is unused.
      
      Change-Id: Id94b790baa6451f24e9aeda6f036390388d93921
      781f6ad7
    • Ronald S. Bultje's avatar
      Remove duplicate code in optimize_mb_NxN vs. vp8_optimize_mby/uv_NxN(). · 11e42d46
      Ronald S. Bultje authored
      Instead, just call vp8_optimize_mby/uv_NxN() inside optimize_mb_NxN().
      
      Change-Id: Ief941064d86db4277ba02e990a26819144b55f7c
      11e42d46
    • Ronald S. Bultje's avatar
      Remove duplicate or unused code in encoder/encodemb.c. · 238ed517
      Ronald S. Bultje authored
      Also make some minor stylistic changes to bring the code closer to
      the style guide. Remove distinction between inter and intra transform
      functions, since both do exactly the same thing except for the check
      against SPLITMV for the second-order transform. Remove some commented
      out debug code. Remove 8x8/16x16 transform code in encode_inter16x16y(),
      since the first-pass only uses 4x4 anyway.
      
      Change-Id: Ife54816ff759825b9141f95dc2ba43c253c14dba
      238ed517
  6. 14 Oct, 2012 5 commits
  7. 12 Oct, 2012 4 commits
  8. 11 Oct, 2012 2 commits
  9. 10 Oct, 2012 1 commit
    • Jim Bankoski's avatar
      convert copy16x16 to rtcd · 89f060e8
      Jim Bankoski authored
      Convert copy16x16 from invoke to rtcd.  The first in a long
      string of converts.
      
      Change-Id: I296b0aa32f40e9fb649f7a3cb914a4e5300cad63
      89f060e8
  10. 09 Oct, 2012 2 commits
    • John Koleszar's avatar
      write_kfmodes: use update_skip_probs() · d94d2b75
      John Koleszar authored
      Use the common update_skip_probs() function rather than duplicating its
      logic in write_kf_modes().
      
      Change-Id: I2890a28f6907cb79ffe0fb21d20f0ef98b85cdd9
      d94d2b75
    • Ronald S. Bultje's avatar
      Selectable transform size try 2. · 9ca3c8b2
      Ronald S. Bultje authored
      Results: derf (vanilla or +hybridtx) +0.2% and (+hybrid16x16
      or +tx16x16) +0.7%-0.8%; HD (vanilla or +hybridtx) +0.1-0.2%
      and (+hybrid16x16 or +tx16x16) +1.4%, STD/HD (vanilla or +hybridtx)
      about even, and (+hybrid16x16 or +tx16x16) +0.8-1.0%.
      
      Change-Id: I03899e2f7a64e725a863f32e55366035ba77aa62
      9ca3c8b2
  11. 05 Oct, 2012 2 commits
    • Deb Mukherjee's avatar
      Mismatch bug-fix when transform expts are off · 105746c8
      Deb Mukherjee authored
      A variety of issues related to tangling of various hybrid transform
      experiments.
      
      Change-Id: I84dac65ff513f8b024407760df55fffa95e198de
      105746c8
    • Paul Wilkins's avatar
      Fix SIMD unsafe use of floating point. · 81c60419
      Paul Wilkins authored
      This commit fixes unsafe simd / floating point interactions arising
      from the current hybrid and 16x16 transform implementation.
      These led to a raft of bugs and issues when the project was
      built using VS2008 for Win32 though they did not show up with
      the unix builds.
      
      Gerrit makes a meal out of presenting the fix but all I have actually
      done is indent the body of each function that uses floating point by
      one level and bracket with emms instructions using  the function
      vp8_clear_system_state(). See below.
      
      function () {
        vp8_clear_system_state();
        {
        ... function body
        }
        vp8_clear_system_state();
      }
      
      This is almost certainly over the top in terms of number of emms
      instructions but is a temporary measure pending implementation of
      integer variants of each function to replace the floating point.
      
      Limited testing suggests that this fixes the problems that arose for
      Win32 VS2008 when the hybrid or 16x16 transforms were enabled.
      
      Change-Id: I7c9a72bd79315246ed880578dec51e2b7c178442
      81c60419