1. 14 Jan, 2011 4 commits
    • Paul Wilkins's avatar
      Testing of modes with Alt Ref frame · 415371c9
      Paul Wilkins authored
      Previously when a frame was being overlaid on a previously coded
      alt ref frame we only checked the alt ref 0,0 mode. Where there is
      a possibility that the alt ref buffer is a filtered frame we should allow
      the other prediction modes as normal or at the least allow use of
      the last frame buffer.
      
      Change-Id: I4d6227223d125c96b4f3066ec6ec9484fee7768c
      415371c9
    • Adrian Grange's avatar
      ARNR filter pointer update bug fix · 2c1b06e6
      Adrian Grange authored
      In cases where the frame width is not a multiple of 16 the
      ARNR filter would go wrong.
      
      In vp8_temporal_filter_iterate_c when updating pointers
      at the end of a row of MBs,  the image size was
      incorrectly used rather than using Num_MBs_In_Row
      times 16 (Y) or 8 (U,V).
      
      This worked when width is multiple of 16 but failed
      otherwise.
      
      Change-Id: I008919062715bd3d17c7aa2562ab58d1cb37053a
      2c1b06e6
    • Paul Wilkins's avatar
      Experimental change to help with ARNR problem. · 72e22b0b
      Paul Wilkins authored
      Allow use of other reference frames for the ARF overlay frame
      when ARNR filtering is enabled
      
      Change-Id: Icd6a9fb38977a88fbe7cc9b9c18198eb454c0273
      72e22b0b
    • Paul Wilkins's avatar
      KF/GF Pulsing · c8338ebf
      Paul Wilkins authored
      This change is designed to try and reduce pulsing effects when moving
      with a complex transition like a fade, into an easy or static section in
      an otherwise difficult clip in CQ mode.
      
      The active CQ level is relaxed down to the user entered level for frames that
      are generating less than the passed in minimum bandwidth.
      
      Change-Id: Id6d8b551daad4f489c087bd742bc95418a95f3f0
      c8338ebf
  2. 13 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      One pass rate control correction. · eda7d538
      Paul Wilkins authored
      Fixed discrepancy cpi->ni_frames vs cm->current_video_frame > 150.
      
      Make one pass path explicit.
      
      There is still scope for some odd behaviour around the transition
      point at cpi->ni_frames > 150.
      
      Change-Id: Icdee130fe6e2a832206d30e45bf65963edd7a74d
      eda7d538
  3. 12 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Limit key frame quantizer for forced key frames. · 55acda98
      Paul Wilkins authored
      Where a key frame occurs because of a minimum interval
      selected by the user, then these forced key frames ideally need
      to be more closely matched in quality to the surrounding frame.
      
      Change-Id: Ia55b1f047e77dc7fbd78379c45869554f25b3df7
      55acda98
  4. 11 Jan, 2011 4 commits
    • Scott LaVarnway's avatar
      Moved ref frame calculations · 96fd758e
      Scott LaVarnway authored
      Moved ref frame calculations to outside of the
      mode_index loop.
      
      Change-Id: I06103fc7e8af88b54b84443acf6691d29b1272ac
      96fd758e
    • Johann's avatar
      use unaligned load · f50f2fd2
      Johann authored
      source buffer is not guaranteed to be aligned for odd size buffers
      
      Change-Id: Id0b1fd40ba3bd6c994bcfada788feccd2b53c5a9
      f50f2fd2
    • Yunqing Wang's avatar
      Add no_skip_block4x4_search flag in SPLITMV mode · 1546e6a8
      Yunqing Wang authored
      Add a flag to always enable block4x4 search for speed=0 (good
      quality) to guarantee no quality loss for speed0.
      
      Change-Id: Ie04bbc25f7e6a33a7bfa30e05775d33148731c81
      1546e6a8
    • Henrik Lundin's avatar
      Remove unused local variables · 48c28fc4
      Henrik Lundin authored
      Removing unused local variables causing compiler warnings in
      Visual Studio.
      
      Change-Id: I0e2096303be1fdbc01428a6e57cca9796bb32c8a
      48c28fc4
  5. 10 Jan, 2011 3 commits
    • Yunqing Wang's avatar
      Fix bug in motion search · 3675b229
      Yunqing Wang authored
      The maximum possible MV in 1/8 pel units is (1<<11), which could
      cause mvcost out of its range that is 1023. Change maximum
      possible MV in 1/8 pel units to (1<<11)-8 will fix this problem.
      
      Change-Id: I5788ed1de773f66658c14f225fb4ab5b1679b74b
      3675b229
    • Paul Wilkins's avatar
      Two Pass VBR change · cf7c4732
      Paul Wilkins authored
      Further experiment with restriction of the Q range.
      
      This uses the average non KF/GF/ARF quantizer,  instead
      of just relying on the initial value. It is not such a strong constraint
      but there may be a reduced risk of rate misses.
      
      Change-Id: I424fe782a37a2f4e18c70805e240db55bfaa25ec
      cf7c4732
    • Paul Wilkins's avatar
      Revert BASE_ERRPERMB · 405499d8
      Paul Wilkins authored
      Constant value reverted pending more tests
      on different video formats.
      
      Change-Id: I07d11a0e0185e60724698c835416caf2e0774e61
      405499d8
  6. 07 Jan, 2011 3 commits
    • Paul Wilkins's avatar
      CQ Mode · e0846c9c
      Paul Wilkins authored
      The merge includes hooks to for CQ mode and other code
      changes merged from the test branch.
      
      CQ mode attempts to maintain a more stable quantizer within a clip
      whilst also trying to adhere to a guidline maximum bitrate.
      
      The existing target data rate parameter is used to specify the
      guideline maximum bitrate.
      
      A new parameter allows the user to specify a target CQ level.
      
      For normal (non kf/gf/arf) frames, the quantizer will not drop BELOW the
      user specified value (0-63). However, in some cases the encoder may
      choose to impose a target CQ that is above that specified by the user,
      if it estimates that consistent use of the target value is not compatible
      with guideline maximum bitrate.
      
      Change-Id: I2221f9eecae8cc3c431d36caf83503941b25e4c1
      e0846c9c
    • Paul Wilkins's avatar
      Limit Q variability in two pass. · 3af3593c
      Paul Wilkins authored
      In two pass encoding each frame is given an active
      Q range to work with. This change limits how much this
      Q range can be altered over time from the initial estimate
      made for the clip as a whole.
      
      There is some danger this could lead to overshoot or undershoot
      in some corner cases but it helps considerably in regard to
      clips where either there is a glut or famine of bits in some sections,
      particularly near the end of a clip.
      
      Change-Id: I34fcd1af31d2ee3d5444f93e334645254043026e
      3af3593c
    • Scott LaVarnway's avatar
      Removed cpi->target_bits_per_mb · 6dbdfe34
      Scott LaVarnway authored
      cpi->target_bits_per_mb is currently not being used,
      so delete it.  Also removed other unused code in rdopt.c.
      
      Change-Id: I98449f9030bcd2f15451d9b7a3b9b93dd1409923
      6dbdfe34
  7. 06 Jan, 2011 2 commits
    • Johann's avatar
      x86 sse2 temporal_filter_apply · 8b0cf5f7
      Johann authored
      count can be reduced to short because the max number of filtered frames
      is set to 15. the max value for any frame is 32 (modifier = 16,
      filter_weight = 2). 15*32 = 480 which requires 9 bits
      
      this function goes from about 7000 us / 1000 iterations for the C code
      to < 275 us / 1000 iterations for sse2 for block_size = 16 and from
      about 1800 us / 1000 iters to < 100 us / 1000 iters for block_size = 8
      
      Change-Id: I64a32607f58a2d33c39286f468b04ccd457d9e6e
      8b0cf5f7
    • Paul Wilkins's avatar
      Disable some features for first pass. · 431dac08
      Paul Wilkins authored
      The following features don't make sense for the first
      pass in its current form and have a significant impact on its
      speed (up to 50%).
      
      Slow quantizer, slow dct and trellis optimization.
      
      Change-Id: Id9943f6765ffbd71fc0084ec7dfbc9d376fd6fcd
      431dac08
  8. 04 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Adjustment to boost calculation in two pass. · b095d9df
      Paul Wilkins authored
      Calculate a minimum intra value to be used in determining the
      IIratio scores used in two pass, second pass.
      
      This is to make sure sections that are low complexity" in the
      intra domain are still boosted appropriately for KF/GF/ARF.
      
      For now I have commented out the Q based adjustment of
      KF boost.
      
      Change-Id: I15deb09c5bd9b53180a2ddd3e5f575b2aba244b3
      b095d9df
  9. 29 Dec, 2010 2 commits
    • Scott LaVarnway's avatar
      Fixed encoder crash when mult-threading is enabled. · de4e8185
      Scott LaVarnway authored
      Happens in real-time mode.  Will happen in good quality, speed 1.
      
      Change-Id: I3e5b68827b1a5798d0431b088a709256d1ce2c95
      de4e8185
    • Yunqing Wang's avatar
      Always update last_frame_type · a864678c
      Yunqing Wang authored
      Scott pointed out that last_frame_type only gets updated while
      loopfilter exists. Since last_frame_type is also needed in
      motion search now, it needs to be updated every frame.
      
      Change-Id: I9203532fd67361588d4024628d9ddb8e391ad912
      a864678c
  10. 28 Dec, 2010 3 commits
    • Scott LaVarnway's avatar
      Use the fast quantizer for inter mode selection · 516ea846
      Scott LaVarnway authored
      Use the fast quantizer for inter mode selection and the
      regular quantizer for the rest of the encode for good quality,
      speed 1.  Both performance and quality were improved.  The
      quality gains will make up for the quality loss mentioned in
      I9dc089007ca08129fb6c11fe7692777ebb8647b0.
      
      Change-Id: Ia90bc9cf326a7c65d60d31fa32f6465ab6984d21
      516ea846
    • Yunqing Wang's avatar
      Adjust MV borders for SPLITMV mode · bf53ec49
      Yunqing Wang authored
      Add limits to avoid MV going out of range.
      
      Change-Id: I8a5deb40bf393488d29f694b5a56804d578e68b5
      bf53ec49
    • Yunqing Wang's avatar
      Modify motion estimation for SPLITMV mode · a5a8d929
      Yunqing Wang authored
      1. Search for block8x16/block16x8 uses block8x8's search results.
      2. Check block4x4 only if block8x8 is chosen. (This hurts quality,
         which will be improved in another check-in.)
      3. In block4x4 search, the previous block's result is used as
         MV predictor for next block.
      
      This change improves performance.
      
      Change-Id: I9dc089007ca08129fb6c11fe7692777ebb8647b0
      a5a8d929
  11. 24 Dec, 2010 1 commit
    • Yaowu Xu's avatar
      adjusted sad_per_bit to correlate with quantizer · 0f5264b5
      Yaowu Xu authored
      Re-calibrated sad_per_bit16 and sad_per_bit4 tables to linearly
      correlated to quantizer values, these two variables are used in
      motion search for costing motion vectors. This change has an small
      positive effect on compression.
      
      Change-Id: Ic9b5ea6fb8d5078ef663ba4899db019cc51f4166
      0f5264b5
  12. 22 Dec, 2010 3 commits
    • Johann's avatar
      improve integer version of filter · 20b855c3
      Johann authored
      the lookup table is based on floating point calculations (see source)
      
      by moving the *3 before the downshift and adding the rounding bit, the
      delta (LUT - integer) goes from:
      ______________________________________
      __ 1__ 1______________________________
      __ 1__ 1______________________________
      ____ 1______ 1________________________
      ____ 1 2__ 2 1________________________
      ______ 1 1 2__ 2__ 2__ 2 1 1__________
      ________ 1 1 2 2__ 1 2 3 1 2__ 2__ 2__
      to:
      __-1__-1______________________________
      ______________________________________
      ____-1______-1________________________
      ______________________________________
      ________-1______________-1____________
      ______________________________________
      
      it's important to be able to use the integer version because the LUT
      more or less precludes SIMD optimizations
      
      Change-Id: I45a81127dc7b72a06fba951649135d9d918386c0
      20b855c3
    • Johann's avatar
      temporal filter naming changes · 4b6219cb
      Johann authored
      be more consistant with the naming pattern, especially wrt rtcd
      
      Change-Id: I3df50686a09f1dab0a9620b5adbb8a1577b40f2f
      4b6219cb
    • Johann's avatar
      abstract apply_temporal_filter · 092b5bef
      Johann authored
      allow for optimized versions of apply_temporal_filter
      (now vp8_apply_temporal_filter_c)
      
      the function was previously declared as static and appears to have been
      inlined. with this change, that's no longer possible. performance takes
      a small hit.
      
      the declaration for vp8_cx_temp_filter_c was moved to onyx_if.c because
      of a circular dependency. for rtcd, temporal_filter.h holds the
      definition for the rtcd table, so it needs to be included by onyx_int.h.
      however, onyx_int.h holds the definition for VP8_COMP which is needed
      for the function prototype. blah.
      
      Change-Id: I499c055fdc652ac4659c21c5a55fe10ceb7e95e3
      092b5bef
  13. 17 Dec, 2010 1 commit
    • John Koleszar's avatar
      Add psnr/ssim tuning option · b0da9b39
      John Koleszar authored
      Add a new encoder control, VP8E_SET_TUNING, to allow the application
      to inform the encoder that the material will benefit from certain
      tuning. Expose this control as the --tune option to vpxenc. The args
      helper is expanded to support enumerated arguments by name or value.
      
      Two tunings are provided by this patch, PSNR (default) and SSIM.
      Activity masking is made dependent on setting --tune=ssim, as the
      current implementation hurts speed (10%) and PSNR (2.7% avg,
      10% peak) too much for it to be a default yet.
      
      Change-Id: I110d969381c4805347ff5a0ffaf1a14ca1965257
      b0da9b39
  14. 16 Dec, 2010 2 commits
    • Scott LaVarnway's avatar
      Changed segmentation check order · 64baa8df
      Scott LaVarnway authored
      In SPLITMV, the 8x8 segment will be checked first.  If the 8x8 rd
      is better than the best, we check the other segments.  Otherwise
      bail.  Adjustments to the thresh_mult were necessary to make
      up for the initial quality loss.
      The performance improved by 20% (average) for good quality,
      speed 0 and speed 1, while the overall quality remained the same.
      
      Change-Id: I717aef401323c8a254fba3e9777d2a316c774cc3
      64baa8df
    • Scott LaVarnway's avatar
      Adjusted breakout RD for SPLITMV · 81cdeb71
      Scott LaVarnway authored
      vp8_rd_pick_best_mbsegmentation looks at y only.  The new
      breakout does not include the frame cost, the prob_skip_false
      cost, or the uv rate.  Performance improved by a few percent
      and the quality remained the same.
      
      Change-Id: I94ff013998ac51e8ecce7130870f7b6600758e15
      81cdeb71
  15. 14 Dec, 2010 4 commits
    • Yunqing Wang's avatar
      Fix a bug in motion search code(2) · 08706a3e
      Yunqing Wang authored
      This fix added MV range checks for NEWMV mode as suggested by Jim.
      To reduce unnecessary MV range checks, I tried Yaowu's suggestion.
      Update UMV borders in NEWMV mode to also cover MV range check.
      Also, in this way, every MV that is valid gets checked in diamond
      search function.
      
      Change-Id: I95a89ce0daf6f178c454448f13d4249f19b30f3a
      08706a3e
    • Yunqing Wang's avatar
      Fix a bug in motion search code · 7fb0f868
      Yunqing Wang authored
      The MV's range is 256. Since the new motion search uses a different
      starting MV than the center ref MV, a MV range checking needs to
      be done to avoid corruption.
      
      Change-Id: I8ae0721d1bd203639e13891e2e54a2e87276f306
      7fb0f868
    • Yaowu Xu's avatar
      fix a bug that "optimize" flag is not set for sub-threads · 64f3d915
      Yaowu Xu authored
      The flag for quantization optimization was not properly propagated to
      mb row encoding threads.
      
      Change-Id: Ic561599c35acd94cd5698c9b314bccd596ac2deb
      64f3d915
    • Johann's avatar
      shrink TOKENEXTRA and vp8_extra_bit_struct · 825adc46
      Johann authored
      Per John's previous change, shrink TOKENEXTRA from 20 to 8 bytes
      original: b7b1e6fb
      reverted: 41f4458a
      
      Also drop unused field from vp8_extra_bit_struct
      
      Update ARM ASM to deal with this change. In particular, Extra is signed
      and needs to be sign-extended when loaded.
      
      Change-Id: Ibd0ddc058432bc7bb09222d6ce4ef77e93a30b41
      825adc46
  16. 13 Dec, 2010 3 commits
    • John Koleszar's avatar
      Revert "Reduce size of TOKENEXTRA struct" · 41f4458a
      John Koleszar authored
      This reverts commit b7b1e6fb. Previous
      fix is incomplete, breaks ARM. Itchy submit finger.
      
      Change-Id: I939dc0d3bf4173cf951c1d152338ab6ea2184bb9
      41f4458a
    • John Koleszar's avatar
      remove unused temporal preproc code · b1aa54ab
      John Koleszar authored
      This code is unused, as the current preproc implementation uses the
      same spatial filter that postproc uses.
      
      Change-Id: Ia06d5664917d67283f279e2480016bebed602ea7
      b1aa54ab
    • John Koleszar's avatar
      Reduce size of TOKENEXTRA struct · b7b1e6fb
      John Koleszar authored
      Change the size of structure elements to reduce memory utilization.
      Removed the 'section' member entirely, as it is set but never read.
      
      Change-Id: Iad043830392fb4168cb3cd6075fb0eb70c7f691c
      b7b1e6fb
  17. 10 Dec, 2010 1 commit
  18. 09 Dec, 2010 1 commit