1. 06 Oct, 2014 1 commit
    • Jingning Han's avatar
      Fix eobs buffer pointer mis-use · a7555158
      Jingning Han authored
      This commit fixes a buffer pointer mis-use in store_coding_context.
      The compression performance for stdhd set of speed 3 is improved by
      0.097%. It fixes issue 869.
      
      Change-Id: Idc59e22035eaf39f7133ca04174894374d647ff7
      a7555158
  2. 05 Oct, 2014 1 commit
    • Jingning Han's avatar
      Fix an IOC issue in vp9_rd_pick_inter_mode_sb · 085b97aa
      Jingning Han authored
      It is possible that the GOLDEN reference frame is not avaiable, in
      which setting the predicted mv will be associated with a residual
      value of INT_MAX. This commit checks this condition before
      left shift and comparison with that of ALTREF frame, to avoid
      overflow issue.
      
      Change-Id: Ib98c3149dbdd016f2fe5beaafb13f67d469dd07c
      085b97aa
  3. 03 Oct, 2014 2 commits
    • Jingning Han's avatar
      Rework partition search skip scheme · bb260d90
      Jingning Han authored
      This commit enables the encoder to skip split partition search if
      the bigger block size has all non-zero quantized coefficients in low
      frequency area and the total rate cost is below a certain threshold.
      It logarithmatically scales the rate threshold according to the
      current block size. For speed 3, the compression performance loss:
      derf  -0.093%
      stdhd -0.066%
      
      Local experiments show 4% - 20% encoding speed-up for speed 3.
      blue_sky_1080p, 1500 kbps
      51051 b/f, 35.891 dB, 67236 ms ->
      50554 b/f, 35.857 dB, 59270 ms (12% speed-up)
      
      old_town_cross_720p, 1500 kbps
      14431 b/f, 36.249 dB, 57687 ms ->
      14108 b/f, 36.172 dB, 46586 ms (19% speed-up)
      
      pedestrian_area_1080p, 1500 kbps
      50812 b/f, 40.124 dB, 100439 ms ->
      50755 b/f, 40.118 dB,  96549 ms (4% speed-up)
      
      mobile_calendar_720p, 1000 kbps
      10352 b/f, 35.055 dB, 51837 ms ->
      10172 b/f, 35.003 dB, 44076 ms (15% speed-up)
      
      Change-Id: I412e34db49060775b3b89ba1738522317c3239c8
      bb260d90
    • Deb Mukherjee's avatar
      Prevent negative cost for highbitdepth · 431cdc33
      Deb Mukherjee authored
      Adds proper scaling for highbitdepth in a rdopt cost.
      
      Change-Id: I066694799a7f491b830945ef1c66eb202071c355
      431cdc33
  4. 01 Oct, 2014 3 commits
    • Deb Mukherjee's avatar
      High-bitdepth bugfixes · a160d725
      Deb Mukherjee authored
      Miscellaneous bug-fixes for high bitdepth functionality.
      With this patch, high bit-depth profiles become mostly functional,
      except for an intermittent assert failure issue that is being
      tracked.
      
      Change-Id: I6a7fcbdcf1e5b09842e88535f8442d2e1230748c
      a160d725
    • Yunqing Wang's avatar
      Modify block transform skipping check · e4aac6bb
      Yunqing Wang authored
      Block transform skipping was implemented based on DCT's energy
      conservation property. Modified the thresholds using zero bin
      parameters. AC and DC coefficients were checked separately to
      allow better identifying of skippable blocks.
      
      Borg test at speed 3 showed:
      stdhd set: psnr gain: 0.153%, ssim gain: 0.051%;
      derf set: psnr gain: 0.023%, ssim gain: 0.036%
      
      For most test clips, the encoding speedup is 1% - 2%.
      parkrun(720p): 7.5% speedup, park_joy(1080p): 3.5% speedup.
      
      Change-Id: If28eb81113a077414f5ca7b021c14f9069b373bb
      e4aac6bb
    • Jingning Han's avatar
      Conditionally skip reference frame check · 891793a5
      Jingning Han authored
      For regular inter frames, if the distance from GOLDEN_FRAME is larger
      than 2 and if the predicted motion vector of LAST_FRAME gives lower
      sse than that of GOLDEN_FRAME, skip the GOLDE_FRAME mode checking in
      the rate-distortion optimization. It provides about 5% speed-up at
      expense of -0.137% and -0.230% performance down for speed 3. Local
      experiment results:
      
      pedestrian 1080p 2000 kbps
      66712 b/f, 40.908 dB, 113688 ms ->
      66768 b/f, 40.911 dB, 108752 ms
      
      blue_sky 1080p 2000 kbps
      51054 b/f, 35.894 dB, 70406 ms ->
      51051 b/f, 35.891 dB, 67236 ms
      
      old_town_cross 720p 1500 kbps
      14412 b/f, 36.252 dB, 60690 ms ->
      14431 b/f, 36.249 dB, 57346 ms
      
      Change-Id: Idfcafe7f63da7a4896602fc60bd7093f0f0d82ca
      891793a5
  5. 26 Sep, 2014 1 commit
    • Jingning Han's avatar
      Skip certain ALTREF inter modes in ARF coding · ccdb518f
      Jingning Han authored
      This commit enables the encoder to skip checking ALTREF inter modes
      in ARF coding, if the predicted motion vectors suggest that the
      GOLDEN_FRAME provides higher prediction accuracy than ALTREF_FRAME.
      
      It improves the speed 3 encoding speed by about 5%, at the expense
      of compression performance loss -0.041% and -0.225% for derf and
      stdhd, respectively.
      
      pedestrian_area 1080p 2000 kbps
      66705 b/f, 40.909 dB, 118738 ms ->
      66732 b/f, 40.908 dB, 113688 ms
      
      old_town_cross 720p 1500 kbps
      14427 b/f, 36.256 dB, 62746 ms ->
      14412 b/f, 36.252 dB, 60690 ms
      
      blue_sky 1080p 1500 kbps
      51026 b/f, 35.897 dB, 73310 ms ->
      50921 b/f, 35.893 dB, 70406 ms
      
      bus CIF 1000 kbps
      21301 b/f, 34.841 dB, 7326 ms ->
      21248 b/f, 34.837 dB, 7196 ms
      
      Change-Id: I76cf88b4d655e1ee3c0cb03c8a5745493040e8d2
      ccdb518f
  6. 25 Sep, 2014 2 commits
  7. 23 Sep, 2014 2 commits
    • Yaowu Xu's avatar
      Adapt mode based rd_threshold for similar block size · 4a101310
      Yaowu Xu authored
      The rd_thresholds are adaptively changed based on best mode tested.
      It was only changed for the same block size, this commit makes the
      adaptation for similar block sizes too. The commit also made minor
      adjustment and code cleanups.
      
      The impact on encoding time for _ped:
      118089 ms -> 111927 ms
      
      The impact on compression:
      derf:  -0.339%
      stdhd: -0.303%
      
      Change-Id: I8817fed1102350497f2ec631849e43f753878e5d
      4a101310
    • Yaowu Xu's avatar
      Fix an IOC · 56032b47
      Yaowu Xu authored
      Change-Id: I0ca6746696d81657c035b0f6523c9af370da3c95
      56032b47
  8. 22 Sep, 2014 4 commits
    • Yaowu Xu's avatar
      Remove code duplication · c7ab18fe
      Yaowu Xu authored
      Change-Id: I453b3e0d946951665d5919248445fc4f3222d2ad
      c7ab18fe
    • Yaowu Xu's avatar
      Simplify rd_pick_intra_sby_mode() · f46326c7
      Yaowu Xu authored
      Change-Id: Ifb0915c94c2db48827ddbd446314cb6e3155b99c
      f46326c7
    • Jingning Han's avatar
      Remove unnecessary local variable declaration · f7023ea0
      Jingning Han authored
      This commit removes a repetitive local variable declaration in
      vp9_rd_pick_inter_mode_sb.
      
      Change-Id: I1b0afa98ff1ecbfb46e17d3d1cee95d32c4309db
      f7023ea0
    • Jingning Han's avatar
      Adaptive mode search scheduling · eee904c9
      Jingning Han authored
      This commit enables an adaptive mode search order scheduling scheme
      in the rate-distortion optimization. It changes the compression
      performance by -0.433% and -0.420% for derf and stdhd respectively.
      It provides speed improvement for speed 3:
      
      bus CIF 1000 kbps
      24590 b/f, 35.513 dB, 7864 ms ->
      24696 b/f, 35.491 dB, 7408 ms (6% speed-up)
      
      stockholm 720p 1000 kbps
      8983 b/f, 35.078 dB, 65698 ms ->
      8962 b/f, 35.054 dB, 60298 ms (8%)
      
      old_town_cross 720p 1000 kbps
      11804 b/f, 35.666 dB, 62492 ms ->
      11778 b/f, 35.609 dB, 56040 ms (10%)
      
      blue_sky 1080p 1500 kbps
      57173 b/f, 36.179 dB, 77879 ms ->
      57199 b/f, 36.131 dB, 69821 ms (10%)
      
      pedestrian_area 1080p 2000 kbps
      74241 b/f, 41.105 dB, 144031 ms ->
      74271 b/f, 41.091 dB, 133614 ms (8%)
      
      Change-Id: Iaad28cbc99399030fc5f9951eb5aa7fa633f320e
      eee904c9
  9. 20 Sep, 2014 1 commit
    • hkuang's avatar
      Remove mi_grid_* structures. · c70cea97
      hkuang authored
      mi_grid_* are arrays of pointer to pointer. They save the pointers that point
      to the MIs in cm->mi. But they are unnecessary and complicated. The original
      goal was to remove MODE_INFO_t copy. But with an extra MODE_INFO_t pointer
      inside MODE_INFO_t, same goal could be achieved.
      
      This commit totally removes the mi_grid_* structures. But there are still
      many dummy MODE_INFO_t inside cm->mi which are a waste of memory. Next commit
      will do on-demand MODE_INFO_t allocation in order to save these memories.
      
      Change-Id: I3a05cf1610679fed26e0b2eadd315a9ae91afdd6
      c70cea97
  10. 16 Sep, 2014 2 commits
  11. 15 Sep, 2014 5 commits
  12. 12 Sep, 2014 3 commits
    • Jingning Han's avatar
      Refactor reference frame control in sub8x8 block RD search · adb20849
      Jingning Han authored
      This commit unifies the reference frame control in the rate-
      distortion optimization search loop of sub8x8 block size to remove
      the control dependency on mode search order.
      
      Change-Id: I3a174099f71a7cc176ede9fd60e2374243ae9232
      adb20849
    • Deb Mukherjee's avatar
      Adds high bitdepth transform functions and tests · 10783d4f
      Deb Mukherjee authored
      Adds various high bitdepth transform functions and tests.
      Much of the changes are related to using typedefs tran_low_t
      and tran_high_t for the final transform cofficients and intermediate
      stages of the transform computation respectively rather than fixed
      types int16_t/int. When vp9_highbitdepth configure flag is off,
      these map tp int16_t/int32_t, but when the flag is on, they map
      to int32_t/int64_t to make space for needed extra precision.
      
      Change-Id: I3c56de79e15b904d6f655b62ffae170729befdd8
      10783d4f
    • Jingning Han's avatar
      Format fixes in vp9_rd_pick_inter_mode_sb · 74ddde01
      Jingning Han authored
      Change-Id: Ie45687405dcaa34ba465dce2aa14f76017d3a794
      74ddde01
  13. 11 Sep, 2014 8 commits
  14. 09 Sep, 2014 4 commits
    • Jingning Han's avatar
      Fix a bug in vp9_rd_pick_inter_mode_sb · 68d79146
      Jingning Han authored
      This commit fixes a bug related to skipping intra mode checking, by
      using a separate variable to store the best prediction error from
      inter mode. It avoids unintentionally overwriting intra mode
      rate-distortion cost, and hence affecting other speed features.
      
      Change-Id: I99e12993339c84c8b4f597996b372012e5858fae
      68d79146
    • Jingning Han's avatar
      Remove redundant ref frame pointer assignment · 9a9e2aef
      Jingning Han authored
      Assigning selected reference frame pointer is done in the
      encode_superblock function. No need to do this at the end of
      rate-distortion optimization search.
      
      Change-Id: I33fcede0fd304b4a4c4deef2d126d79546a9c070
      9a9e2aef
    • Jingning Han's avatar
      Remove dependency of intra mode search skip check on mode order · 33593d1f
      Jingning Han authored
      This commit refactors the vp9_rd_pick_inter_mode_sb function to
      remove the intra mode early termination dependency on the mode
      search order.
      
      Change-Id: If6ac49aa7c530c7b9a5bd31b0ab84db83e192bec
      33593d1f
    • Jingning Han's avatar
      Replace best_mode_index table retrieve with fetching best_mbmode · d96228a0
      Jingning Han authored
      This commit allows the encoder to find current best prediction mode
      state using best_mbmode, instead of fetching from the static mode
      search table via best_mode_index.
      
      Change-Id: Ibefeab83aed33a49c2be03e83f09153856ca4271
      d96228a0
  15. 05 Sep, 2014 1 commit
    • Yunqing Wang's avatar
      Correct the mode decisions in special cases · 1dd9a639
      Yunqing Wang authored
      The rate costs calculated for inter modes are not precise in some
      cases, which causes NEWMV is chosen instead of NEARESTMV, NEARMV,
      and ZEROMV. This patch added checks for these cases, and corrected
      the mode decisions.
      
      Borg tests at speed 3 showed:
      1. stdhd set: 0.102% PSNR gain and 0.088% SSIM gain.
      2. derf set:  0.147% PSNR gain and 0.132% SSIM gain.
      No speed change.
      
      Change-Id: I35d17684b89ad4734fb610942d707899146426db
      1dd9a639