1. 04 Jan, 2011 1 commit
    • Paul Wilkins's avatar
      Adjustment to boost calculation in two pass. · b095d9df
      Paul Wilkins authored
      Calculate a minimum intra value to be used in determining the
      IIratio scores used in two pass, second pass.
      
      This is to make sure sections that are low complexity" in the
      intra domain are still boosted appropriately for KF/GF/ARF.
      
      For now I have commented out the Q based adjustment of
      KF boost.
      
      Change-Id: I15deb09c5bd9b53180a2ddd3e5f575b2aba244b3
      b095d9df
  2. 29 Dec, 2010 2 commits
    • Scott LaVarnway's avatar
      Fixed encoder crash when mult-threading is enabled. · de4e8185
      Scott LaVarnway authored
      Happens in real-time mode.  Will happen in good quality, speed 1.
      
      Change-Id: I3e5b68827b1a5798d0431b088a709256d1ce2c95
      de4e8185
    • Yunqing Wang's avatar
      Always update last_frame_type · a864678c
      Yunqing Wang authored
      Scott pointed out that last_frame_type only gets updated while
      loopfilter exists. Since last_frame_type is also needed in
      motion search now, it needs to be updated every frame.
      
      Change-Id: I9203532fd67361588d4024628d9ddb8e391ad912
      a864678c
  3. 28 Dec, 2010 3 commits
    • Scott LaVarnway's avatar
      Use the fast quantizer for inter mode selection · 516ea846
      Scott LaVarnway authored
      Use the fast quantizer for inter mode selection and the
      regular quantizer for the rest of the encode for good quality,
      speed 1.  Both performance and quality were improved.  The
      quality gains will make up for the quality loss mentioned in
      I9dc089007ca08129fb6c11fe7692777ebb8647b0.
      
      Change-Id: Ia90bc9cf326a7c65d60d31fa32f6465ab6984d21
      516ea846
    • Yunqing Wang's avatar
      Adjust MV borders for SPLITMV mode · bf53ec49
      Yunqing Wang authored
      Add limits to avoid MV going out of range.
      
      Change-Id: I8a5deb40bf393488d29f694b5a56804d578e68b5
      bf53ec49
    • Yunqing Wang's avatar
      Modify motion estimation for SPLITMV mode · a5a8d929
      Yunqing Wang authored
      1. Search for block8x16/block16x8 uses block8x8's search results.
      2. Check block4x4 only if block8x8 is chosen. (This hurts quality,
         which will be improved in another check-in.)
      3. In block4x4 search, the previous block's result is used as
         MV predictor for next block.
      
      This change improves performance.
      
      Change-Id: I9dc089007ca08129fb6c11fe7692777ebb8647b0
      a5a8d929
  4. 24 Dec, 2010 1 commit
    • Yaowu Xu's avatar
      adjusted sad_per_bit to correlate with quantizer · 0f5264b5
      Yaowu Xu authored
      Re-calibrated sad_per_bit16 and sad_per_bit4 tables to linearly
      correlated to quantizer values, these two variables are used in
      motion search for costing motion vectors. This change has an small
      positive effect on compression.
      
      Change-Id: Ic9b5ea6fb8d5078ef663ba4899db019cc51f4166
      0f5264b5
  5. 22 Dec, 2010 3 commits
    • Johann's avatar
      improve integer version of filter · 20b855c3
      Johann authored
      the lookup table is based on floating point calculations (see source)
      
      by moving the *3 before the downshift and adding the rounding bit, the
      delta (LUT - integer) goes from:
      ______________________________________
      __ 1__ 1______________________________
      __ 1__ 1______________________________
      ____ 1______ 1________________________
      ____ 1 2__ 2 1________________________
      ______ 1 1 2__ 2__ 2__ 2 1 1__________
      ________ 1 1 2 2__ 1 2 3 1 2__ 2__ 2__
      to:
      __-1__-1______________________________
      ______________________________________
      ____-1______-1________________________
      ______________________________________
      ________-1______________-1____________
      ______________________________________
      
      it's important to be able to use the integer version because the LUT
      more or less precludes SIMD optimizations
      
      Change-Id: I45a81127dc7b72a06fba951649135d9d918386c0
      20b855c3
    • Johann's avatar
      temporal filter naming changes · 4b6219cb
      Johann authored
      be more consistant with the naming pattern, especially wrt rtcd
      
      Change-Id: I3df50686a09f1dab0a9620b5adbb8a1577b40f2f
      4b6219cb
    • Johann's avatar
      abstract apply_temporal_filter · 092b5bef
      Johann authored
      allow for optimized versions of apply_temporal_filter
      (now vp8_apply_temporal_filter_c)
      
      the function was previously declared as static and appears to have been
      inlined. with this change, that's no longer possible. performance takes
      a small hit.
      
      the declaration for vp8_cx_temp_filter_c was moved to onyx_if.c because
      of a circular dependency. for rtcd, temporal_filter.h holds the
      definition for the rtcd table, so it needs to be included by onyx_int.h.
      however, onyx_int.h holds the definition for VP8_COMP which is needed
      for the function prototype. blah.
      
      Change-Id: I499c055fdc652ac4659c21c5a55fe10ceb7e95e3
      092b5bef
  6. 17 Dec, 2010 3 commits
    • John Koleszar's avatar
      propagate user private data on decode · c49f49b1
      John Koleszar authored
      The pointer passed in the user_priv argument to vpx_codec_decode()
      should be propagated through to the corresponding output frame and
      made available in the image's user_priv member. Fixes issue #252
      
      Change-Id: I182746a6882c8549fb146b4a4fdb64f1789eb750
      c49f49b1
    • John Koleszar's avatar
      Add psnr/ssim tuning option · b0da9b39
      John Koleszar authored
      Add a new encoder control, VP8E_SET_TUNING, to allow the application
      to inform the encoder that the material will benefit from certain
      tuning. Expose this control as the --tune option to vpxenc. The args
      helper is expanded to support enumerated arguments by name or value.
      
      Two tunings are provided by this patch, PSNR (default) and SSIM.
      Activity masking is made dependent on setting --tune=ssim, as the
      current implementation hurts speed (10%) and PSNR (2.7% avg,
      10% peak) too much for it to be a default yet.
      
      Change-Id: I110d969381c4805347ff5a0ffaf1a14ca1965257
      b0da9b39
    • Henrik Lundin's avatar
      Inform caller of decoder about updated references · 2a87491f
      Henrik Lundin authored
      Inform the caller of the decoder if a decoded frame updated last,
      golden, or altref frames, required for realtime communication
      proposed in document VP8 RTP payload format.
      
      Added a new vpx_codec_control called VP8D_GET_LAST_REF_UPDATES, to be
      called after vpx_codec_decode. The control will indicate which of the
      reference frames that were updated by setting the 3 LSBs in the input
      int (pointer).
      
      Change-Id: Iac9db60dac414356c7ffa0b0fede88cb91e11bd7
      2a87491f
  7. 16 Dec, 2010 2 commits
    • Scott LaVarnway's avatar
      Changed segmentation check order · 64baa8df
      Scott LaVarnway authored
      In SPLITMV, the 8x8 segment will be checked first.  If the 8x8 rd
      is better than the best, we check the other segments.  Otherwise
      bail.  Adjustments to the thresh_mult were necessary to make
      up for the initial quality loss.
      The performance improved by 20% (average) for good quality,
      speed 0 and speed 1, while the overall quality remained the same.
      
      Change-Id: I717aef401323c8a254fba3e9777d2a316c774cc3
      64baa8df
    • Scott LaVarnway's avatar
      Adjusted breakout RD for SPLITMV · 81cdeb71
      Scott LaVarnway authored
      vp8_rd_pick_best_mbsegmentation looks at y only.  The new
      breakout does not include the frame cost, the prob_skip_false
      cost, or the uv rate.  Performance improved by a few percent
      and the quality remained the same.
      
      Change-Id: I94ff013998ac51e8ecce7130870f7b6600758e15
      81cdeb71
  8. 14 Dec, 2010 4 commits
    • Yunqing Wang's avatar
      Fix a bug in motion search code(2) · 08706a3e
      Yunqing Wang authored
      This fix added MV range checks for NEWMV mode as suggested by Jim.
      To reduce unnecessary MV range checks, I tried Yaowu's suggestion.
      Update UMV borders in NEWMV mode to also cover MV range check.
      Also, in this way, every MV that is valid gets checked in diamond
      search function.
      
      Change-Id: I95a89ce0daf6f178c454448f13d4249f19b30f3a
      08706a3e
    • Yunqing Wang's avatar
      Fix a bug in motion search code · 7fb0f868
      Yunqing Wang authored
      The MV's range is 256. Since the new motion search uses a different
      starting MV than the center ref MV, a MV range checking needs to
      be done to avoid corruption.
      
      Change-Id: I8ae0721d1bd203639e13891e2e54a2e87276f306
      7fb0f868
    • Yaowu Xu's avatar
      fix a bug that "optimize" flag is not set for sub-threads · 64f3d915
      Yaowu Xu authored
      The flag for quantization optimization was not properly propagated to
      mb row encoding threads.
      
      Change-Id: Ic561599c35acd94cd5698c9b314bccd596ac2deb
      64f3d915
    • Johann's avatar
      shrink TOKENEXTRA and vp8_extra_bit_struct · 825adc46
      Johann authored
      Per John's previous change, shrink TOKENEXTRA from 20 to 8 bytes
      original: b7b1e6fb
      reverted: 41f4458a
      
      Also drop unused field from vp8_extra_bit_struct
      
      Update ARM ASM to deal with this change. In particular, Extra is signed
      and needs to be sign-extended when loaded.
      
      Change-Id: Ibd0ddc058432bc7bb09222d6ce4ef77e93a30b41
      825adc46
  9. 13 Dec, 2010 3 commits
    • John Koleszar's avatar
      Revert "Reduce size of TOKENEXTRA struct" · 41f4458a
      John Koleszar authored
      This reverts commit b7b1e6fb. Previous
      fix is incomplete, breaks ARM. Itchy submit finger.
      
      Change-Id: I939dc0d3bf4173cf951c1d152338ab6ea2184bb9
      41f4458a
    • John Koleszar's avatar
      remove unused temporal preproc code · b1aa54ab
      John Koleszar authored
      This code is unused, as the current preproc implementation uses the
      same spatial filter that postproc uses.
      
      Change-Id: Ia06d5664917d67283f279e2480016bebed602ea7
      b1aa54ab
    • John Koleszar's avatar
      Reduce size of TOKENEXTRA struct · b7b1e6fb
      John Koleszar authored
      Change the size of structure elements to reduce memory utilization.
      Removed the 'section' member entirely, as it is set but never read.
      
      Change-Id: Iad043830392fb4168cb3cd6075fb0eb70c7f691c
      b7b1e6fb
  10. 10 Dec, 2010 1 commit
  11. 09 Dec, 2010 3 commits
    • Fritz Koenig's avatar
      vp8 fast quantizer sse2 optimizations for eob. · e0cf330c
      Fritz Koenig authored
      Changed the end of block computation to use pmaxw.  Removed
      additional pushing and popping of registers that was not needed.
      
      Change-Id: I08cb9b424513cd8a2c7ad8cea53b4e2adc66ef98
      e0cf330c
    • John Koleszar's avatar
      fix uninitialized read in encode breakout · cb969895
      John Koleszar authored
      Change I3430820b performed an uninitialized read when
      encode_breakout == 0, since the sum and sse wouldn't be set:
      
         if(x->encode_breakout)
             VARIANCE_INVOKE(..., get16x16var)(..., &sum, &sse);
         if (cpi->active_map_enabled && x->active_ptr[0] == 0) {
             ...
         } else if (sse < x->encode_breakout)
      
      Change-Id: I915eb76d1227b4b6d1137a0dedf2c143860098a2
      cb969895
    • Paul Wilkins's avatar
      Correct q_low and q_high limits for the recode loop · c63fc881
      Paul Wilkins authored
      Corrected the initial Q range limits for the recode loop
      to reflect the current allowed range for the frame.
      
      In experimental work on constrained quality this bug was
      causing unnecessary recodes.
      
      Change-Id: I7e256fbfa681293b0223fe21ec329933d76c229f
      c63fc881
  12. 07 Dec, 2010 2 commits
    • Jim Bankoski's avatar
      vp8e - static threshold play · 718c1971
      Jim Bankoski authored
      Realized no need for new assembly code sum is already
      calculated.
      
      Change-Id: Ie2d94feb4b7c1f77c5359bca29b66228e41638c9
      718c1971
    • Yaowu Xu's avatar
      adjust RDMULT for UV plane in quantization RDO · 7c03a1c3
      Yaowu Xu authored
      This patch adds a weighting factor on RDMULT for UV blocks. The change
      has an overall gain about 0.5% based on ssim, between 0.1 and 0.2% by
      psnr numbers.
      
      Change-Id: I97781b077ce3bb7e34241b03268491917e8d1d72
      7c03a1c3
  13. 06 Dec, 2010 3 commits
    • Yunqing Wang's avatar
      Fix a memory leak problem in encoder · 9520f4b3
      Yunqing Wang authored
      Deallocating the buffers before re-allocating them.
      
      The fix passed James Berry's test program for memory
      leak check.
      
      Change-Id: I18c3cf665412c0e313a523e3d435106c03ca438d
      9520f4b3
    • Scott LaVarnway's avatar
      vp8_rd_pick_best_mbsegmentation code restructure · 2fa5d5a2
      Scott LaVarnway authored
      Moved the code from the segmentation loop into a function
      which is now called for each segment. This will allow us
      to change the segment order checking more easily.
      
      Change-Id: I9510d26f0acae5a73043fcca8f1984b121d3e052
      2fa5d5a2
    • Patrik Westin's avatar
      Fix for manual Golden frame frequency · 8534071d
      Patrik Westin authored
      When auto_golden wasn't set it forced all frames to be a golden
      frame. Now the manual configured frequency is adhered to.
      
      Change-Id: I360acac9bc487db0d9c4d4da6ee41f70c227c539
      8534071d
  14. 04 Dec, 2010 1 commit
    • Paul Wilkins's avatar
      Change to inter_minq table. · cec6a596
      Paul Wilkins authored
      The inter_minq table controls the range of quantizers available
      for a particular frame in two pass relative to a max Q value.
      
      The changes reduces the range somewhat. The effect of this
      was a small increase (0.3% average) in psnr for the test set
      but it should also help encode speed somewhat for higher
      quality modes as it will reduce the number of iterations in the
      recode loop.
      
      The change damps the range of quantizers available locally
      within a section of a clip and should therefore help keep quality
      more uniform. If there is systematic overshoot or undershoot the
      range can shift gradually to accommodate. However, there is
      some increased risk of overshoot or undershoot against the target
      bit rate in VBR mode and this risk will be more pronounced for short
      clips.
      
      The change damps the range of quantizers available locally
      within a section of a clip and should therefore help keep quality
      more uniform. If there is systematic overshoot or undershoot the
      range can shift gradually to accommodate. However, there is
      some increased risk of overshoot or undershoot against the
      target bit rate in VBR mode and this risk will be more
      pronounced for short clips.
      
      Change-Id: I84465567d49ae767c6c73ff2a2aac30c895adb52
      cec6a596
  15. 03 Dec, 2010 1 commit
    • Yunqing Wang's avatar
      Improve MV prediction accuracy to achieve performance gain · c3bbb291
      Yunqing Wang authored
      Add vp8_mv_pred() to better predict starting MV for NEWMV
      mode in vp8_rd_pick_inter_mode(). Set different search
      ranges according to MV prediction accuracy, which improves
      encoder performance without hurting the quality. Also,
      as Yaowu suggested, using diamond search result as full
      search starting point and therefore adjusting(reducing)
      full search range helps the performance.
      
      Change-Id: Ie4a3c8df87e697c1f4f6e2ddb693766bba1b77b6
      c3bbb291
  16. 01 Dec, 2010 1 commit
    • Fritz Koenig's avatar
      Set refresh_alt_ref_frame on keyframe encode. · 9c8ad79f
      Fritz Koenig authored
      On a keyframe alt ref and golden are refreshed.  The flag was
      not being set and so on the frame after a keyframe, motion
      search would occur on the alt ref frame.  This is not necessary
      because the alt ref frame identical to the last frame in this
      scenario.
      
      Handle corner case where a forward alt-ref frame is put
      directly after a keyframe.
      
      Change-Id: I9be4cf290d694f8cf2f9a31852014b5ccf1504d3
      9c8ad79f
  17. 27 Nov, 2010 1 commit
  18. 25 Nov, 2010 1 commit
    • Pascal Massimino's avatar
      allow dimensions as low as 1 pixel · fd9f9dc0
      Pascal Massimino authored
      remove warning comment in vpxenc.c: in case of 1x1 picture,
      detect_bytes will be equal to '3' and we'll fall back to
      RAW_TYPE.
      fix read_frame() by tracking the pre-read buffer length
      in the struct detect
      
      Change-Id: If1ed86ee5260dcdbc8f9d10da6cbb84a4cc2f151
      fd9f9dc0
  19. 22 Nov, 2010 1 commit
    • Paul Wilkins's avatar
      Recalibration of bits per MB tables · ad6150f7
      Paul Wilkins authored
      The baseline bits per MB prediction tables have been
      re calibrated based on the assumption that bits per mb
      is inversely proportional to the quantizer level.
      
      Change-Id: Ibd355c7acac4b8053dda1baf1032fe35f11da7f7
      ad6150f7
  20. 19 Nov, 2010 1 commit
  21. 18 Nov, 2010 1 commit
    • Pascal Massimino's avatar
      remove warning · ed5ab7fa
      Pascal Massimino authored
      was having: "vp8/encoder/onyx_if.c:5365: warning: comparison of unsigned expression >= 0 is always true"
      ed5ab7fa
  22. 17 Nov, 2010 1 commit