1. 06 Jun, 2014 1 commit
    • Adrian Grange's avatar
      Revert "Removing this_frame_stats member from TWO_PASS struct." · a4f74792
      Adrian Grange authored
      Use of stack frame variable "fps" beyond the lifetime of the function.
      
      fps is sent as a paremeter to output_stats and stored in the
      packet holding this encoded frame. This has scope beyond the
      lifetime of the calling function.
      
      This reverts commit 3f95a230
      
      Change-Id: Icd8e14b3d7dd733590ada12e619b9dce95b6b0f5
      a4f74792
  2. 28 May, 2014 2 commits
  3. 27 May, 2014 1 commit
    • Paul Wilkins's avatar
      Remove brightness weighting in two pass. · f085d128
      Paul Wilkins authored
      This code dates from the ancient past and
      applied an error score weighting based on pixel
      brightness. This not seem to be providing any
      benefit metrics wise and could be making some
      visual issues in dark frames worse.
      
      The field is left in place in the FIRSTPASS_STATS data
      structure in this patch, pending changes to unit tests that
      use a pre-defined first pass file.
      
      Change-Id: Id50f04205230234858e7548ce523f11acaf3567d
      f085d128
  4. 23 May, 2014 2 commits
    • Paul Wilkins's avatar
      Further first pass allocation changes. · 1edbaeb0
      Paul Wilkins authored
      Further changes to first pass allocation for gf/arf groups.
      Three variables removed from TWO_PASS structure as only
      now used locally. Dont adjust gf_group_bits in the post
      encode update as this will no longer have any effect.
      
      Change-Id: Iff89b225db923fc856f5d2aedbc899f1d7d68b55
      1edbaeb0
    • Paul Wilkins's avatar
      Re-factor bit allocation in first pass. · 03eb0621
      Paul Wilkins authored
      Restructuring to allocate the bits for each frame in
      a GF group at the time the group is defined.
      
      At the moment the allocation closely mirrors what
      we had before.
      
      Also changes the default rate adjustment method to
      LONG_TERM_VBR_CORRECTION.
      
      Change-Id: Ie5793c46c6b9c888cead5d8790792efd7d60b7c1
      03eb0621
  5. 22 May, 2014 5 commits
  6. 21 May, 2014 2 commits
  7. 20 May, 2014 3 commits
  8. 19 May, 2014 1 commit
    • Paul Wilkins's avatar
      Cosmetic clean up. · f07a96fd
      Paul Wilkins authored
      Use type TWO_PASS instead of "struct twopass".
      
      Change-Id: I9d92920893bd436537b2ca19e9c9d355cca56c7c
      f07a96fd
  9. 16 May, 2014 3 commits
  10. 15 May, 2014 2 commits
  11. 14 May, 2014 2 commits
    • Paul Wilkins's avatar
      Simplify 2 pass KF bitrate allocation · 6122ca87
      Paul Wilkins authored
      Simplify the calculation of KF bitrate in similar way
      to previous patch for GF/arf.
      
      This has no impact on derf or std hd sets but gives a
      small net gain of ~0.1% for yt and yt-hd sets.
      
      Change-Id: Ida64ac1428d9c2a62adb67056fadbf0180eff030
      6122ca87
    • Paul Wilkins's avatar
      Further two pass clean up. · d677ea1f
      Paul Wilkins authored
      The variation in boost calculation for gf and arf groups
      is not significant enough to justify the extra complexity.
      Also removed some other spurious code that no longer
      has much material impact.
      
      The handling of the rare case, where the boost bits
      number is less than the number of bits a that would
      be allocated if a frame was not boosted, will be dealt
      with in a subsequent patch.
      
      This change actually helps on all sets a little by
      ~0.1% - 0.2% with slightly bigger gains on SSIM.
      
      Change-Id: Id42c1ac22a80a8c4993cfa0e51bc733eb9ed4f75
      d677ea1f
  12. 12 May, 2014 2 commits
    • Paul Wilkins's avatar
      Clean up of firstpass.c · 702e2583
      Paul Wilkins authored
      Re-factor duplicate code.
      Add two pass check for use of section_intra_rating as
      it is un-initialised in the 1 pass and rt case.
      
      Change-Id: I93120796f07961b8a21fb26e1a9f0d3d13949994
      702e2583
    • Paul Wilkins's avatar
      First pass clean up. · 00d54aa3
      Paul Wilkins authored
      One of a series of changes to clean up two pass
      allocation as precursor to support for multiple arf
      or boosted frames per GF/ARF group.
      
      This change pulls out the calculation of the total bits
      allocated to a GF/ARF group into a function, to aid
      readability and reduce the line count for define_gf_group().
      
      This change should have no material impact on output.
      
      Change-Id: I716fba08e26f9ddde3257e7d9b188453791883a3
      00d54aa3
  13. 08 May, 2014 1 commit
  14. 01 May, 2014 1 commit
    • Paul Wilkins's avatar
      Switch the default 2 pass vbr variant. · 307b6c22
      Paul Wilkins authored
      On balance Deb's  modified rate control for VBR seems
      to be outperforming especially on some low motion YT
      clips so I have switched this to be the default mode for
      now.
      
      Change-Id: I0713d430cad6425ac5c48fccdf332e12814ee44a
      307b6c22
  15. 30 Apr, 2014 1 commit
  16. 29 Apr, 2014 2 commits
  17. 24 Apr, 2014 2 commits
  18. 23 Apr, 2014 1 commit
    • Adrian Grange's avatar
      Fixed handling of regularly placed keyframes · 086ae992
      Adrian Grange authored
      The encoder was not handling requests to place keyframes at
      fixed intervals, i.e. kf_min_dist == kf_max_dist, correctly.
      
      In this case when looking to place the next keyframe it was
      accumulating stats all the way up to the end of the firstpass
      file. This patch corrects this behavior.
      
      Change-Id: I948ad9f1d7faa0c05861df588136cce3bb61d7e7
      086ae992
  19. 22 Apr, 2014 1 commit
    • Dmitry Kovalev's avatar
      Renaming "onyx" to "encoder". · ef003078
      Dmitry Kovalev authored
      Actual renames:
        vp9_onyx_if.c -> vp9_encoder.c
        vp9_onyx_int.h -> vp9_encoder.h
      
      Change-Id: I80532a80b118d0060518e6c6a0d640e3f411783c
      ef003078
  20. 21 Apr, 2014 1 commit
    • Paul Wilkins's avatar
      Change naming of end_usage parameter. · 4c7af859
      Paul Wilkins authored
      The end_useage parameter  is confusingly named since it
      now actually defines the rate control method used.
      
      Change-Id: I98912caabfe556b7af0b939a645d1336409e4d71
      4c7af859
  21. 18 Apr, 2014 2 commits
  22. 17 Apr, 2014 2 commits
    • Dmitry Kovalev's avatar
      Removing cq_target_quality from VP9_COMP. · 53dbc7f9
      Dmitry Kovalev authored
      Use cq_level (which is identical) from VP9_CONFIG instead.
      
      Change-Id: I1aaf2fcef3d2dbd4577f613d27693ff8a68989fd
      53dbc7f9
    • Paul Wilkins's avatar
      Merge two new VBR adjustment schemes. · 02e5bde3
      Paul Wilkins authored
      To make direct side by side testing this patch combines two
      VBR corrections schemes to allow more direct side by side testing.
      (The other patch was by Debargha chg id I0cd1f7...)
      
      Change-Id: I271c45e5c4ccf8de8305589000218b80d9dc3a25
      02e5bde3